| *** santoshkumark has quit IRC | 00:38 | |
| *** bobh has joined #tacker | 00:41 | |
| *** sripriya__ has quit IRC | 00:42 | |
| *** sridhar_ram has quit IRC | 01:46 | |
| *** s3wong has quit IRC | 01:52 | |
| *** bobh has quit IRC | 02:00 | |
| *** bobh has joined #tacker | 02:10 | |
| *** tbh has quit IRC | 02:13 | |
| openstackgerrit | vishwanath jayaraman proposed stackforge/tacker: Fixes VNF state being stuck in PENDING_CREATE https://review.openstack.org/229706 | 02:24 |
|---|---|---|
| openstackgerrit | vishwanath jayaraman proposed stackforge/tacker: Fixes VNF state being stuck in PENDING_CREATE https://review.openstack.org/229706 | 02:30 |
| *** prashantD has quit IRC | 02:37 | |
| openstackgerrit | vishwanath jayaraman proposed stackforge/tacker-horizon: Fixes VNF state being stuck in PENDING_CREATE https://review.openstack.org/229709 | 02:39 |
| *** lhcheng has quit IRC | 02:45 | |
| *** tbh has joined #tacker | 02:55 | |
| tbh | bobh, Hi | 03:24 |
| bobh | tbh: hello | 03:24 |
| tbh | bobh, when I tried to onboard VNF, I got HTTPBadRequest: Unrecognized attribute(s) 'vnfd' error | 03:25 |
| tbh | is it a known error | 03:25 |
| tbh | I am using template in your patch | 03:25 |
| bobh | tbh: Is this using one of the sample templates? | 03:25 |
| tbh | bobh, yes | 03:26 |
| bobh | tbh: I haven't seen that error | 03:27 |
| tbh | bobh, let me figure out what's the problem then | 03:28 |
| tbh | I will get back to you | 03:28 |
| bobh | tbh: ok | 03:28 |
| tbh | bobh, the problem is here https://github.com/stackforge/tacker/blob/master/tacker/api/v1/base.py#L580 | 03:43 |
| tbh | bobh, I got extra keys as vnfd | 03:43 |
| bobh | tbh: what does your command line look like? | 03:44 |
| tbh | bobh, I ran from the dashboard | 03:44 |
| bobh | tbh: interesting - could be a new bug | 03:45 |
| tbh | bobh, regarding http ping driver, it is almost same as ping driv er | 03:49 |
| tbh | but I am taking HTTP method and port number to check | 03:49 |
| tbh | so only is_pingable method changes | 03:49 |
| bobh | tbh: sounds good. These will be good reference implementations and others can get more complex as needed | 03:49 |
| tbh | bobh, okay | 03:50 |
| tbh | bobh, I will try to push http ping driver today and will update devrefs too | 03:51 |
| tbh | bobh, sorry for the late, had been working on ovs firewall driver | 03:51 |
| bobh | tbh: no worries - I've been way behind too. Way too many things to do and all at the same time | 03:53 |
| tbh | :) | 03:53 |
| bobh | tbh: time to call it a day. ttyl | 03:53 |
| tbh | ttyl | 03:53 |
| *** bobh has quit IRC | 03:54 | |
| *** lhcheng has joined #tacker | 04:04 | |
| *** lhcheng_ has joined #tacker | 04:17 | |
| *** lhcheng has quit IRC | 04:19 | |
| *** tbh has quit IRC | 05:10 | |
| openstackgerrit | vishwanath jayaraman proposed stackforge/tacker: Fixes VNF state being stuck in PENDING_CREATE https://review.openstack.org/229706 | 05:33 |
| *** lhcheng has joined #tacker | 05:47 | |
| *** lhcheng_ has quit IRC | 05:50 | |
| *** tbh has joined #tacker | 07:22 | |
| *** lhcheng has quit IRC | 07:42 | |
| *** openstackgerrit has quit IRC | 07:46 | |
| *** zeih has quit IRC | 07:46 | |
| *** zeih has joined #tacker | 07:46 | |
| *** openstackgerrit has joined #tacker | 07:47 | |
| *** lhcheng has joined #tacker | 09:31 | |
| *** lhcheng has quit IRC | 09:36 | |
| *** lhcheng has joined #tacker | 11:20 | |
| *** lhcheng has quit IRC | 11:25 | |
| *** lhcheng has joined #tacker | 11:44 | |
| *** lhcheng has quit IRC | 11:49 | |
| *** bobh has joined #tacker | 12:21 | |
| *** bobh has quit IRC | 12:25 | |
| openstackgerrit | bharaththiruveedula proposed stackforge/tacker: HTTP ping monitor driver for Monitoring Framework https://review.openstack.org/229858 | 12:38 |
| openstackgerrit | bharaththiruveedula proposed stackforge/tacker: HTTP ping monitor driver for Monitoring Framework https://review.openstack.org/229858 | 13:01 |
| *** trozet has joined #tacker | 13:38 | |
| *** trozet has quit IRC | 13:46 | |
| *** trozet has joined #tacker | 13:48 | |
| *** tbh has quit IRC | 13:52 | |
| *** bobh has joined #tacker | 14:26 | |
| *** sridhar_ram has joined #tacker | 14:36 | |
| *** sripriya has joined #tacker | 15:22 | |
| *** sridhar_ram has quit IRC | 15:35 | |
| *** zeih has quit IRC | 15:37 | |
| *** tbh has joined #tacker | 15:44 | |
| *** sridhar_ram has joined #tacker | 15:55 | |
| *** lhcheng has joined #tacker | 15:57 | |
| *** prashantD has joined #tacker | 16:00 | |
| openstackgerrit | Sripriya Seetharam proposed stackforge/tacker: Add unit tests for heat infra driver https://review.openstack.org/229987 | 16:00 |
| sridhar_ram | hi tackers - please come over to #openstack-meeting for the weekly mtg | 16:01 |
| *** prashantD has quit IRC | 16:04 | |
| *** s3wong has joined #tacker | 16:34 | |
| *** bobh has quit IRC | 17:00 | |
| sripriya | tbb: hello | 17:00 |
| sripriya | tbh* | 17:00 |
| tbh | sripriya, hello | 17:00 |
| sripriya | tbh: i have not yet deepdived into monitoring code, but can we discuss the issue you were facing | 17:01 |
| sripriya | tbh: where exactly is it choking up? | 17:01 |
| tbh | sripriya, http://paste.openstack.org/show/475098/ | 17:03 |
| * sripriya looking | 17:04 | |
| tbh | sripriya, I haven't seen the exact cause, but checking the working of HTTP ping driver | 17:04 |
| sripriya | tbh: i will have to pull your code and check to see the issue, just the exception is not helping me in this case, is this happening with HTTP ping driver only? | 17:08 |
| tbh | sripriya, no with ping driver also | 17:10 |
| sripriya | tbh: i see | 17:11 |
| tbh | sripriya, I will try to figure out the issue | 17:12 |
| sripriya | tbh: i will also try to look in parallel | 17:15 |
| *** elo1 has quit IRC | 17:15 | |
| *** bobh has joined #tacker | 17:15 | |
| *** prashantD_ has joined #tacker | 17:16 | |
| tbh | sripriya, I just tried to look at the problem, I think we are adding template_id param here https://github.com/stackforge/tacker/blob/master/tacker/vm/plugin.py#L669 | 17:17 |
| tbh | but not here https://github.com/stackforge/tacker/blob/master/tacker/vm/plugin.py#L294 | 17:18 |
| tbh | sripriya, so I thought that is making the problem, will have to look exactly | 17:18 |
| sripriya | tbh: create_vnf is calling create_device internally which in turn is calling _create_device, so the template_id should be reflected all the way down up to _create_device | 17:22 |
| sripriya | tbh: are you calling create_device directly? | 17:23 |
| *** elo1 has joined #tacker | 17:23 | |
| tbh | sripriya, sorry I haven't looked that call | 17:26 |
| sridhar_ram | tbh: sripriya: as seen in #link https://review.openstack.org/#/c/229858/ .. there is no code change by bharath in any of the areas like create_device ... | 17:48 |
| sridhar_ram | so.. wondering how such template_id issue would crop just for this | 17:50 |
| sripriya | sridhar_ram: i see vnfd_id getting trickled down to vm_db in device_dict. | 17:54 |
| sripriya | tbh: sridhar_ram: found the root cause of the issue | 18:17 |
| sridhar_ram | sripriya: please explain if you've a min | 18:17 |
| * sridhar_ram pulls the chair to listen | 18:18 | |
| sripriya | this is an issue where the vnf response is still used after returning from create_device | 18:18 |
| sripriya | the vnf is while returning back modifies tenant_id to vnfd_id and returns back the response of vnf dict | 18:18 |
| sripriya | but in background the thread is still active for create_device_wait which now will use the modified vnf dict | 18:19 |
| sridhar_ram | ouch... race condition | 18:19 |
| sripriya | which refers to vnfd_id | 18:19 |
| sripriya | yeah we can say that, cos vnf create would have already returned from the call to send the right response | 18:20 |
| sripriya | in create_vnf we pop the template_id back to vnfd_id before sending the response | 18:20 |
| sripriya | but background create_wait thread is still running | 18:21 |
| sridhar_ram | hmm... create_device_wait running in the background is the expected behaviour.. nothing wrong w/ that | 18:23 |
| sripriya | sridhar_ram: yes, rather send a copy of vnf response instead of modifying the actual dict. | 18:24 |
| sridhar_ram | do you have a line # for template_id to vnfd_id switch ? that piece doesn't sound correct | 18:24 |
| sripriya | https://github.com/stackforge/tacker/blob/master/tacker/vm/plugin.py#L671 | 18:25 |
| sripriya | this is done to reflect "vnf" response as seen by the user | 18:27 |
| *** sridhar_ram has quit IRC | 18:30 | |
| *** openstackgerrit has quit IRC | 18:31 | |
| *** openstackgerrit has joined #tacker | 18:32 | |
| tbh | sripriya, I think this should work http://paste.openstack.org/show/475110/ ? | 18:33 |
| tbh | I just got my setup working, I will try with this | 18:33 |
| sripriya | tbh: yup! that is what needs to be done! | 18:38 |
| sripriya | tbh: did the issue get resolved after this fix? | 18:39 |
| tbh | sripriya, checking that now | 18:39 |
| tbh | sripriya, that's working | 18:42 |
| tbh | nice, thanl you | 18:42 |
| tbh | *thankyou | 18:43 |
| tbh | sripriya, have you raised this bug in launchpad? | 18:46 |
| sripriya | tbh: sure, sorry this was caused due to the new changes we integrated for MANO api. i'm going to raise a bug for this | 18:46 |
| tbh | sripriya, sure thanks | 18:47 |
| *** tbh has quit IRC | 18:49 | |
| *** shrinathsuresh has joined #tacker | 19:18 | |
| *** shrinathsuresh has quit IRC | 19:19 | |
| *** sripriya has quit IRC | 19:46 | |
| openstackgerrit | vishwanath jayaraman proposed stackforge/tacker: Fixes VNF state being stuck in PENDING_CREATE https://review.openstack.org/229706 | 19:59 |
| *** elo1 has quit IRC | 20:10 | |
| *** sripriya has joined #tacker | 20:20 | |
| *** elo has joined #tacker | 20:28 | |
| *** sridhar_ram has joined #tacker | 20:55 | |
| vishwanathj | tackers, would appreciate review of https://review.openstack.org/229706, not too much code changes, but definitely a better user experience once this gets reviewed, approved and merged | 21:12 |
| *** sarob has left #tacker | 21:16 | |
| *** bobh has quit IRC | 21:44 | |
| openstackgerrit | vishwanath jayaraman proposed stackforge/tacker: Fixes vnf create failure even if all parameters are supplied https://review.openstack.org/230169 | 22:03 |
| openstackgerrit | Sripriya Seetharam proposed stackforge/tacker: Handle vnf response appropriately for MANO API https://review.openstack.org/230185 | 22:21 |
| *** prashantD_ has quit IRC | 23:13 | |
| *** bobh has joined #tacker | 23:59 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!