| *** hrou has joined #swift3 | 02:54 | |
| *** hrou has quit IRC | 04:11 | |
| *** openstackgerrit has quit IRC | 06:31 | |
| *** openstackgerrit has joined #swift3 | 06:32 | |
| openstackgerrit | Merged openstack/swift3: Ensure object copy response timestamp tags consistent with S3 https://review.openstack.org/223880 | 08:29 |
|---|---|---|
| kota_ | note I might break something in swift3 with patch 223880 | 12:27 |
| patchbot | kota_: https://review.openstack.org/#/c/223880/ - Ensure object copy response timestamp tags consist... | 12:27 |
| kota_ | I'm not sure right now but X-Timestamp should be in request object but the patch uses the header from response instance/ | 12:28 |
| kota_ | response instance for PUT request has X-Timestamp? | 12:29 |
| kota_ | probabry I am missing something because functional tests worked well anyway. | 12:30 |
| *** hrou has joined #swift3 | 13:59 | |
| timburke | kota_: swob ensures that the req.environ is resp.environ (as long as you've passed in the request); see https://github.com/openstack/swift/blob/7242c4a/swift/common/swob.py#L1141-L1142 | 17:19 |
| kota_ | timburke: thx! | 17:20 |
| timburke | still might not be a bad idea to change it to req (it's already available in both places), but it kinda feels more natural to look at the response... | 17:20 |
| timburke | i kinda wish swift *did* stuff it in the response headers... | 17:21 |
| kota_ | but it is only when request instance given. | 17:21 |
| kota_ | thanks again, currently swit3 is not broken if and only if swift doesn't make a weird response (i.e. generate response instance w/o request argument) | 17:22 |
| openstackgerrit | Kota Tsuyuzaki proposed openstack/swift3: WIP: Fix last modified on copy result https://review.openstack.org/242578 | 17:26 |
| kota_ | I think Swifters know we should make a response instance with the request instance but it seems not to be ensured. | 17:27 |
| kota_ | patch 242578 is still working in progress but | 17:28 |
| patchbot | kota_: https://review.openstack.org/#/c/242578/ - WIP: Fix last modified on copy result | 17:28 |
| kota_ | in the patch, I am trying to enxure the X-Timestamp existence even if backend swift does some wrong behavior. | 17:29 |
| kota_ | s/enxure/ensure | 17:29 |
| kota_ | but... no time I have to be heading to bed to get rest for tommorow flight. | 17:32 |
| kota_ | timburke: good night, thanks | 17:36 |
| timburke | g'night kota_! | 17:36 |
| *** openstackgerrit has quit IRC | 21:01 | |
| *** openstackgerrit has joined #swift3 | 21:02 | |
| *** hrou has quit IRC | 23:12 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!