*** kota_ has joined #swift3 | 00:25 | |
*** lyrrad has quit IRC | 00:36 | |
timburke | kota_: what do you think of patch 224912? as something of a package maintainer, it'd certainly simplify my life a little :) | 00:38 |
---|---|---|
patchbot | timburke: https://review.openstack.org/#/c/224912/ - Add a manifest file similar to Swift's | 00:38 |
timburke | and patch 198842; i feel like that one's been open for a while... | 00:38 |
patchbot | timburke: https://review.openstack.org/#/c/198842/ - Quote-wrap etags in bucket listings | 00:38 |
kota_ | let me look at | 00:38 |
timburke | thanks! | 00:39 |
*** _hrou_ has joined #swift3 | 00:47 | |
kota_ | patch 224912 looks good to me. | 00:48 |
patchbot | kota_: https://review.openstack.org/#/c/224912/ - Add a manifest file similar to Swift's | 00:48 |
kota_ | let me take a time to test according to your gerrit comment. | 00:48 |
*** hrou has quit IRC | 00:51 | |
kota_ | timburke: btw, could you have a time to look at signature v4 patch? (patch 211933) | 00:52 |
patchbot | kota_: https://review.openstack.org/#/c/211933/ - support AWS signature v4 | 00:52 |
timburke | kota_: yeah, i'd meant to circle back on that. i think there's still more work that needs to be done, but i haven't actually finished my review yet | 00:53 |
timburke | i'm not terribly fond of the version-specific user-agent sniffing :/ | 00:53 |
kota_ | yup, thanks. | 01:00 |
kota_ | done for patch 224912 | 01:13 |
patchbot | kota_: https://review.openstack.org/#/c/224912/ - Add a manifest file similar to Swift's | 01:13 |
openstackgerrit | Merged stackforge/swift3: Add a manifest file similar to Swift's https://review.openstack.org/224912 | 01:21 |
kota_ | timburke: still here? | 01:27 |
timburke | yeah, winding down for the day though | 01:27 |
kota_ | timburke: I'm now looking at patch 198842 but I still have a question | 01:28 |
patchbot | kota_: https://review.openstack.org/#/c/198842/ - Quote-wrap etags in bucket listings | 01:28 |
kota_ | for the validation of " | 01:28 |
kota_ | that is because the object list (i.e. objects variable) comes from GET container with format=json. | 01:29 |
kota_ | I tried to figure out the format but it seems not to include " in the name. | 01:29 |
kota_ | even if it is slo object. | 01:29 |
kota_ | As you said, the header etag of slo includes " character but ... | 01:30 |
timburke | correct. the container listing doesn't | 01:30 |
timburke | i'm still inclined to leave it though, in case Swift ever starts including quotes in etags for container listings | 01:31 |
kota_ | oh really, is that deprecated? | 01:32 |
timburke | not exactly; the rfc (http://tools.ietf.org/html/rfc2616#section-3.11) says that entity tags are quoted opaque strings, possibly prefixed by 'W/' | 01:36 |
timburke | so etags *should* have quotes, but apparently the one time that we tried to fix it, it broke a bunch of clients (or something; i kinda remember notmyname saying something along those lines) | 01:37 |
timburke | so it definitely won't happen in v1. but we might fix it whenever Swift gets a v2 api | 01:38 |
kota_ | ah, yeah | 01:39 |
kota_ | I know the history, thanks but still wonder about container listing. | 01:42 |
kota_ | RFC seems to define the header format of etag, that need quotes absolutely, I agreed. | 01:43 |
kota_ | And also the etag of GET bucket response includes quotes. | 01:44 |
kota_ | Just one thing, the json-formatted response from vanilla swift will have a chance to include the quotes? | 01:45 |
timburke | hmmm. i see what you're saying... maybe i agree. since we get to define the listing format however we like, it doesn't necessarily have to match the header; even if we wanted to include the weakness indicator, we could just have it as a separate key in the dict... | 01:46 |
kota_ | right now, I don't thinks so because it needs escape charactor in the string. | 01:46 |
kota_ | above my comments is for my previous comment. | 01:47 |
timburke | although the json library should be fine to take care of that for us... but yeah, i can put up a new patchset. if it becomes an issue, we'll fix it later | 01:49 |
kota_ | timburke: thanks :) | 01:49 |
openstackgerrit | Tim Burke proposed stackforge/swift3: Quote-wrap etags in bucket listings https://review.openstack.org/198842 | 01:53 |
timburke | yay! gerritbot works! i think this is the first patchset i've seen as a result :) | 01:54 |
kota_ | Awesome! | 01:54 |
kota_ | timburke: Added +2 +A for that, thanks :) | 01:56 |
openstackgerrit | Merged stackforge/swift3: Quote-wrap etags in bucket listings https://review.openstack.org/198842 | 02:25 |
*** _hrou_ has quit IRC | 03:19 | |
*** bill_az has quit IRC | 03:44 | |
*** chsc has joined #swift3 | 04:41 | |
*** chsc has quit IRC | 04:54 | |
*** openstackgerrit has quit IRC | 06:16 | |
*** openstackgerrit has joined #swift3 | 06:16 | |
*** kota_ has quit IRC | 09:06 | |
*** kota_ has joined #swift3 | 09:48 | |
*** kota_ has quit IRC | 12:57 | |
*** hrou has joined #swift3 | 13:07 | |
*** bill_az has joined #swift3 | 13:25 | |
*** chsc has joined #swift3 | 14:03 | |
*** lyrrad has joined #swift3 | 16:01 | |
*** hrou has quit IRC | 22:00 | |
*** hrou has joined #swift3 | 23:29 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!