| diablo_rojo | o/ | 18:04 |
|---|---|---|
| diablo_rojo | We said we wanted to meet today? | 18:05 |
| * diablo_rojo is late | 18:05 | |
| fungi | i can | 18:14 |
| fungi | improved feature for our container-based service deployments in opendev... virtual web browser screenshots are now fairly trivial to add to any job: https://zuul.opendev.org/t/openstack/build/731706bb6c57469cb3bb4c7bb96d7c2f/artifacts | 18:16 |
| fungi | that's probably good enough for us to ditch what we were previously trying to do with the storyboard-dev previews for webclient changes | 18:17 |
| diablo_rojo | Oh that would be cool. | 18:19 |
| diablo_rojo | What needs to happen to get that setup? Just get things setup like I did for the ptgbot like we've talked about? | 18:20 |
| fungi | yeah, basically | 18:21 |
| fungi | here's a cool example, comparing the same page on gerrit 3.2 (what we're running now) and 3.3 (what we hope to upgrade to soon): https://85d8043d60dd871d9480-d880cdb4cc1983adbfeb24ef0c06b667.ssl.cf5.rackcdn.com/807659/3/check/system-config-run-review-3.3/2d374af/bridge.openstack.org/screenshots/gerrit-change-page-1.png | 18:22 |
| fungi | https://db62f022a051878f64d1-33cd363c3f72485dda255154bdda0fc8.ssl.cf2.rackcdn.com/807659/3/check/system-config-run-review-3.2/cdc0e8f/bridge.openstack.org/screenshots/gerrit-change-page-1.png | 18:22 |
| fungi | some not so subtle differences, like removal of the comments column, addition of the assignee field... | 18:23 |
| fungi | code review icon changed from a clock face to an hourglass | 18:24 |
| fungi | color change to a lighter blue for the active status badge | 18:25 |
| diablo_rojo | Oh that is pretty cool. | 18:25 |
| diablo_rojo | Yeah you can see them well when you flip back and forth between the images | 18:25 |
| fungi | addition of the only comments slider and comment threads column | 18:25 |
| diablo_rojo | That is super cool! | 18:26 |
| fungi | but yeah, basically you just add the screenshot role to the job and specify what url you want to screenshot and what filename you want it saved as | 18:26 |
| diablo_rojo | Makes sense. | 18:26 |
| diablo_rojo | Got a link to what that role looks like? | 18:27 |
| fungi | i take back what i said about a role, it's happening in the testinfra script, so a python function definition (but a simple one!): https://opendev.org/opendev/system-config/src/branch/master/testinfra/test_gitea.py#L89-L99 | 18:28 |
| fungi | plus the addition of "from util import take_screenshots" at the top of the script | 18:29 |
| fungi | ianw did a bang-up job of generalizing this to make it more reusable | 18:30 |
| fungi | but also that test_gitea.py is a great example of how we might more generally test changes with a mock storyboard server deployment | 18:31 |
| fungi | you can see examples in there of things like checking that the robots.txt exists and has specific content, that services are running and listening and logging correctly | 18:33 |
| diablo_rojo | Okay. That's not so bad. | 18:33 |
| diablo_rojo | ianw is awesome like that | 18:33 |
| fungi | even an example cors header test in the mix | 18:33 |
| diablo_rojo | So one would need to make a script like this for storyboard. | 18:44 |
| diablo_rojo | And it would live in this test infra folder. | 18:45 |
| fungi | yep, that's where we keep the set of exercises for mock deployments of services we run in opendev, essentially | 18:46 |
| diablo_rojo | Yeah, looking through the rest of the dir, thats what I gleaned. | 18:46 |
| fungi | diablo_rojo: they can start off very simply too, like https://opendev.org/opendev/system-config/src/branch/master/testinfra/test_registry.py | 18:50 |
| fungi | that simply tests that a service started and bound a listening socket | 18:51 |
| diablo_rojo | Oh yeah that is super simple. | 18:52 |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!
