| *** jamesmcarthur has quit IRC | 00:14 | |
| *** jamesmcarthur has joined #storyboard | 00:15 | |
| *** jamesmcarthur has quit IRC | 00:16 | |
| *** jamesmcarthur has joined #storyboard | 00:16 | |
| *** jamesmcarthur has quit IRC | 00:17 | |
| *** jamesmcarthur has joined #storyboard | 00:19 | |
| *** jamesmcarthur has quit IRC | 00:19 | |
| *** jamesmcarthur has joined #storyboard | 00:35 | |
| *** jamesmcarthur has quit IRC | 00:52 | |
| *** diablo_rojo has quit IRC | 01:02 | |
| *** ianychoi has quit IRC | 01:16 | |
| *** ianychoi has joined #storyboard | 01:16 | |
| *** jamesmcarthur has joined #storyboard | 01:32 | |
| *** jamesmcarthur has quit IRC | 01:55 | |
| *** jamesmcarthur has joined #storyboard | 02:31 | |
| *** ianychoi has quit IRC | 02:31 | |
| *** ianychoi has joined #storyboard | 02:33 | |
| *** jamesmcarthur has quit IRC | 02:38 | |
| *** ianychoi has quit IRC | 02:51 | |
| *** ianychoi has joined #storyboard | 02:52 | |
| *** diablo_rojo has joined #storyboard | 03:02 | |
| *** diablo_rojo has quit IRC | 03:39 | |
| *** udesale has joined #storyboard | 04:04 | |
| *** ianychoi has quit IRC | 05:13 | |
| *** ianychoi has joined #storyboard | 05:14 | |
| *** ianychoi has quit IRC | 05:26 | |
| *** ianychoi has joined #storyboard | 05:28 | |
| *** jtomasek has joined #storyboard | 06:23 | |
| *** udesale has quit IRC | 07:06 | |
| *** udesale has joined #storyboard | 07:06 | |
| *** tosky has joined #storyboard | 07:12 | |
| *** udesale has quit IRC | 07:41 | |
| *** udesale has joined #storyboard | 07:42 | |
| *** udesale has quit IRC | 11:18 | |
| *** tonyb has joined #storyboard | 11:31 | |
| *** ianychoi has quit IRC | 11:37 | |
| *** ianychoi has joined #storyboard | 11:40 | |
| *** ianychoi has quit IRC | 12:00 | |
| *** ianychoi has joined #storyboard | 12:03 | |
| *** jamesmcarthur has joined #storyboard | 12:18 | |
| *** jamesmcarthur has quit IRC | 12:30 | |
| *** ianychoi has quit IRC | 12:39 | |
| *** ianychoi has joined #storyboard | 12:41 | |
| *** ianychoi has quit IRC | 12:54 | |
| *** ianychoi has joined #storyboard | 12:57 | |
| *** udesale has joined #storyboard | 13:31 | |
| *** diablo_rojo has joined #storyboard | 13:49 | |
| *** ianychoi has quit IRC | 13:58 | |
| *** ianychoi has joined #storyboard | 14:00 | |
| *** ianychoi has quit IRC | 14:38 | |
| *** ianychoi has joined #storyboard | 14:40 | |
| *** jamesmcarthur has joined #storyboard | 14:53 | |
| *** udesale has quit IRC | 15:34 | |
| *** diablo_rojo_phon has joined #storyboard | 15:42 | |
| *** efried has joined #storyboard | 15:44 | |
| efried | o/ storyboard! | 15:44 |
|---|---|---|
| diablo_rojo_phon | Hello efried! | 15:44 |
| Zara | \o | 15:45 |
| efried | couple of things I noticed yesterday & today | 15:45 |
| efried | 1) I can't assign a task. I tried putting variants of my name/handle in, using keys/mouse, punching the magnifying glass or hitting Return, etc; the tasks stay unassigned. | 15:46 |
| efried | specifically for this story: https://storyboard.openstack.org/#!/story/1735016 | 15:46 |
| efried | 1b) I kinda would have expected the same bot that changes Todo=>Review would assign to owner of review? | 15:47 |
| diablo_rojo_phon | 1) Which task? I can see if I can try and maybe reproduce the issue. | 15:47 |
| diablo_rojo_phon | 1b) that's actually a change that needs to be done by a bot that lives in Gerritland not in Storyboard and it is on our list of things to look into because we agree that would be ideal. | 15:49 |
| efried | 2) the bot comment when a related change is uploaded reads e.g. | 15:49 |
| efried | Change 690071 had a related patch set uploaded by Eric Fried: | 15:49 |
| efried | Link to (some) plugin doc pages | 15:49 |
| efried | https://review.opendev.org/690071 | 15:49 |
| efried | That is, it says "Change $gerritnum had... ... $link-to-same-$gerritnum" | 15:49 |
| efried | The duplication of $gerritnum isn't as useful as, for instance, if it said "Task $storyboard_task_num had a related patch set uploaded..." | 15:49 |
| efried | diablo_rojo_phon: 1) any of the tasks in that story. | 15:49 |
| efried | 1b) ack, so known issue ++ | 15:50 |
| *** ianychoi has quit IRC | 15:52 | |
| diablo_rojo | 2) We have discussed taking the review numbers/urls and associating them with the tasks instead of just posting on the comments section | 15:53 |
| diablo_rojo | I think we are in agreement as a team its cleaner and we want to do it this way. | 15:54 |
| diablo_rojo | We just havent gotten around to the UI changes yet. | 15:54 |
| *** ianychoi has joined #storyboard | 15:54 | |
| diablo_rojo | And that url would get updated each patch instead of a new comment each time | 15:54 |
| diablo_rojo | efried, ^^ | 15:55 |
| efried | oo, that would be neat. Having them in the comment stream is better than nothing, but I agree they would be much more useful tied to the task somehow | 15:56 |
| diablo_rojo | Yeah we could include some data I suppose about when it was last updated, but I think the closer association rather than just dumping into the timeline would be more helpful? | 15:56 |
| efried | o look, there's a twistie on a task where I can add notes. | 15:56 |
| efried | diablo_rojo: not sure what's possible here, but ideally a "note" on the task logging the action taken, plus a first-order field on the summary row indicating patch(es) *currently* associated | 15:57 |
| efried | the main improvement being associating either/both with the task instead of the story at large | 15:58 |
| efried | I guess many/most stories probably have only one task so it's not a huge deal... | 15:58 |
| efried | I need to run to a meeting. Thanks for the help diablo_rojo! | 15:58 |
| diablo_rojo | efried, thanks for the feedback! | 15:59 |
| diablo_rojo | I will keep looking in issue #1 | 15:59 |
| diablo_rojo | :) | 15:59 |
| efried | lmk if you want me to open stories for any of this or whatever | 15:59 |
| diablo_rojo | It would just be 1 if I can't figure it out. | 15:59 |
| diablo_rojo | I think we already have them for the other two points | 15:59 |
| diablo_rojo | But if you want to comment on them further I can dig them up | 15:59 |
| SotK | oops, part 1 looks like we added a bug in the webclient | 16:03 |
| * SotK can reproduce it trivially on any task | 16:04 | |
| SotK | I'll send a patch for that in a couple of hours | 16:04 |
| efried | cool, thanks SotK | 16:04 |
| fungi | also note that the story commit message footer is no longer really needed in addition to the task footer. you can just use the task footer and everything will still work | 16:15 |
| fungi | the story footer tends to be more relevant when you want a comment added to that story but you don't have a specific task in that story to update (so sort of like doing related-bug footers for launchpad bugs) | 16:16 |
| fungi | so i would use one or the other in a commit, not both | 16:16 |
| *** ianychoi has quit IRC | 17:39 | |
| *** ianychoi has joined #storyboard | 17:42 | |
| *** ianychoi has quit IRC | 17:55 | |
| *** ianychoi has joined #storyboard | 17:58 | |
| *** jamesmcarthur has quit IRC | 18:01 | |
| *** ianychoi has quit IRC | 18:12 | |
| *** ianychoi has joined #storyboard | 18:16 | |
| *** ianychoi has quit IRC | 18:26 | |
| *** ianychoi has joined #storyboard | 18:30 | |
| *** ianychoi has quit IRC | 18:38 | |
| *** ianychoi has joined #storyboard | 18:42 | |
| *** jamesmcarthur has joined #storyboard | 18:47 | |
| *** jamesmcarthur_ has joined #storyboard | 18:50 | |
| *** jamesmcarthur has quit IRC | 18:54 | |
| *** ianychoi has quit IRC | 19:04 | |
| *** jamesmcarthur has joined #storyboard | 19:05 | |
| *** jamesmca_ has joined #storyboard | 19:06 | |
| *** ianychoi has joined #storyboard | 19:08 | |
| *** jamesmcarthur_ has quit IRC | 19:08 | |
| *** jamesmcarthur has quit IRC | 19:09 | |
| *** jamesmcarthur has joined #storyboard | 19:10 | |
| *** jamesmcarthur has quit IRC | 19:12 | |
| *** jamesmca_ has quit IRC | 19:13 | |
| *** jamesmcarthur has joined #storyboard | 19:15 | |
| *** ianychoi has quit IRC | 19:15 | |
| *** ianychoi has joined #storyboard | 19:24 | |
| *** jamesmcarthur has quit IRC | 19:27 | |
| *** jamesmcarthur has joined #storyboard | 19:32 | |
| *** ianychoi has quit IRC | 19:39 | |
| *** jamesmcarthur has quit IRC | 19:46 | |
| *** jtomasek has quit IRC | 19:53 | |
| * SotK finally gets to a computer | 20:05 | |
| efried | SotK: I added more tasks to that story for you to play with :P | 20:06 |
| fungi | we've also got https://storyboard-dev.openstack.org/ if folks need a playground | 20:10 |
| *** openstackgerrit has joined #storyboard | 20:12 | |
| openstackgerrit | Adam Coldrick proposed opendev/storyboard-webclient master: Fix user_typeahead result rendering https://review.opendev.org/690400 | 20:12 |
| SotK | diablo_rojo, fungi: that fixes the task assignment issue if you have time for a quick review | 20:14 |
| diablo_rojo_phon | Looks like it was the show emails change that broke things. | 20:15 |
| fungi | for such a regression, i will make time | 20:15 |
| diablo_rojo_phon | (already looking at the patch) | 20:15 |
| fungi | diablo_rojo_phon: yep, i assumed that to be the case | 20:15 |
| diablo_rojo_phon | +2 ed | 20:16 |
| fungi | this won't show the e-mail address though, right? | 20:16 |
| SotK | it will do, that function renders the email too | 20:17 |
| fungi | oh! right | 20:17 |
| fungi | good deal | 20:17 |
| fungi | thanks! | 20:17 |
| efried | that will hit the real storyboard once the publish-openstack-javascript-content job makes it through post? | 20:20 |
| * efried guesses... | 20:20 | |
| SotK | it'll take a little longer, that job publishes a tarball which gets deployed whenever puppet next runs | 20:22 |
| efried | ight. | 20:23 |
| efried | Thanks SotK fungi diablo_rojo_phon! | 20:23 |
| SotK | you're welcome! | 20:23 |
| fungi | efried: yeah, hopefully no more than an hour after merge | 20:25 |
| fungi | there are ideas on how to speed that up too | 20:25 |
| efried | I'm not like slavering to assign my tasks to myself or anything. | 20:25 |
| efried | just to pop it off the stack | 20:25 |
| fungi | but it's also preventing you from reassigning your tasks to other unsuspecting victims! | 20:26 |
| efried | haha, I should do that :) | 20:26 |
| efried | fortunately for the world, I've been completing all my own tasks | 20:26 |
| efried | patches in seven new-to-me projects since yesterday | 20:27 |
| fungi | SotK: i noticed that the story about not being able to save something if you type the full string instead of a substring is expected to be fixed by upgrading the typeahead lib. i assume we need to bump the version of it somewhere and then get that into an updated webclient tarball? | 20:28 |
| SotK | yeah we'll need to bump the version in package.json | 20:29 |
| fungi | cool, i'll give that a shot once i get the webclient drafts sorted | 20:30 |
| SotK | however recent enough versions have a slightly different naming convention for the various attribute names it uses so there'll likely be some amount of find/replace needed | 20:30 |
| SotK | (iirc its just a simple prepending of uib- to most of them, but I'd need to check to be sure) | 20:31 |
| fungi | cool, will keep that in mind. thanks! | 20:32 |
| openstackgerrit | Adam Coldrick proposed opendev/storyboard-webclient master: Render user-submitted links with nofollow attribute https://review.opendev.org/648322 | 20:41 |
| openstackgerrit | Adam Coldrick proposed opendev/storyboard-webclient master: Render user-submitted links with nofollow attribute https://review.opendev.org/648322 | 20:42 |
| openstackgerrit | Merged opendev/storyboard-webclient master: Fix user_typeahead result rendering https://review.opendev.org/690400 | 20:44 |
| *** cgoncalves has quit IRC | 20:49 | |
| *** cgoncalves has joined #storyboard | 20:55 | |
| openstackgerrit | Adam Coldrick proposed opendev/storyboard-webclient master: Allowing the user to choose what Columns are seen https://review.opendev.org/651270 | 21:02 |
| openstackgerrit | Adam Coldrick proposed opendev/storyboard-webclient master: Render user-submitted links with nofollow attribute https://review.opendev.org/648322 | 21:12 |
| efried | SotK: assignment is now working, thank you! Though the search drop-down doesn't render quiiite right: https://imgur.com/a/fnPM4Vr | 21:32 |
| *** tosky has quit IRC | 22:56 | |
| *** diablo_rojo has quit IRC | 23:47 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!