| *** diablo_rojo has joined #storyboard | 00:21 | |
| *** tosky has quit IRC | 00:36 | |
| *** diablo_rojo has quit IRC | 00:51 | |
| *** diablo_rojo has joined #storyboard | 01:06 | |
| *** whoami-rajat has joined #storyboard | 02:08 | |
| *** diablo_rojo has quit IRC | 02:49 | |
| *** udesale has joined #storyboard | 04:31 | |
| *** kei-ichi has joined #storyboard | 04:49 | |
| *** irclogbot_0 has quit IRC | 05:30 | |
| *** irclogbot_3 has joined #storyboard | 05:32 | |
| *** jtomasek has joined #storyboard | 07:06 | |
| *** tosky has joined #storyboard | 07:15 | |
| *** dtantsur|afk is now known as dtantsur | 07:56 | |
| *** jpich has joined #storyboard | 07:59 | |
| *** tosky has quit IRC | 09:47 | |
| *** tosky has joined #storyboard | 09:48 | |
| *** udesale has quit IRC | 11:53 | |
| *** udesale has joined #storyboard | 11:53 | |
| *** udesale has quit IRC | 12:20 | |
| *** udesale has joined #storyboard | 12:21 | |
| *** udesale has quit IRC | 12:25 | |
| *** udesale has joined #storyboard | 12:25 | |
| *** jamesmcarthur has joined #storyboard | 14:05 | |
| *** diablo_rojo has joined #storyboard | 16:00 | |
| *** udesale has quit IRC | 16:12 | |
| *** jpich has quit IRC | 16:27 | |
| *** tosky has quit IRC | 16:47 | |
| *** diablo_rojo has quit IRC | 16:56 | |
| *** dtantsur is now known as dtantsur|afk | 16:56 | |
| *** diablo_rojo has joined #storyboard | 17:26 | |
| *** diablo_rojo has quit IRC | 18:05 | |
| *** diablo_rojo has joined #storyboard | 18:31 | |
| diablo_rojo | SotK, fungi got anything we should discuss today? | 18:32 |
|---|---|---|
| diablo_rojo | I guess we should probably talk about what to do now that we don't have an intern :'( | 18:32 |
| diablo_rojo | I'm updating the agenda now | 18:33 |
| fungi | we were un-intern'd? | 18:35 |
| fungi | i'm around, though all i've really storyboarded since last meeting was a few reviews, tagging some releases and importing karbor bugs | 18:37 |
| diablo_rojo | fungi, yeah she got a job offer and then her start date got moved to like.. this week | 18:37 |
| fungi | oh, and i did a test restore of our production server remote backups just to be sure they're viable | 18:37 |
| diablo_rojo | fungi, those are good things to have documented in a meeting log ;) | 18:38 |
| diablo_rojo | fungi, so Karbor is migrated? | 18:38 |
| fungi | hiring interns?!? how uncool ;) | 18:38 |
| diablo_rojo | fungi, I know stupid companies and their hiring people.. | 18:38 |
| fungi | yeah, karbor switched a week or two back and initially thought they didn't want to bother importing old bugs from lp, but once they were on sb they changed their minds and asked for imports | 18:39 |
| *** jamesmcarthur has quit IRC | 18:40 | |
| diablo_rojo | I'll still add them as a part of the annoucements in the agenda | 18:41 |
| *** jamesmcarthur has joined #storyboard | 18:41 | |
| * diablo_rojo runs to coffee shop before meeting | 18:41 | |
| diablo_rojo | Agenda should be up to date | 18:41 |
| *** jamesmcarthur has quit IRC | 18:46 | |
| *** diablo_rojo has quit IRC | 18:46 | |
| SotK | thank you :) | 18:50 |
| * fungi hopes nobody realizes when he says "coffee shop" it's a euphemism for the pub | 18:55 | |
| *** diablo_rojo has joined #storyboard | 18:57 | |
| diablo_rojo | back | 18:59 |
| *** jamesmcarthur has joined #storyboard | 19:04 | |
| *** jamesmcarthur has quit IRC | 19:10 | |
| *** jamesmcarthur has joined #storyboard | 19:23 | |
| diablo_rojo | So I should be able to just keep the function thats there in the patch and pop the regex in the include args | 19:50 |
| fungi | presumably | 19:50 |
| diablo_rojo | Okay so.. don't laugh. Here's my regex: [a-zA-Z0-9]*:[a-zA-Z0-9]* | 19:51 |
| diablo_rojo | SotK, look alright? | 19:51 |
| fungi | that will technically match ":" or any combination of mixed-case ascii letters and digits before and/or after the : | 19:51 |
| diablo_rojo | Which I thought is what we wanted..? | 19:52 |
| diablo_rojo | https://review.opendev.org/#/c/644424/4/src/app/services/criteria/criteria.js | 19:52 |
| diablo_rojo | for reference fungi ^ | 19:52 |
| SotK | I think we want be less restrictive on the right hand side of the colon, to support email addresses and such | 19:54 |
| fungi | my point was that your expression will also match anything with a : in it | 19:54 |
| SotK | and also we should use + instead of * | 19:55 |
| SotK | to make sure there is something on either side of the colon | 19:55 |
| fungi | you may also want to anchor the beginning and/or end of the expression with ^ and $ so it's not just matching a substring | 19:56 |
| fungi | also, SotK's example there includes _ in the mix, so your character class should probably match that too? | 19:56 |
| SotK | I think I'd do something like `^\w+:.*$` | 19:57 |
| fungi | that seems more like it | 19:57 |
| fungi | assuming it's valid js regex syntax | 19:57 |
| fungi | basically any string starting with one or more "word characters" followed by a : followed by zero or more of any sort of characters | 19:58 |
| fungi | though .*$ is redundant | 19:58 |
| diablo_rojo | Ehhh doesn't work in the checker | 19:58 |
| fungi | "^\w+:.*$" and "^\w+:" are functionally the same expression | 19:58 |
| SotK | yeah, I meant to type .+ | 19:59 |
| SotK | good spot | 19:59 |
| fungi | ahh, in that case sure, ending in one or more of any character | 19:59 |
| fungi | though again ".+$ is the same as "." | 20:00 |
| fungi | so "^\w+:." | 20:00 |
| diablo_rojo | Unless I am typing something wrong it doesnt actually match emails according to the checker | 20:01 |
| fungi | what example string are you trying to match? | 20:02 |
| fungi | something like user:foo@bar | 20:02 |
| diablo_rojo | I have a 'test:test' and a 'name@example.com' | 20:02 |
| fungi | test:test should match, name@example.com will not because there's no : | 20:03 |
| diablo_rojo | Yeah okay got it now. | 20:03 |
| diablo_rojo | Also the input for tests wasn't being accepted like I thought it was | 20:03 |
| fungi | i assume the idea is that we're going to tokenize around the part of the string before the first of one or more : characters | 20:05 |
| fungi | so if somehow i lived in a locale where : was an actual character in my language then user:fung:ble would match a user named "fung:ble" | 20:06 |
| fungi | but just entering "fung:ble" is not going to work because there are no "fung" type objects | 20:07 |
| SotK | yeah | 20:08 |
| fungi | so this is safe as long as terms are always preceded by a type identifier | 20:08 |
| fungi | and then the \w means we can have some flexibility in how we name our object types as long as they consist of non-whitespace non-punctuation | 20:08 |
| fungi | (where _ is generally not considered punctuation) | 20:09 |
| fungi | at least i assume that's how the \w class is handled by js | 20:09 |
| SotK | it is | 20:09 |
| SotK | we could/should probably also fall back to treating it as a regular search term if we don't have a matching thing to filter by to avoid weird errors if someone searches for "fung:ble" | 20:10 |
| fungi | that's not a bad idea | 20:10 |
| fungi | postel's law | 20:11 |
| fungi | (a.k.a. the robustness principle) | 20:11 |
| *** jamesmcarthur has quit IRC | 20:13 | |
| openstackgerrit | Kendall Nelson proposed opendev/storyboard-webclient master: Converting a search query into a browse https://review.opendev.org/644424 | 20:14 |
| *** jamesmcarthur has joined #storyboard | 20:15 | |
| openstackgerrit | Kendall Nelson proposed opendev/storyboard-webclient master: Allowing the user to choose what Columns are seen https://review.opendev.org/651270 | 20:22 |
| *** jamesmcarthur has quit IRC | 20:23 | |
| openstackgerrit | Kendall Nelson proposed opendev/storyboard-webclient master: Enabling suggestions on all user fields https://review.opendev.org/648525 | 20:30 |
| *** jtomasek has quit IRC | 20:38 | |
| *** whoami-rajat has quit IRC | 20:47 | |
| *** jamesmcarthur has joined #storyboard | 21:40 | |
| *** jamesmcarthur has quit IRC | 21:51 | |
| *** diablo_rojo has quit IRC | 22:05 | |
| *** zbr|ruck has quit IRC | 22:17 | |
| *** diablo_rojo has joined #storyboard | 22:35 | |
| openstackgerrit | Kendall Nelson proposed opendev/storyboard-webclient master: Converting a search query into a browse https://review.opendev.org/644424 | 22:44 |
| openstackgerrit | Kendall Nelson proposed opendev/storyboard-webclient master: Converting a search query into a browse https://review.opendev.org/644424 | 23:20 |
| diablo_rojo | SotK, can I get a review here when you've got a sec? https://review.opendev.org/#/c/645960/ | 23:30 |
| diablo_rojo | Would be nice to get that out of the way before I go adding to the contributor info with the story tags | 23:30 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!