*** jamesmcarthur has quit IRC | 01:09 | |
*** diablo_rojo has quit IRC | 02:37 | |
*** whoami-rajat has joined #storyboard | 02:37 | |
*** udesale has joined #storyboard | 04:04 | |
*** udesale has quit IRC | 05:52 | |
*** udesale has joined #storyboard | 06:33 | |
*** tosky has joined #storyboard | 07:20 | |
*** tosky has quit IRC | 07:33 | |
*** tosky has joined #storyboard | 07:33 | |
*** jpich has joined #storyboard | 07:52 | |
*** frickler has quit IRC | 07:58 | |
*** frickler has joined #storyboard | 07:59 | |
*** dtantsur|afk is now known as dtantsur | 08:00 | |
*** zbr has quit IRC | 08:28 | |
*** udesale has quit IRC | 09:57 | |
*** udesale has joined #storyboard | 09:58 | |
*** udesale has quit IRC | 10:56 | |
*** zbr has joined #storyboard | 11:09 | |
*** jamesmcarthur has joined #storyboard | 12:17 | |
johnsom | Yeah, they are not distinct. There are currently two of me. | 12:31 |
---|---|---|
*** jamesmcarthur has quit IRC | 12:34 | |
*** openstackgerrit has quit IRC | 12:44 | |
*** dtantsur is now known as dtantsur|brb | 12:46 | |
*** jamesmcarthur has joined #storyboard | 12:50 | |
*** jamesmcarthur has quit IRC | 13:04 | |
*** mkarray has joined #storyboard | 13:24 | |
*** udesale has joined #storyboard | 13:36 | |
mkarray | Yea I wasn't under the impression they were unique. We have creator_id for uniqueness | 13:42 |
*** dtantsur|brb is now known as dtantsur | 14:30 | |
*** jamesmcarthur has joined #storyboard | 14:47 | |
*** openstackgerrit has joined #storyboard | 15:07 | |
openstackgerrit | Malek Karray proposed openstack-infra/storyboard-webclient master: Allowing the user to choose what Columns are seen https://review.openstack.org/651270 | 15:07 |
*** udesale has quit IRC | 15:37 | |
*** jamesmcarthur has quit IRC | 15:42 | |
*** diablo_rojo has joined #storyboard | 16:01 | |
*** jamesmcarthur has joined #storyboard | 16:05 | |
*** mkarray has quit IRC | 16:09 | |
*** jamesmcarthur has quit IRC | 16:23 | |
*** mkarray has joined #storyboard | 16:45 | |
*** jamesmcarthur has joined #storyboard | 16:45 | |
*** jpich has quit IRC | 16:54 | |
*** dtantsur is now known as dtantsur|afk | 17:03 | |
diablo_rojo | fungi, seems theres a problem with the build links for most storyboard webclient patches these days any idea what's happening? - http://logs.openstack.org/70/651270/1/check/build-javascript-content/b246981/npm/html/ | 17:27 |
diablo_rojo | Ex. https://review.openstack.org/#/c/651270/1 | 17:31 |
clarkb | diablo_rojo: http://logs.openstack.org/70/651270/1/check/build-javascript-content/b246981/job-output.txt.gz#_2019-04-09_15_16_32_054615 I think that task being skipped is the cause | 17:32 |
clarkb | but I don't know why it is being skipped | 17:32 |
clarkb | http://logs.openstack.org/70/651270/1/check/build-javascript-content/b246981/ara-report/file/1351a833-d8ef-4f8b-81ca-e178933ae7b1/#line-115 seems like javascript_content_dir does not exist? | 17:34 |
fungi | i wonder if it got renamed (or the job started expecting it in a different place) | 17:34 |
fungi | looks like it's defaulting to "dist" | 17:38 |
fungi | though possibly creating the content in "build" instead? http://logs.openstack.org/70/651270/1/check/build-javascript-content/b246981/ara-report/result/b58fddc5-b5b3-4313-8693-fa21edd28c0a/ | 17:40 |
*** gmann is now known as gmann_afk | 17:40 | |
fungi | perhaps related to https://review.openstack.org/643531 | 17:40 |
fungi | it switched output: './dist' to './build' in Gruntfile.js | 17:42 |
fungi | merged a couple weeks ago | 17:42 |
fungi | we probably need to override javascript_content_dir to "build" in a local variant of the build-javascript-content job? | 17:43 |
clarkb | ya that looks right | 17:43 |
diablo_rojo | Oh yeah I think that would do it. | 17:44 |
diablo_rojo | fungi, if you want to put the patch up I can +2 +W | 17:47 |
fungi | i'll give it a try | 17:47 |
openstackgerrit | Jeremy Stanley proposed openstack-infra/storyboard-webclient master: Override javascript_content_dir in build job https://review.openstack.org/651341 | 17:52 |
fungi | diablo_rojo: clarkb: SotK: ^ | 17:52 |
fungi | that *should* be self-testing | 17:52 |
diablo_rojo | fungi, looks right to me, but will wait to see Zuul results | 17:53 |
fungi | please do | 17:54 |
* diablo_rojo should probably learn the zuul config stuff better | 17:54 | |
SotK | Oops sorry, I didn't think about that job needing to be updated too | 17:55 |
diablo_rojo | SotK, no worries, I didn't catch it either. Easy enough to fix too. | 17:56 |
SotK | That change looks like it'll fix it to me, thanks fungi | 17:56 |
SotK | I'd rather extend the backend code to use a join or some ORM magic to allow the stories table to be sorted by creator name than add a full name column, duplicating that data seems unnecessary and problematic if we ever need to update a name for whatever reason | 17:58 |
fungi | no need to apologize, just glad clarkb managed to figure it out so fast | 17:58 |
*** gmann_afk is now known as gmann | 18:21 | |
diablo_rojo | Came back green and has a javascript build! So I +2 +W ed | 18:30 |
fungi | that's what we want. awesome! | 18:31 |
openstackgerrit | Merged openstack-infra/storyboard-webclient master: Override javascript_content_dir in build job https://review.openstack.org/651341 | 18:42 |
*** jamesmcarthur has quit IRC | 18:55 | |
mkarray | I have the exact mySQL query needed to make that magic happen SotK, though I am unfamiliar with the sqlalchemy api and had no luck piecing it together | 19:00 |
*** whoami-rajat has quit IRC | 19:17 | |
*** jamesmcarthur has joined #storyboard | 19:21 | |
*** NCLanceman has joined #storyboard | 19:25 | |
clarkb | mkarray: maybe push up a change with a comment that has your sql query and where you've started to sqlalchemize it? | 19:32 |
clarkb | gives peopel somethign to start with | 19:32 |
clarkb | (and then often times we can convince mordred to take a look) | 19:32 |
fungi | it helps to dare him to solve the riddle | 19:35 |
mordred | :) | 19:38 |
*** tsmith2 has quit IRC | 20:05 | |
*** tsmith2 has joined #storyboard | 20:06 | |
*** jamesmcarthur has quit IRC | 20:17 | |
*** jamesmcarthur has joined #storyboard | 20:18 | |
*** jamesmcarthur has quit IRC | 20:44 | |
*** jamesmcarthur has joined #storyboard | 20:45 | |
*** jamesmcarthur has quit IRC | 21:11 | |
openstackgerrit | Merged openstack-infra/storyboard master: Search bars handle queries as if they have a * at the end https://review.openstack.org/644487 | 21:40 |
*** mkarray has quit IRC | 21:55 | |
*** jamesmcarthur has joined #storyboard | 22:03 | |
*** jamesmcarthur has quit IRC | 22:42 | |
*** dangtrinhnt has quit IRC | 22:50 | |
*** jamesmcarthur has joined #storyboard | 22:52 | |
*** dangtrinhnt has joined #storyboard | 22:57 | |
*** jamesmcarthur has quit IRC | 23:03 | |
*** jamesmcarthur has joined #storyboard | 23:06 | |
*** jamesmcarthur has quit IRC | 23:14 | |
*** jamesmcarthur has joined #storyboard | 23:30 | |
*** jamesmcarthur has quit IRC | 23:30 | |
*** tosky has quit IRC | 23:36 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!