*** jamesmcarthur has quit IRC | 00:24 | |
*** jamesmcarthur has joined #storyboard | 00:55 | |
*** jamesmcarthur has quit IRC | 00:55 | |
*** jamesmcarthur has joined #storyboard | 00:56 | |
*** NCLanceman has quit IRC | 01:12 | |
*** NCLanceman has joined #storyboard | 01:13 | |
*** dtantsur|afk has quit IRC | 01:24 | |
*** dtantsur has joined #storyboard | 01:25 | |
*** whoami-rajat has joined #storyboard | 01:57 | |
*** jamesmcarthur has quit IRC | 02:31 | |
*** jamesmcarthur has joined #storyboard | 03:01 | |
*** udesale has joined #storyboard | 04:00 | |
*** scherbatsky has quit IRC | 04:21 | |
*** scherbatsky has joined #storyboard | 04:23 | |
*** whoami-rajat has quit IRC | 04:57 | |
*** tosky has joined #storyboard | 07:09 | |
*** whoami-rajat has joined #storyboard | 07:13 | |
SotK | the idea behind story_types was originally to allow specification of stories as one of "bug", "feature", "private vulnerability", or "public vulnerability", with a pre-defined set of ways to transition between those states | 07:13 |
---|---|---|
SotK | it has since been successfully argued that there isn't sufficient functional difference between "bug" and "feature" to need it specifying in a more complex way than by just using a tag if really necessary | 07:14 |
SotK | also, "private vulnerability" and "public vulnerability" don't provide enough granularity; we wanted the ability for any story to be private, not just security-related things | 07:16 |
SotK | at which point it is pointless to implement as a set of types which can be mutated between, and instead just use a boolean to denote whether or not a story is private | 07:17 |
SotK | (and to complete the story, whether or not a story is security-related, as added in https://review.openstack.org/#/c/642056/) | 07:17 |
SotK | so yes, story_types isn't actually used anywhere since it was never fully implemented, we've just never cleaned it up after changing the approach (see https://review.openstack.org/#/c/451505/ for some old unfinished work in that direction) | 07:19 |
SotK | that search template is the template for the search view (the one which searches "everything" rather than specifically stories), its referenced here: https://opendev.org/openstack-infra/storyboard-webclient/src/branch/master/src/app/search/module.js#L30 | 07:23 |
SotK | as for redesigning the applySearch stuff, I think that ideally we need to have something which calls applySearch on each of the resources after they're all initialised (and the applySearch call in them removed), to avoid them having a set order in which they can be used | 07:27 |
SotK | I'm not sure on the best place to put that really | 07:28 |
SotK | probably in src/app/storyboard/module.js in a similar way to the way we add transition hooks for ui-router | 07:30 |
SotK | speaking of which, it'd be great if someone can review https://review.openstack.org/#/c/642755/ because fixing that will greatly improve everyone's quality of life | 07:31 |
*** NCLanceman has quit IRC | 07:48 | |
*** jpich has joined #storyboard | 07:56 | |
*** jpich has quit IRC | 09:27 | |
*** jpich has joined #storyboard | 09:28 | |
*** dhellmann has quit IRC | 09:37 | |
*** whoami-rajat has quit IRC | 09:37 | |
*** dhellmann has joined #storyboard | 09:46 | |
*** dhellmann has quit IRC | 09:53 | |
*** dhellmann has joined #storyboard | 10:02 | |
*** udesale has quit IRC | 11:26 | |
*** whoami-rajat has joined #storyboard | 12:19 | |
*** jamesmcarthur has quit IRC | 12:26 | |
*** jamesmcarthur has joined #storyboard | 12:27 | |
*** dtantsur is now known as dtantsur|brb | 12:36 | |
*** jamesmcarthur has quit IRC | 12:36 | |
*** dtantsur|brb is now known as dtantsur | 12:36 | |
*** jamesmcarthur_ has joined #storyboard | 12:43 | |
*** mkarray has joined #storyboard | 13:12 | |
mkarray | Thanks for the info SotK :) | 13:17 |
*** ankita-2798 has joined #storyboard | 13:28 | |
*** ankita-2798 has quit IRC | 13:31 | |
*** udesale has joined #storyboard | 13:56 | |
scherbatsky | SotK: Thanks, I'll try to work it out :) | 15:06 |
*** jamesmcarthur_ has quit IRC | 15:53 | |
*** NCLanceman has joined #storyboard | 15:56 | |
*** jamesmcarthur has joined #storyboard | 16:12 | |
*** jamesmcarthur has quit IRC | 16:15 | |
*** udesale has quit IRC | 16:19 | |
*** jamesmcarthur has joined #storyboard | 16:23 | |
*** dtantsur is now known as dtantsur|afk | 16:24 | |
*** openstackgerrit has joined #storyboard | 16:26 | |
openstackgerrit | Jason Lee proposed openstack-infra/storyboard master: WORK IN PROGRESS: Added script for webscraping Launchpad Blueprint pages, generating a list of blueprints in a project. https://review.openstack.org/649666 | 16:26 |
*** jpich has quit IRC | 16:27 | |
*** jamesmcarthur has quit IRC | 16:52 | |
*** jamesmcarthur has joined #storyboard | 16:56 | |
*** jamesmcarthur has quit IRC | 17:35 | |
*** jamesmcarthur has joined #storyboard | 18:17 | |
*** jamesmcarthur has quit IRC | 18:21 | |
*** samueldmq has joined #storyboard | 18:25 | |
*** jamesmcarthur has joined #storyboard | 18:31 | |
*** tosky has quit IRC | 19:44 | |
*** jamesmcarthur has quit IRC | 19:55 | |
*** mrhillsman is now known as mrhillsman_bbiab | 20:11 | |
*** whoami-rajat has quit IRC | 20:29 | |
*** jamesmcarthur has joined #storyboard | 20:33 | |
*** jamesmcarthur has quit IRC | 20:39 | |
*** jamesmcarthur has joined #storyboard | 20:41 | |
*** NCLanceman has quit IRC | 20:53 | |
*** mkarray has quit IRC | 21:19 | |
*** jamesmcarthur has quit IRC | 22:14 | |
*** jamesmcarthur has joined #storyboard | 22:32 | |
*** jamesmcarthur has quit IRC | 22:32 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!