*** irclogbot_3 has joined #storyboard | 00:18 | |
*** jamesmcarthur has quit IRC | 00:30 | |
*** jamesmcarthur has joined #storyboard | 01:46 | |
*** jamesmcarthur has quit IRC | 02:03 | |
*** diablo_rojo has quit IRC | 02:25 | |
*** udesale has joined #storyboard | 03:21 | |
*** whoami-rajat has joined #storyboard | 03:41 | |
*** jamesmcarthur has joined #storyboard | 03:51 | |
*** jamesmcarthur has quit IRC | 04:12 | |
*** ivy has joined #storyboard | 04:22 | |
*** ivy has joined #storyboard | 04:23 | |
*** ivy has quit IRC | 04:27 | |
*** hogepodge has quit IRC | 04:32 | |
*** johnsom has quit IRC | 04:32 | |
*** diablo_rojo_phon has quit IRC | 04:33 | |
*** thrace has quit IRC | 04:33 | |
*** thrace has joined #storyboard | 04:33 | |
*** johnsom has joined #storyboard | 04:35 | |
*** hogepodge has joined #storyboard | 04:35 | |
*** udesale has quit IRC | 04:47 | |
*** udesale has joined #storyboard | 04:47 | |
*** jamesmcarthur has joined #storyboard | 04:52 | |
*** jamesmcarthur has quit IRC | 04:57 | |
*** diablo_rojo_phon has joined #storyboard | 05:09 | |
*** jtomasek has joined #storyboard | 06:17 | |
*** scherbatsky has joined #storyboard | 06:18 | |
*** whoami-rajat has quit IRC | 07:11 | |
*** whoami-rajat has joined #storyboard | 07:30 | |
*** Rou has left #storyboard | 07:52 | |
*** Rou has joined #storyboard | 07:52 | |
*** tosky has joined #storyboard | 07:53 | |
scherbatsky | I'm working on adding Stories as a thing that Projects can be browsed on, so that they appear the search dropdown, but I've been getting a lot of circular dependency errors as I do that. So basically Project depends on Story, which in turn depends on Project. | 07:59 |
---|---|---|
scherbatsky | I've tried using the $injector service, but keep getting more and more errors like that | 08:00 |
scherbatsky | Does anyone know how could I refactor the code to get rid of these ? | 08:01 |
*** dtantsur|afk is now known as dtantsur | 08:33 | |
*** jpich has joined #storyboard | 08:43 | |
*** scherbatsky has quit IRC | 08:55 | |
*** scherbatsky has joined #storyboard | 08:56 | |
SotK | oh, that's a really horrible circular dependency | 09:32 |
SotK | I suspect the whole resource_factory.js approach will need refactoring somewhat | 09:32 |
* SotK does some thinking | 09:32 | |
scherbatsky | Probably, because it all starts in resource factory where the injector service is getting the resource type using injector service (precisely line 125) | 09:34 |
scherbatsky | Rephrasing this - 'Probably, because it all starts in resource factory where the injector service is used to get the resource type (precisely line 125)' | 09:37 |
SotK | yep | 09:37 |
scherbatsky | If you've some clue about how we could refactor it, I'll give it a shot | 09:39 |
SotK | I think we'll need to have some way of calling applySearch outside of all the resource abstractions themselves, so they're all actually available to be injected when we need them, but I'm not really sure on what the best way to do that will be | 09:42 |
scherbatsky | okay, I'll try to figure that | 09:54 |
*** jpich has quit IRC | 10:13 | |
*** jpich has joined #storyboard | 10:14 | |
*** dtantsur is now known as dtantsur|brb | 10:28 | |
*** johnsom has quit IRC | 10:59 | |
*** johnsom has joined #storyboard | 10:59 | |
*** whoami-rajat has quit IRC | 10:59 | |
*** diablo_rojo_phon has quit IRC | 11:00 | |
*** whoami-rajat has joined #storyboard | 11:01 | |
*** ankita-2798 has joined #storyboard | 11:22 | |
*** ankita-2798 has quit IRC | 11:31 | |
*** ankita-2798 has joined #storyboard | 11:31 | |
*** scherbatsky has quit IRC | 11:55 | |
*** scherbatsky has joined #storyboard | 11:55 | |
*** dtantsur|brb is now known as dtantsur | 12:05 | |
*** ankita-2798 has quit IRC | 12:12 | |
Rou | [Radwa Khattab (radwasm), Rou's Workspace] In this issue... https://storyboard.openstack.org/#!/story/2001615 | 12:46 |
*** udesale has quit IRC | 12:47 | |
Rou | [Radwa Khattab (radwasm), Rou's Workspace] I wouldn't need to change anything in webclient, I think, right? | 12:47 |
Rou | Cuz from what I noticed is that the search already considers the text as a tag, however no results are returned upon this option. | 12:47 |
*** udesale has joined #storyboard | 12:48 | |
*** altlogbot_2 has quit IRC | 13:01 | |
*** irclogbot_3 has quit IRC | 13:01 | |
*** altlogbot_0 has joined #storyboard | 13:03 | |
*** irclogbot_0 has joined #storyboard | 13:03 | |
*** ivy has joined #storyboard | 13:08 | |
*** mkarray has joined #storyboard | 13:08 | |
mkarray | To continue on yesterday's short discussion, I think this might actually do the trick better than a star: https://fontawesome.com/icons/thumbtack?style=solid | 13:17 |
mkarray | To me a star is more symbolic of anything important, which might make sense when a user is querying on themselves, but not for other people. | 13:18 |
*** scherbatsky has quit IRC | 14:11 | |
*** cmoura has quit IRC | 14:42 | |
*** cmoura has joined #storyboard | 14:43 | |
persia | Am I interpreting context properly that this is a proposal for https://fontawesome.com/icons/thumbtack?style=solid for "subscriber"? | 14:45 |
mkarray | it is a proposal for subscriber_id, if a query is made on subscriber_id:2 it will bring up the stories user 2 is subscriber to | 14:58 |
mkarray | subscribed* | 15:01 |
persia | Cool. Just wanted to make sure I was following :) | 15:08 |
*** jamesmcarthur has joined #storyboard | 15:12 | |
*** altlogbot_0 has quit IRC | 15:21 | |
*** altlogbot_2 has joined #storyboard | 15:26 | |
*** irclogbot_0 has quit IRC | 15:30 | |
*** irclogbot_3 has joined #storyboard | 15:33 | |
*** irclogbot_3 has quit IRC | 15:36 | |
*** irclogbot_3 has joined #storyboard | 15:38 | |
*** diablo_rojo_phon has joined #storyboard | 15:42 | |
*** scherbatsky has joined #storyboard | 15:53 | |
*** jpich has quit IRC | 16:54 | |
*** udesale has quit IRC | 17:00 | |
*** jamesmcarthur has quit IRC | 17:05 | |
*** dtantsur is now known as dtantsur|afk | 17:11 | |
*** diablo_rojo has joined #storyboard | 17:15 | |
*** jamesmcarthur has joined #storyboard | 17:22 | |
*** jamesmcarthur has quit IRC | 17:27 | |
*** jamesmcarthur has joined #storyboard | 17:34 | |
*** ericbarrett has quit IRC | 17:35 | |
*** diablo_rojo has quit IRC | 17:39 | |
*** gmann is now known as gmann_afk | 17:52 | |
*** gmann_afk is now known as gmann | 18:11 | |
mkarray | Anyone here with a decent understanding of routing in angularjs? | 18:16 |
*** jamesmcarthur has quit IRC | 18:19 | |
*** jamesmcarthur has joined #storyboard | 18:20 | |
*** jamesmcarthur has quit IRC | 18:24 | |
*** mkarray has quit IRC | 18:49 | |
*** mkarray has joined #storyboard | 18:56 | |
*** mkarray has quit IRC | 19:21 | |
*** jtomasek has quit IRC | 19:23 | |
*** ivy has quit IRC | 19:25 | |
Rou | [Radwa Khattab (radwasm), Rou's Workspace] Why doesn't anything change when I edit something in code and refresh page on localhost? | 20:17 |
Rou | There supposed to be a change immediately, right?! | 20:17 |
clarkb | Rou: is this in the python code? | 20:19 |
clarkb | if it is the python code you likely have to restart the python process to pick up the changes | 20:19 |
*** diablo_rojo has joined #storyboard | 20:22 | |
*** ankita-2798 has joined #storyboard | 20:50 | |
*** ankita-2798 has quit IRC | 20:54 | |
Rou | [Radwa Khattab (radwasm), Rou's Workspace] Out of topic, are your work days from Sunday to Thursday or from Monday to Friday or what? | 21:20 |
openstackgerrit | Kendall Nelson proposed openstack-infra/storyboard-webclient master: Show Email Addresses when Searching https://review.openstack.org/589713 | 22:00 |
*** whoami-rajat has quit IRC | 22:41 | |
diablo_rojo | Rou, depends on who you are talking to and where you are based. I work M-F but I am US based so depending on where you are at it might be your Tuesday when I start working. | 22:45 |
*** tosky has quit IRC | 23:01 | |
openstackgerrit | Kendall Nelson proposed openstack-infra/storyboard master: Link development.rst to contributing.rst https://review.openstack.org/645960 | 23:29 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!