Wednesday, 2019-02-27

*** tosky has quit IRC00:02
*** jamesmcarthur has joined #storyboard00:47
*** jamesmcarthur has quit IRC01:01
*** jamesmcarthur has joined #storyboard01:02
*** whoami-rajat has joined #storyboard02:01
*** jamesmcarthur has quit IRC02:18
*** jamesmcarthur has joined #storyboard02:20
*** jamesmcarthur has quit IRC02:25
*** jamesmcarthur has joined #storyboard02:55
*** jamesmcarthur has quit IRC03:01
*** jamesmcarthur has joined #storyboard04:46
*** ivy has quit IRC05:05
*** jamesmcarthur has quit IRC05:19
*** udesale has joined #storyboard05:42
*** kshitija has joined #storyboard06:23
*** kshitija has quit IRC06:45
*** jamesmcarthur has joined #storyboard06:49
*** jtomasek has joined #storyboard06:53
*** jamesmcarthur has quit IRC06:54
*** kshitija has joined #storyboard07:00
*** lakshmi_p has joined #storyboard07:38
lakshmi_pHello :) I'm Lakshmi, I got here through the Outreachy program. I'm looking forward to work with you guys and know you all :)07:42
*** lakshmi_p has quit IRC07:49
*** jamesmcarthur has joined #storyboard07:51
*** lakshmi has joined #storyboard07:51
*** lakshmi has quit IRC07:54
*** lakshmi has joined #storyboard07:54
*** jamesmcarthur has quit IRC07:55
*** zbr|ssbarnea has joined #storyboard08:22
*** zbr|ssbarnea is now known as zbr08:22
*** tosky has joined #storyboard08:41
*** jamesmcarthur has joined #storyboard08:51
*** jamesmcarthur has quit IRC08:56
*** jpich has joined #storyboard09:04
cmouraHi folks. I'm working on #28146 and I want to test the migration process from launchpad to storyboard. But, I'm getting an error when I'm trying to run the migration. Here: https://pastebin.com/6HJFXShr09:34
jaosoriorhey folks! could I get a review for this https://review.rdoproject.org/r/#/c/19016/ ?09:36
jaosoriord'oh! wrong channel09:36
*** rluders has joined #storyboard09:36
SotKcmoura: oh, looks like the openid library we use doesn't support python3 :(09:42
SotKhttps://pypi.org/project/python3-openid/ appears to exist, you could try replacing python-openid with python3-openid in our requirements.txt and retrying09:43
SotK(you'll also need to do `rm -rf .tox/venv` to force tox to regenerate the virtualenv with the new dependency)09:44
cmouraSotK, Thanks :)09:47
*** rijukhatri has joined #storyboard09:50
*** jamesmcarthur has joined #storyboard09:52
*** jamesmcarthur has quit IRC09:57
rijukhatriHi there!10:35
rijukhatriI'm new to openstack, and was trying to setup the storyboard project locally on my mac, following the guide https://docs.openstack.org/infra/storyboard/install/development.html10:36
rijukhatriBut I'm kinda stuck. It'd be great if someone could help me out here10:37
SotKhi!10:37
SotKwhat issues are you having?10:37
rijukhatriThe instructions here are for linux it seems, and when I try to install the packages using brew - it can't find them10:39
SotKyeah, the instructions are for linux, but other than the package installation bits they should work on Mac too I think10:42
SotKas for the packages, https://gist.github.com/nrollr/3f57fc15ded7dddddcc4e82fe137b58e looks like it should be sufficient for the mysql part10:42
SotKand I think that `brew install python` should get you a sufficient version of python10:43
SotKthat should install pip too, so there's no need for the separate install of python-pip10:44
cmouraSotK, I found one bug in migrate/launchpad/reader.py at line 42. but I fixed it. ;) So far so good the migration is running10:44
*** lakshmi_p has joined #storyboard10:44
*** lakshmi has quit IRC10:44
rijukhatriYes I've got python and mysql, but what about libpq-dev and libmysqlclient-dev?10:45
SotKrijukhatri: they aren't actually needed (libmysqlclient-dev is a dependency of the ubuntu mysql packages and libpq-dev is for postgresql which we no longer support)10:47
SotKthere's a patch to update those docs to be more accurate here: https://review.openstack.org/#/c/633354/10:47
rijukhatrioh alright! thanks !10:48
SotKcmoura: feel free to send a patch to Gerrit with the dependency update and bugfix then (since I assume the bugfix was also related to using python3 rather than python2) :)10:49
*** udesale has quit IRC10:53
*** lakshmi_p has quit IRC11:20
*** lakshmi has joined #storyboard11:22
*** rijukhatri has quit IRC11:43
*** jamesmcarthur has joined #storyboard11:54
*** lakshmi has quit IRC11:58
*** jamesmcarthur has quit IRC11:59
*** kenellysra has joined #storyboard12:01
*** kenellysra has quit IRC12:02
*** kenysra has joined #storyboard12:04
*** kenysra has quit IRC12:05
*** udesale has joined #storyboard12:26
*** jamesmcarthur has joined #storyboard12:55
*** jamesmcarthur has quit IRC12:59
*** rijukhatri has joined #storyboard13:01
*** kshitija has quit IRC13:35
*** kshitija has joined #storyboard13:40
*** jamesmcarthur has joined #storyboard13:48
cmouraSo, in test "sudo tox" I had this error:  https://pastebin.com/LnrNsTVA13:59
*** mkarray has quit IRC14:07
*** jamesmcarthur has quit IRC14:14
*** mkarray has joined #storyboard14:19
cmouraCan I do the commit with this error?  because I think this won't relation with my alteration.14:32
*** jamesmcarthur has joined #storyboard15:03
*** lakshmi has joined #storyboard15:06
openstackgerritCamila Moura proposed openstack-infra/storyboard master: Fixes the dependencies for Python 3  https://review.openstack.org/63971515:45
openstackgerritCamila Moura proposed openstack-infra/storyboard master: Fixes LauchpadReader iterator  https://review.openstack.org/63971615:45
openstackgerritMerged openstack-infra/storyboard master: Update development installation documentation  https://review.openstack.org/63335416:04
openstackgerritCamila Moura proposed openstack-infra/storyboard master: Fixes the dependencies for Python 3  https://review.openstack.org/63971616:08
*** udesale has quit IRC16:10
*** gouthamr has quit IRC16:48
*** gouthamr has joined #storyboard16:50
*** rijukhatri has quit IRC16:57
*** jamesmcarthur_ has joined #storyboard17:14
*** jamesmcarthur has quit IRC17:17
*** jpich has quit IRC17:30
*** kshitija has quit IRC17:32
*** kenysra has joined #storyboard17:33
*** kenysra has quit IRC17:33
*** rijukhatri has joined #storyboard17:34
mordredSotK, fungi: remote:   https://review.openstack.org/639760 WIP Add support for generating form-post signatures17:45
fungithanks!!!17:45
mordredI still need to add tests, but that should be the code needed to generate the hmac signature. then, the storyboard api can return the signature/timestamp to the user in the API call instead of the token17:46
mordredand the webclient can FORM post to the url17:46
mordredas per the instructions on the linked swift docs page17:46
mordredbut that way we'll ensure if anybody uses the API directly, we'll only be giving them expriable access to upload files to a specific location17:47
mordredfungi: also - the 'key' is just an arbitrary shared secret, and it can be re-read from swift if a user has access - so I'm thinking I'm going to update that method to not require passing the key in, but instead to just read if from the swift metadata. that way we don't need to have storyboard need a copy of the key in its own config17:49
fungithat'll help17:50
*** ivy has joined #storyboard17:53
SotKnice, that looks like it should make things really neat on the webclient side, thanks18:01
*** rijukhatri has quit IRC18:07
mordred\o/18:08
mordrednow just have to actually test it18:09
*** lakshmi has quit IRC18:10
*** jtomasek has quit IRC18:15
*** pooja_agarwal has joined #storyboard18:43
fungiare we holding a meeting today?19:00
fungiper discussion in #openstack-infra i've created a story for "Add activity indicator to new worklist modal" https://storyboard.openstack.org/#!/story/200510419:01
SotKI can run one if people want one19:02
fungistill not 100% sure i get the steps which led to prometheanfire's 500 error when removing criteria from an automatic worklist during creation... i was unable to reproduce it myself19:02
SotKI don't think I have anything that desperately needs a meeting19:02
SotK(sorry, I lost track of time reading sqlalchemy docs)19:02
funginor do i. i did get through reviewing your api-side series of changes for the attachments implementation19:03
clarkbas anyone looked at the local unittest setup story (re cmoura and ivy's questions?)19:03
fungiworth noting mordred pointed out a concern with the way credentials were being handled and has worked up an alternative solution to that using swift tempurls19:03
clarkbI'm assuming the setup script(s) work to some degree because we must ci with them, but we may be missing setup steups?19:04
fungiclarkb: i approved (i think i did anyway) SotK's dev environment setup documentation updates from a few weeks ago earlier today19:04
clarkbah ok19:04
fungihttps://review.openstack.org/633354 Update development installation documentation19:04
funginot sure if that covers it all though19:05
clarkbcmoura: ^ can you check if that gets your tests running?19:05
diablo_rojoSotK, fungi meeting time?19:05
fungidiablo_rojo: we were just debating the merits of holding a formal meeting today or not19:05
fungiso... you're just in time for that anyway! ;)19:06
SotKthat patch doesn't cover getting the tests set up19:06
* diablo_rojo should read the scrollback lol19:06
clarkbSotK: ah its just setting up the service from scratch?19:06
fungiare we in agreement on no meeting this week then? i'll say something in #openstack-meeting if so19:10
SotKyeah, to run the tests you either need to add a database account with the credentials we have hardcoded (openstack_citest:openstack_citest iirc) or set the STORYBOARD_TEST_DB environment variable to contain the correct connection string19:11
fungiclarkb: one of my initial concerns is that we seem to have been instructing people to `sudo tox ...` which doesn't seem like it ought to be necessary if we have some separate setup script for the root parts19:11
clarkbfungi: git grep 'sudo tox' returns no results19:12
clarkbso not sure where we are doing that19:12
SotKyeah that sudo was definitely unnecessary, I'm not sure what Zara and I were doing that made it seem required when we were first setting up our environments19:12
fungithe aforementioned change removed it19:12
clarkbah19:12
clarkbI would expect sudo tools/test-setup.sh && tox -re py27 to work19:13
clarkbor something really similar to that so probably just a matter of making that work out side the CI environment19:13
fungiand also `tox -e bindep` followed by installing whatever system packages it says are missing19:14
SotKthe tools/install_test_backend.sh script should set up the required account in mysql, but it also does a bunch of other stuff19:14
openstackgerritJames E. Blair proposed openstack/boartty master: Fix opening a story by ID  https://review.openstack.org/63980720:17
openstackgerritJames E. Blair proposed openstack/boartty master: Increase width of task number column in story view  https://review.openstack.org/63980820:20
*** jamesmcarthur_ has quit IRC20:20
openstackgerritMerged openstack/boartty master: Fix opening a story by ID  https://review.openstack.org/63980720:25
openstackgerritMerged openstack/boartty master: Increase width of task number column in story view  https://review.openstack.org/63980820:25
openstackgerritMerged openstack/boartty master: Change openstack-dev to openstack-discuss  https://review.openstack.org/62193820:33
*** tosky has quit IRC20:36
*** agarwalpooja has joined #storyboard20:43
*** jamesmcarthur has joined #storyboard20:57
*** jaosorior has quit IRC21:08
*** ivy has quit IRC21:17
*** jamesmcarthur has quit IRC21:24
*** jamesmcarthur has joined #storyboard21:24
*** pooja_agarwal has quit IRC22:04
*** mkarray has quit IRC22:21
*** jamesmcarthur has quit IRC22:36
*** jamesmcarthur has joined #storyboard22:36
clarkbOk I seem to have the unittests running. My process was to get an ubuntu "server", install git python3 python3-dev python3-pip, pip3 install tox, tox -ebindep, copy the output of that and apt-get install that. Then because I was in a container poking at things I had to manually start mysql and postgres due to no proper init. Then run storyboard/tools/test-setup.sh. Then tox -epy36 seems to work23:19
clarkbhowever every test case takes about 2 minutes locally23:19
clarkband top shows mysql is the most busy process during the tests. I'm guessing we are doing some fairly non trivial db migrations every test case?23:19
clarkbthat si a fair bit slower than our test nodes, but not completely unexpected since this is my slow local machine23:20
clarkbalso there is a lot of stdout/stderr getting logged which is a bit annoying. Maybe we can clean that up23:23
clarkbso if ivy returns the issue with no output may be that the tests take a long time on $hardware23:23
clarkbbut also tools/test-setup.sh does seem tow ork if you install things with bindep first (and optionally start mysql and postgresql if running in an env with an init)23:23
*** jamesmcarthur has quit IRC23:55

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!