| *** whoami-rajat has quit IRC | 00:00 | |
| *** jamesmcarthur has quit IRC | 00:22 | |
| *** jamesmcarthur has joined #storyboard | 00:26 | |
| *** jamesmcarthur has quit IRC | 00:31 | |
| *** jamesmcarthur has joined #storyboard | 00:47 | |
| *** jamesmcarthur has quit IRC | 00:58 | |
| *** jamesmcarthur has joined #storyboard | 01:15 | |
| *** jamesmcarthur has quit IRC | 01:20 | |
| *** jamesmcarthur has joined #storyboard | 01:34 | |
| *** jamesmcarthur has quit IRC | 01:46 | |
| *** jamesmcarthur has joined #storyboard | 02:06 | |
| *** jamesmcarthur has quit IRC | 02:11 | |
| *** jamesmcarthur has joined #storyboard | 02:27 | |
| *** jamesmcarthur has quit IRC | 02:32 | |
| *** jamesmcarthur has joined #storyboard | 02:48 | |
| *** jamesmcarthur has quit IRC | 02:53 | |
| *** jamesmcarthur has joined #storyboard | 03:00 | |
| *** jamesmcarthur has quit IRC | 03:18 | |
| *** jamesmcarthur has joined #storyboard | 03:19 | |
| *** diablo_rojo has quit IRC | 03:48 | |
| *** jamesmcarthur has quit IRC | 04:49 | |
| *** jamesmcarthur has joined #storyboard | 04:50 | |
| *** jamesmcarthur has quit IRC | 04:54 | |
| *** jamesmcarthur has joined #storyboard | 05:10 | |
| *** jamesmcarthur has quit IRC | 05:15 | |
| *** jamesmcarthur has joined #storyboard | 05:31 | |
| *** jamesmcarthur has quit IRC | 05:35 | |
| *** jamesmcarthur has joined #storyboard | 05:51 | |
| *** jamesmcarthur has quit IRC | 05:56 | |
| *** whoami-rajat has joined #storyboard | 06:08 | |
| *** jamesmcarthur has joined #storyboard | 06:12 | |
| *** jamesmcarthur has quit IRC | 06:16 | |
| *** jamesmcarthur has joined #storyboard | 06:33 | |
| *** jamesmcarthur has quit IRC | 06:38 | |
| *** jamesmcarthur has joined #storyboard | 06:54 | |
| *** jamesmcarthur has quit IRC | 06:59 | |
| *** jtomasek has joined #storyboard | 07:00 | |
| *** jamesmcarthur has joined #storyboard | 07:15 | |
| *** jamesmcarthur has quit IRC | 07:20 | |
| *** jamesmcarthur has joined #storyboard | 07:37 | |
| *** jamesmcarthur has quit IRC | 07:42 | |
| *** jamesmcarthur has joined #storyboard | 07:58 | |
| *** ivoline has joined #storyboard | 07:59 | |
| *** jamesmcarthur has quit IRC | 08:03 | |
| *** jamesmcarthur has joined #storyboard | 08:19 | |
| *** jamesmcarthur has quit IRC | 08:24 | |
| *** tosky has joined #storyboard | 08:38 | |
| *** jamesmcarthur has joined #storyboard | 08:41 | |
| *** jamesmcarthur has quit IRC | 08:45 | |
| *** jamesmcarthur has joined #storyboard | 09:02 | |
| *** jamesmcarthur has quit IRC | 09:07 | |
| *** jamesmcarthur has joined #storyboard | 09:23 | |
| *** jamesmcarthur has quit IRC | 09:28 | |
| *** jamesmcarthur has joined #storyboard | 09:45 | |
| *** jamesmcarthur has quit IRC | 09:49 | |
| *** jamesmcarthur has joined #storyboard | 10:06 | |
| *** dtantsur|afk is now known as dtantsur | 10:09 | |
| *** jamesmcarthur has quit IRC | 10:11 | |
| *** ivoline has quit IRC | 10:18 | |
| *** jamesmcarthur has joined #storyboard | 10:28 | |
| *** jamesmcarthur has quit IRC | 10:32 | |
| *** jamesmcarthur has joined #storyboard | 10:49 | |
| *** jamesmcarthur has quit IRC | 10:54 | |
| *** jamesmcarthur has joined #storyboard | 11:10 | |
| *** jamesmcarthur has quit IRC | 11:15 | |
| *** jamesmcarthur has joined #storyboard | 11:31 | |
| *** jamesmcarthur has quit IRC | 11:36 | |
| *** jamesmcarthur has joined #storyboard | 11:53 | |
| *** jamesmcarthur has quit IRC | 11:57 | |
| *** jamesmcarthur has joined #storyboard | 12:14 | |
| *** jamesmcarthur has quit IRC | 12:19 | |
| *** tosky has quit IRC | 12:30 | |
| *** jamesmcarthur has joined #storyboard | 12:35 | |
| *** tosky has joined #storyboard | 12:36 | |
| *** jamesmcarthur has quit IRC | 12:40 | |
| *** jamesmcarthur has joined #storyboard | 12:57 | |
| *** whoami-rajat has quit IRC | 12:57 | |
| *** jamesmcarthur has quit IRC | 13:01 | |
| *** jamesmcarthur has joined #storyboard | 13:18 | |
| *** jamesmcarthur has quit IRC | 13:24 | |
| *** tosky has quit IRC | 13:25 | |
| *** tosky has joined #storyboard | 13:26 | |
| *** jamesmcarthur has joined #storyboard | 13:40 | |
| *** whoami-rajat has joined #storyboard | 13:41 | |
| *** jamesmcarthur has quit IRC | 13:44 | |
| *** jamesmcarthur has joined #storyboard | 13:45 | |
| *** jamesmcarthur has quit IRC | 13:50 | |
| *** jamesmcarthur has joined #storyboard | 14:06 | |
| *** jamesmcarthur has quit IRC | 14:10 | |
| *** jamesmcarthur has joined #storyboard | 14:27 | |
| *** jamesmcarthur has quit IRC | 14:31 | |
| openstackgerrit | Ngong Ivoline-Clarisse proposed openstack-infra/storyboard master: Fixed hyperlinks to worklist and boards documents https://review.openstack.org/637193 | 14:46 |
|---|---|---|
| *** ivoline has joined #storyboard | 14:48 | |
| ivoline | hello guys, I was able to figure out what was wrong with my installation. It was permission issues. Now my local webclient works :) . | 14:58 |
| ivoline | I also just pushed a patch to the remote. Will be glad if someone can review. | 15:01 |
| *** jamesmcarthur has joined #storyboard | 15:08 | |
| *** jamesmcarthur has quit IRC | 15:13 | |
| fungi | thanks ivoline! i'll take a look | 15:27 |
| fungi | and glad you got your file perms sorted | 15:27 |
| fungi | that was certainly a strange error you were getting | 15:27 |
| *** jamesmcarthur has joined #storyboard | 15:29 | |
| fungi | ivoline: looks like you somehow managed to also reset file permissions on every file in the repository in the process. your proposed change adds execute permissions on every file in the repository | 15:29 |
| fungi | the links you fixed look great though! http://logs.openstack.org/93/637193/1/check/tox-docs/9ea46c0/html/gui/theory.html#worklists-and-boards | 15:32 |
| *** jamesmcarthur has quit IRC | 15:34 | |
| ivoline | I'll try to change the execute permissions that were added | 15:34 |
| ivoline | After changing these, do I need to create a different branch to push the changes or can I just use the same branch? | 15:38 |
| fungi | it's all the same branch, you just need to amend your original commit switching back the file permissions to their original state | 15:40 |
| ivoline | Okay, thanks | 15:41 |
| fungi | you can reset the permissions with something like `git show -p -R --no-color | grep -E "^(diff|(old|new) mode)" --color=never | git apply` and then amend the commit with `git commit -a --amend` | 15:41 |
| ivoline | okay | 15:42 |
| fungi | after that, `git show` should give you just the two changed lines and no messages about permission changes on other files | 15:43 |
| fungi | if so, then `git review` again and a new revision will be pushed up | 15:43 |
| openstackgerrit | Ngong Ivoline-Clarisse proposed openstack-infra/storyboard master: Reverted execute permissions on files https://review.openstack.org/637209 | 15:47 |
| ivoline | Thanks so much fungi. Worked like a charm | 15:47 |
| ivoline | :) | 15:47 |
| *** jamesmcarthur has joined #storyboard | 15:51 | |
| *** jamesmcarthur has quit IRC | 15:53 | |
| ivoline | From the documentation, I guess it might be good practice to report bugs on storyboard. And then link to the stories/task for the issue in the commit messages. But given that this was a minor change. I didn't do that. | 15:53 |
| *** jamesmcarthur has joined #storyboard | 15:53 | |
| ivoline | Is it important to always report the bugs on storyboard? | 15:53 |
| persia | I think it is important to report bugs if a) you aren't fixing it right away (as a way of leaving a note), b) someone else might want to work on the same thing (as a way of using assignment to tell others about your work), or c) you aren't sure about the solution (to provide a forum to discuss the issue). | 15:55 |
| persia | Otherwise, probably not as much. | 15:55 |
| fungi | agreed, if you're fixing something you spotted, there's no real need to do extra "paperwork" | 15:56 |
| fungi | the commit message serves as a suitable means of explaining what was wrong | 15:56 |
| SotK | +1 | 15:57 |
| ivoline | Okay. Good to know | 15:57 |
| fungi | ivoline: it seems you did a new commit instead of amending your original commit, so it was pushed up as a separate change | 15:59 |
| fungi | you can get back the earlier change from gerrit if needed with `git review -d 637193` | 16:00 |
| fungi | then run the command to fix up the permissions and follow up with `git commit -a --amend` | 16:01 |
| fungi | the --amend makes it update the current commit rather than creating a new one | 16:01 |
| fungi | this is why i suggested `git show` afterward should show your fixed lines in the document and not mention anything about permissions being changed | 16:02 |
| ivoline | Oh okay. When I run the command `git commit -a --amend`, I am asked to enter a commit message. So, I ran this command instead 'git commit -m "Reverted execute permissions on files" -a --amend' but it was rather pushed up as a seperate change | 16:04 |
| fungi | oh, you don't have a suitable editor to enter commit messages interactively? | 16:05 |
| fungi | also, normally when amending a commit there's no need to mention changes you're making to correct previous mistakes in the commit itself | 16:06 |
| ivoline | No. I just use the command line | 16:06 |
| fungi | so the original commit message in 637193 is fine | 16:07 |
| ivoline | Which editor can I use? | 16:07 |
| fungi | you can just do `git commit -a --amend --no-edit` in this case to not alter the original commit message | 16:08 |
| ivoline | Okay | 16:08 |
| fungi | but generally, git users will rely on some console-based text editor (vim, emacs, nano, pico, joe...) to create or alter commit messages interactively | 16:09 |
| openstackgerrit | Ngong Ivoline-Clarisse proposed openstack-infra/storyboard master: Fixed hyperlinks to worklist and boards documents https://review.openstack.org/637193 | 16:10 |
| ivoline | Okay. I should get used to using an editor then. Thanks :) | 16:11 |
| fungi | you're welcome! in the end it's much easier than trying to compose detailed commit messages through the command-line interface | 16:12 |
| ivoline | Okay | 16:13 |
| ivoline | I have learnt alot today. Now,I have learnt how to do changes in the documentation. I think I can now pick one of the low-hanging-fruit bugs on StoryBoard and start working on it. Hopefully, it can help me to get used to the codebase | 16:20 |
| ivoline | What do you think? | 16:21 |
| ivoline | Would that be a good next step? | 16:26 |
| SotK | I think it would be yeah | 16:27 |
| fungi | ivoline: and yeah, that docs fix looks great now. i've abandoned the extra change you accidentally made | 16:28 |
| fungi | what happened there, when you used -m, was that it replaced the original commit message entirely including the change-id footer previously added by the gerrit commit hook, so a new change-id footer was generated resulting in a separate change in gerrit | 16:29 |
| ivoline | aahh I see now. | 16:29 |
| fungi | the way gerrit knows a new git push is a revision for an existing change is by matching on the change-id footer that commit hook adds to the commit message for you | 16:30 |
| ivoline | Okay. Lesson learned :) | 16:30 |
| ivoline | Now, I can move to the forward. | 16:34 |
| ivoline | When a patch is pushed and reviewed, how long after that is it merged ? | 16:38 |
| persia | Depends on the load on the merge infrastructure, but usually within a couple hours after final review approval. Range is probably something like 10 minutes to 10 hours. | 16:43 |
| ivoline | Ok | 16:45 |
| *** dtantsur is now known as dtantsur|afk | 17:08 | |
| fungi | ivoline: if you visit https://zuul.openstack.org/ you can see it being tested. once the jobs for it complete successfully, it should merge automatically | 17:28 |
| openstackgerrit | Merged openstack-infra/storyboard master: Fixed hyperlinks to worklist and boards documents https://review.openstack.org/637193 | 17:28 |
| fungi | and now it's done | 17:28 |
| diablo_rojo_phon | Congratulations ivoline :) I know it's not your first patch ever, but it's your first to storyboard :) | 17:29 |
| ivoline | :) Thank you guys | 17:41 |
| fungi | please don't thank us--we're greatful to have new folks getting involved! | 17:42 |
| fungi | er, grateful | 17:43 |
| ivoline | I'm happy to be part of the community. You guys are super helpful. | 17:45 |
| fungi | the only way to get new people to help us is to help them too. glad to know it works! ;) | 17:47 |
| ivoline | :) | 17:51 |
| *** ivoline has quit IRC | 18:08 | |
| *** ivoline has joined #storyboard | 19:13 | |
| *** ivoline has quit IRC | 19:14 | |
| *** jamesmcarthur has quit IRC | 19:22 | |
| *** jamesmcarthur has joined #storyboard | 19:23 | |
| *** jamesmcarthur has quit IRC | 19:27 | |
| *** jamesmcarthur has joined #storyboard | 19:33 | |
| *** jamesmcarthur has quit IRC | 19:37 | |
| *** jamesmcarthur has joined #storyboard | 19:38 | |
| *** jamesmcarthur has quit IRC | 19:40 | |
| *** jamesmcarthur has joined #storyboard | 19:48 | |
| -openstackstatus- NOTICE: The StoryBoard service on storyboard.openstack.org is offline momentarily for maintenance: http://lists.openstack.org/pipermail/openstack-discuss/2019-February/002666.html | 20:05 | |
| fungi | that maintenance is done now, btw | 20:11 |
| fungi | seems everything is working as expected | 20:11 |
| SotK | Nice, thanks fungi | 20:21 |
| fungi | you bet. sorry to take so long to make it happen | 20:24 |
| fungi | just wanted to be sure it had minimal impact | 20:25 |
| *** jamesmcarthur has quit IRC | 20:31 | |
| *** jamesmcarthur has joined #storyboard | 20:38 | |
| *** jamesmcarthur has quit IRC | 20:48 | |
| *** jamesmcarthur has joined #storyboard | 20:52 | |
| *** jamesmcarthur_ has joined #storyboard | 20:55 | |
| *** jamesmcarthur_ has quit IRC | 20:57 | |
| *** jamesmcarthur has quit IRC | 20:58 | |
| *** whoami-rajat has quit IRC | 21:30 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!