| *** diablo_rojo has quit IRC | 00:02 | |
| *** ianychoi has quit IRC | 01:17 | |
| *** ianychoi has joined #storyboard | 01:28 | |
| *** ianychoi has quit IRC | 01:42 | |
| *** jamesmcarthur has joined #storyboard | 01:58 | |
| *** ianychoi has joined #storyboard | 02:19 | |
| *** jamesmcarthur has quit IRC | 02:59 | |
| *** jamesmcarthur has joined #storyboard | 04:59 | |
| *** jamesmcarthur has quit IRC | 05:04 | |
| *** udesale has joined #storyboard | 05:41 | |
| *** tosky has joined #storyboard | 07:03 | |
| *** jpich has joined #storyboard | 07:35 | |
| *** jtomasek_ has joined #storyboard | 08:21 | |
| *** jtomasek has quit IRC | 08:23 | |
| *** jtomasek has joined #storyboard | 08:34 | |
| *** jtomasek_ has quit IRC | 08:36 | |
| *** jtomasek has quit IRC | 08:59 | |
| *** jtomasek has joined #storyboard | 09:15 | |
| *** udesale has quit IRC | 10:26 | |
| *** jtomasek has quit IRC | 10:28 | |
| *** jtomasek has joined #storyboard | 11:18 | |
| *** jtomasek has quit IRC | 11:57 | |
| *** udesale has joined #storyboard | 12:03 | |
| *** jtomasek has joined #storyboard | 12:39 | |
| *** udesale has quit IRC | 13:05 | |
| SotK | just a heads up, I probably won't be around at meeting time today I'm afraid, feel free to have it without me if you like | 13:31 |
|---|---|---|
| *** tosky__ has joined #storyboard | 13:51 | |
| *** tosky has quit IRC | 13:51 | |
| *** tosky__ is now known as tosky | 13:52 | |
| *** jamesmcarthur has joined #storyboard | 13:57 | |
| *** jtomasek has quit IRC | 15:10 | |
| *** jtomasek has joined #storyboard | 15:10 | |
| *** jpich has quit IRC | 17:32 | |
| *** jamesmcarthur has quit IRC | 17:41 | |
| *** fatema_ has joined #storyboard | 17:51 | |
| *** jamesmcarthur has joined #storyboard | 17:57 | |
| *** jamesmcarthur has quit IRC | 18:08 | |
| *** diablo_rojo has joined #storyboard | 18:41 | |
| *** jamesmcarthur has joined #storyboard | 18:44 | |
| fungi | SotK: thanks for the heads up. i didn't have much, other than i think i've mostly worked out the task linking but keeping it from breaking the task updating automation in its-storyboard has required a fair amount of trial and error | 19:02 |
| fungi | diablo_rojo: what say you? to meet or not to meet? | 19:03 |
| fungi | taking this as your vote to not meet ;) | 19:07 |
| diablo_rojo | Oh noes, I had updated the agenda | 19:08 |
| fungi | we can totally still meet | 19:08 |
| diablo_rojo | I am available to meet if you are | 19:08 |
| * diablo_rojo was distracted by election-y thins | 19:08 | |
| fungi | i also need to keep an eye out for pizza delivery | 19:08 |
| diablo_rojo | YUM | 19:08 |
| diablo_rojo | that sounds amazing | 19:09 |
| fungi | mmm, election thins, a righteous snack | 19:09 |
| diablo_rojo | Lol | 19:09 |
| diablo_rojo | I guess if SotK isn't going to be around we can skip this week, but it would be great if I could get some eyes on things from you fungi | 19:11 |
| fungi | i seem to be short a few eyes this week but will see what i can do | 19:11 |
| diablo_rojo | I put a draft of the attachments spec up yesterday with as much info as I had from the PTG | 19:11 |
| fungi | thanks! saw you hacking on it | 19:12 |
| diablo_rojo | Thats the most important of the things so I can stop there since you are shorthanded this week | 19:12 |
| diablo_rojo | Yup. Finally got around to not procrastinating anymore. | 19:12 |
| diablo_rojo | Lol | 19:12 |
| fungi | okay, i've successfully gotten task and story hyperlinking working on review-dev without breaking the task update automation | 19:14 |
| diablo_rojo | Woohoo! | 19:14 |
| diablo_rojo | That is awesome. | 19:14 |
| fungi | now trying to see if i can solve the failure for story footers by themselves to add story comments | 19:14 |
| fungi | since i seem to be on a roll | 19:14 |
| diablo_rojo | Thats awesome. | 19:14 |
| diablo_rojo | At some point I mean to look at the ltsstoryboard thing so that we can auto assign when reviews are pushed | 19:15 |
| fungi | gotta put on your java boots for that one | 19:16 |
| diablo_rojo | Yeah.. I started this crazy train wih 3 years of Java so maybe I can figure it out. | 19:17 |
| fungi | as it stands, i think i'm going to need to dissect that plugin to work out what it expects for story commenting without a task | 19:19 |
| *** jamesmcarthur has quit IRC | 19:19 | |
| *** jamesmcarthur has joined #storyboard | 19:19 | |
| diablo_rojo | If you wanna do that first, go ahead :) | 19:19 |
| fungi | for reference, the source lives at https://gerrit.googlesource.com/plugins/its-storyboard/ | 19:20 |
| fungi | we're running the stable-2.13 branch currently, i believe | 19:21 |
| diablo_rojo | Thanks :) | 19:25 |
| fungi | reading https://gerrit.googlesource.com/plugins/its-storyboard/+/stable-2.13/src/main/java/com/googlesource/gerrit/plugins/its/storyboard/StoryboardClient.java it looks like getStory() relies on getStoryId() which assumes it will always be triggered with a task | 19:30 |
| fungi | so this may never have actually been implemented | 19:30 |
| diablo_rojo | Sounds right | 19:30 |
| persia | Never implemented definitely sounds right. My memory is that there was a grand design (hinted at in the PTG session), and then everyone involved was told they had sharply limited time (for both Storyboard and its-storyboard), so something "just good enough" was put together in a hurry. | 19:43 |
| persia | (no ill-will towards anyone involved: we all operate under constraints, and perfect is often the enemy of good) | 19:44 |
| fungi | https://review.openstack.org/607698 adds the version i've been testing for review-dev, and https://review.openstack.org/607699 does the same for review.openstack.org | 20:01 |
| * diablo_rojo opens tabs to review | 20:02 | |
| persia | fungi: I don't understand how that differs from the action labeled "its-storyboard" immediately below your new "task" entry. | 20:03 |
| persia | If it is just that the link is wrong... | 20:04 |
| fungi | the way the its plugins work is that the commentlink system needs to match a pattern in a commit message and if the name of the commentlink matches the name of an its plugin then the link parameters are passed into it | 20:05 |
| persia | Right, but both 'task' and 'its-storyboard' match '\\\\b[Tt]ask:? #?(\\\\d+)', which is what confuses me. | 20:06 |
| fungi | it's far more magical than i ever expected when i first started digging into it | 20:06 |
| fungi | yeah, i'm testing now to see if order matters between those two | 20:06 |
| fungi | for whatever reason, seems order doesn't matter | 20:06 |
| fungi | example: https://review-dev.openstack.org/107975 | 20:07 |
| fungi | this is with the same configuration put in place manually, in the same order | 20:07 |
| fungi | the task footer is correctly hyperlinked, and the its-storyboard plugin also correctly updated the task status and commented on the corresponding story | 20:08 |
| persia | To ask another way, can we remove the entry for "name => 'its-storyboard'," and get the same behaviour? | 20:08 |
| fungi | without that, as i understand it, there's nothing to map the "\\b[Tt]ask:? #?(\\d+)" pattern to the its-storyboard plugin call | 20:09 |
| fungi | but i'll try it on a whim | 20:09 |
| persia | My thought is that "link => 'https://storyboard-dev.openstack.org/#!/task/$1'" is so different from "link => 'task: $1'" that one of them probably doesn't work, unless I'm missing the sheer volume of magic involved. | 20:09 |
| fungi | "magic" in this case is that they overloaded the commentlinks structure to configure bug tracker plugins | 20:10 |
| persia | We don't have an equivalent for 'story", which is what made me think we probably didn't need it for "task" | 20:10 |
| persia | (also not for bug, blueprint, etc.) | 20:10 |
| fungi | the reason for no story equivalent is that functionality was never implemented in the plugin (see earlier discussion) | 20:11 |
| persia | Oh, heh, right. Nevermind. I understand it all now. Your patches look roughly correct :) | 20:11 |
| fungi | bug and blueprint don't trigger automation via commentlinks, but instead rely on a gerrit commit hook script we write to scrape teh commit messages for similar patterns | 20:11 |
| fungi | er, commit hook script we wrote | 20:12 |
| fungi | the its plugin system was added to gerrit to provide a native solution so that deployments wouldn't need hook scripts | 20:12 |
| persia | That makes sense. I suppose migraing the commit hook to an its plugin is somewhere at the dusty bottom of some TODO list somewhere :) | 20:14 |
| persia | Also, thanks for explaining the overload on its-storyboard and task: the commit message was much easier to understand after the explanation. | 20:14 |
| fungi | the idea at the time was we'd just move off launchpad and not bother reimlpementing our update-bug.py and update-blueprint.py python scripts in java | 20:14 |
| fungi | anyway, i tested with the its-storyboard block removed (so just the story and task ones present) with patchset 7 of https://review-dev.openstack.org/107975 and it did not update the task status nor comment on the story, so i think that proves the unpleasant magic is still present | 20:16 |
| persia | Now that I understand the magic, my interest in removing something has entirely dissipated :) | 20:17 |
| fungi | patchset 8 too just to be sure | 20:17 |
| persia | It's just *very* magic. | 20:17 |
| fungi | now i'm putting it back and going to try again with ps9 | 20:17 |
| fungi | yep, started working again once i put that back, so definitely what's doing it | 20:20 |
| *** jamesmcarthur has quit IRC | 21:26 | |
| *** jamesmcarthur has joined #storyboard | 21:36 | |
| *** jtomasek has quit IRC | 21:54 | |
| *** tosky has quit IRC | 22:24 | |
| *** jamesmcarthur has quit IRC | 23:11 | |
| *** fatema_ has quit IRC | 23:38 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!