Friday, 2018-09-28

diablo_rojopersia, so multiple things being archived at 9999 at once?00:22
* diablo_rojo read the sentence several times and couldn't figure it out for some reason00:22
persiaI can't see any code that prevents that, yes.00:23
persiaBut I might not have followed the code correctly, etc.00:23
diablo_rojoWhen everything gets moved up when an item is taken out it should end up putting the next item at 9999 and the previous item will move to 9998?00:25
diablo_rojoI think?00:25
diablo_rojoI will have to go back through the code again.00:26
persiaMy read of the code was: something is added @ 999900:27
persiaSomething else is added @ 999900:28
persiaI didn't see anything that pushed it to 9998 *unless* something was reordered.00:28
*** jamesmcarthur has quit IRC00:28
persiaBut yeah, if you don't see it, feel free to overrride my concern.00:28
* persia doesn't have any particular agenda behind this opinion, but is rather worred there is a potential corner-case bug in the code00:29
persia(with "rather" above being a synonym for "instead" and not an intensifier)00:29
*** jamesmcarthur has joined #storyboard00:29
* persia goes to do something that triggers less semantic confusion00:29
*** jamesmcarthur has quit IRC00:34
diablo_rojoNo worries. I'll look at it again tomorrow. Maybe my brain has just given up for the day.00:35
*** jamesmcarthur has joined #storyboard00:55
*** jamesmcarthur has quit IRC00:59
*** diablo_rojo has quit IRC01:05
*** jamesmcarthur has joined #storyboard01:28
*** jamesmcarthur has quit IRC04:57
*** jamesmcarthur has joined #storyboard05:01
*** jamesmcarthur has quit IRC05:06
*** udesale has joined #storyboard05:09
*** jamesmcarthur has joined #storyboard06:29
*** jamesmcarthur has quit IRC06:34
*** jtomasek has joined #storyboard06:44
*** jamesmcarthur has joined #storyboard07:07
*** jamesmcarthur has quit IRC07:11
*** jamesmcarthur has joined #storyboard07:29
*** jamesmcarthur has quit IRC07:34
*** tosky has joined #storyboard07:50
*** jamesmcarthur has joined #storyboard07:56
*** jpich has joined #storyboard07:58
*** jamesmcarthur has quit IRC08:01
SotKpersia read it correctly, items are added in position 99999 (which is the same position all deleted/"archived" cards get moved to)08:34
SotKthey're then moved into the correct place by "move_item"08:35
SotKits possible for two requests to be almost clashing and the position of a new card to temporarily become 100000, but it doesn't really matter since it should be eventually consistent in all cases where there are less than 99998 unarchived cards in the list when adding a new card unless I'm logically missing something08:39
SotKand if you have 100000 cards in your worklist more things will break than just ordering08:40
SotKre-reading the above, adding something at position 99999 deliberately will also make that card's position get wonky when more things are added, you're right, we probably should cap attempts to add a card too far outside the existing bounds08:56
*** tosky has quit IRC09:02
*** tosky has joined #storyboard09:03
*** jtomasek has quit IRC09:56
*** jamesmcarthur has joined #storyboard10:12
*** jamesmcarthur has quit IRC10:16
*** dtantsur|afk is now known as dtantsur10:57
*** udesale has quit IRC11:32
*** EmilienM is now known as EvilienM12:00
*** jamesmcarthur has joined #storyboard12:45
*** jaosorior has quit IRC13:00
*** jamesmcarthur has quit IRC14:18
*** jamesmcarthur has joined #storyboard14:18
*** jamesmcarthur has quit IRC14:38
*** jamesmcarthur has joined #storyboard14:38
*** jamesmcarthur has quit IRC14:41
*** jamesmcarthur has joined #storyboard14:42
*** jamesmcarthur has quit IRC14:46
*** jamesmcarthur has joined #storyboard14:55
*** jamesmcarthur has quit IRC14:59
*** jamesmcarthur has joined #storyboard15:00
*** ianychoi has quit IRC16:39
*** ianychoi has joined #storyboard16:44
*** dtantsur is now known as dtantsur|afk16:45
*** jpich has quit IRC16:52
*** jtomasek has joined #storyboard17:24
*** jamesmcarthur has quit IRC17:48
*** diablo_rojo has joined #storyboard17:52
*** TheJulia is now known as needssleep18:02
*** EvilienM is now known as EmilienM22:20
*** jamesmcarthur has joined #storyboard22:36
*** jamesmcarthur has quit IRC22:40
*** tosky has quit IRC22:42
*** jamesmcarthur has joined #storyboard23:34
*** jamesmcarthur has quit IRC23:39

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!