| *** jamesmcarthur has joined #storyboard | 02:23 | |
| *** jamesmcarthur has quit IRC | 02:27 | |
| *** jamesmcarthur has joined #storyboard | 02:32 | |
| *** jamesmcarthur has quit IRC | 02:36 | |
| *** udesale has joined #storyboard | 03:59 | |
| *** jamesmcarthur has joined #storyboard | 04:46 | |
| *** jamesmcarthur has quit IRC | 04:50 | |
| *** jamesmcarthur has joined #storyboard | 07:34 | |
| *** jamesmcarthur has quit IRC | 07:38 | |
| *** jpich has joined #storyboard | 07:41 | |
| *** dtantsur|afk is now known as dtantsur | 09:07 | |
| -openstackstatus- NOTICE: Jobs using devstack-gate (legacy devstack jobs) have been failing due to an ara update. We use now a newer ansible version, it's safe to recheck if you see "ImportError: No module named manager" in the logs. | 09:58 | |
| *** udesale has quit IRC | 11:12 | |
| *** EmilienM is now known as EvilienM | 12:57 | |
| *** tosky has joined #storyboard | 13:02 | |
| *** jamesmcarthur has joined #storyboard | 14:08 | |
| *** jaosorior has quit IRC | 14:43 | |
| *** jpich has quit IRC | 15:59 | |
| *** openstackgerrit has quit IRC | 16:06 | |
| *** jamesmcarthur has quit IRC | 17:30 | |
| *** jamesmcarthur has joined #storyboard | 17:34 | |
| *** jamesmcarthur has quit IRC | 17:45 | |
| *** dtantsur is now known as dtantsur|afk | 17:59 | |
| *** openstackgerrit has joined #storyboard | 18:18 | |
| openstackgerrit | Adam Coldrick proposed openstack-infra/storyboard-webclient master: Refactor Project Group editing to match other objects https://review.openstack.org/598407 | 18:18 |
|---|---|---|
| openstackgerrit | Adam Coldrick proposed openstack-infra/storyboard-webclient master: Support linking to Project Groups by name https://review.openstack.org/598408 | 18:18 |
| openstackgerrit | Adam Coldrick proposed openstack-infra/storyboard-webclient master: Link to Project Groups by name https://review.openstack.org/598409 | 18:18 |
| openstackgerrit | Adam Coldrick proposed openstack-infra/storyboard-webclient master: Refactor Project Group editing to match other objects https://review.openstack.org/598407 | 18:21 |
| openstackgerrit | Adam Coldrick proposed openstack-infra/storyboard-webclient master: Support linking to Project Groups by name https://review.openstack.org/598408 | 18:21 |
| openstackgerrit | Adam Coldrick proposed openstack-infra/storyboard-webclient master: Link to Project Groups by name https://review.openstack.org/598409 | 18:21 |
| SotK | anyone feeling bored and like they fancy being a second reviewer on https://review.openstack.org/#/c/590047/ ? | 18:22 |
| clarkb | SotK: left a couple comments, I'm not super familiar with pecan so unsure if that is expected use but it feels like the wrong thing to do in python | 18:35 |
| clarkb | (basically overriding _route is probably not a great idea if pecan changes internals later, could we instead have pecan do route dispatch then we branch after based on the type of the input | 18:36 |
| clarkb | but I'm unsure of common practice around that so didn'1 -1 | 18:36 |
| clarkb | *didn't | 18:36 |
| *** tosky has quit IRC | 18:52 | |
| *** openstackstatus has quit IRC | 18:58 | |
| SotK | clarkb: thanks! | 19:13 |
| SotK | overriding _route is the documented way to do custom routing in Pecan (https://pecan.readthedocs.io/en/latest/routing.html#pecan-s-routing-algorithm) and is also consistent with what we currently do elsewhere that we need custom routing | 19:15 |
| SotK | though I agree thinking about it that branching after Pecan has handled the routing would probably be neater | 19:15 |
| SotK | although actually I'm not sure how easy it is to neatly make wsme allow either a string or int on the same method | 19:20 |
| clarkb | SotK: is it an error to treat 12345 as a string in wsme? (I sort of assumed that was allowed) then you'd be able to is_int after and convert to int if necesary | 19:21 |
| clarkb | but its possible wsme treats that as an error | 19:22 |
| SotK | yeah that would probably work | 19:23 |
| * SotK tries it | 19:27 | |
| *** openstackstatus has joined #storyboard | 19:39 | |
| *** ChanServ sets mode: +v openstackstatus | 19:39 | |
| SotK | it works fine for the projects subcontroller, so I'll make the change there | 19:51 |
| SotK | it'll work fine for the project controller which is the other place we override that function, I'll update that in a different patch because I prefer this approach | 19:52 |
| SotK | however it doesn't entirely work for the project groups controller (and I found a bug with the existing patch in the process) since the default RestController routing can't handle doing something like `http://localhost:8080/v1/project_groups/sotk/programming/projects` | 19:54 |
| SotK | (it gives a 404 rather than routing to the projects subcontroller as it should do) | 19:54 |
| *** openstackstatus has quit IRC | 19:55 | |
| *** openstackstatus has joined #storyboard | 19:59 | |
| *** ChanServ sets mode: +v openstackstatus | 19:59 | |
| *** openstackstatus has quit IRC | 20:11 | |
| *** openstackstatus has joined #storyboard | 20:13 | |
| *** ChanServ sets mode: +v openstackstatus | 20:13 | |
| SotK | I'm too sleepy to reason about this logic, I'll update my patch tomorrow | 20:27 |
| *** openstackstatus has quit IRC | 20:36 | |
| *** openstackstatus has joined #storyboard | 20:39 | |
| *** ChanServ sets mode: +v openstackstatus | 20:39 | |
| *** jamesmcarthur has joined #storyboard | 21:44 | |
| *** EvilienM is now known as EmilienM | 22:04 | |
| *** tosky has joined #storyboard | 22:09 | |
| *** jamesmcarthur has quit IRC | 23:01 | |
| *** jamesmcarthur has joined #storyboard | 23:10 | |
| *** tosky has quit IRC | 23:14 | |
| *** jamesmcarthur has quit IRC | 23:15 | |
| fungi | SotK: clarkb: on the rare occasions i've had pecan/wsme questions, i've sought input from dhellmann. he seems to have some familiarity there | 23:23 |
| *** jamesmcarthur has joined #storyboard | 23:31 | |
| *** jamesmcarthur has quit IRC | 23:40 | |
| *** jamesmcarthur has joined #storyboard | 23:53 | |
| *** jamesmcarthur has quit IRC | 23:57 | |
| *** jamesmcarthur has joined #storyboard | 23:58 | |
| *** jamesmcarthur has quit IRC | 23:58 | |
| *** jamesmcarthur has joined #storyboard | 23:58 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!