| *** tosky has quit IRC | 00:40 | |
| *** jamesmcarthur has joined #storyboard | 00:52 | |
| *** jamesmcarthur has quit IRC | 00:56 | |
| *** jamesmcarthur has joined #storyboard | 03:00 | |
| *** jamesmcarthur has quit IRC | 03:04 | |
| *** udesale has joined #storyboard | 04:44 | |
| *** jtomasek has joined #storyboard | 08:15 | |
| *** tosky has joined #storyboard | 10:21 | |
| *** jamesmcarthur has joined #storyboard | 11:01 | |
| *** jamesmcarthur has quit IRC | 11:05 | |
| *** tosky has quit IRC | 13:24 | |
| *** tosky has joined #storyboard | 13:28 | |
| *** udesale has quit IRC | 13:29 | |
| *** udesale_ has joined #storyboard | 13:29 | |
| *** tosky__ has joined #storyboard | 13:54 | |
| *** tosky has quit IRC | 13:55 | |
| *** tosky__ is now known as tosky | 13:55 | |
| *** tosky has quit IRC | 14:03 | |
| *** tosky has joined #storyboard | 14:23 | |
| openstackgerrit | Luigi Toscano proposed openstack-infra/storyboard master: Migration script: optional parameters to filter by tags https://review.openstack.org/549222 | 15:56 |
|---|---|---|
| tosky | I tested it more | 15:57 |
| zara_the_lemur__ | thanks! :) | 15:57 |
| tosky | diablo_rojo: you mentioned that you want to retest the sahara migration with that patch; I have the list of combinations of projects and tags for sahara, where should I document it? | 16:07 |
| tosky | can I simple edit the task on the story about migrating projects? | 16:07 |
| *** jamesmcarthur has joined #storyboard | 16:35 | |
| diablo_rojo | Yeah that would be perfect tosky | 16:35 |
| diablo_rojo | Or if its complicated you can write in an etherpad and link that in the task | 16:36 |
| tosky | diablo_rojo: I was just not sure whether that field was intended to be small or not | 16:37 |
| tosky | just to be clear: I'm talking about editing the task 6307 in https://storyboard.openstack.org/#!/story/2000876 | 16:38 |
| tosky | or should I add a separate comment in the story? | 16:38 |
| *** jdandrea has quit IRC | 16:38 | |
| *** jdandrea has joined #storyboard | 16:40 | |
| *** mcnanci has quit IRC | 16:41 | |
| *** jamesmcarthur has quit IRC | 16:43 | |
| *** jamesmcarthur has joined #storyboard | 16:43 | |
| diablo_rojo | tosky, I think putting it in the Sahara specifc task would be better. | 16:43 |
| *** jamesmcarthur has quit IRC | 16:47 | |
| *** jamesmcarthur has joined #storyboard | 16:47 | |
| tosky | diablo_rojo: ack | 16:49 |
| tosky | diablo_rojo: did you think about allowing more comments per task? | 16:50 |
| diablo_rojo | tosky, I would be fine with that, I think the trouble comes with how to show it in the UI without it getting too overwhelming. | 16:52 |
| *** udesale_ has quit IRC | 16:53 | |
| persia | To my mind, the field is intended to be just enough to progress. Most of the time, that is fairly small (often a URL or small note),. Sometimes it is a large bundle of markdown. | 16:53 |
| diablo_rojo | Maybe there was some other reason historically it wasn't a thing, but as far as I'm concerned, I think its a good idea :) | 16:53 |
| diablo_rojo | fungi, I know we chatted at the woo happy hour about some things and was trying to follow up today. If memory serves you said you would be able to help fix the gerrit/sb regression that happened? And that you might be able to help upgrade the db to support utf-8 I think it was? | 16:54 |
| fungi | i don't remember what the details were for the gerrit/sb regression (i think you said you'd get me an example) | 16:59 |
| fungi | as far as the db update, i can do that no problem but will want to schedule a few minutes of downtime for it | 16:59 |
| *** jamesmcarthur has quit IRC | 17:00 | |
| *** jamesmcarthur has joined #storyboard | 17:01 | |
| diablo_rojo | fungi, let me grab the story for it. As for the db, maybe we can do it tomorrow morning? | 17:10 |
| diablo_rojo | fungi, https://storyboard.openstack.org/#!/story/2001411 | 17:10 |
| diablo_rojo | Basically gerrit doesn't add links on stories in sb anymore. | 17:11 |
| diablo_rojo | Ex https://storyboard.openstack.org/#!/story/2000676 | 17:12 |
| fungi | got it, so the its-storyboard plugin for gerrit isn't updating sb any longer | 17:12 |
| diablo_rojo | Yeah that sounds correct | 17:12 |
| fungi | do we have an example of a recent one which didn't update the story linked in its commit message? | 17:12 |
| diablo_rojo | Yeah let me grab one. | 17:13 |
| fungi | i'm wondering if the api token we generated for it got lost or expired | 17:13 |
| diablo_rojo | fungi, https://storyboard.openstack.org/#!/story/107 and patch: https://review.openstack.org/#/c/548244/ | 17:16 |
| SotK | the gerrit plugin is still updating task statuses, so I think it must still have a valid token | 17:21 |
| SotK | re: utf8, the change is that the db needs to use the utf8mb4 charset rather than utf8 iirc | 17:22 |
| *** tosky has quit IRC | 17:24 | |
| fungi | yeah, we have a similar db migration planned for gerrit anyway, and did one a year or so ago for etherpad | 17:24 |
| fungi | and i agree, if it's updating task statuses but not commenting, then it's not likely the token at fault | 17:25 |
| fungi | i'll see if we have gerrit api logs back to feb 27 | 17:26 |
| fungi | nothing for that change in the error log that day | 17:28 |
| fungi | does anyone remember how long it's been since gerrit has left a comment in sb? | 17:29 |
| *** tosky has joined #storyboard | 17:30 | |
| diablo_rojo | fungi, a very long time.. I don't recall when it stopped. Maybe SotK has an idea? | 17:32 |
| fungi | curious if it may have coincided with our upgrade to gerrit 2.13 | 17:32 |
| diablo_rojo | When was that? | 17:33 |
| diablo_rojo | Date wise | 17:33 |
| fungi | tracking that down | 17:36 |
| fungi | 2017-09-18 23:48:12 UTC review.openstack.org Gerrit 2.13 upgrade is functionally complete. The Infra team will be cleaning up bookkeeping items over the next couple days. If you have any questions please let us know | 17:37 |
| fungi | https://wiki.openstack.org/wiki/Infrastructure_Status | 17:37 |
| SotK | I don't remember the exact date it stopped working, but I also suspect the gerrit upgrade | 17:37 |
| persia | My vague memory is that we started hearing comments about the lack of updates something like 6 months ago, although initially those seemed to be about "not getting notifications" in general, which was because of the mail gateway issues. | 17:37 |
| fungi | so sounds plausible | 17:37 |
| fungi | entirely possible that we upgraded to a regression in gerrit's its-storyboard plugin | 17:44 |
| fungi | https://gerrit.googlesource.com/plugins/its-storyboard/ | 17:44 |
| fungi | i wonder whether zaro_ has any suggestions for troubleshooting this (if he's around) | 17:46 |
| fungi | i definitely see gerrit's log mentioning performing the task updates for the initial patchset of https://review.openstack.org/548244 but logs mention nothing about commenting on the story | 17:47 |
| fungi | looks like when upgrading to gerrit 2.13 we also upgraded its-storyboard from a9cb131 to 805f9ac | 17:51 |
| fungi | that brought in 6 new commits | 17:52 |
| fungi | and there are a couple additional commits newer than what we're running, which seem to be entirely about replacing the buck build system with bazel | 17:56 |
| fungi | digging through java source, the plugin looks like it should log errors if it can't comment on a story, so i have a feeling it's not even trying | 18:04 |
| zaro_ | hi. not sure about this but here's few things to look at | 18:05 |
| fungi | i wonder if we missed updating the actions config when we upgraded | 18:06 |
| zaro_ | is the plugin even loaded? you should see this in logs https://gerrit.googlesource.com/plugins/its-storyboard/+/stable-2.13/src/main/java/com/googlesource/gerrit/plugins/its/storyboard/StoryboardModule.java#51 | 18:06 |
| fungi | yeah, it's loaded and updating task statuses | 18:06 |
| fungi | it just seems to skip commenting on any stories | 18:06 |
| fungi | the log definitely mentions loading the plugin and has log entries associated with the plugin's actions on various tasks | 18:07 |
| zaro_ | ohh, then this is the story endpoint it uses. https://gerrit.googlesource.com/plugins/its-storyboard/+/stable-2.13/src/main/java/com/googlesource/gerrit/plugins/its/storyboard/StoryboardClient.java#43 | 18:07 |
| zaro_ | could be something with permissions? | 18:07 |
| fungi | i doubt anything changed with respect to the permissions for the /api/v1/stories endpoint (especially since it seems to be using /api/v1/tasks just fine) | 18:08 |
| fungi | SotK: ^ any idea if the api path for that changed? | 18:08 |
| SotK | that's the correct endpoint | 18:09 |
| fungi | diffing between the versions of the plugin we upgraded from/to it looks like the example commentlink for "story" was added but it matches what we're using at http://git.openstack.org/cgit/openstack-infra/system-config/tree/modules/openstack_project/manifests/review.pp#n150 | 18:10 |
| *** jtomasek_ has joined #storyboard | 18:14 | |
| *** jtomasek has quit IRC | 18:15 | |
| zaro_ | fungi: i guess maybe turn debugging on for review-dev and test it? | 18:18 |
| zaro_ | looks like there's some logging output you can look at, https://gerrit.googlesource.com/plugins/its-storyboard/+/stable-2.13/src/main/java/com/googlesource/gerrit/plugins/its/storyboard/StoryboardClient.java#43 | 18:19 |
| fungi | wrong url? | 18:20 |
| fungi | or you just mean the various log.debug() calls in the methods in the same file? | 18:24 |
| zaro_ | opps, https://gerrit.googlesource.com/plugins/its-storyboard/+/stable-2.13/src/main/java/com/googlesource/gerrit/plugins/its/storyboard/StoryboardItsFacade.java#57 | 18:25 |
| fungi | that's a log.warn() so shouldn't i see it already? | 18:25 |
| fungi | i'm seeing log.info() level stuff in our log for its-storyboard actions on tasks | 18:26 |
| zaro_ | true. do you see it? | 18:26 |
| zaro_ | if that method isn't getting called then i think it's a config issue. | 18:27 |
| fungi | e.g.: INFO com.googlesource.gerrit.plugins.its.storyboard.StoryboardClient : Updated https://storyboard.openstack.org/api/v1/tasks/6546 with {"task_id":"6546","status":"merged"} | 18:27 |
| fungi | but no lines like "unable to comment" or "Storyboard item" | 18:27 |
| fungi | and yes, i'm leaning toward the possibility that it's not matching on our commentlink | 18:28 |
| fungi | http://paste.openstack.org/show/693411/ is what the relevant commentlinks look like from the gerrit.config on our production server's filesystem right now | 18:29 |
| fungi | i expect the link entry for the its-storyboard (task) commentlink is incorrect but hopefully not what's causing this issue since comments are getting updated just fine | 18:30 |
| fungi | er, i mean since tasks are getting their statuses set just fine | 18:30 |
| zaro_ | hmm, why are the links different? | 18:30 |
| zaro_ | fungi: "NOTE: Historically the association has been defined in the Gerrit's commentLink section. That setting is deprecated but still supported for the current release. You are encouraged to move the association policy to the plugin section, the commentLink.association will be discontinued in the next major release." | 18:34 |
| zaro_ | https://gerrit.googlesource.com/plugins/its-base/+/master/src/main/resources/Documentation/config-common.md | 18:34 |
| fungi | ooh, neat | 18:34 |
| zaro_ | hope that help :) | 18:35 |
| fungi | yeah, the only plugin section in our gerrit.conf is for plugin "javamelody" | 18:35 |
| *** jamesmcarthur has quit IRC | 18:36 | |
| fungi | zaro_: is it possible to do the its plugin association in the plugin section as far back as 2.13? | 18:36 |
| fungi | whatever version of its-base 2.13 uses anyway | 18:37 |
| zaro_ | the same message is 2.13 https://gerrit.googlesource.com/plugins/its-base/+/stable-2.13/src/main/resources/Documentation/config-common.md | 18:38 |
| fungi | okay, good | 18:38 |
| zaro_ | *is in | 18:38 |
| fungi | zaro_: do you know where there might be any good examples of configuring this in a plugin section rather than in a commentlink section? that page looks like it documents the old method, and says that it will be discontinued in favor of the new method, but doesn't explain how to do it the new way | 18:43 |
| fungi | unless i'm completely misreading it | 18:43 |
| zaro_ | i think it's just this https://gerrit.googlesource.com/plugins/its-storyboard/+/stable-2.13/src/main/resources/Documentation/quick-install-guide.md#its_connection_its_connectionconnection-configuration | 18:51 |
| zaro_ | ohh, i see what you mean. it's slightly confusing. | 18:53 |
| fungi | we have that bit in our config already | 18:53 |
| fungi | curious how to set the item match pattern and link pattern in the plugin config section rather than in a commentlink | 18:53 |
| zaro_ | hmm, i'm wondering if wikimedia has an example of how they do maniphest config. should be pretty similar | 18:54 |
| fungi | like, do they use the same format as a commentlink block? are the parameters named the same (match and link)? | 18:54 |
| fungi | good idea, they likely do. they have most of their configuration public | 18:54 |
| fungi | i'm looking around now | 18:54 |
| zaro_ | https://phabricator.wikimedia.org/source/operations-puppet/browse/master/templates/gerrit/gerrit.config.erb;9b90605fefbf4d0d98d0a73ea71b8ff2106ce522 | 18:55 |
| fungi | good find, but i don't see "its" in there | 18:56 |
| zaro_ | maybe not the right repo? | 18:56 |
| fungi | they do have a [bugzilla] section | 18:57 |
| fungi | though if that's for an its plugin, they seem to probably still use the match and link details from the corresponding commentlink entry | 18:58 |
| zaro_ | i think you would just add a [its-storyboard] section | 18:59 |
| zaro_ | i think it just needs to match the plugin name | 18:59 |
| zaro_ | fungi: i'm pretty sure that's it. | 19:01 |
| zaro_ | if you would like confirmation then just ask qchris on #gerrit | 19:01 |
| fungi | will do, thanks! | 19:01 |
| *** tosky has quit IRC | 19:42 | |
| *** tosky has joined #storyboard | 19:45 | |
| aspiers | 500: POST /api/v1/tasks: (InternalError) (1213, u'Deadlock found when trying to get lock; try restarting transaction') u'UPDATE stories SET updated_at=%(updated_at)s WHERE stories.id = %(stories_id)s' {'updated_at': datetime.datetime(2018, 3, 6, 20, 14, 37, 109789), 'stories_id': 2001639} | 20:14 |
| aspiers | anyone know what that's about? | 20:15 |
| aspiers | seen while creating a fresh story with 5 tasks | 20:16 |
| aspiers | interesting - it created the story and 3 of the tasks | 20:16 |
| *** jamesmcarthur has joined #storyboard | 20:26 | |
| *** jamesmcarthur has quit IRC | 20:45 | |
| *** jamesmcarthur has joined #storyboard | 20:57 | |
| *** jtomasek_ has quit IRC | 21:01 | |
| *** tosky has quit IRC | 21:11 | |
| *** tosky has joined #storyboard | 21:16 | |
| -openstackstatus- NOTICE: The infrastructure team is aware of replication issues between review.openstack.org and github.com repositories. We're planning a maintenance to try and address the issue. We recommend using our official supported mirrors instead located at https://git.openstack.org. | 21:19 | |
| diablo_rojo | aspiers, I've hit that one before. I think there is a story for it already. | 21:25 |
| *** jamesmcarthur has quit IRC | 21:57 | |
| *** jamesmcarthur has joined #storyboard | 22:05 | |
| *** tosky has quit IRC | 23:37 | |
| *** jamesmcarthur has quit IRC | 23:46 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!