| *** udesale has joined #storyboard | 04:04 | |
| *** udesale_ has joined #storyboard | 04:07 | |
| *** udesale_ has quit IRC | 04:31 | |
| *** udesale_ has joined #storyboard | 04:31 | |
| *** udesale has quit IRC | 04:32 | |
| *** jtomasek has joined #storyboard | 06:47 | |
| *** jtomasek has quit IRC | 06:47 | |
| *** jtomasek has joined #storyboard | 06:56 | |
| *** openstackgerrit has joined #storyboard | 07:32 | |
| openstackgerrit | Merged openstack-infra/storyboard master: Create a StoryBoard gui manual https://review.openstack.org/325474 | 07:32 |
|---|---|---|
| *** Zara has quit IRC | 10:59 | |
| *** EmilienM has quit IRC | 10:59 | |
| *** Zara has joined #storyboard | 10:59 | |
| *** EmilienM has joined #storyboard | 11:00 | |
| *** Zara_ has joined #storyboard | 11:25 | |
| *** Zara has quit IRC | 11:34 | |
| *** Zara_ is now known as Zara | 11:44 | |
| *** udesale_ has quit IRC | 11:50 | |
| *** betherly has quit IRC | 13:15 | |
| *** betherly has joined #storyboard | 13:16 | |
| *** udesale has joined #storyboard | 13:32 | |
| *** mwhahaha has quit IRC | 13:54 | |
| *** mwhahaha has joined #storyboard | 13:56 | |
| *** udesale has quit IRC | 15:19 | |
| *** openstackgerrit has quit IRC | 18:33 | |
| *** jtomasek has quit IRC | 21:27 | |
| dmsimard | It's a UX thing and I know markdown is supported | 21:49 |
| dmsimard | but it kind of bothers me that we wrap multi-line content into single line | 21:49 |
| dmsimard | See comments: https://storyboard.openstack.org/#!/story/2001570 | 21:50 |
| diablo_rojo | dmsimard, Yeah definitely looks better when formatted properly. | 21:53 |
| dmsimard | diablo_rojo: I was wondering if it could be multiline without necessarily being formatted as markdown -- if you try and paste a python stack trace, you end up with my first comment | 21:54 |
| diablo_rojo | dmsimard, I would think that its something that could be disabled by default somewhere. Off the top of my head I'm not sure exactly where besides generally in the webclient repo. | 21:55 |
| diablo_rojo | https://github.com/openstack-infra/storyboard-webclient | 21:55 |
| diablo_rojo | dmsimard, somewhere here maybe? https://github.com/openstack-infra/storyboard-webclient/tree/master/src/app/stories | 21:56 |
| dmsimard | yeah I'm not too familiar with the storyboard code, just thought I'd provide some feedback as I come across something that could be improved | 21:57 |
| diablo_rojo | dmsimard, I can investigate a bit more to see if its something to disable or something we can change by setting a div. If so, I can make a story for it in storybord against the webclient. | 21:58 |
| dmsimard | diablo_rojo: it's not an emergency but that's awesome, thanks for your help | 21:59 |
| diablo_rojo | dmsimard, no problem :) If you want to poke around and get it fixed sooner I am happy to review :) | 22:00 |
| diablo_rojo | I don't think it will be that involved. | 22:00 |
| SotK | plain non-markdown multiline content used to be how things worked before we added markdown (see https://storyboard.openstack.org/#!/story/94) for a bit of that history | 22:43 |
| SotK | to support non-markdown things nicely I think we'd need to add something to the data model to indicate the format of a comment/description | 22:44 |
| dmsimard | I think supporting markdown is great | 22:46 |
| dmsimard | I mean, github does it the same way | 22:47 |
| dmsimard | but when you paste something multiline in github, I'm pretty sure it doesn't fold everything into one line | 22:47 |
| persia | Depends on where it is pasted in github. | 23:00 |
| persia | I think github has some content analysis algorithm that adds markup in some cases (like comments an issue reports) in an attempt to DTRT | 23:00 |
| persia | But I could be entirely mistaken. | 23:00 |
| persia | From a UX perspective, instead of a pulldown that allows one to select markup style, would a more prominent note reminding folk how to mark up code or log snippets in markdown achieve the goal? | 23:01 |
| * persia is not generally a fan of more options or more controls unless they are truly needed to accomplish multiple goals for specific different folk | 23:02 | |
| dmsimard | yeah, I don't have a strong opinion... it was just not my expectation that multiline would be folded into one line :) | 23:06 |
| dmsimard | as far as what the implementation ends up looking like, I'm not a frontend or UX expert so I'll defer to the pros :) | 23:06 |
| dmsimard | I do have another question though -- there's the gerrit < - > storyboard hook implementation where Gerrit will update the status of a story/task to "review" but it doesn't leave a comment or anything about what review actually caused the update. I'd like to improve that, where should I look ? | 23:07 |
| persia | I think https://gerrit.googlesource.com/plugins/its-storyboard/ is the right thing. | 23:10 |
| persia | It used to leave comments, but then it stopped, and I'm not sure it is currently closely maintained or tested well against OpenStack gerrit (other than as a side effect of production use) | 23:11 |
| persia | Personally, I think it ought leave a task note where it can, but that might be tricky (especially if the task note has existing comments). | 23:12 |
| dmsimard | Oh dear, java. I expected something along the lines of an event listener that consumed firehose and then queried/updated storyboard | 23:22 |
| dmsimard | Looks like this is where it'd happen: https://gerrit.googlesource.com/plugins/its-storyboard/+/9420d223c06478236675f5ed1d94581b934aec3d/src/main/java/com/googlesource/gerrit/plugins/its/storyboard/StoryboardClient.java#162 | 23:23 |
| dmsimard | Maybe there's a clue in the gerrit logs, I'll take a look. | 23:23 |
| diablo_rojo | dmsimard, yeah that looks like where you would make the change. | 23:30 |
| persia | For that plugin, we had the luck to gain the interest of a gerrit developer, which made it easy to get done for the team, but conversely differently maintained. | 23:48 |
| persia | dmsimard: Note that the plugin has both Story: and Task: responses, with different behaviours for each (the former comments and the latter updates status) | 23:49 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!