| *** jtomasek has quit IRC | 07:08 | |
| *** jtomasek has joined #storyboard | 08:28 | |
| *** jtomasek has quit IRC | 08:57 | |
| *** jtomasek has joined #storyboard | 09:00 | |
| *** jtomasek has quit IRC | 09:36 | |
| openstackgerrit | Merged openstack-infra/python-storyboardclient master: build universal wheels https://review.openstack.org/545446 | 10:28 |
|---|---|---|
| openstackgerrit | Merged openstack-infra/storyboard master: handle missing lanes arg when creating a board https://review.openstack.org/545168 | 10:31 |
| *** jmccrory_ has joined #storyboard | 11:58 | |
| *** openstackgerrit has quit IRC | 12:00 | |
| *** jmccrory has quit IRC | 12:00 | |
| *** jmccrory_ is now known as jmccrory | 12:00 | |
| * SotK sends https://review.openstack.org/545594 in an attempt to fully fix the webclient publishing job | 12:40 | |
| persia | SotK: Doesn't that just run `git rev-parse --short HEAD` and use that value in the absence of a tag? | 12:53 |
| persia | Oh, nevermind. The names confused me. | 12:54 |
| persia | I now believe there to be a bug in "Get commits since tag" in version-from-git | 13:00 |
| SotK | I believe this to be the case too | 13:00 |
| persia | I think that failed_when: needs to be not only on a nonzero exit code, but also on blank content. | 13:01 |
| persia | Because there is logic to function in the absence of a tag: it is just buggy. | 13:02 |
| persia | Sadly my ansible isn't sufficient to know the syntax, and looking at the docs isn't helping :( I do think that fixing the bug is better than not using the role though. | 13:05 |
| persia | (but I don't want to complain in review, as the lack of publication is very annoying, and I don't know how to fix it the better way) | 13:05 |
| SotK | I'd agree if we actually used the output of the role for anything in the other parts of the job, but afaict we don't | 13:08 |
| SotK | (but yes, it would be good to fix it too) | 13:08 |
| persia | Do you think "failed_when: false or none" would work? | 13:09 |
| SotK | I'm not sure | 13:11 |
| SotK | my best guess based on my also somewhat lacking ansible would be `failed_when: false or commits_since_tag_output.stdout == ''` | 13:13 |
| persia | Indeed. Looking through the following jobs, it seems the version is entirely unused. | 13:15 |
| * SotK should've probably checked that when creating the playbook in the first place rather than assuming based on others xD | 13:16 | |
| persia | zuul is lovely at testing itself in many ways, but testing POST jobs is tricky to do before merging the results. | 13:21 |
| *** openstackgerrit has joined #storyboard | 13:22 | |
| openstackgerrit | Adam Coldrick proposed openstack-infra/storyboard master: Fix login when using python 3 https://review.openstack.org/545596 | 13:22 |
| openstackgerrit | Adam Coldrick proposed openstack-infra/storyboard master: Fix login when using python 3 https://review.openstack.org/545596 | 15:13 |
| *** jtomasek has joined #storyboard | 17:12 | |
| *** jtomasek has quit IRC | 18:53 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!