| *** openstackgerrit has joined #storyboard | 00:15 | |
| openstackgerrit | Kendall Nelson proposed openstack-infra/storyboard master: Migrate incomplete as todo https://review.openstack.org/529433 | 00:15 |
|---|---|---|
| *** jamesmcarthur has joined #storyboard | 00:34 | |
| *** jamesmcarthur has quit IRC | 00:50 | |
| *** jamesmcarthur has joined #storyboard | 00:51 | |
| *** davidlenwell_ has joined #storyboard | 02:04 | |
| *** jamesmcarthur has quit IRC | 02:06 | |
| *** thrace_ has joined #storyboard | 02:06 | |
| *** davidlenwell has quit IRC | 02:07 | |
| *** thrace has quit IRC | 02:07 | |
| *** davidlenwell_ is now known as davidlenwell | 02:07 | |
| *** jamesmcarthur has joined #storyboard | 02:28 | |
| *** jamesmcarthur has quit IRC | 02:28 | |
| *** jamesmcarthur has joined #storyboard | 02:29 | |
| *** jamesmcarthur has quit IRC | 02:44 | |
| *** jamesmcarthur has joined #storyboard | 02:53 | |
| *** jamesmcarthur has quit IRC | 02:58 | |
| *** jamesmcarthur has joined #storyboard | 03:35 | |
| *** thrace_ is now known as thrace | 04:01 | |
| *** jamesmcarthur has quit IRC | 05:03 | |
| *** sparkycollier has quit IRC | 06:26 | |
| *** betherly has quit IRC | 06:26 | |
| *** ironfoot has quit IRC | 06:26 | |
| *** persia has quit IRC | 06:26 | |
| *** sparkycollier has joined #storyboard | 06:31 | |
| *** betherly has joined #storyboard | 06:31 | |
| *** ironfoot has joined #storyboard | 06:31 | |
| *** persia has joined #storyboard | 06:31 | |
| *** sparkycollier has quit IRC | 06:48 | |
| *** betherly has quit IRC | 06:48 | |
| *** ironfoot has quit IRC | 06:48 | |
| *** persia has quit IRC | 06:48 | |
| *** ironfoot has joined #storyboard | 07:24 | |
| *** persia has joined #storyboard | 07:25 | |
| *** sparkycollier has joined #storyboard | 07:25 | |
| *** betherly has joined #storyboard | 07:25 | |
| *** mcnanci has quit IRC | 07:37 | |
| *** AJaeger has joined #storyboard | 07:54 | |
| AJaeger | storyboard cores, https://review.openstack.org/528481 is ready now, you can now click on build-javascript-content and preview the application. could you review, please? | 07:55 |
| AJaeger | mordred: it works ;) | 07:55 |
| *** jamesmcarthur has joined #storyboard | 09:20 | |
| *** jamesmcarthur has quit IRC | 09:24 | |
| *** jamesmcarthur has joined #storyboard | 09:37 | |
| *** jtomasek has joined #storyboard | 09:42 | |
| *** jamesmcarthur has quit IRC | 09:45 | |
| SotK | AJaeger: it seems like it doesn't quite work the same way as the old js-draft job, since I get 404s when trying to do anything which interacts with the API | 10:04 |
| SotK | (whereas the js-draft job successfully used the storyboard-dev API) | 10:04 |
| *** jtomasek has quit IRC | 10:07 | |
| AJaeger | SotK: oh - let's ask mordred what needs changing ^ | 10:27 |
| AJaeger | thanks for testing! | 10:27 |
| AJaeger | mordred: I think we need build:draft instead of build for npm | 10:28 |
| SotK | yw, thanks for the patch :) | 10:29 |
| openstackgerrit | Andreas Jaeger proposed openstack-infra/storyboard-webclient master: Migrate js-draft job to be zuul v3 native https://review.openstack.org/528481 | 11:58 |
| openstackgerrit | Andreas Jaeger proposed openstack-infra/storyboard-webclient master: Migrate js-draft job to be zuul v3 native https://review.openstack.org/528481 | 12:00 |
| *** mcnanci has joined #storyboard | 12:03 | |
| AJaeger | mordred: build:draft does not work ^ ;( Should I revert or do you want to take it further? | 12:21 |
| SotK | the old job used a config.json file containing this: http://paste.openstack.org/show/629580/ in order to point to the api correctly | 12:54 |
| SotK | I don't remember where that file was created off the top of my head | 12:54 |
| SotK | ah, its in our repo | 12:56 |
| SotK | I think the issue is that the patch runs `npm build:draft` when it actually needs to run `grunt build:draft` or some npm command which will invoke that | 13:07 |
| SotK | which, looking in package.json would be `npm run-script draft` | 13:09 |
| SotK | or just `npm run draft`, which is vaguely nicer to look at | 13:11 |
| SotK | AJaeger: ^ | 13:11 |
| AJaeger | SotK: thanks, will update... | 13:18 |
| openstackgerrit | Andreas Jaeger proposed openstack-infra/storyboard-webclient master: Migrate js-draft job to be zuul v3 native https://review.openstack.org/528481 | 13:19 |
| *** jtomasek has joined #storyboard | 13:34 | |
| SotK | nice, it works :D | 13:35 |
| SotK | thanks AJaeger! | 13:35 |
| SotK | the commit message probably wants updating to match that fix though :P | 13:37 |
| AJaeger | Yeah, glad to hear. | 14:35 |
| openstackgerrit | Andreas Jaeger proposed openstack-infra/storyboard-webclient master: Migrate js-draft job to be zuul v3 native https://review.openstack.org/528481 | 14:35 |
| AJaeger | mordred: do you want to do it as proposed - or update zuul-config to use draft by default for this job? ^ | 14:35 |
| *** jtomasek has quit IRC | 14:37 | |
| AJaeger | SotK: any other core to approve this ? ^ | 16:05 |
| SotK | Zara: do you have time to have a look? | 16:08 |
| Zara | not just now but I might have time in a few hours | 16:08 |
| SotK | otherwise I'm happy to +W it if someone from infra also approves it | 16:09 |
| AJaeger | SotK: let's see, mordred was already asking there... | 16:10 |
| diablo_rojo | SotK, Zara fungi TripleO test migrated successfully :) | 18:56 |
| fungi | excellent! | 18:57 |
| diablo_rojo | fungi, will reach out to the ptl today to get started planning when they might want to migrate- I imagine after the first of the year. | 18:57 |
| fungi | you may want to loop in EmilienM too since if memory serves he was the one who brought up the idea of tripleo piloting it | 18:59 |
| diablo_rojo | fungi, can do! Thinking I might start with an email. | 19:02 |
| diablo_rojo | Can cc him on it though. | 19:02 |
| fungi | yup, great idea | 19:04 |
| *** EmilienM has joined #storyboard | 19:45 | |
| EmilienM | hellow | 19:45 |
| *** diablo_rojo has quit IRC | 19:51 | |
| *** jamesmcarthur has joined #storyboard | 20:16 | |
| *** jamesmcarthur has quit IRC | 20:26 | |
| *** jamesmcarthur has joined #storyboard | 20:41 | |
| *** jamesmcarthur has quit IRC | 20:50 | |
| *** diablo_rojo has joined #storyboard | 20:51 | |
| *** AJaeger has left #storyboard | 20:59 | |
| *** diablo_rojo has quit IRC | 22:07 | |
| *** diablo_rojo has joined #storyboard | 22:13 | |
| *** diablo_rojo has quit IRC | 22:49 | |
| *** jamesmcarthur has joined #storyboard | 22:58 | |
| *** jamesmcarthur has quit IRC | 23:23 | |
| *** jamesmcarthur has joined #storyboard | 23:27 | |
| *** jamesmcarthur has quit IRC | 23:36 | |
| *** jamesmcarthur has joined #storyboard | 23:36 | |
| *** jamesmcarthur has quit IRC | 23:56 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!