| *** diablo_rojo has quit IRC | 02:03 | |
| SotK | mistral imported fine except that there are some branches, so we'll need the non-master branches work merged before that | 11:44 |
|---|---|---|
| * SotK will send his patch for unique emails when he returns | 11:44 | |
| *** jtomasek has joined #storyboard | 14:15 | |
| zara_the_lemur__ | well, I just got up, since I stayed up 'til like 5am playing an RPG, but should be around in the early evening | 15:41 |
| *** openstackgerrit has joined #storyboard | 16:19 | |
| openstackgerrit | Adam Coldrick proposed openstack-infra/storyboard master: Add a UUID to the temporary email address https://review.openstack.org/444593 | 16:19 |
| zara_the_lemur__ | oh, nice | 16:37 |
| * SotK also sends https://review.openstack.org/444595 | 16:50 | |
| zara_the_lemur__ | how come it's pip2? | 16:55 |
| SotK | launchpadlib seems to be python2 only so I am making sure the right pip gets used | 16:57 |
| SotK | though having said that if storyboard gets installed with pip3 then the script won't work anyway | 16:57 |
| SotK | but I don't think storyboard will either, and at least this way puppet won't fail | 16:57 |
| zara_the_lemur__ | sure, thought I should check since it looked like there were a few things out there called pip2 (eg: https://pypi.python.org/pypi/pip2/0.0.1.dev1) | 17:16 |
| zara_the_lemur__ | would you mind submitting a thing based on http://paste.openstack.org/show/602332/ as a docs patch sometime? 'Migrating Launchpad Projects to StoryBoard' or something like that so it doesn't get lost? (gonna review stuff now, and mayyybe remove the story_types things) | 18:39 |
| SotK | yeah I can do | 18:57 |
| SotK | I was considering just doing that in the first place but figured I'd do a paste for now | 18:57 |
| zara_the_lemur__ | sure | 18:57 |
| zara_the_lemur__ | I wondered about sending a thing based on it but it's your work, so lucky you | 18:59 |
| zara_the_lemur__ | hm, https://review.openstack.org/#/c/436702/ is still in need of reviews | 19:15 |
| zara_the_lemur__ | I will poke people about it in the week. | 19:15 |
| zara_the_lemur__ | now I've noticed inconsistent quotation marks in the 'install-storyboard' command in the puppet manifest, but I feel like sending a patch for that is just weird... | 19:18 |
| zara_the_lemur__ | (as in, that one uses double quotes for the command, none of the others do) | 19:19 |
| SotK | the double quotes are deliberate, since that command has a variable being substituted into it | 19:21 |
| zara_the_lemur__ | that made me think double quotes should be the default, but then actually it's useful to see at a glance which commands have things being substituted | 19:22 |
| zara_the_lemur__ | so ignore me =D | 19:22 |
| SotK | also the linter complains if you use double quotes by default, which I how I discovered that reasoning | 19:23 |
| zara_the_lemur__ | ah, did not know | 19:24 |
| zara_the_lemur__ | evidently. | 19:24 |
| * SotK only learnt this today :) | 19:25 | |
| zara_the_lemur__ | still got there first ;_; | 19:26 |
| zara_the_lemur__ | one day I will win because it is totally a competition | 19:27 |
| zara_the_lemur__ | hm our 'add to worklist' search needs refining | 19:47 |
| zara_the_lemur__ | (it allows things other than worklists to be the result of a search) | 19:47 |
| zara_the_lemur__ | (browse) | 19:47 |
| SotK | ha, that seems annoying | 19:47 |
| zara_the_lemur__ | I should try adding to the worklist 'Adam Coldrick' and seeing what happens xD | 19:47 |
| zara_the_lemur__ | actually it's not htat | 19:48 |
| SotK | wait how did you manage that? | 19:48 |
| zara_the_lemur__ | ignore me | 19:48 |
| zara_the_lemur__ | well not totally | 19:48 |
| zara_the_lemur__ | it does search on worklists | 19:48 |
| zara_the_lemur__ | but the user filter is for 'users who are assigned a thing in that worklist' | 19:48 |
| zara_the_lemur__ | I think | 19:48 |
| zara_the_lemur__ | so hm, can see a need for it, ui is a bit confusing. | 19:48 |
| * SotK believes it to likely be filtering by creator ID | 19:49 | |
| zara_the_lemur__ | oh, yeah | 19:49 |
| SotK | I suspect that user_id would be more useful than creator_id there | 19:50 |
| zara_the_lemur__ | probably | 19:50 |
| zara_the_lemur__ | I need to think a bit about how to make that interface clearer | 19:51 |
| SotK | since that should take into account the current set of people with permission | 19:51 |
| SotK | s | 19:51 |
| zara_the_lemur__ | heh | 19:51 |
| * zara_the_lemur__ is running the cloudkitty migration to see the users bug in action | 20:07 | |
| SotK | you'll need to already have the user that triggered the bug in your database | 20:07 |
| zara_the_lemur__ | oh ha, I don't know if I do or not | 20:08 |
| zara_the_lemur__ | I only have monasca in mine already | 20:08 |
| zara_the_lemur__ | (in terms of migrated projects) | 20:08 |
| zara_the_lemur__ | the patch looks fine | 20:09 |
| SotK | looking at when the user was created in my db I suspect they are also from cloudkitty | 20:09 |
| SotK | so maybe you won't already need them | 20:09 |
| zara_the_lemur__ | guess we'll find out | 20:09 |
| zara_the_lemur__ | yep, failed with the dupliate error | 20:20 |
| zara_the_lemur__ | *duplicate | 20:20 |
| SotK | \o/ | 20:20 |
| zara_the_lemur__ | running it again with the patch | 20:21 |
| zara_the_lemur__ | this time it succeeded \o/ | 20:43 |
| zara_the_lemur__ | I wonder how many near-duplicate users this will end up leaving in the db | 20:46 |
| zara_the_lemur__ | haha, too used to python import statements | 21:02 |
| zara_the_lemur__ | just tried to do `from users select * ;` for a sql query.... | 21:02 |
| zara_the_lemur__ | (well first I actually did `from users select 8 ;` because I failed to adequately hold shift for the asterisk..... ) | 21:03 |
| zara_the_lemur__ | anyway all looks fine with this patch | 21:03 |
| zara_the_lemur__ | hm.... does the search bar on the 'users' page (under 'admin') do anything at all? | 21:06 |
| zara_the_lemur__ | ah okay yes | 21:06 |
| zara_the_lemur__ | but only when you press 'enter'; it doesn't search as you type | 21:06 |
| zara_the_lemur__ | anyway... so iiuc, this might mean that some existing users' emails will be changed in the db if we import projects that they are involved in | 21:09 |
| zara_the_lemur__ | which could be a bit surprising if they've been getting notifications | 21:09 |
| SotK | hmm, it should leave the emails alone for existing users I think? | 21:10 |
| zara_the_lemur__ | well, I looked at the users page and searched the users with uuids in their emails | 21:11 |
| zara_the_lemur__ | that brought up one user per name | 21:11 |
| zara_the_lemur__ | changing the email of that user changed the email address for the one in the db with the uuid, and removed the uuid from their name | 21:11 |
| zara_the_lemur__ | or I'm getting confused | 21:11 |
| zara_the_lemur__ | could easily be the latter | 21:11 |
| zara_the_lemur__ | example: select * on users gives me the first thing here: http://paste.openstack.org/show/602407/ then I search user in web interface and change email like: http://imgur.com/a/6aqGY . run the select again and it gives me the second thing in the paste. | 21:16 |
| zara_the_lemur__ | (well, select * on users gives me more than just that record, but that's the relevant one) | 21:17 |
| zara_the_lemur__ | (I didn't change the full name from the thing it suggested by default btw.) | 21:17 |
| SotK | that all looks like correct behaviour to me | 21:21 |
| zara_the_lemur__ | I was indeed getting confused; thought I had some of these users in my db before. | 21:23 |
| zara_the_lemur__ | I didn't. | 21:23 |
| zara_the_lemur__ | patch looks fine then | 21:31 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!