| *** diablo_rojo has joined #storyboard | 00:44 | |
| *** diablo_rojo_ has joined #storyboard | 01:12 | |
| *** diablo_rojo__ has joined #storyboard | 01:13 | |
| *** diablo_rojo__ has quit IRC | 01:13 | |
| *** diablo_rojo_ has quit IRC | 01:13 | |
| *** diablo_rojo has quit IRC | 03:44 | |
| *** zara_the_lemur__ has quit IRC | 03:45 | |
| *** fay has joined #storyboard | 08:16 | |
| *** fay is now known as Guest53910 | 08:16 | |
| *** jtomasek has joined #storyboard | 08:20 | |
| *** Guest53910 is now known as faybrocklebank | 09:20 | |
| *** bethwhite has joined #storyboard | 09:53 | |
| Zara | morning, storyboard! | 10:11 |
|---|---|---|
| Zara | I'm about to go on an exciting voyage into sqlalchemy | 10:13 |
| SotK | morning! | 10:27 |
| SotK | good luck | 10:27 |
| SotK | don't forget about oslo.db too | 10:28 |
| Zara | thanks for the tip :) | 10:32 |
| Zara | started reading models.py, 'oh hey, maybe the specific db is all abstracted out', then https://github.com/openstack-infra/storyboard/blob/8a6a90e6f63bb44917985a8c7afb59df4365192f/storyboard/db/models.py#L511 | 10:34 |
| persia | You might look at the history of that: I remember that Storyboard used to work on postgresql | 10:42 |
| persia | But there was also lots of debate about only using mysql. My memory of the discussion mostly surrounded the desire to only support one DB for gating, but there may have also been some limitations that required awkwardnesses (such as wanting constructions that were not easily abstracted). | 10:43 |
| Zara | yeah, I think the specific thing I linked would be straightforward to abstract, but I've only just started looking | 10:50 |
| Zara | things like this make me wonder https://github.com/openstack-infra/storyboard/blob/4926b471e2ccf0f4adb6e92e9f26769c942ae621/storyboard/migrate/cli.py#L50 | 10:52 |
| persia | Indeed, although some parts (like that one) aren't meaningful unless setting up a Storyboard based on LP data. | 10:54 |
| Zara | yeah, I just wonder what might be lurking. :) | 10:55 |
| persia | heh | 10:55 |
| * Zara is going to have a wander through the history | 10:55 | |
| *** alexismonville has joined #storyboard | 12:34 | |
| *** alexismonville has quit IRC | 12:38 | |
| *** alexismonville has joined #storyboard | 14:03 | |
| *** alexismonville has quit IRC | 15:03 | |
| *** alexismonville has joined #storyboard | 15:05 | |
| Zara | so far I'm finding that the code has changed so much since the other sql support that it's hard to contextualise | 15:16 |
| Zara | I think more general understanding of db -> sqlalchemy -> api will help with that | 15:17 |
| Zara | (+ there are specific patches to remove the tests for postgres, but I haven't found any 'remove postgres support' patches or similar for the main codebase, so I think mysql-specific things just steadily spread through the code once it was agreed to only support mysql | 15:26 |
| persia | That description of mysql-specific code matches my memory. | 15:28 |
| persia | I believe the decision to only support mysql was taken in late 2014: I don't remember if Storyboard was in advance of the general gating decision (at Summit), or a result of that decision. | 15:29 |
| Zara | yeah, 2014 is where I've found the last of the explicit mentions of other sqls | 15:30 |
| Zara | but rather hard to tell; I'm just git grepping everything... | 15:30 |
| *** diablo_rojo has joined #storyboard | 16:06 | |
| *** alexismonville has quit IRC | 16:34 | |
| *** alexismonville has joined #storyboard | 16:35 | |
| *** alexismonville has quit IRC | 16:40 | |
| *** alexismonville has joined #storyboard | 16:44 | |
| *** alexismonville has quit IRC | 16:50 | |
| *** alexismonville has joined #storyboard | 17:31 | |
| *** bethwhite has quit IRC | 17:36 | |
| *** bethwhite has joined #storyboard | 18:12 | |
| *** alexismonville has quit IRC | 19:00 | |
| *** diablo_rojo has quit IRC | 19:06 | |
| *** alexismonville has joined #storyboard | 19:07 | |
| *** diablo_rojo has joined #storyboard | 19:15 | |
| *** alexismonville has quit IRC | 19:22 | |
| *** alexismonville has joined #storyboard | 19:28 | |
| *** alexismonville has quit IRC | 19:31 | |
| *** jtomasek_ has joined #storyboard | 19:34 | |
| *** zara_the_lemur__ has joined #storyboard | 19:44 | |
| *** jtomasek_ has quit IRC | 20:22 | |
| *** alexismonville has joined #storyboard | 21:14 | |
| *** jtomasek_ has joined #storyboard | 21:20 | |
| *** diablo_rojo_phon has joined #storyboard | 21:29 | |
| *** alexismonville has quit IRC | 21:31 | |
| *** jtomasek_ has quit IRC | 21:47 | |
| *** diablo_rojo has quit IRC | 22:07 | |
| *** bethwhite has quit IRC | 22:19 | |
| *** alexismonville has joined #storyboard | 22:41 | |
| *** alexismonville has quit IRC | 22:58 | |
| *** alexismonville has joined #storyboard | 22:59 | |
| *** alexismonville has quit IRC | 22:59 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!