| *** zara_the_lemur__ has quit IRC | 03:05 | |
| *** openstackgerrit has joined #storyboard | 04:07 | |
| openstackgerrit | Tuan Luong-Anh proposed openstack-infra/storyboard: Replace assertEquals with assertEqual https://review.openstack.org/400130 | 04:07 |
|---|---|---|
| *** diablo_rojo has joined #storyboard | 04:32 | |
| openstackgerrit | Tristan Cacqueray proposed openstack-infra/storyboard: Ignore bad requests in notification hook https://review.openstack.org/407915 | 05:45 |
| *** diablo_rojo has quit IRC | 06:41 | |
| openstackgerrit | Tristan Cacqueray proposed openstack-infra/storyboard: Ignore bad requests in notification hook https://review.openstack.org/407915 | 07:19 |
| *** pedroalvarez has quit IRC | 08:29 | |
| *** pedroalvarez has joined #storyboard | 08:29 | |
| SotK | good morning! | 09:02 |
| *** alexismonville has joined #storyboard | 10:59 | |
| *** alexismonville has quit IRC | 11:10 | |
| *** bethwhite has quit IRC | 11:23 | |
| *** bethwhite has joined #storyboard | 11:27 | |
| *** bethwhite has joined #storyboard | 11:27 | |
| *** alexismonville has joined #storyboard | 12:43 | |
| *** alexismonville has quit IRC | 12:48 | |
| *** zara_the_lemur__ has joined #storyboard | 13:53 | |
| zara_the_lemur__ | afternoon! | 13:55 |
| zara_the_lemur__ | huh, I seem to be able to create private stories with no users (discovered while testing 408297, though I can reproduce it on master) | 14:56 |
| SotK | do they still appear to have no users once you've created them? | 14:57 |
| persia | The behaviour I would expect is that the creator would have full access (as a permissioned user) if no explicit grants were performed. | 14:58 |
| zara_the_lemur__ | SotK: I think so; I get a 404 'story not found' after I create them and can't see them on the list, but if I create another story after it has the next ID. | 14:58 |
| zara_the_lemur__ | making me think it's there and I'm just not allowed to see it. | 14:58 |
| SotK | persia: that is the behaviour I believe I implemented, but it would appear I broke something | 14:58 |
| zara_the_lemur__ | it's not the biggest problem in the world, anyway | 14:58 |
| zara_the_lemur__ | (annoying since it's an edge case we already thought of and designed for but hey.) | 14:59 |
| persia | Probably worth tracking down though, as it seems a bit odd, and may be related to other permissions processing issues. | 15:00 |
| zara_the_lemur__ | yep | 15:01 |
| zara_the_lemur__ | oh, btw, it does automatically list the creator as a user who can access it, it's just possible to *remove* the creator | 15:03 |
| zara_the_lemur__ | and not put any other users in | 15:03 |
| SotK | aha, and that will be making the assumption that "users" is either unset or a populated list here untrue: https://git.openstack.org/cgit/openstack-infra/storyboard/tree/storyboard/api/v1/stories.py#n220 | 15:04 |
| zara_the_lemur__ | so, set but empty? | 15:05 |
| SotK | indeed | 15:05 |
| zara_the_lemur__ | cool | 15:06 |
| * zara_the_lemur__ forgot again that None != empty... | 15:07 | |
| * persia always forgets that | 15:07 | |
| persia | Is there a sensible way to add a test for that, so that we don't end up breaking it again? | 15:08 |
| SotK | yeah | 15:08 |
| SotK | I intend to add tests for all the teams permissions stuff too over the next couple of weeks | 15:09 |
| zara_the_lemur__ | I worry about you | 15:09 |
| zara_the_lemur__ | (https://review.openstack.org/#/c/408297/ seems fine, anyway) | 15:10 |
| zara_the_lemur__ | (will merge) | 15:10 |
| SotK | thanks :) | 15:24 |
| *** jpmaxman has joined #storyboard | 15:27 | |
| fungi | "400: GET /api/v1/users/preferences: Invalid input for field/attribute user_id. Value: 'preferences'. unable to convert to int" | 15:32 |
| fungi | i've probably asked about that before | 15:32 |
| fungi | comes up from time to time when returning to sb, possibly with an expired session | 15:33 |
| fungi | don't recall if there's already a defect report about that | 15:33 |
| SotK | hm, that looks vaguely different to the error message I see when my refresh token has expired I think | 15:35 |
| SotK | though I may be misremembering | 15:35 |
| fungi | i'm skimming active stories and not spotting any | 15:35 |
| pedroalvarez | this is the story SotK is thinking about: https://storyboard.openstack.org/#!/story/2000407 | 15:35 |
| SotK | ah, looks like I am indeed misremembering then | 15:36 |
| fungi | https://storyboard.openstack.org/#!/story/2000394 also looks sort of similar | 15:36 |
| fungi | i wonder if it manifests differently depending on the page | 15:36 |
| zara_the_lemur__ | (yeah, there used to be a worse error, which the first bit of 2000407 refers to; the 'epilogue' is where we're at at the moment) | 15:37 |
| fungi | aha, yep, the quoted error there is indeed the one which was reported to me | 15:37 |
| * zara_the_lemur__ notes she's messed up her markdown and now the whole thing is italicised... | 15:39 | |
| * zara_the_lemur__ removes the fake html tags | 15:40 | |
| zara_the_lemur__ | (it used to be wrapped in <I wish I could put this in a marquee> </wishful thinking> but I think some updated component didn't like that.) | 15:40 |
| *** diablo_rojo has joined #storyboard | 16:02 | |
| *** fay_ has quit IRC | 17:09 | |
| *** bethwhite has quit IRC | 18:16 | |
| *** diablo_rojo has quit IRC | 19:05 | |
| *** diablo_rojo has joined #storyboard | 19:16 | |
| *** SpamapS has joined #storyboard | 19:21 | |
| SpamapS | \o/ Yay for the book icon for stories. :) | 19:22 |
| zara_the_lemur__ | :D | 19:22 |
| zara_the_lemur__ | thanks for the suggestion! | 19:22 |
| *** alexismonville has joined #storyboard | 19:24 | |
| *** alexismonville has quit IRC | 21:05 | |
| *** alexismonville has joined #storyboard | 21:10 | |
| *** alexismonville has quit IRC | 21:17 | |
| *** bethwhite has joined #storyboard | 22:27 | |
| *** diablo_rojo has quit IRC | 22:30 | |
| *** bethwhite has quit IRC | 22:35 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!