| *** openstackgerrit has joined #storyboard | 00:49 | |
| openstackgerrit | Tristan Cacqueray proposed openstack-infra/storyboard-webclient: Fix absolute href https://review.openstack.org/407249 | 00:49 |
|---|---|---|
| *** alexismonville has joined #storyboard | 00:52 | |
| *** alexismonville has quit IRC | 01:33 | |
| *** anteaya has quit IRC | 05:16 | |
| *** anteaya has joined #storyboard | 05:29 | |
| *** jtomasek has joined #storyboard | 07:40 | |
| *** bethwhite has joined #storyboard | 09:44 | |
| Zara_ | oh, neat | 10:10 |
| *** Zara_ is now known as Zara | 10:10 | |
| Zara | so yeah, I was fine to +2 the teams patch since it's better than what came before, just leaving it for a bit so there's a chance to read the comments in review | 10:13 |
| *** alexismonville has joined #storyboard | 12:24 | |
| openstackgerrit | Merged openstack-infra/storyboard-webclient: Inhibit browser autocomplete when selecting a project https://review.openstack.org/406471 | 17:15 |
| Zara | oh, https://review.openstack.org/#/c/389997/6 awaits reviews | 17:49 |
| Zara | I nearly merged it, but it was an older version that had a +1 | 17:50 |
| *** fay_ has quit IRC | 17:56 | |
| dmsimard | Zara: thanks for merging ^ | 18:49 |
| dmsimard | I think we shouldn't consider https://storyboard.openstack.org/#!/story/2000818 solved, however, since like I mentioned, there's so many fields all over the place | 18:49 |
| dmsimard | I'll let the pros handle it from there | 18:50 |
| *** zara_the_lemur__ has joined #storyboard | 18:56 | |
| zara_the_lemur__ | dmsimard: yeah, really those templates should be using the directives that are defined once, so that there's less duplication (instead of just <input> tags), but that's a bigger fix and right now I can't say when we'll get round to it, so I'd rather it's nice for our users in the meantime! :) plus it's probably quite a good way into the codebase for new | 19:04 |
| zara_the_lemur__ | contributors. | 19:04 |
| zara_the_lemur__ | thank *you* for writing the patch! :) | 19:04 |
| *** pleia2 has quit IRC | 19:34 | |
| *** pleia2 has joined #storyboard | 19:34 | |
| *** zara_the_lemur__ has left #storyboard | 20:12 | |
| *** alexismonville has quit IRC | 20:52 | |
| *** jtomasek has quit IRC | 21:39 | |
| *** jtomasek has joined #storyboard | 23:14 | |
| *** jtomasek has quit IRC | 23:18 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!