*** jtomasek has joined #storyboard | 07:02 | |
*** jtomasek has quit IRC | 08:04 | |
*** jtomasek has joined #storyboard | 08:18 | |
*** jtomasek has quit IRC | 08:57 | |
Zara | https://etherpad.openstack.org/p/ocata-infra-community-task-tracking | 10:19 |
---|---|---|
jamesmcarthur | just wanted to say great job to the amazing storyboard team!! love what you all are doing and can't wait to start using. | 13:33 |
SotK | :) thanks | 13:52 |
SotK | glad you like what we're doing! | 13:52 |
Zara | yes, thank you! :) it was great to meet in person at last! | 13:53 |
* Zara realises she's confused jamesmcarthur with jpmaxman | 13:55 | |
Zara | oh well, nothing like some public embarrassment to break the ice \o/ | 13:55 |
SotK | :) | 13:55 |
jamesmcarthur | zara: no worries, it happens more frequently than you would think ;) | 13:56 |
jamesmcarthur | I'm sorry I didn't stick around to chat. Had to run. But we're looking forward to moving the Foundation's tasks over to storyboard. | 13:56 |
jamesmcarthur | zara: to be specific - foundation o.o and app tasks :) | 13:57 |
Zara | yay! :D | 13:57 |
Zara | (and thanks, sorry again about the mixup!) | 13:58 |
* SotK is pleased that folk are excited to use storyboard | 13:58 | |
*** jtomasek has joined #storyboard | 15:06 | |
*** jtomasek has quit IRC | 15:31 | |
openstackgerrit | Adam Coldrick proposed openstack-infra/storyboard: Add filters to the /v1/tasks/search endpoint https://review.openstack.org/390983 | 16:42 |
Zara | hm, I get a 500 when I add a user to a private story | 18:30 |
SotK | which patch is that with? | 18:31 |
Zara | https://review.openstack.org/#/c/389997/ but now checking if it's on master | 18:31 |
Zara | bleh, looks like it is. | 18:32 |
SotK | o.O | 18:32 |
Zara | http://paste.openstack.org/show/587207/ | 18:33 |
* SotK sees the same | 18:34 | |
* SotK will attempt to solve this after food | 18:36 | |
Zara | we have ordered our priorities the same way | 18:36 |
*** bethwhite has quit IRC | 20:00 | |
*** bethwhite has joined #storyboard | 20:08 | |
*** alexismonville has joined #storyboard | 20:16 | |
*** alexismonville has quit IRC | 20:32 | |
* SotK returns to see whats broken! | 21:16 | |
*** jtomasek has joined #storyboard | 21:48 | |
*** jtomasek has quit IRC | 21:52 | |
*** bethwhite has quit IRC | 22:04 | |
openstackgerrit | Adam Coldrick proposed openstack-infra/storyboard: Fix modification of private stories https://review.openstack.org/391310 | 22:15 |
* Zara vaguely wishes for a bunch of public storyboard VMs that could be manually deployed and used for development. I'd love to eliminate my office network from the process. no idea where to start with that | 22:15 | |
Zara | \o/ | 22:15 |
SotK | its not very pretty, but I feel its better than trying to force the user id all over the place | 22:16 |
Zara | yeah, this bug is weird, it doesn't stop you from editing things, but it throws an error that makes it look as though the edit hasn't gone through | 22:16 |
Zara | (that wasn't in reply to you, we just posted at the same time) | 22:16 |
SotK | :) | 22:16 |
Zara | I was just giving some context | 22:16 |
Zara | :) | 22:16 |
Zara | hah, I see what you mean about 'not pretty' | 22:17 |
Zara | that looks very fragile... but I don't have a better idea rn | 22:17 |
Zara | maybe 'fragile' is the wrong word... 'looks liable to be accidentally replicated in the wrong places in the future' | 22:18 |
SotK | yes, I tried to make the docstring sound as disuasive as possible | 22:18 |
Zara | yeah, I appreciate it | 22:19 |
Zara | I suspect it won't be enough, but yeah, no better approach springs to mind | 22:19 |
Zara | and if one does, we'll change it | 22:19 |
SotK | (it was erroring because an error was being swallowed by *something* in story_update_updated_at and then sqlalchemy exploded the next time it tried to do something (which happened to be the notification thing)) | 22:20 |
SotK | indeed | 22:20 |
Zara | aha | 22:20 |
SotK | and in the mean time I will leave grumpy reviews on folk that try to use it and/or replicate it | 22:20 |
Zara | I suspect the inelegance of it will nag at you so much that you won't be able to stop thinking about it and you'll change it quite quickly, haha | 22:20 |
* Zara will test now | 22:20 | |
SotK | actually, maybe the error wasn't being swallowed but pecan was still running the post-request hook after the failure | 22:21 |
Zara | that sounds worse | 22:22 |
SotK | so the exception was raised correctly but didn't make it into the traceback because pecan tried to die gracefully and instead died worse | 22:22 |
SotK | (through no fault of its own) | 22:22 |
Zara | hahaha, I just tried to do 'git review -d 39131' | 22:23 |
SotK | :D | 22:24 |
Zara | turns out this here gerrit's a *bit* bigger than that | 22:24 |
Zara | (hm, also I think I'm getting to the point where the things I'm prefacing with 'hahaha' are things that people mock software engineers for prefacing with 'hahaha') | 22:26 |
Zara | looks good so far | 22:44 |
SotK | \o/ | 22:44 |
Zara | I can save a private story and edit some words and users without scariness | 22:44 |
Zara | yeah, it seems fine | 22:48 |
Zara | have now raced through my other tests-that-I-really-should-automate | 22:50 |
Zara | one thing I haven't checked is the behaviour of emails | 22:50 |
Zara | okay, 500 seems fine with that patch | 23:22 |
Zara | though it's reminded me of what I originally noticed that led to the discovery of the strangeness | 23:22 |
Zara | which is that our email templates for stories don't yet include changes in the users of private stories | 23:23 |
Zara | *changes to the list of users | 23:23 |
Zara | huh, gerrit isn't providing a linkable failure log | 23:24 |
Zara | I wonder if that's known and I just haven't been paying attention | 23:24 |
SotK | hm, doesn't POST_FAILURE mean something like it failed to successfully upload the logs? | 23:25 |
Zara | one would think | 23:25 |
* Zara will recheck and see what happens | 23:26 | |
Zara | in case it was a brief blip of some sort | 23:26 |
* Zara is very technical and knows all the technical things | 23:27 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!