Thursday, 2016-10-27

*** jtomasek has joined #storyboard07:02
*** jtomasek has quit IRC08:04
*** jtomasek has joined #storyboard08:18
*** jtomasek has quit IRC08:57
Zarahttps://etherpad.openstack.org/p/ocata-infra-community-task-tracking10:19
jamesmcarthurjust wanted to say great job to the amazing storyboard team!! love what you all are doing and can't wait to start using.13:33
SotK:) thanks13:52
SotKglad you like what we're doing!13:52
Zarayes, thank you! :) it was great to meet in person at last!13:53
* Zara realises she's confused jamesmcarthur with jpmaxman13:55
Zaraoh well, nothing like some public embarrassment to break the ice \o/13:55
SotK:)13:55
jamesmcarthurzara: no worries, it happens more frequently than you would think ;)13:56
jamesmcarthurI'm sorry I didn't stick around to chat. Had to run. But we're looking forward to moving the Foundation's tasks over to storyboard.13:56
jamesmcarthurzara: to be specific - foundation o.o and app tasks :)13:57
Zarayay! :D13:57
Zara(and thanks, sorry again about the mixup!)13:58
* SotK is pleased that folk are excited to use storyboard13:58
*** jtomasek has joined #storyboard15:06
*** jtomasek has quit IRC15:31
openstackgerritAdam Coldrick proposed openstack-infra/storyboard: Add filters to the /v1/tasks/search endpoint  https://review.openstack.org/39098316:42
Zarahm, I get a 500 when I add a user to a private story18:30
SotKwhich patch is that with?18:31
Zarahttps://review.openstack.org/#/c/389997/ but now checking if it's on master18:31
Zarableh, looks like it is.18:32
SotKo.O18:32
Zarahttp://paste.openstack.org/show/587207/18:33
* SotK sees the same18:34
* SotK will attempt to solve this after food18:36
Zarawe have ordered our priorities the same way18:36
*** bethwhite has quit IRC20:00
*** bethwhite has joined #storyboard20:08
*** alexismonville has joined #storyboard20:16
*** alexismonville has quit IRC20:32
* SotK returns to see whats broken!21:16
*** jtomasek has joined #storyboard21:48
*** jtomasek has quit IRC21:52
*** bethwhite has quit IRC22:04
openstackgerritAdam Coldrick proposed openstack-infra/storyboard: Fix modification of private stories  https://review.openstack.org/39131022:15
* Zara vaguely wishes for a bunch of public storyboard VMs that could be manually deployed and used for development. I'd love to eliminate my office network from the process. no idea where to start with that22:15
Zara\o/22:15
SotKits not very pretty, but I feel its better than trying to force the user id all over the place22:16
Zarayeah, this bug is weird, it doesn't stop you from editing things, but it throws an error that makes it look as though the edit hasn't gone through22:16
Zara(that wasn't in reply to you, we just posted at the same time)22:16
SotK:)22:16
ZaraI was just giving some context22:16
Zara:)22:16
Zarahah, I see what you mean about 'not pretty'22:17
Zarathat looks very fragile... but I don't have a better idea rn22:17
Zaramaybe 'fragile' is the wrong word... 'looks liable to be accidentally replicated in the wrong places in the future'22:18
SotKyes, I tried to make the docstring sound as disuasive as possible22:18
Zarayeah, I appreciate it22:19
ZaraI suspect it won't be enough, but yeah, no better approach springs to mind22:19
Zaraand if one does, we'll change it22:19
SotK(it was erroring because an error was being swallowed by *something* in story_update_updated_at and then sqlalchemy exploded the next time it tried to do something (which happened to be the notification thing))22:20
SotKindeed22:20
Zaraaha22:20
SotKand in the mean time I will leave grumpy reviews on folk that try to use it and/or replicate it22:20
ZaraI suspect the inelegance of it will nag at you so much that you won't be able to stop thinking about it and you'll change it quite quickly, haha22:20
* Zara will test now22:20
SotKactually, maybe the error wasn't being swallowed but pecan was still running the post-request hook after the failure22:21
Zarathat sounds worse22:22
SotKso the exception was raised correctly but didn't make it into the traceback because pecan tried to die gracefully and instead died worse22:22
SotK(through no fault of its own)22:22
Zarahahaha, I just tried to do 'git review -d 39131'22:23
SotK:D22:24
Zaraturns out this here gerrit's a *bit* bigger than that22:24
Zara(hm, also I think I'm getting to the point where the things I'm prefacing with 'hahaha' are things that people mock software engineers for prefacing with 'hahaha')22:26
Zaralooks good so far22:44
SotK\o/22:44
ZaraI can save a private story and edit some words and users without scariness22:44
Zarayeah, it seems fine22:48
Zarahave now raced through my other tests-that-I-really-should-automate22:50
Zaraone thing I haven't checked is the behaviour of emails22:50
Zaraokay, 500 seems fine with that patch23:22
Zarathough it's reminded me of what I originally noticed that led to the discovery of the strangeness23:22
Zarawhich is that our email templates for stories don't yet include changes in the users of private stories23:23
Zara*changes to the list of users23:23
Zarahuh, gerrit isn't providing a linkable failure log23:24
ZaraI wonder if that's known and I just haven't been paying attention23:24
SotKhm, doesn't POST_FAILURE mean something like it failed to successfully upload the logs?23:25
Zaraone would think23:25
* Zara will recheck and see what happens23:26
Zarain case it was a brief blip of some sort23:26
* Zara is very technical and knows all the technical things23:27

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!