| *** davidlenwell has quit IRC | 00:03 | |
| *** davidlenwell has joined #storyboard | 00:16 | |
| *** alexismonville has joined #storyboard | 00:52 | |
| *** alexismonville has quit IRC | 01:31 | |
| *** fay has joined #storyboard | 06:48 | |
| *** fay is now known as Guest21499 | 06:49 | |
| *** Guest21499 is now known as faybrocklebank | 07:57 | |
| SotK | morning storyboard! | 08:39 |
|---|---|---|
| Zara | morning! | 09:21 |
| Zara | seems it took me a while to tab through my active windows | 09:21 |
| Zara | yay, review, thanks! :D also, yeah, I was a bit unsure of the box when logged in with no notes; I mainly left it up because I wanted the 'add notes' button in the same place as the 'edit notes' button and that way was simple vs playing with css for a few more hours | 09:41 |
| Zara | I decided it looked a bit odd but not odd enough to worry xD | 09:42 |
| Zara | hah, I think we have the same instincts with panels | 09:42 |
| * Zara will update that | 09:43 | |
| openstackgerrit | Zara proposed openstack-infra/storyboard-webclient: Give certain lists a border https://review.openstack.org/373467 | 09:50 |
| Zara | removed from task list. | 09:51 |
| SotK | \o/ | 09:51 |
| Zara | I feel like the lack of borders can make things look 'unfinished' sometimes. I suppose I could spend some time making a custom class for the panels so the borders were lighter, but suspect there might be better ways to spend a day xD | 09:57 |
| Zara | it's bothered me on-and-off all year for the dash, anyhoo | 09:58 |
| Zara | I think because it's two lists side-by-side | 09:58 |
| SotK | yep, I think its the lack of that that makes it jarring on the task lists too | 09:58 |
| SotK | (lack of being two lists side by side) | 09:58 |
| Zara | yeah. I still think I prefer it slightly, but only when no notes, and it's not a strong preference and I keep changing my mind, so would rather just leave it out! | 10:00 |
| Zara | I did want to do it for the worklists list in stories but couldn't get it to work | 10:00 |
| *** dabukalam has quit IRC | 10:19 | |
| Zara | oh hm, https://review.openstack.org/#/c/368917/ still requires +1s | 10:46 |
| * pedroalvarez looks at it | 10:48 | |
| *** davidlenwell has quit IRC | 10:57 | |
| *** davidlenwell has joined #storyboard | 10:58 | |
| Zara | thanks for the review :) | 11:10 |
| pedroalvarez | yw | 11:15 |
| *** dabukalam has joined #storyboard | 11:37 | |
| *** dabukalam has quit IRC | 11:46 | |
| Zara | reeeecheck | 11:54 |
| *** dabukalam_ has joined #storyboard | 12:07 | |
| Zara | hm, lot of errors showing up with my email worker, but not sure exactly when generated or what my setup was at the time. might mean a recent api patch had interesting side-effects | 12:08 |
| *** dabukalam_ has quit IRC | 12:14 | |
| *** dabukalam_ has joined #storyboard | 12:18 | |
| Zara | gah, while testing webclient patch, found a bug in the api teams patch | 12:22 |
| Zara | managed to catch it before it was merged ;_; | 12:22 |
| Zara | guessing a story doesn't have a list of permissions if not private? | 12:24 |
| SotK | if its never been private, that is true | 12:25 |
| SotK | if it was once private but is now public it'll still have the old ones (they'll just be bypassed) | 12:25 |
| Zara | yeah, this one had never been private | 12:26 |
| Zara | so this is the line: elif teams == [] and original_story.permissions[0].users == []: | 12:26 |
| *** dabukalam_ has quit IRC | 12:26 | |
| Zara | that it doesn't like | 12:26 |
| Zara | presumably because there's no permissions[0] | 12:26 |
| SotK | yeah, that'd do it | 12:26 |
| * SotK grumbles at himself | 12:26 | |
| Zara | heh | 12:26 |
| Zara | I'm just relieved I caught it before merge | 12:27 |
| Zara | given I'd +A'd and then it timed out so it was mid-recheck | 12:27 |
| Zara | hm, we haven't had a storyboard musical interlude for ages | 12:42 |
| Zara | I'll have to think about it | 12:42 |
| Zara | in other news, storyboard meeting at 15:00 UTC. | 12:43 |
| *** dabukalam has joined #storyboard | 13:06 | |
| *** dabukalam has quit IRC | 13:12 | |
| *** dabukalam has joined #storyboard | 13:22 | |
| *** dabukalam has quit IRC | 13:23 | |
| pedroalvarez | good catch Zara | 13:31 |
| *** alexismonville has joined #storyboard | 14:27 | |
| *** openstack has joined #storyboard | 15:01 | |
| *** faybrocklebank has quit IRC | 16:07 | |
| *** dabukalam has joined #storyboard | 16:19 | |
| Zara | yay, storyboard's famous again! http://superuser.openstack.org/articles/openstack-gerrit-storyboard-integration/ | 19:03 |
| *** alexismonville has quit IRC | 19:55 | |
| *** alexismonville has joined #storyboard | 20:11 | |
| *** alexismonville has quit IRC | 20:16 | |
| SotK | \o/ | 20:38 |
| *** alexismonville has joined #storyboard | 21:11 | |
| *** alexismonville has quit IRC | 21:16 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!