Friday, 2016-07-29

*** davidlenwell has quit IRC07:22
*** davidlenwell has joined #storyboard07:34
Zaramorning, storyboard09:10
SotKmorning!09:10
Zarahow are people doing?09:44
SotKpretty good thanks09:46
SotKhow're you?09:46
ZaraI'm still waking up... but I learned about an unusual type of chicken yesterday09:47
Zaraactual animals: http://photorator.com/photos/images/silkie-chickens--30013.jpg09:47
SotK:D silkies are great looking creatures09:48
Zaraeveryone else has heard of them! clearly I've been disadvantaged growing up in a city09:49
Zarabefore this, my favourite chicken was a buff orpington (it looks like a normal chicken, except it's the size of a toddler)09:49
Zarabut I have upgraded09:49
faybrocklebankI also know nothing about chicken breeds but that one is ace09:51
*** tlbr has quit IRC09:52
*** tlbr has joined #storyboard09:53
*** tlbr has quit IRC09:53
Zara:D09:53
*** tlbr has joined #storyboard09:54
*** tlbr has quit IRC09:54
*** tlbr has joined #storyboard09:56
*** tlbr is now known as Guest4546609:56
*** Guest45466 has quit IRC10:00
*** tlbr_ has joined #storyboard10:13
Zaraoh, the linter doesn't like the complex priorities ui in its current form, btw10:16
Zara2016-07-28 19:27:55.219859 | src/app/stories/controller/story_detail_controller.js10:16
Zara2016-07-28 19:27:55.219890 |   80:0  error  Line 80 exceeds the maximum line length of 80  max-len10:16
*** tlbr_ has quit IRC10:17
openstackgerritAdam Coldrick proposed openstack-infra/storyboard-webclient: Complex priorities UI in stories  https://review.openstack.org/31266610:23
Zaraokay, I think it has all the relevant information now. :) though, gah, having played around with it, I think it should display 1 thing per worklist by default, but have a clickable way to expand to the full list. otherwise it pushes stories a long way down. (my test is here: http://docs-draft.openstack.org/66/312666/17/check/gate-storyboard-webclient-js-draft/2ca0a06//dist/#!/story/32 ; I put all the task10:29
Zaras from it in a subscribed worklist, http://docs-draft.openstack.org/66/312666/17/check/gate-storyboard-webclient-js-draft/2ca0a06//dist/#!/worklist/41)10:29
ZaraI think that's the *last* thing.10:30
openstackgerritAdam Coldrick proposed openstack-infra/storyboard-webclient: Complex priorities UI in stories  https://review.openstack.org/31266610:56
*** Guest5363 has joined #storyboard11:36
*** Guest5363 has quit IRC11:36
*** tlbr_ has joined #storyboard12:05
*** tlbr_ has quit IRC12:09
Zaraoh huh, so tags.get(108) gets the tag with id 108, but tags.update(id=108) updates the tags for story 10812:26
Zara(oh, and tags.get(id=108) also gets tag with id 108)12:27
Zarawell that explains why I've been confused.12:28
*** Guest41883 has joined #storyboard12:35
Zaraaaand it gets weirder12:35
ZaraI think something's back-to-front...12:36
Zaraso if I want to add a tag, 'LHF', to story 170, this is the syntax: `storyboard.tags.update(id=170, LHF='tag_name')`12:36
Zarait doesn't have to say 'tag_name' in the string but there does need to be some string there12:36
Zaraso yeah, for some reason it takes the key as the tag name value12:37
Zaraif I just have (id=170, 'blah'), I get errors, same if I swap those around, try 'blah' sans quotes....12:38
Zarathat syntax will create a new tag or append an existing one12:39
Zaraand it seems totally bizarre to me.12:39
*** Guest41883 has quit IRC12:40
*** tlbr_ has joined #storyboard12:48
Zaraalso, I suspect it'll be better to have task titles in the complex priorities 'more...' modal (since it's harder to scroll to see task numbers with it open), but I'm fine with iterating on that. this looks like a good starting point! :) I'm going to look a bit more closely now.12:52
*** tlbr_ has quit IRC12:52
Zaraanyway, if anyone has any thoughts on tag-stuff above, I'd appreciate it, since I'm not really sure what it *should* look like. I'd imagine storyboard.tags.update(story_id=170, title='LHF') would be more the expected sort of thing, but I don't really know if it's weird or not (or if it matters that much, if it is weird but is documented)13:09
SotKI suspect this is related to the weirdness in the tags api that was tripping anteaya up when writing the api docs too13:10
Zarayeah, I vaguely remember it taking the story_id from somewhere unexpectedly13:10
Zara(also, I couldn't find any way of updating a tag for a story via storyboard.stories..., but maybe there is and I just didn't know the syntax)13:12
Zarabut yeah, that's how I ended up trying it that way round13:13
SotKhmm, what would "updating a tag for a story" actually entail?13:19
Zarasorry, phrased that badly, I meant 'adding a tag to a story'13:19
*** tlbr has joined #storyboard13:19
Zaraeither an existing one or making a new one13:20
Zara*tag13:20
Zarafffff I can't make sense today13:20
*** tlbr is now known as Guest2865813:20
Zaraso yeah, adding a tag *to a specific story* vs 'creating a new tag' or 'changing the title of a tag with a certain id'13:20
Zara(I couldn't actually find any way of doing the latter)13:20
SotKI don't think there is a way13:21
Zarayeah. I doubt it matters. just confused me that storyboard.tags.update() behaves so differently to all other update() things13:22
ZaraI decided to start with getting familiar with that again, since 1) it'll be used a lot and 2) I figured it'd offer a good example for updating things like stuff in worklists13:23
Zarabut since it's weird, maybe not xD13:23
*** Guest28658 has quit IRC13:24
Zaraanother bad thing about it working like this is that it means the client constrains formatting for tags, since it applies rules for keywords (I think? I get 'keyword can't be an expression' if I put a hyphen in the tag name)13:29
SotKyeah, I think that problem is because the API expects the body of that request to be a list of tag names, and the client only knows to do "make a dict of the form {key: value} from the keyword arguments"13:31
Zaraahhh13:32
ZaraI guess that's fixable in the client, then13:33
ZaraI added copious task notes to https://storyboard.openstack.org/#!/story/9813:40
Zaraevery time I read my storyboard emails, I smile. those poor little email templates! so ugly... but functional <313:45
Zaramy favourite bit is the 'I don't know how to say what kind of thing changed but I can point out what changed and you can work it out'13:46
Zaraprobably the lowest of low-hanging fruit13:46
pedroalvarezlet's create colorful html templates !13:47
* pedroalvarez runs away13:47
Zara>:D13:47
pedroalvarezI would really love that for story descriptions (and maybe task notes now) it only sends you a git-diff like summary13:47
pedroalvarezsorry, love bikeshedding13:48
Zarahahaha13:48
Zarayeah, this is what I get for task notes atm: http://paste.openstack.org/show/543903/13:48
Zaraso at the bottom is our current diff-like thing (it says 'this is what's here now, this is what was there before')13:49
pedroalvarezyup13:49
Zarabut it's not pretty or obvious13:49
Zarareally it should go "type of change: 'task notes added', change: $new_thing, $old_thing"13:51
Zarainstead of "type of change: $new thing, prior to change: $old thing"13:51
Zarabut oh well13:52
pedroalvarezwoo difflib rules13:53
Zaraheehee13:53
Zaraafter googling difflib just then, looks like it's probably simple enough to do, though I've never looked at difflib13:54
pedroalvarezlittle example: http://paste.openstack.org/show/543905/14:07
pedroalvarezwith the reslt included :)14:07
Zaratugutugu_title :D14:10
pedroalvareznote that I had to introuce some '\n' in the text to make the diff usable14:11
pedroalvarezhopefully, storyboard users, if this feature is implemented, would learn to do that to make emails more useful14:12
Zaraah, I suspect people wouldn't generally do that, so it would have to be automated afterward somehow.14:14
*** tlbr_ has joined #storyboard14:33
*** tlbr_ has quit IRC14:34
*** tlbr_ has joined #storyboard14:50
*** tlbr_ has quit IRC14:53
anteayayes Zara, your tag experience sounds like my tag experience15:14
anteayaregarding emails, many folks in openstack recieve emails as text only15:14
anteayaso if you want to spend time in html emails note that folks will want to select to recieve text only emails15:15
ZaraI think pedro was joking :)15:16
Zaraas far as I know, none of us want to do that! :D15:16
Zaraso fear not :)15:16
pedroalvarezhehe I was joking, yes15:17
anteayaah okay15:19
anteayamy morning bleary eyes missed the joking bit15:20
anteayasorry about that15:20
Zaraheh, I'm sure people have proposed it for projects in earnest before15:20
Zaraso I think it's good to be cautious! :)15:21
*** Guest79767 has joined #storyboard15:29
*** Guest79767 has quit IRC15:34
Zaravery vague plans in the works for a js meetup so that our js things aren't from the 17th century.15:36
*** tlbr_ has joined #storyboard15:40
*** tlbr_ has quit IRC15:45
ZaraI've poked about gerrit integration patches, but I think people are pretty busy today15:56
Zara(there's no massive urgency to it, I just know it's a big chunk of work, and the longer it waits the higher the risk of merge conflicts and things grinding to a halt, so I'm hoping we can get something up and running soon)15:59
*** Guest30197 has joined #storyboard16:28
*** Guest30197 has quit IRC16:33
*** tlbr_ has joined #storyboard16:40
openstackgerritAnita Kuno proposed openstack-infra/storyboard: Add example commands for the Teams api  https://review.openstack.org/33912316:40
Zara\o/16:42
*** tlbr_ has quit IRC16:44
ZaraI should probably have more input for POSTs and PUTs and things next week, but happy to +1 for now and merge if it gets more reviews before that (I think SotK has gone home for the night, so I'd expect Monday for that at the earliest)16:44
Zaraanteaya: just saw your new comment on the patch; I think the problem is the trailing slash in the command you used16:48
ZaraI just tried it with and without the trailing slash and it worked without16:48
anteayaah thank you16:48
* anteaya also tries without the trailing slash16:48
anteayaso it does, thanks16:49
ZaraI hope it works! :D16:49
Zarayay16:49
anteayait does so16:49
Zarahaha I'm too slow16:49
anteayashould it also work with the trailing slash?16:49
ZaraI don't know what the best practice should be. I think we may want to note somewhere that the examples won't work with trailing slashes16:50
Zaraif it shouldn't be changed16:50
anteayaummm, hmmm16:50
anteayaI don't know a lot about apis16:50
anteayabut I think annegentle does16:51
anteayaI think I will ask on -dev and see if anne has any best practice suggestions16:51
Zaraokay, thank you. :) there may be historical reasons why it is the way it is, but not my area, and it's nearly the end of my day, so sorry I can't be more help.16:52
Zara+ it's useful to be aware of it, so thanks for shedding light on it16:53
anteayano I understand16:55
anteayathank you for seeing it16:55
Zara:) (on a related note, at some point I really want to find out why stories.get_all() (or browsing to api/v1/stories) doesn't work for storyboard.openstack.org. it works for dev and it works for other instances, so I think it's something in the storyboard database that's confusing things.)16:56
Zaraatm it's bad news for scripts that want to analyse all stories to see if they fulfil some criteria16:57
Zarahttps://storyboard.openstack.org/api/v1/stories for the curious16:57
* Zara closes about 30 tabs, 'night, all! :D17:03
anteayanight17:08
anteayaoh my17:09
anteayayes I can see that api request being a popular script starting point17:09
anteayaso it looks like I will try again next week to see if I can get some guidance on how the api should handle trailing slashes17:15
anteayaso far we have some thoughts on -dev but no consensous17:15
*** tlbr_ has joined #storyboard17:25
*** tlbr_ has quit IRC17:30
*** tlbr has joined #storyboard19:00
*** tlbr is now known as Guest8412419:00
*** Guest84124 has quit IRC19:04
*** tlbr has joined #storyboard19:42
*** tlbr is now known as Guest7910019:42
*** Guest79100 has quit IRC19:51
*** Guest97891 has joined #storyboard21:32
*** Guest97891 has quit IRC21:39
*** tlbr_ has joined #storyboard21:46
*** tlbr_ has quit IRC21:47
*** tlbr_ has joined #storyboard22:00
*** tlbr_ has quit IRC22:04
*** Guest13477 has joined #storyboard22:14
*** Guest13477 has quit IRC22:19
*** tlbr_ has joined #storyboard22:24
*** tlbr_ has quit IRC22:29
*** tlbr_ has joined #storyboard22:35
*** tlbr_ has quit IRC22:40
*** Guest59655 has joined #storyboard22:56
*** Guest59655 has quit IRC23:02
*** tlbr_ has joined #storyboard23:22
*** tlbr_ has quit IRC23:27
*** tlbr has joined #storyboard23:34
*** tlbr is now known as Guest1620723:34
*** Guest16207 has quit IRC23:38
*** tlbr_ has joined #storyboard23:58

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!