| *** openstackgerrit has quit IRC | 06:33 | |
| *** openstackgerrit has joined #storyboard | 06:33 | |
| *** mrmartin has joined #storyboard | 07:07 | |
| *** mrmartin has quit IRC | 07:25 | |
| *** matthewbodkin has joined #storyboard | 07:44 | |
| *** mrmartin has joined #storyboard | 08:12 | |
| *** mrmartin has quit IRC | 08:22 | |
| *** mrmartin has joined #storyboard | 08:26 | |
| *** mrmartin has quit IRC | 09:40 | |
| Zara | morning, storyboard! SotK is ill today and I'm leaving early, so although I know this channel is *the* place to be, expect the party to die down earlier than usual. | 09:45 |
|---|---|---|
| Zara | (I also have a bunch of patches to write so although it may look like I'm chatty, it's often a case of thinking out loud for the logs, so doesn't mean every other subject of conversation has the same priority.) | 09:46 |
| *** alexismonville has joined #storyboard | 10:04 | |
| *** mrmartin has joined #storyboard | 10:09 | |
| *** mrmartin has quit IRC | 10:35 | |
| *** faybrocklebank has quit IRC | 11:21 | |
| *** faybrocklebank has joined #storyboard | 11:23 | |
| *** alexismonville has quit IRC | 11:38 | |
| *** alexismonville has joined #storyboard | 11:47 | |
| Zara | persia: just going through 'patches that were submitted in their original form over a month ago'; subscribe button for worklists in review here, I think it's ready for merge in that form, but needs another +1; you've +1'd an older version so you may be interested! https://review.openstack.org/#/c/324550/ | 11:57 |
| * persia has not had much time for review lately, unfortunately, but tries to figure out what changed since that +1 | 11:58 | |
| Zara | np :)off the top of my head, the issues I commented on were fixed... which isn't very helpful | 12:00 |
| persia | Oh, that seems to have all the missing bits that I thought we future patches filled. Nice! | 12:00 |
| Zara | haha | 12:00 |
| persia | Oh, and some rebasing (including conceptual rebasing), but that's only to be expected. | 12:01 |
| Zara | \o/ thank you! | 12:01 |
| openstackgerrit | Merged openstack-infra/storyboard-webclient: Allow comments to be edited by their owner https://review.openstack.org/333418 | 12:01 |
| persia | Oh ugh, and that makes the patch that really excites me get into Merge Conflict. | 12:02 |
| persia | I suppose it was inevitable, but ... | 12:02 |
| Zara | yeah, I hadn't got to testing it yet, unfortunately, and thought that if I found bugs, SotK would not be able to fix until Monday anyway, and I shouldn't wait 'til I'd tested to touch other patches, but I think that one's pretty close to being ready to merge by now | 12:05 |
| persia | Found a nit in it anyway. | 12:06 |
| Zara | the changes made since my last review were fairly substantial (behaving right for archived lists) and ime those sorts of changes can often introduce fiddly bugs, so I wanted a good block of time to test. | 12:06 |
| Zara | hahaha I'll take that as proof xD | 12:07 |
| Zara | well, no, having seen the nit I won't. | 12:08 |
| Zara | since I was thinking more 'links going to unexpected places'. and with that, I vanish into code once more... | 12:09 |
| persia | No, the nit is not a bug, just a nit. Don't let it block testing: it's not functional in any way: just decorative adjustment. | 12:10 |
| persia | (and some would say that the current decoration is preferred as being more commonly used) | 12:10 |
| openstackgerrit | Merged openstack-infra/storyboard-webclient: Add a subscribe button to worklists https://review.openstack.org/324550 | 12:14 |
| Zara | hm, the back-button issue causes more pain than usual when the user navigates from review.openstack.org to the js-draft, since there's no way of getting back to review.openstack.org after viewing the changes | 12:27 |
| Zara | btw, https://review.openstack.org/#/c/342164/ is a nice little fix that was previously tucked away in another patch. if you've ever been burned by the error messages appearing off the visible screen so that you don't know there's an error, this patch may be of interest. | 12:30 |
| Zara | you can test by comparing typing numbers in the header search on storyboard-dev.openstack.org and doing the same thing in the draft build | 12:31 |
| Zara | harder to explain in words than just demonstrating :) | 12:31 |
| Zara | advance warning that I'm feeling a bit ill, I'm only planning to be in another 2 hours anyway, but just so people are aware! | 13:03 |
| * Zara tries looking at project groups vs worklists to work out what's going on. still stumped by this typeahead. | 13:14 | |
| * Zara concludes it's not the resource. | 13:19 | |
| anteaya | Zara: I'm sorry you aren't feeling well, I also hope SotK feels better soon too | 13:35 |
| Zara | thank you :) | 13:47 |
| anteaya | :) | 13:52 |
| -openstackstatus- NOTICE: Gerrit is restarting to correct memory/performance issues. | 14:19 | |
| *** matthewbodkin has quit IRC | 14:33 | |
| *** jamesmcarthur has joined #storyboard | 14:41 | |
| *** jamesmcarthur_ has joined #storyboard | 14:44 | |
| *** jamesmcarthur has quit IRC | 14:51 | |
| *** jamesmcarthur_ is now known as jamesmcarthur | 14:51 | |
| *** alexismonville has quit IRC | 15:27 | |
| openstackgerrit | Zara proposed openstack-infra/storyboard-webclient: Revert "Allow comments to be edited by their owner" https://review.openstack.org/342987 | 17:30 |
| *** alexismonville has joined #storyboard | 17:31 | |
| Zara | I think that will take a few hours to get through, unfortunately. :( | 17:35 |
| anteaya | :( | 17:44 |
| anteaya | thanks for fixing | 17:44 |
| Zara | you're welcome! :) | 17:45 |
| anteaya | :) | 17:46 |
| openstackgerrit | Merged openstack-infra/storyboard-webclient: Revert "Allow comments to be edited by their owner" https://review.openstack.org/342987 | 17:53 |
| anteaya | oh by the way, I mentioned the updated api docs in the release team meeting today stating that I am asking a very small handful of people the question | 18:01 |
| anteaya | if we migrate to storyboard tomorrow, could you get work done? | 18:01 |
| anteaya | dhellmann said he would take a look at things next week and share his response to that question | 18:01 |
| anteaya | reminder: I won't be around much next week, I'll be at the nova mid cycle | 18:02 |
| Zara | okay, thank you for approaching them! :) | 18:02 |
| anteaya | welcome :) | 18:05 |
| Zara | (if anyone's curious about the strategy I used to work out what was going on with the exciting bug today: suspected most recent patch, but didn't want to conclusions, so I checked if the problem was across instances. it was present in all infra instances, but not my test instance. attempted to check db for dev, for permissions things, but turned out it was different to how I do it locally and I didn't kno | 18:05 |
| Zara | w how yet. I noticed the stories were 'hidden', but they were listed from other views, meaning it wasn't actually a permissions issue. the obvious differences between our instances are comments settings, so I tried to reproduce issue on my instance for ages, failed, then remembered eventually that the web console was a thing and compared logs from various instances. and it showed an error!) | 18:06 |
| Zara | so about half an hour of wandering around running into things from noticing to patching. :) | 18:06 |
| Zara | my suspicions were correct and I forgot to use the most obvious tool. maybe someone can learn something from it, maybe not, I've no idea. | 18:08 |
| * Zara vanishes again | 18:08 | |
| *** jmccrory_away is now known as jmccrory | 18:08 | |
| anteaya | thanks for the debrief | 18:14 |
| anteaya | and for fixing the issue | 18:14 |
| *** davidlenwell has quit IRC | 18:23 | |
| Zara | still waiting for it to build/deploy | 19:54 |
| Zara | /pointless-announcement | 19:55 |
| * Zara disappears again | 19:55 | |
| Zara | aaand they work again! :) thanks, all | 20:22 |
| Zara | both storyboard.openstack.org and storyboard-dev.openstack.org should be back to normal | 20:23 |
| Zara | goodnight! | 20:23 |
| *** davidlenwell has joined #storyboard | 20:34 | |
| *** alexismonville has quit IRC | 21:28 | |
| *** alexismonville has joined #storyboard | 22:00 | |
| *** alexismonville has quit IRC | 22:44 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!