| *** gothicmindfood has joined #storyboard | 01:36 | |
| *** openstackgerrit has quit IRC | 07:33 | |
| *** openstackgerrit has joined #storyboard | 07:33 | |
| *** mrmartin has joined #storyboard | 08:17 | |
| *** openstackgerrit has quit IRC | 08:18 | |
| *** openstackgerrit has joined #storyboard | 08:18 | |
| Zara | morning, storyboard! | 09:22 |
|---|---|---|
| *** mrmartin has quit IRC | 09:30 | |
| * Zara looks at https://review.openstack.org/#/c/333409/ | 10:59 | |
| openstackgerrit | Merged openstack-infra/storyboard: Add a way to retrieve the history of edited comments https://review.openstack.org/333409 | 11:50 |
| Zara | aw, linting fails for the non-permanent filter buttons | 11:51 |
| Zara | not sure why it wasn't caught before the gate, hm | 11:51 |
| Zara | 2016-07-01 11:07:08.607800 | src/app/stories/controller/story_detail_controller.js | 11:51 |
| Zara | 2016-07-01 11:07:08.607830 | 107:34 error headers is defined but never used no-unused-vars | 11:51 |
| Zara | that seems like something that should have been caught | 11:51 |
| Zara | (for: https://review.openstack.org/#/c/331748/ ) | 11:52 |
| SotK | I think something has changed, like the version of eslint used in the gate or something | 11:52 |
| SotK | I saw that in a totally unrelated patch too iirc | 11:52 |
| Zara | huh, the same failure is present in the test that's marked as success | 11:53 |
| SotK | oh, the subscribe button xD | 11:53 |
| Zara | 2016-06-21 11:28:28.920835 src/app/stories/controller/story_detail_controller.js | 11:53 |
| Zara | 2016-06-21 11:28:28.920865 107:34 error headers is defined but never used no-unused-vars | 11:53 |
| SotK | https://review.openstack.org/#/c/324550/4/src/app/stories/controller/story_detail_controller.js is the fix you need | 11:53 |
| SotK | hmm, weird | 11:53 |
| Zara | yeah, I'm more bothered by the test reporting success than by the actual error, which seems sensible enough... | 11:53 |
| *** mrmartin has joined #storyboard | 11:54 | |
| * SotK disappears again | 11:54 | |
| Zara | :) | 11:54 |
| Zara | and I was about to ask how the holiday was going! | 11:54 |
| *** mrmartin has quit IRC | 12:05 | |
| Zara | asked in #infra, AJaeger has shed light on it; t'was a bug fixed by: https://review.openstack.org/#/c/334582/ | 12:07 |
| Zara | so I think it was just checked before that merged | 12:08 |
| Zara | I'm still not au fait with changing other people's patches in gerrit. which is to say that last time I tried, everything went wrong and I panicked. | 12:41 |
| Zara | I'd rather announce events timelineness after we have the non-permanent filters, so... atm plan to send out an email mid-next-week. | 12:42 |
| Zara | it's so quiet today! | 13:06 |
| persia | Zara: Context on the notes-read-only-by-default change: that was a consequence of notmorgan accidentally overwriting a few notes when looking around. | 13:22 |
| Zara | okay, I agree with the motivations for it, I'm partly hoping that if someone asks about the possibility of having ephemeral notes in a few months' time, it'll ring a bell | 13:25 |
| Zara | might be wishful thinking, but hoping people won't get caught up in redoing it. | 13:26 |
| Zara | (also, heh, I'd remembered it as dhellman but wasn't sure... I timed that bugsquash atrociously.) | 13:29 |
| Zara | pedroalvarez: I'm pinging you about the ansible role/docs since I said I'd bug you about it ages ago and forgot. :) did you get anywhere with it? | 13:45 |
| *** sparkycollier has quit IRC | 14:23 | |
| *** sparkycollier has joined #storyboard | 14:24 | |
| *** jamesmcarthur has joined #storyboard | 15:22 | |
| Zara | hm, looks like once you archive a lane, you can't add things from that lane to other lanes in the same board | 15:40 |
| Zara | I thought we'd found and fixed that earlier, but maybe I'm getting it confused | 15:40 |
| Zara | this is probably why my oldest board isn't finding a bunch of tasks and stories, anyway | 15:40 |
| Zara | grr | 15:40 |
| Zara | I've added a task for it so it doesn't get lost. | 15:45 |
| Zara | ugh, linting fails for task notes patch, too; gonna take a wild guess about what the error will be... | 16:26 |
| Zara | yup, same thing | 16:26 |
| Zara | ('headers' var is unused) | 16:26 |
| Zara | welp on monday I'll dig into changing others' patches via gerrit, since that's blocked... 2 patches today? there's no urgency to merging them today, but that's annoying. | 16:27 |
| Zara | hm, subscriptions page does one GET per type of subscription. not sure if that's avoidable or not | 16:32 |
| Zara | it seems a bit weird that it does both a GET for projects with subscriber foo, plus a GET for subscriptions that are to projects, with subscriber foo | 16:33 |
| Zara | and similar for all other resources | 16:33 |
| Zara | the page doesn't load particularly slowly, anyway; that just seems weird. | 16:33 |
| *** jamesmcarthur has quit IRC | 16:46 | |
| Zara | heh, that archived cards order problem is very visible on this worklist I was just testing | 16:55 |
| Zara | also seems weird that it just increments the subscription id each time (so if you subscribe, then delete subscription, then subscribe again, the id is incremented the second time you subscribe). well, that's simplest.... I just wonder if it'll get weird wiht high numbers. | 16:58 |
| Zara | probably fine | 16:58 |
| persia | Any given deployment probably needs thousands of developers making thousands of changes a day for thousands of years to overflow in any interesting way. | 17:01 |
| Zara | yup | 17:02 |
| persia | Erm, plus another factor of ten. | 17:02 |
| Zara | I could see it being slower than it had to be if there were things that requested the full list of subscriptions, including all those deleted ones | 17:02 |
| Zara | but that's the only thing I can think of | 17:03 |
| Zara | (ie: all the deleted ones when it didn't need to request those) | 17:03 |
| Zara | and in practice I don't think they hang around; I think it's just the id that's incremented, but I might be wrong on that | 17:03 |
| SotK | yeah, its just that ids are not reused unless explicitly set | 17:08 |
| Zara | \o/ | 17:11 |
| Zara | how's the holiday? | 17:11 |
| *** jamesmcarthur has joined #storyboard | 17:34 | |
| Zara | evidently absorbing! \o/ night, all | 17:43 |
| *** jamesmcarthur has quit IRC | 17:44 | |
| *** jtomasek has quit IRC | 19:42 | |
| -openstackstatus- NOTICE: The infrastructure team is taking Gerrit offline for maintenance beginning shortly after 20:00 UTC to upgrade the Zuul and static.openstack.org servers. We aim to have it back online around 22:00 UTC. | 19:54 | |
| *** jtomasek has joined #storyboard | 19:55 | |
| -openstackstatus- NOTICE: Gerrit is offline for maintenance until approximately 22:00 UTC | 20:08 | |
| *** ChanServ changes topic to "Gerrit is offline for maintenance until approximately 22:00 UTC" | 20:08 | |
| *** nibalize1 has joined #storyboard | 21:50 | |
| *** nibalizer has quit IRC | 21:53 | |
| *** nibalize1 is now known as nibalizer | 21:58 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!