| *** jamesmcarthur has joined #storyboard | 00:04 | |
| *** jamesmcarthur has quit IRC | 00:10 | |
| *** jamesmcarthur has joined #storyboard | 00:10 | |
| *** jamesmcarthur has quit IRC | 00:18 | |
| *** jamesmcarthur has joined #storyboard | 00:20 | |
| *** jamesmcarthur has quit IRC | 00:25 | |
| *** jamesmcarthur has joined #storyboard | 00:27 | |
| *** jamesmcarthur has quit IRC | 01:37 | |
| *** pleia2_ is now known as pleia2 | 03:15 | |
| *** SotK has quit IRC | 03:25 | |
| *** SotK has joined #storyboard | 03:27 | |
| *** ttx has quit IRC | 07:03 | |
| *** ttx has joined #storyboard | 07:04 | |
| *** persia has quit IRC | 07:08 | |
| *** jtomasek has joined #storyboard | 07:11 | |
| *** persia has joined #storyboard | 07:11 | |
| SotK | good morning storyboard! | 09:27 |
|---|---|---|
| pedroalvarez | morning! :) | 09:29 |
| SotK | thanks for the email threading patch, I'm taking a look at it now :) | 09:29 |
| pedroalvarez | It will be possible to put all of it in a get_thread_id() function to not mix the code | 09:30 |
| Zara | pleia2: ahaha, fwiw I've been laughing at the collapse of our economy! not much else I can do xD | 09:39 |
| Zara | SotK: I think https://review.openstack.org/#/c/272667/ is ready for a +2 or similar | 09:39 |
| Zara | unless you see something weird | 09:39 |
| Zara | thanks | 10:19 |
| Zara | gah, always forget that colspan != total of col-xs-whatever | 10:19 |
| Zara | hm, on my test instance, the project icon takes ages to load for each task (and the subscribe button), in the story detail view | 10:52 |
| Zara | it's not all icons so I don't think it's a problem finding assets or anything | 10:52 |
| Zara | hm, 9 GETs for the story | 10:54 |
| Zara | (well, for all the things relevant to the story; 9 GETs for the page) | 10:54 |
| openstackgerrit | Zara proposed openstack-infra/storyboard-webclient: Show Each Task ID in Story Detail View https://review.openstack.org/272667 | 10:58 |
| Zara | I also changed the task title column length back, since I'd only changed it out of confusion | 11:00 |
| pedroalvarez | uhm.. zuul links to "live logs" of builds link now to telnet://IP:port | 11:10 |
| pedroalvarez | wow! if you `telnet IP port` from the terminal, you get the logs :D | 11:11 |
| Zara | yup! :D | 11:12 |
| Zara | I'll find the email about it, hang on | 11:12 |
| Zara | http://lists.openstack.org/pipermail/openstack-dev/2016-June/097595.html | 11:13 |
| pedroalvarez | I was aware of this one, which is not merged yet: https://review.openstack.org/#/c/320563/ | 11:14 |
| pedroalvarez | thanks Zara! | 11:14 |
| Zara | yw :) | 11:15 |
| pedroalvarez | I will need to learn how all of this works, if I want to use it :) | 11:16 |
| Zara | :) yeah, been a while since I used telnet, haha | 11:29 |
| Zara | now looking at https://review.openstack.org/#/c/331646/ | 11:29 |
| Zara | oh, I expect the slow loading I noticed before is because my test story has a big timeline, so this kind of thing should help | 11:32 |
| Zara | (when I eventually get to the filters, too... | 11:32 |
| Zara | yeah, it loads faster when I deselectall events, so it's that. | 11:38 |
| Zara | though huh; task priority doesn't seem to be included in 'task details changed' | 11:38 |
| pedroalvarez | I'm only seeing story created events, and seeing the prioiry changes | 11:39 |
| Zara | yeah | 11:40 |
| Zara | This has made me notice that 'task priority changed' is a separate event from 'task details changed' but there's no option to configure it. | 11:40 |
| Zara | with all events unchecked, my GET looks like: 127.0.0.1 - - [27/Jun/2016 11:39:04] "GET /v1/stories/1/events?event_type=task_priority_changed&sort_dir=asc&sort_field=id HTTP/1.1" 200 628 | 11:41 |
| Zara | so yeah \o/ | 11:41 |
| Zara | SotK: oh, last week I made some comments on https://review.openstack.org/#/c/331030/ but I'm not sure there's anything to be done in that patch, just checking you agree before I +A it. | 11:48 |
| SotK | oh | 11:49 |
| SotK | those comments make sense, but we can probably improve it further in future patches :) | 11:50 |
| Zara | cool | 11:51 |
| Zara | I'm not very fussed about the last bit. the first bit is gonna be disruptive as more people use it, but yeah, something to fix later. | 11:52 |
| * Zara +As | 11:54 | |
| Zara | https://review.openstack.org/#/c/331646 awaits more pairs of eyes. | 11:55 |
| pedroalvarez | oh, I didn't notice that it wasn't filtering the results nowadays | 11:58 |
| pedroalvarez | voted | 11:58 |
| Zara | \o/ | 11:59 |
| pedroalvarez | and the following one looks good to me too. although I'm not sure I like that you have to go through the "Advanced" dialog, when wanting to use your custom filters | 12:00 |
| pedroalvarez | https://review.openstack.org/#/c/331748 ^ | 12:00 |
| Zara | yeah, I think it's a bit unintuitive, because the user will expect those buttons to work the same way, but the 'advanced' one is a bit different. I've held off commenting to that effect in gerrit because I can't think of a way to improve that, yet. | 12:04 |
| Zara | but SotK was also uneasy with it so it sounds like we all agree | 12:04 |
| Zara | maybe 'advanced' should apply filters selected via the gear menu, and the gear be moved nearer to it? (maybe changed to 'custom'? idk) | 12:06 |
| pedroalvarez | the gear disappears I believe | 12:08 |
| Zara | yeah, I mean from its old position. I guess you're doing four things 'show all, show just comments, show the things I want, let me pick the things I want', and atm there's no separation between the last two. | 12:08 |
| pedroalvarez | yup | 12:08 |
| pedroalvarez | but that can be improved later too | 12:08 |
| pedroalvarez | is an improvement as it is right now | 12:09 |
| * pedroalvarez votes | 12:09 | |
| Zara | :) | 12:10 |
| openstackgerrit | Merged openstack-infra/storyboard-webclient: Make the Tags resource look for existing tags to filter by https://review.openstack.org/331030 | 12:14 |
| openstackgerrit | Merged openstack-infra/storyboard-webclient: Only request desired timeline events https://review.openstack.org/331646 | 12:16 |
| openstackgerrit | Merged openstack-infra/storyboard-webclient: Show Each Task ID in Story Detail View https://review.openstack.org/272667 | 13:19 |
| *** jamesmcarthur has joined #storyboard | 14:28 | |
| Zara | gonna look at the comment history db stuff now | 14:29 |
| Zara | for some reason I keep pasting the page url instead of the download url... | 14:30 |
| *** jamesmca_ has joined #storyboard | 15:15 | |
| *** jamesmcarthur has quit IRC | 15:17 | |
| *** alexismonville has joined #storyboard | 15:30 | |
| pedroalvarez | SotK: thanks :) have you tested it? | 15:52 |
| SotK | yes :) | 15:52 |
| SotK | seems to work well, thanks! | 15:52 |
| pedroalvarez | yay | 15:52 |
| openstackgerrit | Merged openstack-infra/storyboard: Store history of a comment when editing https://review.openstack.org/332208 | 16:25 |
| openstackgerrit | Merged openstack-infra/storyboard: Add support for email threading by story_id https://review.openstack.org/334179 | 16:33 |
| * pedroalvarez bows | 16:33 | |
| pedroalvarez | thanks for reviewing Zara :) | 16:34 |
| Zara | np :) I was sad I couldn't test it (I'm still not daring to switch my email worker on until a weekend), but I didn't see anything odd, and it worked for sotk! | 16:34 |
| Zara | (I'm worried my storyboard instance may still have emails it wants to send) | 16:35 |
| Zara | tens of thousands of emails... | 16:35 |
| pedroalvarez | hahahahahha | 16:35 |
| Zara | :D | 16:35 |
| pedroalvarez | set a different mail server, and start the worker :) | 16:36 |
| pedroalvarez | different == fake | 16:36 |
| Zara | hm, thanks, I'll try that | 16:36 |
| openstackgerrit | Merged openstack-infra/storyboard-webclient: Use tag icon when tags are used as filter criteria https://review.openstack.org/331054 | 16:48 |
| zaro | Zara: hey, i just realized that we need a valid url for task ids, something like https://storyboard-dev.openstack.org/#!/task/1 | 16:49 |
| zaro | I'm guessing that it should redirect to the page with the related story? | 16:49 |
| zaro | ohh we need it because we plan to link to tasks from gerrit. so when you have a reference in your commit message like 'task: 1' it will be a link that should goto a valid web page. | 16:50 |
| Zara | oh, for the ui? yeah, you can get directly to a task via a url, but there's not nice ui for it (eg: https://storyboard-dev.openstack.org/api/v1/tasks/1 ) | 16:50 |
| Zara | yeah, that's why I wondered about deriving a story id from the task id | 16:51 |
| Zara | so that then someone could link to the story url, since there's nice ui for that | 16:51 |
| zaro | yeah, but that needs to be done on storyboard side. | 16:51 |
| persia | zaro: You're suggesting that the storybaord JS client redirect calls to the task to the containing story? | 16:52 |
| zaro | yes | 16:52 |
| zaro | otherwise create a seperate page to view tasks | 16:53 |
| Zara | the lack of ui shouldn't block changing task status, though. but yeah, atm someone wouldn't be able to click on a url for a task in a commit message and get taken to the relevant story page. | 16:53 |
| zaro | i agree with that. but i also think that redirect is a requirement before installing its-storyboard plugin | 16:55 |
| zaro | otherwise links on gerrit commit messages won't work. | 16:55 |
| Zara | could we start by only linking to stories, and not pairing a link with a task id? (eg: story: 112, task: 144, where 'story' acts as a link and 'task' doesn't?) maybe I'm missing why we need to have it first. | 16:58 |
| zaro | hmm, maybe. i'll need to test that scenario. | 17:00 |
| Zara | cool. :) I'm about to head off for the night but I should be in later, tomorrow. | 17:02 |
| *** mrmartin has joined #storyboard | 17:07 | |
| zaro | Zara: good news, just verified that it's doable with only config change. good night! | 17:10 |
| *** zara_the_lemur has joined #storyboard | 17:39 | |
| zara_the_lemur | zaro: :D Brilliant! Thanks | 17:39 |
| *** zara_the_lemur has quit IRC | 17:39 | |
| *** jamesmca_ has quit IRC | 18:01 | |
| *** jamesmcarthur has joined #storyboard | 18:04 | |
| *** jamesmcarthur has quit IRC | 18:21 | |
| *** jamesmcarthur has joined #storyboard | 18:37 | |
| *** jamesmcarthur has quit IRC | 20:02 | |
| *** mrmartin has quit IRC | 20:21 | |
| *** jamesmcarthur has joined #storyboard | 20:31 | |
| *** jamesmcarthur has quit IRC | 20:31 | |
| *** jamesmcarthur has joined #storyboard | 20:48 | |
| *** jamesmcarthur has quit IRC | 22:05 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!