| *** jtomasek has joined #storyboard | 06:33 | |
| *** ttx_ is now known as ttx | 07:06 | |
| *** bethwhite has joined #storyboard | 08:05 | |
| openstackgerrit | Adam Coldrick proposed openstack-infra/storyboard: Allow filtering of worklists and boards by story or task https://review.openstack.org/288910 | 09:35 |
|---|---|---|
| Zara | \o/ | 09:38 |
| Zara | argh so many patches | 09:38 |
| SotK_ | that was the one that's had a merge conflict for ages :) | 09:40 |
| *** SotK_ is now known as SotK | 09:40 | |
| Zara | less than a week 'til texas, sldkfjdslkjflskf | 10:26 |
| * SotK keeps alternating between nervous and kind of exciting | 10:45 | |
| SotK | s/exciting/excited/ | 10:45 |
| Zara | yup | 10:46 |
| openstackgerrit | Zara proposed openstack-infra/storyboard-webclient: 'All Boards and Worklists' Page https://review.openstack.org/279753 | 11:01 |
| Zara | that just amends the commit so it no longer depends on 'move search icon' patch, since that one's stuck | 11:01 |
| *** krotscheck_ has joined #storyboard | 11:04 | |
| *** jasondotstar_ has joined #storyboard | 11:05 | |
| *** jasondotstar has quit IRC | 11:05 | |
| *** krotscheck has quit IRC | 11:06 | |
| *** jasondotstar_ is now known as jasondotstar | 11:06 | |
| *** krotscheck_ is now known as krotscheck | 11:06 | |
| openstackgerrit | Adam Coldrick proposed openstack-infra/storyboard-webclient: Don't allow cards to be dragged to/from automatic worklists https://review.openstack.org/306497 | 11:34 |
| openstackgerrit | Adam Coldrick proposed openstack-infra/storyboard-webclient: Make the Add Lane button show the new worklist modal https://review.openstack.org/306399 | 11:34 |
| openstackgerrit | Adam Coldrick proposed openstack-infra/storyboard-webclient: Remove pointless variable creation https://review.openstack.org/306401 | 11:34 |
| openstackgerrit | Adam Coldrick proposed openstack-infra/storyboard-webclient: Show a modal when editing worklists in a board https://review.openstack.org/306400 | 11:34 |
| Zara | \o/ | 11:35 |
| Zara | good timing, just finished my tea/fb break | 11:36 |
| openstackgerrit | Adam Coldrick proposed openstack-infra/storyboard-webclient: Don't allow cards to be dragged to/from automatic worklists https://review.openstack.org/306497 | 12:27 |
| openstackgerrit | Adam Coldrick proposed openstack-infra/storyboard-webclient: Make the Add Lane button show the new worklist modal https://review.openstack.org/306399 | 12:27 |
| openstackgerrit | Adam Coldrick proposed openstack-infra/storyboard-webclient: Remove pointless variable creation https://review.openstack.org/306401 | 12:27 |
| openstackgerrit | Adam Coldrick proposed openstack-infra/storyboard-webclient: Show a modal when editing worklists in a board https://review.openstack.org/306400 | 12:27 |
| Zara | :) | 12:28 |
| Zara | dragging is deeply unhappy with the first patch, don't yet know why | 12:52 |
| SotK | :( | 12:56 |
| Zara | it's really weird... you haven't changed the script | 12:58 |
| Zara | the lane contents template, that is | 12:58 |
| Zara | so maybe it doesn't like loading both... | 12:59 |
| Zara | I guess a way to check that would be to just load the static one | 13:00 |
| Zara | and then if that works fine alone, we've narrowed it down a bit. | 13:00 |
| Zara | okay, fairly confident it's the css line | 13:08 |
| Zara | or at least the bit where that's added | 13:08 |
| Zara | (I just tried removing each of the other divs and I get the same issue... so if it's not that, then it doesn't like the use of ng-if) | 13:09 |
| SotK | removing that line doesn't seem to help :/ | 13:11 |
| Zara | oh yeah, just tried it :/ | 13:12 |
| Zara | I guess it really doesn't like the 'if' statment, then? | 13:16 |
| SotK | I think I've misunderstood how my own code works or something | 13:17 |
| * Zara tries removing both ifs to see if they're both evaluating to the same thing, or if it's something odder | 13:18 | |
| Zara | removing both ifs results in me trying to drag the lane | 13:19 |
| Zara | so that's different behaviour, at least | 13:19 |
| Zara | although after a bit I get the same error, hm | 13:20 |
| SotK | I fixed it | 13:20 |
| SotK | dragging the lane is kind of a hint | 13:20 |
| SotK | I'd indented my code badly, and thus that patch removes a </div> that breaks everything | 13:20 |
| Zara | \o/ | 13:20 |
| Zara | I looked for missing divs! gah | 13:21 |
| SotK | I guess because it can't decide whether to drag the lane or drag the card | 13:21 |
| Zara | sad I didn't spot it | 13:21 |
| Zara | yes | 13:21 |
| Zara | divs were the first things I looked for, gah gah gah | 13:21 |
| SotK | yeah, it was confusing to spot because one of the others was unclosed I think | 13:21 |
| Zara | ;_; | 13:21 |
| Zara | glad you found it, anyway! | 13:21 |
| * Zara switches branch before her fan dies | 13:22 | |
| SotK | ah, it wasn't unclosed, just weirdly indented | 13:26 |
| Zara | oh no | 13:27 |
| Zara | I feel like it's something to do with sb not knowing which if applies (or maybe neither being applicable), but that's just a guess | 13:33 |
| SotK | nah, it was what I thought, just the confusing indentation made me add stuff in the wrong place :) | 13:33 |
| Zara | ohhhh | 13:34 |
| Zara | hahaha | 13:34 |
| Zara | a similar thing tbh but I thought it might require dramatically more divs, phew | 13:35 |
| Zara | or a reshuffling of divs. yay, anyway | 13:36 |
| persia | Am I reading that correctly as being three separate divs, each with a separate condition, each condition being evaluated separately? | 13:37 |
| * persia is looking at patch #3 | 13:38 | |
| * SotK was typing out a reply then realised he missed another bit | 13:43 | |
| Zara | uh oh | 13:43 |
| Zara | I'm testing it with the next patch as I can't see automatic lanes in the board otherwise, drag and drop seems to work so far | 13:44 |
| SotK | why can't you see automatic lanes without the second patch? | 13:45 |
| Zara | oh, I just didn't know how to add them to a board, it's not the code afaik | 13:46 |
| Zara | seems to work.. though I found another quirk... | 13:47 |
| SotK | go on... | 13:47 |
| Zara | due dates | 13:47 |
| Zara | cards in automatic worklists | 13:48 |
| Zara | user can try to add them | 13:48 |
| Zara | but cannot as cards aren't real | 13:48 |
| Zara | so error | 13:48 |
| SotK | ah | 13:48 |
| Zara | get 'missing argument item_id' (guessing because there's no 'item' really) and the date set vanishes :P | 13:49 |
| persia | Hrm. The desire to handle due dates kinda invalidates the current data model for targets and automatic lists. | 13:51 |
| persia | I suspect some design thought is required to make that work. | 13:51 |
| persia | For now, I suspect it would be more sensible to just not deal with targets for automatic lists. | 13:51 |
| SotK | that is my plan for now | 13:52 |
| Zara | sorry it makes the modal more complex :( | 13:52 |
| Zara | does it require a separate modal template or can you use an if for the existing modal? | 13:53 |
| SotK | I can use an if, its not much trouble | 13:54 |
| Zara | phew | 13:58 |
| Zara | I wasn't sure if the place the template was displayed from had been designed to know the status of the lane | 13:59 |
| Zara | and I was too lazy to look | 13:59 |
| *** jmccrory has quit IRC | 14:01 | |
| *** jmccrory has joined #storyboard | 14:02 | |
| openstackgerrit | Adam Coldrick proposed openstack-infra/storyboard-webclient: Don't allow users to interact with cards in automatic worklists https://review.openstack.org/306497 | 14:02 |
| openstackgerrit | Adam Coldrick proposed openstack-infra/storyboard-webclient: Make the Add Lane button show the new worklist modal https://review.openstack.org/306399 | 14:02 |
| openstackgerrit | Adam Coldrick proposed openstack-infra/storyboard-webclient: Remove pointless variable creation https://review.openstack.org/306401 | 14:02 |
| openstackgerrit | Adam Coldrick proposed openstack-infra/storyboard-webclient: Show a modal when editing worklists in a board https://review.openstack.org/306400 | 14:02 |
| * Zara will take a look shortly (making lunch) | 14:04 | |
| Zara | at lunchtime | 14:04 |
| SotK | this is not lunchtime | 14:05 |
| SotK | for our timezone anyway | 14:05 |
| Zara | I think you will find it is the time at which I am making my lunch | 14:05 |
| Zara | ergo, it is lunchtime | 14:05 |
| Zara | by definition | 14:05 |
| * SotK has no comeback | 14:06 | |
| Zara | I WIN | 14:06 |
| Zara | wait what it takes 20 mins to microwave rice | 14:09 |
| Zara | hmph | 14:09 |
| Zara | looks like lunchtime is closer to 4pm ;_; | 14:09 |
| * Zara checks out patch | 14:09 | |
| Zara | I always feel warm near the microwave. I hope it's not cooking me. | 14:13 |
| persia | If you heat something wet in a microwave, steam escapes from the food, which is often vented out. If you are not heating something wet, it may get very hot, and the radiant heat causes hot air that escapes when you open the door (and may be vented). If you feel warm around a microwave under other conditions, you should get a different oven. | 14:16 |
| Zara | given it's rice, I hope it's wet, or I've got a problem | 14:27 |
| Zara | a fire problem | 14:27 |
| Zara | we should have educational storyboard science interludes more often | 14:27 |
| * persia tries to get undistracted by a comparison of 27MHz vs. 2.4GHz for home heating applications and considers the differences between an incident tracker and a requirements tracker | 14:28 | |
| persia | At a high level, a requirements tracker describes what the system should do (and possibly lists tasks to accomplish that goal), and an incident tracker describes some thing that happened (and perhaps tasks that need to be undertaken to report on it, or ensure it doesn't repeat). | 14:30 |
| persia | Both are "bug trackers" in some sense, but I wonder if it makes sense to handle incidents better in Storyboard (based on backscroll from the infra bug sprint) | 14:30 |
| persia | Or maybe the solution is to specify that a system is required not to behave in the reported way, and then take it from that viewpoint (except this misses all the useful reporting bits) | 14:31 |
| Zara | https://etherpad.openstack.org/p/newton-infra-community-task-tracking etherpad for task-tracking session is here if it's useful to note things there at all | 14:39 |
| Zara | I'm not even sure how fully sb is meant to be tracking bugs of any kind, even before we get to the differences between them | 14:40 |
| Zara | in practice it's used that way... and sometimes people use it to report inscidents too... but nobody looks on it for incidents | 14:41 |
| persia | To my way of thinking, a "bug" is only an incomplete requirement specifiction. For example, if software crashes when someone enters a "&" in a text field, it ought not crash, for which it is not hard to assert it is required to not crash under that condition. | 14:43 |
| persia | For hosted production systems, life is a bit more complicated. Where the infrastructure is entirely software-defined, one can consider failures to be inputs to the requirement specification for the defining software. | 14:44 |
| Zara | you can have a bug where there's a spec but the software just doesn't meet it (and maybe did in the past) | 14:44 |
| persia | Where it isn't entirely software defined (or that software definition isn't entirely under the control of the folk using the Storyboard instance), there are incidents where the appropriate response is to ask someone else to do something, be aware while it hasn't been done, and then report it done to interested parties. | 14:45 |
| persia | To my way of thinking about software, that sort of bug is either a result of incomplete specification or of failing to validate the code against the requirements as the code changes. | 14:46 |
| persia | It often happens that something used to work and now stopped working, but we ought have tests for everything that is supposed to work, so that we know when it stops working. The challenge is finding the right balance of requirements testing so that one doesn't end up having tests for every implementation detail in such a way that it becomes difficult to support new requirements as they arrive. | 14:48 |
| Zara | + it can be tricky to automate tests for layout things (eg: 'this additional div means foo button has now been shifted so it's harder to spot, as the user must scroll to see it') | 14:53 |
| Zara | my lunch is finally nearly ready | 14:54 |
| persia | Traditional interface development frameworks typically use the accessibility layer to instrument and articulate the interface for testing, so that questions like that can be resolved. I'm not sure we have such a thing for browsers. | 15:00 |
| persia | Hrm. ngAria might help (https://docs.angularjs.org/guide/accessibility), but given the recent drafts of the ARIA spec (last month), I imagine that we're some way away from having the same depth of analysis we have for non-browsers. | 15:04 |
| persia | Hmm. Sadly, it seems the current version is entirely focused on screen readers, and contains facilities to beat the user over the head if desired (audio overrides, etc.). | 15:06 |
| persia | As a result, I no longer believe it will reach the point of being a useful framework to interact with web applications. | 15:06 |
| Zara | :( | 15:13 |
| Zara | I can no longer find bugs in https://review.openstack.org/#/c/306497/ and https://review.openstack.org/#/c/306399/ , if anyone wants to take a look and prove me unhelpful :) | 15:23 |
| * Zara takes a look at https://review.openstack.org/#/c/306400/7 | 15:23 | |
| Zara | hm, if I change a manual worklist to automatic, and click save changes, it works, and all items in worklist disappear (after a pause). if I then refresh, edit the (now automatic) worklist, check the box so that it will be manual again, and then click 'save changes', it hangs | 15:37 |
| Zara | forever | 15:37 |
| Zara | now to test if it's for all 'save changes' on an auto worklist | 15:38 |
| SotK | weird, I tested making a worklist automatic and then making it manual again | 15:39 |
| Zara | seems like it's all changes to an automatic worklist when edited from the board view | 15:39 |
| Zara | whoa my api is not happy | 15:39 |
| SotK | working fine at my end | 15:39 |
| Zara | http://paste.openstack.org/show/494443/ | 15:40 |
| Zara | (clock on my vm seems to be utc) | 15:41 |
| Zara | that's as far back as it goes, I just pasted everything | 15:41 |
| Zara | DBError: (IntegrityError) (1048, u"Column 'list_id' cannot be null") 'UPDATE worklist_items SET updated_at=%s, list_id=%s WHERE worklist_items.id = %s' (datetime.datetime(2016, 4, 18, 15, 35, 44, 257946), None, 400) | 15:43 |
| Zara | seems to be the actual error | 15:43 |
| Zara | ah, and it's just clicking hte 'save changes' button that triggers it, no need to actually make a change | 15:43 |
| SotK | huh | 15:44 |
| SotK | is your api up to date? | 15:44 |
| Zara | I think so | 15:44 |
| Zara | git pull says it is | 15:44 |
| Zara | (and normally it says when it isn't) | 15:45 |
| SotK | what is the latest commit? | 15:46 |
| Zara | eaf32542b5974cee2db22d6390db02f5c8c4f039 | 15:46 |
| Zara | so I've got 'resolve worklist filters in boards' | 15:46 |
| Zara | the only thing I can think of is if I needed to do a migration sometime and didn't? though I don't think I've missed one | 15:47 |
| Zara | how would I check what version's actually running? | 15:47 |
| SotK | do `SELECT * FROM alembic_version;` on your database | 15:48 |
| Zara | okay | 15:48 |
| Zara | 56 | 15:49 |
| SotK | seems correct | 15:49 |
| Zara | aye | 15:49 |
| * SotK messes with his | 15:49 | |
| Zara | I'll try with a worklist outside of a board and see if it happens there | 15:51 |
| Zara | it was a manual worklist containing items, if that makes a difference | 15:54 |
| Zara | and I gave it no criteria | 15:55 |
| Zara | oooh, also get errr for a worklist outside of a board | 15:55 |
| SotK | aha! | 15:55 |
| Zara | 500: PUT /api/v1/worklists/13: (IntegrityError) (1048, u"Column 'list_id' cannot be null") 'UPDATE worklist_items SET updated_at=%s, list_id=%s WHERE worklist_items.id = %s' (datetime.datetime(2016, 4, 18, 15, 55, 27, 821095), None, 484) | 15:55 |
| SotK | its the no criteria which is causing it, for some reason | 15:55 |
| Zara | perhaps dislikes lack of criteria | 15:56 |
| Zara | snap | 15:56 |
| Zara | I should look at my screen faster. | 15:56 |
| * Zara finds all the bugs, Zara finds all the bugs, Zara finds all the bugs, all day long~ | 15:57 | |
| SotK | heh, what a weird bug | 16:05 |
| SotK | does editing a manual worklist that is empty also do it? | 16:05 |
| SotK | apparently not | 16:05 |
| SotK | I guess because there are no items to try to update | 16:06 |
| Zara | I'm just going to choose to interpret IntegrityError as storyboard saying 'I'm not going to update this worklist because I think it has bad moral character' | 16:07 |
| *** bethwhite has quit IRC | 16:29 | |
| openstackgerrit | Adam Coldrick proposed openstack-infra/storyboard: Fix updating automatic worklists with no filters https://review.openstack.org/307362 | 16:33 |
| SotK | that will fix it | 16:34 |
| * Zara tries it | 16:49 | |
| openstackgerrit | Merged openstack-infra/storyboard-webclient: Remove 'Subscriptions' button from header dropdown https://review.openstack.org/294579 | 17:05 |
| Zara | it'd be nice if the colour of the worklist changed only when the contents updated, but that's a smallish niggle | 17:07 |
| Zara | changing to/from automatic seems to be working fine now | 17:08 |
| Zara | gonna check that patch with master in case any strange things happen there | 17:08 |
| SotK | \o/ | 17:12 |
| Zara | seems fine to me so far :) | 17:19 |
| * Zara +As | 17:21 | |
| Zara | https://review.openstack.org/#/c/306497 and https://review.openstack.org/#/c/306399/ await reviews | 17:22 |
| Zara | (well, so do other things, but those have got past zara the testing dragon) | 17:22 |
| SotK | \o/ | 17:23 |
| SotK | thanks Zara | 17:23 |
| * Zara notices exclamation mark in https://review.openstack.org/#/c/306400/ | 17:31 | |
| Zara | awww | 17:31 |
| Zara | emails are nice. I no longer have to be a living notifications daemon. may take a while to adjust | 17:33 |
| Zara | btw, now worklist-in-board titles link to worklists, I expect more questions about importing existing worklists into boards | 17:35 |
| Zara | just a heads-up | 17:35 |
| Zara | + it's a little odd that titles don't link for logged-out users | 17:37 |
| Zara | argh save buttons caught me out again | 17:38 |
| * Zara renames 'task tracking infra session' to 'save button improvement session' | 17:39 | |
| Zara | argh *again* | 17:40 |
| Zara | that was literally 2 minutes lates | 17:40 |
| Zara | *later | 17:40 |
| Zara | everything seems to work as expected, though | 17:41 |
| Zara | :0 "WEATHER: Austin is expecting possible thunderstorms next week. The Summit campus includes multiple buildings and most of the evening events will be held at outdoor venues. We suggest you pack an umbrella, rain jacket and shoes that can get wet for walking between buildings, restaurants and bars! Check the weather before you travel." | 17:43 |
| SotK | oh joy! | 17:53 |
| Zara | ~well, there's floodin' down in texas, all of the telephone lines are down~ | 17:56 |
| Zara | I've +1'd that but not +2'd because of the logged-out-title-links-thing, but I can change it to +2 if there's no time, since it's better with than without, just figured I'd get the request in there before I forgot it | 18:01 |
| Zara | so there's just the pointless variable creation one left over, should get to that tomorrow | 18:02 |
| Zara | seems fine but always like to check for unexpected side-effects. am heading off now | 18:02 |
| Zara | if anyone else has thoughts on: https://review.openstack.org/#/c/304539/ , would be good | 18:03 |
| Zara | 'night! | 18:04 |
| *** b3rnard0 is now known as b3rnard0_away | 18:21 | |
| openstackgerrit | Pedro Alvarez Piedehierro proposed openstack-infra/storyboard-webclient: Fix dashboard template to show the right information https://review.openstack.org/307448 | 20:07 |
| *** b3rnard0_away is now known as b3rnard0 | 21:53 | |
| *** b3rnard0 is now known as b3rnard0_away | 22:10 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!