| *** NikitaKonovalov2 has joined #storyboard | 04:30 | |
| *** NikitaKonovalov has quit IRC | 04:30 | |
| *** NikitaKonovalov2 is now known as NikitaKonovalov | 04:31 | |
| *** davidlenwell has joined #storyboard | 06:03 | |
| *** perryl_ has joined #storyboard | 06:07 | |
| *** perryl has quit IRC | 06:08 | |
| *** davidlenwell_ has quit IRC | 06:08 | |
| *** krotscheck_dcm has quit IRC | 06:08 | |
| *** persia_ has quit IRC | 06:08 | |
| *** krotscheck has joined #storyboard | 06:09 | |
| *** perryl_ is now known as perryl | 06:41 | |
| *** mrmartin has joined #storyboard | 06:48 | |
| *** fay_ has joined #storyboard | 07:47 | |
| *** bethwhite has joined #storyboard | 08:23 | |
| *** openstackstatus has joined #storyboard | 08:27 | |
| *** ChanServ sets mode: +v openstackstatus | 08:27 | |
| *** mrmartin has quit IRC | 09:21 | |
| *** mrmartin has joined #storyboard | 09:30 | |
| *** bethwhite has quit IRC | 09:33 | |
| *** perryl has quit IRC | 09:33 | |
| *** perryl has joined #storyboard | 09:33 | |
| *** bethwhite has joined #storyboard | 09:33 | |
| *** mrmartin has quit IRC | 09:49 | |
| *** jtomasek_ has joined #storyboard | 10:01 | |
| Zara | morningish, storyboard! | 10:09 |
|---|---|---|
| SotK | morning! | 10:09 |
| *** jtomasek_ has quit IRC | 10:11 | |
| * Zara finally finishes backscroll | 10:16 | |
| Zara | ack, completely forgot about https://review.openstack.org/#/c/303482/ | 10:58 |
| Zara | so deploying new instances doesn't work atm; please review | 10:58 |
| Zara | I'm getting back to my review queue before everyone wakes up for more bugsquash things | 10:59 |
| Zara | I'm guessing we'll end up discussing that with infra, probably on Friday | 10:59 |
| Zara | the etherpad looks long :) | 10:59 |
| Zara | 8 patches from krotscheck, 2 from pedro, 4 from adam (though one needs a rework, https://review.openstack.org/#/c/288910/ ) | 11:04 |
| * Zara rolls up sleeves | 11:04 | |
| Zara | (I also have abunch in review, just saying) https://review.openstack.org/#/q/owner:zara.zaimeche%2540codethink.co.uk+status:open | 11:05 |
| Zara | many of those are tiny pythonclient things, in fairness | 11:06 |
| Zara | and some old ones should probably just be abandoned | 11:06 |
| Zara | (I haven't updated the list much because nobody's had time to look at it, might be a circular thing) | 11:07 |
| Zara | sure, gerrit, why not just default to the old patchset | 11:14 |
| * Zara tries testing the patch again... | 11:15 | |
| pedroalvarez | one of my patches is "easy to test" and the other one still needs discussion | 11:17 |
| Zara | okay | 11:17 |
| Zara | hmm... I'm not sure this eslint patch works... | 11:18 |
| Zara | at any rate, I'm defining variables as other undefined variables in module.js, and it's not giving me any errors | 11:18 |
| Zara | krotscheck ^ | 11:19 |
| Zara | (not posting on the patch because I'm not sure if it's that specific patch yet) | 11:19 |
| Zara | but that's for https://review.openstack.org/#/c/304539/2 | 11:20 |
| Zara | it's finding the tests now, but doesn't seem to be running them (or they're all passing) | 11:20 |
| Zara | logs are just http://paste.openstack.org/show/494040/ | 11:22 |
| Zara | okay, it's definitely that patch; I tried master and the tests work | 11:36 |
| *** mrmartin has joined #storyboard | 11:36 | |
| *** jtomasek_ has joined #storyboard | 11:49 | |
| *** mrmartin has quit IRC | 12:14 | |
| *** pleia2 has quit IRC | 13:17 | |
| *** pleia2 has joined #storyboard | 13:18 | |
| *** tlbr has quit IRC | 13:26 | |
| *** tlbr has joined #storyboard | 13:26 | |
| *** b3rnard0_away is now known as b3rnard0 | 13:37 | |
| *** bethwhite has quit IRC | 13:49 | |
| *** bethwhite has joined #storyboard | 13:49 | |
| Zara | https://review.openstack.org/#/c/304622/ awaits reviews | 14:02 |
| Zara | as does https://review.openstack.org/#/c/304694/ | 14:02 |
| Zara | https://review.openstack.org/#/c/288910/ needs a rebase or something | 14:03 |
| Zara | oh, and ace, filter ui fix, will take a look | 14:03 |
| Zara | \o/ thanks, pedro | 14:04 |
| * Zara types `git stauts` for the fifth time today | 14:05 | |
| pedroalvarez | they were actually easy patches | 14:05 |
| Zara | :) | 14:06 |
| Zara | yup, I thought I'd reviewed the resolving filters one a couple of days ago, but apparently not | 14:07 |
| SotK | does that filter ui fix actually work? | 14:07 |
| Zara | testing it now | 14:08 |
| Zara | hm, I think I'd like it if you could amend the commit message so it makes it clear it refers to automatic worklists. | 14:09 |
| Zara | atm it just says 'worklists' | 14:09 |
| Zara | ohh, the filter ui fix is a different fix to the one I thought it was, I skimmed | 14:12 |
| Zara | I hadn't noticed that bug | 14:12 |
| SotK | what did you think it was? | 14:12 |
| Zara | make a filter editable after saving it, instead of having to delete it (I just saw 'delete' and 'worklist filter', have since read commit message and title.) | 14:13 |
| Zara | okay, so it seems to work | 14:13 |
| Zara | but the first 'save' button is greyed out | 14:13 |
| Zara | which makes sense, really, since you're not saving a new filter | 14:14 |
| Zara | but it is a bit ambigous from the layout whether that refers to a specific filter or to 'save' the list of filters | 14:14 |
| Zara | (I don't like the two save buttons anyway, they often catch me out... maybe an 'add filter' button would be better than the first 'save') | 14:15 |
| Zara | I don't know | 14:15 |
| * SotK also doesn't know | 14:15 | |
| Zara | maybe it should just save it by default,if it's easy enough to delete again | 14:15 |
| Zara | though then, when, eh | 14:16 |
| SotK | when indeed :P | 14:16 |
| Zara | yeah, that's my problem, I don't like that bit of the layout but I don't yet know how to fix it | 14:16 |
| Zara | so I just end up whinging, which isn't very useful | 14:17 |
| Zara | I guess an option would be to have filters as a submenu, or a different edit menu | 14:17 |
| Zara | *editing filters | 14:17 |
| Zara | that could be clearer but more annoying | 14:18 |
| SotK | definitely more annoying | 14:18 |
| SotK | and probably more confusing when creating a new worklist rather than editing an existing one | 14:18 |
| openstackgerrit | Merged openstack-infra/storyboard-webclient: Fix archiving worklists https://review.openstack.org/304694 | 14:18 |
| Zara | I think whether it's more confusing would depend on how you did it (modal for criteria changes? idk) but yeah, more clicks, pain if you want to do it fast | 14:19 |
| Zara | (it can also catch me out because the worklist is displayed while editing, so I scroll down and forget I'm in the edit window | 14:21 |
| Zara | and then navigate away, but things aren't saved | 14:21 |
| Zara | I don't think the worklist is updated as the settings are edited, so maybe it shouldn't be displayed | 14:22 |
| * Zara keeps an eye on https://wiki.openstack.org/wiki/Design_Summit/Newton/Etherpads | 15:05 | |
| Zara | oh, hm, might have found a bug | 15:11 |
| Zara | yeah, I have | 15:11 |
| Zara | cancel = save | 15:11 |
| Zara | er, big cancel, that is | 15:11 |
| Zara | for automatic worklists | 15:11 |
| SotK | you mean for the filters? | 15:12 |
| Zara | the overall 'cancel edits' button when editing | 15:12 |
| Zara | so yeah... maybe only the filters are saved | 15:12 |
| Zara | but that means it's extra confusing | 15:12 |
| Zara | since they're edited in the same window | 15:13 |
| SotK | yeah, that is indeed a confusion point | 15:13 |
| * SotK was thinking how to make it not confusing earlier today | 15:13 | |
| Zara | okay, phew I guess, at least it's working as we think it is. | 15:13 |
| Zara | yeah, in windows you normally have 'apply' and 'save' | 15:13 |
| Zara | that's the only equivalent that springs to mind | 15:13 |
| SotK | (at the moment, the filter is created when you click "save" on the filter, and deleted-beyond-recovery when you remove it) | 15:14 |
| Zara | atm the first save seems like 'apply', but is also a save | 15:14 |
| Zara | ahh, I see | 15:14 |
| *** b3rnard0 is now known as b3rnard0_away | 15:14 | |
| Zara | yeah, so it gets perceived as the difference between 'make this list of filters' and 'apply them to this worklist now' | 15:16 |
| Zara | but actually, they both happen in the same step | 15:16 |
| SotK | indeed | 15:16 |
| Zara | and then there's another 'save' + 'cancel' button that actually applies to different edits, but seems like i tapplies to that one. | 15:16 |
| Zara | gah, that just makes me want to separate them visually | 15:17 |
| Zara | and just do a separate 'edit filters' button | 15:18 |
| Zara | ohh, I was about to ask about https://review.openstack.org/#/c/304700/1 then noticed it said 'when creating a *new* worklist' | 15:20 |
| Zara | it works | 15:22 |
| SotK | \o/ | 15:27 |
| *** b3rnard0_away is now known as b3rnard0 | 16:34 | |
| *** b3rnard0 is now known as b3rnard0_away | 16:59 | |
| *** b3rnard0_away is now known as b3rnard0 | 16:59 | |
| openstackgerrit | Merged openstack-infra/storyboard: Resolve worklist filters in boards https://review.openstack.org/304622 | 17:10 |
| openstackgerrit | Merged openstack-infra/storyboard-webclient: Make it possible to remove filters when creating a new worklist https://review.openstack.org/304700 | 17:10 |
| Zara | aw, nice email from pleia2, thank you! (I'm about to head off home for the night) | 17:12 |
| Zara | (so if no response later, that's why) | 17:12 |
| pleia2 | it was a good day, thank you! | 17:12 |
| *** b3rnard0 is now known as b3rnard0_away | 17:22 | |
| *** bethwhite has quit IRC | 17:26 | |
| *** jtomasek_ has quit IRC | 17:40 | |
| *** NikitaKonovalov_ has joined #storyboard | 18:00 | |
| *** davidlenwell has quit IRC | 18:23 | |
| *** davidlenwell has joined #storyboard | 18:31 | |
| *** b3rnard0_away is now known as b3rnard0 | 18:32 | |
| *** NikitaKonovalov_ has quit IRC | 18:45 | |
| *** NikitaKonovalov_ has joined #storyboard | 18:47 | |
| *** NikitaKonovalov_ has quit IRC | 18:53 | |
| * SotK wishes for an endpoint that returns all the timeline events | 22:21 | |
| SotK | alternatively/additionally, I wish that stories "updated_at" was actually useful | 22:23 |
| *** b3rnard0 is now known as b3rnard0_away | 23:28 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!