| *** openstackgerrit has quit IRC | 06:17 | |
| *** openstackgerrit_ is now known as openstackgerrit | 06:17 | |
| *** openstackgerrit_ has joined #storyboard | 06:18 | |
| *** openstackgerrit_ is now known as openstackgerrit | 06:19 | |
| *** openstackgerrit_ has joined #storyboard | 06:19 | |
| *** jtomasek has joined #storyboard | 07:52 | |
| *** fay_ has joined #storyboard | 08:31 | |
| *** mrmartin has joined #storyboard | 09:13 | |
| Zara | morning, storyboard! | 10:46 |
|---|---|---|
| Zara | it's quiet today! | 12:00 |
| Zara | echo echo echo | 12:01 |
| * fay_ waves | 12:02 | |
| Zara | Hi fay_! :D | 12:03 |
| Zara | it's nearly a party now! | 12:03 |
| openstackgerrit | Merged openstack-infra/storyboard-webclient: Make task notes visible for logged-out users https://review.openstack.org/292957 | 12:07 |
| Zara | \o/ even openstackgerrit arrived | 12:14 |
| * SotK joins the party | 12:19 | |
| Zara | :D ain't no party like an S(toryboard)-Club party! | 12:20 |
| Zara | ... I think that made everyone leave the party... ;_; | 12:21 |
| SotK | :D | 12:23 |
| Zara | come back! we have music involving an oud! https://www.youtube.com/watch?v=uAt-HLnqBUk | 12:26 |
| * fay_ should probably not admit that she preferred sclub7 | 12:28 | |
| Zara | xD | 12:28 |
| Zara | I have a bad memory of auditioning for a school play aged 12. we had to sing. turns out it's pretty easy to sing 'reach up for the stars' completely off-key with all the wrong lyrics. =D | 12:29 |
| Zara | (we had to audition solo in front of a panel of 3 teachers. the music teacher said "it's okay, just take your time to find the starting note" which freaked me out because I'd just planned to start it wherever, and had no idea what note it actually started on. xD) | 12:32 |
| Zara | gah, I don't know how to filter these tasks after the browse.it's probably really obvious. | 13:18 |
| Zara | (I'm looking at https://review.openstack.org/#/c/292509/ again ) | 13:18 |
| Zara | oh nvm I think I did it | 13:20 |
| Zara | I should evidently just think out loud in here even *more* often. | 13:20 |
| openstackgerrit | Zara proposed openstack-infra/storyboard-webclient: Improve 'Tasks Assigned to Me' https://review.openstack.org/292509 | 13:42 |
| Zara | I should improve the appearance of the labels on that, but it shouldn't do a million GETs now | 13:42 |
| Zara | it also takes a while to load, which is weird | 13:43 |
| persia | Does it take longer to load, with less gets? | 13:46 |
| Zara | it *seems* to, but I might only be noticing the length of the load because I'm actually paying attention to that page (I haven't measured it, so it's just the perceived length) | 14:06 |
| Zara | gonna try switching branches and see if the behaviour actually is different | 14:06 |
| Zara | ah, it's the same | 14:07 |
| persia | Ah, cool. Sometimes I worry about optimising for network traffic vs. local processing: it may actually make things slower or less responsive in certain situations. | 14:14 |
| persia | That said, when one is uncertain, it's good to test with different network latencies to validate everything. | 14:14 |
| persia | In this case, it sounds like the browser time is the same, but the network is less noisy, which probably indicates a correct optimisation. | 14:15 |
| Zara | :) I think I've worked out what's making it slow for me, anyway | 14:20 |
| Zara | it's loading the list of recentEvents, and that's about 500 things on my instance | 14:20 |
| persia | Ooh, even better :) | 14:20 |
| Zara | I suppose I can test by deleting them and seeing if it speeds up, though then I lose a big list of recentEvents to test with | 14:21 |
| persia | Take a DB dump, truncate teh recentEvents, then edit the dump, and replay the recentEvents to get them back. | 14:22 |
| persia | (yes, this is hacky, and only works in development environments, but ...) | 14:22 |
| Zara | hah, I just deleted them (I figured I'd soon have a lot again) | 14:23 |
| Zara | it was definitely that, anyway | 14:23 |
| Zara | btw, the first time I clicked the button to delete them all, it didn't actually delete them all | 14:24 |
| Zara | it left 366 from about 530 | 14:24 |
| Zara | the second time it worked. The first time, I didn't expand the menu first. The second time, I expanded the menu first. It might be relevant | 14:24 |
| *** mrmartin has quit IRC | 14:30 | |
| persia | It likely was relevant. Might be worth a story talking about how someone might expect "delete all" or "select all" or similar to also cover things not in the current view. | 14:32 |
| Zara | yeah, I'm going to make one, but it'll be pretty vague at this point (it did delete things that were out of view, since everything was hidden-- it just didn't delete everything :S) | 14:34 |
| *** mrmartin has joined #storyboard | 14:41 | |
| Zara | hm, if we put a codeblock button in, I wonder if people would use it | 14:43 |
| Zara | atm people paste terminal output into the description field, but it doesn't count line breaks unless there are two in a row | 14:44 |
| Zara | so the story description ends up being jumbled in those cases | 14:45 |
| *** mrmartin has quit IRC | 15:36 | |
| Zara | hm... where does story-status-label live... | 15:53 |
| Zara | (looking into making a task-status-label) | 15:53 |
| Zara | ah, guessing it's storyTaskStatus | 15:54 |
| Zara | or even better, story_status_label... | 15:55 |
| Zara | hm, we could just use story_status_label for tasks as well... renaming it feels like going overboard | 15:56 |
| openstackgerrit | Zara proposed openstack-infra/storyboard-webclient: Improve 'Tasks Assigned to Me' https://review.openstack.org/292509 | 16:11 |
| Zara | that has labels that are different colours. hacky implementation | 16:11 |
| openstackgerrit | Zara proposed openstack-infra/storyboard-webclient: Improve 'Tasks Assigned to Me' https://review.openstack.org/292509 | 16:14 |
| Zara | now includes some comments about the weirdness | 16:14 |
| openstackgerrit | Zara proposed openstack-infra/storyboard-webclient: Improve 'Tasks Assigned to Me' https://review.openstack.org/292509 | 16:23 |
| Zara | ^ makes colours consistent with other task status things in storyboard | 16:23 |
| Zara | oh, turns out I can still use the normal task status dropdown... | 16:29 |
| Zara | I wonder if it'd be useful to be able to change task status from the dashboard | 16:33 |
| openstackgerrit | Zara proposed openstack-infra/storyboard-webclient: Improve 'Tasks Assigned to Me' https://review.openstack.org/292509 | 16:35 |
| * persia is really a huge fan of automatic status adjustment, and prefers that to any sort of improvements to manual workflows | 16:44 | |
| openstackgerrit | Zara proposed openstack-infra/storyboard-webclient: Improve 'Tasks Assigned to Me' https://review.openstack.org/292509 | 16:52 |
| Zara | until someone is assigned to the gerrit plugin, ^ might be bit better | 16:52 |
| Zara | than the default | 16:52 |
| persia | heh | 16:57 |
| persia | While I'm dreaming up wishlist integration features: wouldn't it be cool if there was an IRC bot that reported new tasks to channels with some sort of configuration that allowed many-to-many relations between channels and projects? | 16:58 |
| *** mrmartin has joined #storyboard | 16:58 | |
| Zara | yup, I think that'd generally be more useful than email notifications tbh | 17:01 |
| * Zara knows nothing about irc bots yet | 17:01 | |
| *** b3rnard0 is now known as b3rnard0_away | 17:06 | |
| * Zara wonders how much overlap there'd be between the issues in this thread and a storyboard hooked up to gerrit: http://lists.openstack.org/pipermail/openstack-dev/2016-March/089791.html | 17:08 | |
| persia | It gets complicated, because SB was slow, and reno exists, but there's some overlap. | 17:10 |
| persia | The trick is finding a workflow that makes sense. I think having a milestone-foo worklist would make sense, but I don't know if that would work for everyone. | 17:10 |
| Zara | you could also tag a story with milestone-foo, provided all tasks in the story aim at that milestone. but for it to be useful, the task statuses and links to reviews would need to be automated | 17:12 |
| *** mrmartin has quit IRC | 17:16 | |
| Zara | I wondered why launchpad wasn't able to help with their issue, since I thought you could subscribe to tags there, and I assume they're using it. | 17:17 |
| persia | I suppose, but for me, the idea of using stories-as-milestones feels somehow less clean than a worklist. | 17:17 |
| persia | I don't know either. I know LP used to be enough for some folk to do release management, but then it seemed to stop being good enough. I don't know enough of the history. | 17:18 |
| *** yarkot1 has quit IRC | 17:18 | |
| *** yarkot has joined #storyboard | 17:23 | |
| openstackgerrit | Adam Coldrick proposed openstack-infra/storyboard: Add API functionality for automatic worklist filters https://review.openstack.org/295422 | 17:31 |
| SotK | sorry its huge, I can try to split it up if people want | 17:32 |
| Zara | =D | 17:32 |
| Zara | how would you split it up, ooi? | 17:32 |
| Zara | (I'm gonna test behaviour more than inspect the code, so the size isn't too bad for me, but it might be better for the history to split it in case we find bugs later | 17:33 |
| Zara | bit easier to narrow down etc.... but at a glance I don't see an obvious way to split it... I guess db migration separate to other stuff? | 17:34 |
| SotK | the only way I can think is by splitting the migration and the rest of the implementation | 17:34 |
| Zara | WE ARE BEST TEAM | 17:34 |
| Zara | thank you so much for these | 17:36 |
| SotK | yw | 17:37 |
| Zara | if you are planning to separate them out, I'll wait for the rework to test, so that my migration is representative, but I can start looking at the code now | 17:38 |
| Zara | and give you a '-2 this commit message doesn't rhyme; please make it rhyme' | 17:38 |
| * SotK isn't planning to | 17:40 | |
| Zara | oh, that gerrit, moving things around at random. | 17:40 |
| * Zara started looking at WorklistFilter | 17:40 | |
| * Zara notes jenkins has given some failures, including: 'AssertionError: True is not false : Found two revisions with id 055' | 17:49 | |
| Zara | I always like the start of that one | 17:49 |
| Zara | ahhh, I think it should be 56... | 17:50 |
| Zara | at least, comments as replies are my 55 | 17:50 |
| SotK | yeah, oops | 17:51 |
| Zara | heehee | 17:52 |
| openstackgerrit | Adam Coldrick proposed openstack-infra/storyboard: Add API functionality for automatic worklist filters https://review.openstack.org/295422 | 17:52 |
| Zara | seems to be the same error with both tests, so hopefully that's it | 17:53 |
| Zara | :) | 17:53 |
| Zara | hah, what. so I noticed that for my dashboard patch, updating a task status there doesn't update the recent events. but it *does* change the task status, and update the timeline events for the relevant story. | 18:00 |
| Zara | ???? | 18:00 |
| Zara | and similarly, I don't get emails... so I'd guess the worker doesn't like it for some reason???????? | 18:01 |
| SotK | did you restart the worker? :D | 18:03 |
| Zara | yup, made no difference! :D | 18:03 |
| Zara | recent events still work if I update the task status from the story | 18:03 |
| Zara | just not from the dashboard | 18:03 |
| Zara | but the task status is updated | 18:03 |
| SotK | very weird | 18:03 |
| Zara | and displays in the story, and on the story's timeline events | 18:04 |
| Zara | yup | 18:04 |
| Zara | suggests they're not as tightly coupled as I thought | 18:04 |
| Zara | maybe that's good and it means a 'show all' or 'show just comments' etc button will be easier to implement without affecting recent events | 18:04 |
| Zara | (sorry, I suddenly noticed it and got distracted from automatic worklists-- though I won't have much time to test today anyway) | 18:05 |
| *** b3rnard0_away is now known as b3rnard0 | 18:12 | |
| Zara | okay, so I think maybe it's to do with it not ending up part of subscription_events, for some reason | 18:13 |
| Zara | the story page makes requests like http://172.16.20.111:9000/api/v1/stories/9/events | 18:13 |
| Zara | but the dash makes requests like | 18:14 |
| Zara | http://172.16.20.111:9000/api/v1/subscription_events | 18:14 |
| Zara | (well, put a GET at the start :P) | 18:14 |
| Zara | so for some reason it looks like stories/story_id/events contain different stuff to the subscription_events (I thought they were a subset) | 18:15 |
| Zara | anyway, I realllyyyy need to sleep | 18:16 |
| SotK | nope, timeline events (the former) and subscription events (the latter) are two totally different things | 18:17 |
| Zara | \o/ | 18:17 |
| Zara | I thought subscription events was a collection of timeline events for anything you were subscribed to | 18:18 |
| Zara | argh | 18:18 |
| Zara | since you set the preferences in the same place | 18:18 |
| SotK | those preferences don't affect subscription events afaik | 18:19 |
| Zara | but I thought they affected what you got notified for? | 18:20 |
| Zara | and that you got notified for subscription events? | 18:20 |
| Zara | IS MY WHOLE LIFE A LIE | 18:20 |
| SotK | you do get notified for subscription events, but I don't think those preferences affect the notifications at all | 18:20 |
| Zara | are we thinking of the same preferences? I thought the ones on the timeline were the same as the ones in 'preferences', and that those affected what you got notified for? | 18:21 |
| SotK | we are | 18:23 |
| Zara | gah, I see, yeah, I get notifications for everything | 18:23 |
| Zara | probably didn't notice because I have everything checked | 18:23 |
| SotK | the ones on the timeline are the same as the ones in preferences, and afaik they don't affect notifications | 18:23 |
| Zara | ;_; | 18:23 |
| Zara | oh well, I thought the problem was that they were bound together | 18:24 |
| Zara | maybe it's better that there's just nothing there | 18:24 |
| Zara | ;_; | 18:24 |
| Zara | ;_; | 18:24 |
| Zara | ;_; | 18:24 |
| Zara | I'm heading off to weep over my dinner. | 18:28 |
| Zara | 'night! | 18:28 |
| SotK | sorry :) | 18:28 |
| SotK | night! | 18:28 |
| Zara | haha, not your fault! :D I think it is better than the situation I thought was the case | 18:29 |
| Zara | just annoyed I had it confused | 18:29 |
| Zara | for literally months | 18:29 |
| Zara | that's why I made a fuss of getting all the templates... | 18:29 |
| Zara | fkljsdafkjdas | 18:29 |
| Zara | hm, I should also actually *buy* food | 18:29 |
| Zara | that might help | 18:29 |
| Zara | right, actual 'night! :) | 18:30 |
| SotK | :) | 18:31 |
| SotK | night! | 18:31 |
| openstackgerrit | Adam Coldrick proposed openstack-infra/storyboard-webclient: Improve the worklist UI https://review.openstack.org/295450 | 18:45 |
| openstackgerrit | Adam Coldrick proposed openstack-infra/storyboard-webclient: Allow an update of the SearchCriteriaController to be triggered https://review.openstack.org/295451 | 18:45 |
| openstackgerrit | Adam Coldrick proposed openstack-infra/storyboard-webclient: Improve the tag-complete directive https://review.openstack.org/295452 | 18:45 |
| openstackgerrit | Adam Coldrick proposed openstack-infra/storyboard-webclient: Add a resource abstraction for worklist filters https://review.openstack.org/295453 | 18:45 |
| openstackgerrit | Adam Coldrick proposed openstack-infra/storyboard-webclient: Allow filters to be set on automatic worklists https://review.openstack.org/295454 | 18:45 |
| * SotK goes to make food | 18:45 | |
| *** jtomasek has quit IRC | 19:16 | |
| *** zara_ has joined #storyboard | 19:39 | |
| zara_ | SO MANY PATCHES | 19:39 |
| zara_ | that's the last time I check the logs at home | 19:40 |
| *** zara_ has quit IRC | 19:40 | |
| *** b3rnard0 is now known as b3rnard0_away | 19:53 | |
| *** b3rnard0_away is now known as b3rnard0 | 20:01 | |
| *** openstackgerrit has quit IRC | 23:03 | |
| *** openstackgerrit_ is now known as openstackgerrit | 23:03 | |
| *** openstackgerrit has quit IRC | 23:03 | |
| *** openstackgerrit_ has joined #storyboard | 23:04 | |
| *** openstackgerrit_ is now known as openstackgerrit | 23:04 | |
| *** openstackgerrit_ has joined #storyboard | 23:09 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!