| *** openstack has joined #storyboard | 13:21 | |
| Zara | hello openstack | 13:21 |
|---|---|---|
| *** openstackstatus has joined #storyboard | 13:22 | |
| *** ChanServ sets mode: +v openstackstatus | 13:22 | |
| Zara | (this is the emails patch, btw: https://review.openstack.org/#/c/270331/ . it's reporting a syntax error for an extra opening brace, but I think it's the right number of braces and the line-splitting is confusing things somehow. but I could be wrong on that.) | 13:31 |
| pedroalvarez | yeah, I counted also the braces, and they were ok, but I assumed the syntax error is somewhere else | 13:33 |
| Zara | that patch depends on: https://review.openstack.org/#/c/270329/ which has been hanging around for a while | 13:34 |
| Zara | I thought it had been merged by now, hm. | 13:35 |
| *** mrmartin has quit IRC | 13:55 | |
| Zara | meeting in 50 mins or so! | 14:11 |
| persia | About 270331: can this be replicated running `puppet parser validate` locally? Does puppet provide useful output to explain this sort of failure? | 14:19 |
| * SotK expects so (trying to run puppet with an old version of that patch gave some similar errors) | 14:21 | |
| SotK | I don't remember the errors being any more useful that what is in the test log though | 14:21 |
| SotK | (it might be useful if I had an adequate understanding of puppet syntax, but I don't) | 14:22 |
| persia | Irritating. They seem matched when I count also. | 14:30 |
| persia | I wonder if the backslash is applying to a } instead of whitespace | 14:30 |
| SotK | could be... does puppet ignore whitespace or something? | 14:31 |
| Zara | hm, but the placement of the backslash would only escape an opening brace if that were the case (unless I've missed one) | 14:31 |
| persia | According to https://docs.puppetlabs.com/puppet/latest/reference/lang_data_string.html#escape-sequences, backslash-newline doesn't seem to cause the newline to be ignored. | 14:33 |
| persia | I don't know if I'm understanding that correctly though, as backslash-newline is a common pairing to indicate line continuation, and there are apparent examples in the code. | 14:33 |
| persia | Rather, in the docs (including the "Heredocs" section immediately below the escape sequences discussion) | 14:34 |
| SotK | that's about as far as I got to figuring it out when I looked too | 14:38 |
| persia | http://projects.puppetlabs.com/issues/5022 | 14:50 |
| persia | Not that I expect we're really running that old a puppet... | 14:51 |
| Zara | (meeting in 8!) | 14:52 |
| SotK | :O | 14:53 |
| *** mrmartin has joined #storyboard | 15:05 | |
| *** betherly_ is now known as betherly | 15:06 | |
| persia | Not important for the meeting, but on 279753: do I read correctly that there is a view for boards, but none for worklists? | 15:17 |
| pedroalvarez | I think this new View is to be able to explore all boards and worklists present in StoryBoard | 15:20 |
| pedroalvarez | so you can go there, and even search boards you might be interested on | 15:20 |
| pedroalvarez | Because now, you only can play with the URL to discover new boards/worklists | 15:21 |
| persia | Right, but when I looked at the code, I saw boards, but not worklists, so I'm hoping I'm not seeing something. | 15:22 |
| persia | Or rather, I'm not seeing it because I'm incompetent, rather than not seeing it because it isn't there. | 15:22 |
| pedroalvarez | I think it was mentioned in the meetup, that's why I think it implements that functionality | 15:24 |
| Zara | it's not there because it's wip. it does currently display them, it's largely cut 'n' paste fro mdashboard stuff | 15:25 |
| Zara | so the name of the page is 'boards' but it displays both | 15:25 |
| Zara | (sorry, realised that was ambiguous) | 15:25 |
| Zara | similarly, it currently says 'my boards'/'my worklists' because it was a quick patch and it got lost in a bunch of others | 15:26 |
| Zara | I'll improve it iff people care enough xD | 15:26 |
| persia | It's mostly that I was confused reading the code. No worries. | 15:28 |
| Zara | yeah, a bit chicken-and-egg, I don't like to tidy up a patch beyond the bare minimum if I'm not convinced anybody wants it at all. I agree with SotK that a good enough search should make this kind of thing obsolete. | 16:07 |
| Zara | just that right now, we don't have that, and I can't give an estimate on when we will, because I'm still learning about the current behaviour and implementation. | 16:08 |
| persia | Right. My main objection is that it's entirely useless for all the use cases I can imagine. That said, it helps demo stuff, and helps people understand things are there, such that the educational value prevents me from -1ing it. | 16:10 |
| * krotscheck cracks knuckles | 16:12 | |
| krotscheck | Ok. | 16:12 |
| krotscheck | 401 | 16:12 |
| krotscheck | Working on angular has made me learn things that will make this awesome. | 16:12 |
| Zara | oooooooh | 16:13 |
| krotscheck | It turns out that responseError interceptors can recover a request. | 16:13 |
| * krotscheck thinks. | 16:13 | |
| * krotscheck is going to test that | 16:13 | |
| krotscheck | Also, for the time being, I don't see sotryboard acessing more than one API. | 16:14 |
| krotscheck | So using the $http level interceptors to handle token refresh will be way more reliable than the timer. | 16:14 |
| *** mrmartin has quit IRC | 16:17 | |
| persia | krotscheck: What do you mean "accessing more than one API"? | 16:17 |
| krotscheck | persia: Is the webclient making HTTP requests to something other than its own API? | 16:18 |
| persia | No, but I could imagine it doing so. | 16:18 |
| persia | Or, more particularly, I can imagine a dashboard that wants to use components from the Storyboard app as well as other things. | 16:19 |
| krotscheck | persia: Yes. But not yet. And until it does, we don't have to worry about it. And once it does, hopefully angular 1.6 will have been released with this change: https://github.com/angular/angular.js/pull/13273 | 16:19 |
| persia | heh. Please ignore me :) | 16:21 |
| Zara | 16:21 < persia> heh. Please ignore me :) | 16:21 |
| Zara | TEACH ME YOUR POWERS, KROTSCHECK | 16:21 |
| Zara | ahem | 16:21 |
| krotscheck | Zara: Go study the Tao of Logical Fallacies https://yourlogicalfallacyis.com/ | 16:22 |
| persia | Zara: The secret is to have already done all the work before I notice that someone could do it and develop an opinion :) | 16:22 |
| Zara | hehe | 16:23 |
| Zara | I'm excited about this, anyway! :) | 16:24 |
| * SotK is too | 16:24 | |
| pedroalvarez | I am too | 16:25 |
| *** faybrocklebank has quit IRC | 16:56 | |
| Zara | hm, if I have a patch depending on other things in review, and for that reason it's multiple commits, how do I update the commits to match the latest versions of those? eg: in http://paste.openstack.org/show/488056/ , say 'move search icon' has been updated | 17:12 |
| Zara | or am I better off just removing them from the patch? | 17:13 |
| pedroalvarez | Zara: I normally go to the web ui, and click the rebase button in "make header ...." and in "WIP for ...." | 17:14 |
| Zara | oh hey, there's a rebase button. TIL | 17:15 |
| Zara | so I should push it with old versions and then rebase them from the UI once it's in review? | 17:16 |
| pedroalvarez | hm.. I don't know if I understand everything.. | 17:17 |
| pedroalvarez | so, the new change to "move search icons" in this example, isn't done using the web ui? | 17:18 |
| Zara | oh, no, sorry | 17:18 |
| pedroalvarez | normally, when I'm in that situation you are explaining, when I `git review -R` it updates all of them | 17:18 |
| Zara | ahh, okay, I haven't been using the -R flag | 17:19 |
| pedroalvarez | well, let me check what it does, might not be relevant | 17:19 |
| Zara | and normally I'd just rebase on the relevant branch, but it's a bit awkward | 17:19 |
| Zara | because there are three commits, and the second depends on the first | 17:20 |
| Zara | and then the third depends on the second... so maybe I should just rebase on the right branch for the second, and then rebase the result on the right branch for the fist | 17:20 |
| Zara | *first | 17:20 |
| * pedroalvarez is confused | 17:21 | |
| pedroalvarez | :) | 17:21 |
| Zara | :) I am never doing anything with multiple commits ever ever ever again | 17:21 |
| pedroalvarez | I'm not a good teacher on IRC, sorry :( | 17:21 |
| Zara | s'fine, I'm not explaining it well anyway | 17:21 |
| krotscheck | WEll that's annoying | 17:23 |
| krotscheck | Circular dependency | 17:23 |
| SotK | :( | 17:23 |
| krotscheck | This implementation is way too complicated. | 17:26 |
| krotscheck | Whoever originally wrote this should get fired. | 17:26 |
| * krotscheck carefully doesn't look at who wrote it. | 17:26 | |
| krotscheck | ;) | 17:26 |
| pedroalvarez | heh :) | 17:27 |
| Zara | :) aw, looking at the original implementation with hindsight is punishment enough | 17:27 |
| openstackgerrit | Adam Coldrick proposed openstack-infra/storyboard-webclient: Add a calendar directive https://review.openstack.org/278508 | 17:28 |
| openstackgerrit | Adam Coldrick proposed openstack-infra/storyboard-webclient: Make the time-moment directive use moment.js https://review.openstack.org/284275 | 17:28 |
| openstackgerrit | Adam Coldrick proposed openstack-infra/storyboard-webclient: Add onBlur and onFocus callbacks to user-typeahead https://review.openstack.org/284276 | 17:28 |
| openstackgerrit | Adam Coldrick proposed openstack-infra/storyboard-webclient: Improve the board CSS a little https://review.openstack.org/284277 | 17:28 |
| openstackgerrit | Adam Coldrick proposed openstack-infra/storyboard-webclient: Add a $resource wrapper for Due Dates https://review.openstack.org/284278 | 17:28 |
| openstackgerrit | Adam Coldrick proposed openstack-infra/storyboard-webclient: Add Due Dates to boards https://review.openstack.org/284279 | 17:28 |
| openstackgerrit | Adam Coldrick proposed openstack-infra/storyboard-webclient: Display a modal when a card is clicked on https://review.openstack.org/284280 | 17:28 |
| Zara | ¬_¬ SOTK DO YOU MIND | 17:28 |
| anteaya | SotK: thanks, yes I was looking to add that task as a card to the infra cloud board (board number 8) | 17:28 |
| anteaya | I was unsuccessful trying to add that card | 17:29 |
| anteaya | and anytime in may works for me personally | 17:30 |
| openstackgerrit | Zara proposed openstack-infra/storyboard-webclient: Make header 'quick navigate' and 'search' clearer https://review.openstack.org/278987 | 17:32 |
| openstackgerrit | Zara proposed openstack-infra/storyboard-webclient: Move search icon https://review.openstack.org/279204 | 17:32 |
| openstackgerrit | Zara proposed openstack-infra/storyboard-webclient: WIP for boards and worklists page https://review.openstack.org/279753 | 17:32 |
| Zara | (for some reason that rebased everything, but it seems to have rebased them all to the right thing, at least) | 17:36 |
| Zara | the commit message now makes it a bit clearer why the patch exists, and some things have been changed so the comments make a bit more sense (since they were originally cut and pasted from the boards/worklists dashboard page) | 17:38 |
| Zara | as it scales, it probably makes more sense to have a controller for all boards, and a controller for all worklists, and then access them both through the same template... but I couldn't justify splitting it at this stage. | 17:39 |
| Zara | now to review the world | 17:39 |
| Zara | ooh, can't yet, yay | 17:40 |
| SotK | you can review the first 4! :P | 17:41 |
| krotscheck | Ok, so I can create an interceptor, but that interceptor cannot depend on anything that requires HTTP. | 17:45 |
| krotscheck | So you can't build a promise dependent on another request inside an interceptor :/ | 17:45 |
| krotscheck | Unless you do raw XMLHttpRequest | 17:45 |
| krotscheck | WHich, well, we can do. | 17:45 |
| persia | Is the you of 2018 going to want to torture the you of now for having done it that way? | 17:46 |
| *** faybrocklebank has joined #storyboard | 17:49 | |
| openstackgerrit | Adam Coldrick proposed openstack-infra/storyboard: Fix permissions being able to be set by any authenticated user https://review.openstack.org/284313 | 17:56 |
| openstackgerrit | Adam Coldrick proposed openstack-infra/storyboard: Add Due Dates to the API https://review.openstack.org/284314 | 17:56 |
| openstackgerrit | Adam Coldrick proposed openstack-infra/storyboard: Add Due Dates to the WSME models for boards, worklists, tasks, and stories https://review.openstack.org/284315 | 17:56 |
| openstackgerrit | Adam Coldrick proposed openstack-infra/storyboard: Update `PUT /v1/worklists/:id/items/:id` to allow assigning a due date https://review.openstack.org/284316 | 17:56 |
| * SotK apologises if the commit messages are scatterbrained | 17:57 | |
| * SotK will also fix the tests not working for the js stuff tomorrow | 17:58 | |
| * SotK shoots off | 17:58 | |
| Zara | np | 17:58 |
| Zara | I'll just be over here | 17:58 |
| Zara | crying | 17:58 |
| Zara | at my review workload | 17:58 |
| Zara | forever | 17:58 |
| *** faybrocklebank has quit IRC | 18:02 | |
| Zara | (heading home nowish anyway, will look at those tomorrow. reviewing is now my top priority; I doubt I will be able to look any more at search this week.) | 18:02 |
| Zara | 'night! | 18:03 |
| * krotscheck is cautiously otpimistic | 18:13 | |
| krotscheck | persia: The 2018 me will laugh at how obsessed I was with JavaScript | 18:13 |
| * Zara is cautiously optimistic about krotscheck's cautious optimism | 18:15 | |
| Zara | and I am actually going home this time! | 18:15 |
| Zara | night for real! :D | 18:15 |
| *** jtomasek has quit IRC | 18:21 | |
| krotscheck | And now, i dig through all the auth code and try to figure out where all the redundant "is this a valid session" checks are... | 18:22 |
| krotscheck | On an unrelated note, I'm seeing a _lot_ of errros in the javascript console? | 18:30 |
| krotscheck | TypeError: Cannot read property '$promise' of undefined | 18:30 |
| krotscheck | at link (http://localhost:9000/js/storyboard.js:9228:37 | 18:30 |
| krotscheck | TypeError: Cannot set property offsetWidth of #<HTMLElement> which has only a getter | 18:32 |
| *** mrmartin has joined #storyboard | 18:48 | |
| openstackgerrit | Michael Krotscheck proposed openstack-infra/storyboard-webclient: Logging in no longer causes page refresh. https://review.openstack.org/270882 | 19:09 |
| openstackgerrit | Michael Krotscheck proposed openstack-infra/storyboard-webclient: Access tokens are now refreshed in preflight promises. https://review.openstack.org/284356 | 19:09 |
| *** mrmartin has quit IRC | 19:14 | |
| pedroalvarez | wooooo! | 21:07 |
| pedroalvarez | This is just great :) | 21:07 |
| *** b3rnard0 is now known as b3rnard0_away | 22:37 | |
| * SotK will review it first thing tomorrow! | 22:45 | |
| krotscheck | pedroalvarez: Does the logic make sense? I tried to make the interceptor bits as clear as posisble | 23:44 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!