| *** jtomasek__ has joined #storyboard | 07:15 | |
| *** jtomasek_ has joined #storyboard | 07:24 | |
| *** openstackgerrit has quit IRC | 09:02 | |
| *** openstackgerrit has joined #storyboard | 09:02 | |
| *** pedroalvarez_ is now known as pedroalvarez | 09:58 | |
| Zara | moooooorning stoooooooooryboard | 10:29 |
|---|---|---|
| SotK | morning! | 10:29 |
| Zara | noooooooo, I left my headphones at hooooooome | 10:49 |
| pedroalvarez | morning! | 11:46 |
| pedroalvarez | just noticed, drag&drop of lanes, when creating a board (new board dialog) is a bit weird | 11:46 |
| pedroalvarez | is not a big deal, though. I thought i had to share it here :) | 11:47 |
| SotK | pedroalvarez: what weirdness are you seeing? | 12:16 |
| pedroalvarez | odd.. I can't reproduce ... :( | 12:18 |
| pedroalvarez | well, this was me reporting non-existing bugs again. :) | 12:18 |
| *** krotscheck_dcm is now known as krotscheck | 12:39 | |
| Zara | still looking at the timeline events bug. still confused. removed most of the stuff here so it just ran the else statement, and that fixed things. https://github.com/openstack-infra/storyboard/blob/master/storyboard/db/api/base.py#L125 | 12:47 |
| Zara | so then I tried editing tasks.py so that it would just run the else statement. I thought I'd just need to set in_request to false | 12:47 |
| Zara | so tried this; no dice. http://paste.openstack.org/show/486275/ | 12:48 |
| Zara | tried a few variants, increasingly strange, and nothing worked. am probably missing something obvious. | 12:50 |
| pedroalvarez | what is the timeline events bug? related to the one reported here? https://storyboard.openstack.org/#!/story/2000435 | 12:52 |
| Zara | yeah | 12:53 |
| Zara | https://storyboard.openstack.org/#!/story/2000478 | 12:53 |
| pedroalvarez | then I found the place that makes everything go wrong, but I have no idea about the best approach to fix it | 12:53 |
| pedroalvarez | I hope I can find the place again, hold on | 12:54 |
| Zara | haha, yeah I found what changed but yeah, don't know how to fix it (except removing the code, anyway...) | 12:54 |
| pedroalvarez | so, what I found is that original_task here http://git.openstack.org/cgit/openstack-infra/storyboard/tree/storyboard/api/v1/tasks.py#n369 | 12:56 |
| pedroalvarez | changes when we get the updated_task a few lines later | 12:56 |
| Zara | ah, I'd found orginal_task and updated_task were the same, but I didn't know exactly where it happened | 12:57 |
| pedroalvarez | ah, then I guess you already know more about the problem than me :) | 12:58 |
| SotK | I guess its some sqlalchemy weirdness if making it not use the same session for each makes it work | 12:59 |
| Zara | yeah, the changes in get_session here seem to cause that problem https://review.openstack.org/#/c/155751/4/storyboard/db/api/base.py | 13:00 |
| SotK | probably that updating a thing in the database updates the in-memory versions of that thing in the same session | 13:00 |
| SotK | I wonder if changing the line pedroalvarez linked to `original_task = copy.deepcopy(tasks_api.task_get(task_id))` helps at all | 13:01 |
| * Zara tries it | 13:04 | |
| Zara | ah, copy isn't defined in there | 13:04 |
| SotK | you'll need to `import copy` :) | 13:05 |
| Zara | haha | 13:05 |
| Zara | where does it live? | 13:05 |
| Zara | (or is 'import copy as copy' sufficient) | 13:05 |
| *** krotscheck has quit IRC | 13:06 | |
| SotK | `import copy` is sufficient | 13:06 |
| Zara | YES THAT WORKED | 13:06 |
| Zara | yaaaaay \o/ | 13:07 |
| pedroalvarez | nice!!! | 13:14 |
| pedroalvarez | looking forward to that fix :D :D :D | 13:14 |
| Zara | gah I'm so pleased, I've been bashing my head against it for about a week | 13:15 |
| Zara | the best part was realising it had been a bug since last March. | 13:15 |
| pedroalvarez | hah | 13:16 |
| pedroalvarez | Zara: did you use git bisect for that? | 13:16 |
| Zara | pedroalvarez: I had to do it manually because the API and webclient would get out of sync, and I couldn't install the old version of the webclient | 13:17 |
| pedroalvarez | ugh.. | 13:18 |
| Zara | yeah, it was greeeeat :/ | 13:18 |
| pedroalvarez | yeah, that's why I gave up when debugging when the bug was intruduced | 13:18 |
| Zara | hahaha | 13:18 |
| *** krotscheck has joined #storyboard | 13:18 | |
| Zara | I got to the bit where I knew exactly what had changed but didn't know how to fix it... so thanks for the help, everyone! :D | 13:18 |
| * Zara writes commit message | 13:18 | |
| pedroalvarez | Zara: good work :) | 13:19 |
| openstackgerrit | Zara proposed openstack-infra/storyboard: Fix Bugs in Timeline Events https://review.openstack.org/277386 | 13:19 |
| openstackgerrit | Zara proposed openstack-infra/storyboard: Fix Bugs in Timeline Events https://review.openstack.org/277386 | 13:25 |
| Zara | there, I think it's ready now. :) | 13:26 |
| openstackgerrit | Adam Coldrick proposed openstack-infra/storyboard: Don't add non-existent items when resolving lists https://review.openstack.org/276303 | 13:38 |
| Zara | :D | 13:38 |
| * Zara will test shortly | 13:38 | |
| *** b3rnard0_away is now known as b3rnard0 | 13:49 | |
| * Zara starts looking at task metadata... | 13:58 | |
| Zara | will I need an alembic migration for task metadata? I'm guessing I need to update the tasks table in wmodels.py, then update the endpoints for tasks | 14:47 |
| Zara | (not sure if you need a migration for updating a table or just creating one, would guess you would) | 14:48 |
| SotK | the database layout is defined in storyboard/db/models.py | 14:54 |
| SotK | storyboard/api/v1/wmodels.py is defines the WSME types used by the endpoints | 14:54 |
| Zara | hm, for some reason I wrote wmodels.py but meant models.py... | 14:54 |
| SotK | (you'll need to edit both I expect) | 14:55 |
| SotK | (and yes, you'll need a migration) | 14:55 |
| SotK | you can autogenerate a skeleton migration that you can then fine-tune once you've made changes to models.py | 14:55 |
| SotK | ambiguous sentence was ambiguous | 14:55 |
| * SotK tries again | 14:56 | |
| SotK | when you've made changes to models.py, you can autogenerate a skeleton migration that you can then fine-tune | 14:56 |
| Zara | heh | 14:57 |
| SotK | `sudo tox -e venv "storyboard-db-manage --config-file etc/storyboard.conf revision -m $YOUR_MIGRATION_NAME_HERE --autogenerate"` | 14:57 |
| Zara | :> is that documented anywhere? | 14:59 |
| SotK | I think its in a README in the storyboard repo somewhere | 14:59 |
| SotK | yeah, its in storyboard/db/migration/README | 14:59 |
| Zara | oh, huh | 15:00 |
| Zara | I looked around on the docs pages but didn't notice that... | 15:00 |
| Zara | ah, there's a lot of detail there, thanks | 15:01 |
| openstackgerrit | Merged openstack-infra/storyboard: Don't add non-existent items when resolving lists https://review.openstack.org/276303 | 15:05 |
| Zara | hm... my migration turned out long... | 16:02 |
| SotK | most of it will be unneeded | 16:03 |
| * SotK hasn't yet figured out why that happens | 16:03 | |
| Zara | ah, okay. I was looking at the boards/worklists one for reference and I thought it was weird that mine had all this stuff in but that one didn't | 16:03 |
| Zara | makes sense if you manually removed it :P | 16:03 |
| * Zara also notes that `import sqlalchemy.dialects import mysql` has vanished in favour of `import storyboard` | 16:04 | |
| Zara | s/import/from | 16:05 |
| SotK | running it complained about needing to import storyboard, and the other import was for one fo the things I manually removed | 16:06 |
| Zara | ah, right | 16:07 |
| openstackgerrit | Zara proposed openstack-infra/storyboard: Add column for task links https://review.openstack.org/277481 | 16:15 |
| Zara | I sent the first bit... not very sure of what I'm doing, but easier to comment on a thing than on nothing. | 16:15 |
| *** kencjohnston has joined #storyboard | 16:17 | |
| pedroalvarez | is it the idea a relation 1:1 | 16:18 |
| pedroalvarez | 1 task 1 link? | 16:18 |
| Zara | I think so, it might make sense to have multiple ones, though I'm not sure how to represent it... I thought I'd start with the easier option and make it more complicated if we needed it. | 16:25 |
| Zara | though I may have just done it completely wrong anyway =D | 16:25 |
| openstackgerrit | Zara proposed openstack-infra/storyboard: Add column for task links https://review.openstack.org/277481 | 16:28 |
| Zara | oops, rechecked other patch but it was actually failing because things weren't in alphabetical order... | 16:51 |
| * Zara fixes | 16:52 | |
| openstackgerrit | Zara proposed openstack-infra/storyboard: Fix Bugs in Timeline Events https://review.openstack.org/277386 | 16:53 |
| openstackgerrit | Zara proposed openstack-infra/storyboard-webclient: Rename board and worklist controllers https://review.openstack.org/272211 | 17:07 |
| Zara | hadn't rebased that in a while... | 17:08 |
| openstackgerrit | Zara proposed openstack-infra/storyboard: Add column for task links https://review.openstack.org/277481 | 17:19 |
| Zara | (misc pep8 style things) | 17:19 |
| Zara | I'm off, 'night, all! | 18:23 |
| Zara | task links are going well, expect patches soon. | 18:23 |
| *** jtomasek_ has quit IRC | 20:00 | |
| *** mrmartin has joined #storyboard | 20:52 | |
| *** mrmartin has quit IRC | 20:54 | |
| *** kencjohnston has quit IRC | 22:01 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!