| *** coolsvap|away is now known as coolsvap | 05:19 | |
| *** davidlenwell has quit IRC | 07:00 | |
| *** davidlenwell has joined #storyboard | 07:02 | |
| *** davidlenwell has quit IRC | 07:24 | |
| *** coolsvap is now known as coolsvap|away | 07:25 | |
| *** davidlenwell has joined #storyboard | 07:26 | |
| *** davidlenwell has quit IRC | 07:29 | |
| *** jtomasek has joined #storyboard | 07:29 | |
| *** davidlenwell has joined #storyboard | 07:33 | |
| *** davidlenwell has quit IRC | 07:41 | |
| *** davidlenwell has joined #storyboard | 07:45 | |
| *** coolsvap|away is now known as coolsvap | 08:16 | |
| Zara | morning, storyboard! | 10:01 |
|---|---|---|
| betherly | hey Zara and all | 10:06 |
| betherly | ughhhhhhhh came into the office today as midc cycle on and boss and co worker people around | 10:06 |
| betherly | buuuuuut...the network setup here etc has completely screwed my localrc and rendered my vms useless | 10:07 |
| betherly | yayyyy! | 10:07 |
| Zara | ;_; | 10:07 |
| Zara | actually this calls for blue tears | 10:07 |
| Zara | ;_; | 10:07 |
| Zara | did you get it to stop pretending it didn't have enough memory? | 10:08 |
| betherly | Zara: nooope | 10:09 |
| betherly | nothing fun like that | 10:09 |
| betherly | so now i have 2 issues | 10:09 |
| betherly | the pretty major one being that i cant use it...at all | 10:09 |
| Zara | can you make a new one? | 10:09 |
| betherly | ye thats what im trying | 10:11 |
| * betherly crying | 10:11 | |
| betherly | does not encourage me to work from the office lol | 10:11 |
| Zara | heh, I'm in the reverse position where I never figured out how to access my storyboard VM from my browser at home, so I always have to come in to do development. | 10:12 |
| betherly | thats sucky | 10:12 |
| Zara | the best bit is that I can still access the VM through the terminal, I just can't see any of the changes. xD | 10:12 |
| Zara | I hope your new one is successful, anyway! :) | 10:13 |
| betherly | ohhh thats fun :/ | 10:14 |
| Zara | at least this weekend we tried virtualbox on windows, so now I think I should just do that sometime. it's funny because the setup is the reverse of the virt-manager setup (in virt-manager, you pick your iso first and then add storage after, whereas in virtualbox it seems you pick your iso at the end...) | 10:20 |
| Zara | ('we' being me + bf, not storyboard or anything) | 10:20 |
| Zara | the rechecks seem to like https://review.openstack.org/#/c/270406/ at last! | 10:25 |
| Zara | I need to get on testing these patches... | 11:35 |
| Zara | ah, after clicking 'archive board', the user is taken back to boards/worklists page, but clicking 'archive worklist' keeps the user on the worklist detail page. I think they should both go back to boards/worklists page | 12:23 |
| Zara | in general the WorklistDeleteController and BoardArchiveController are probably more different than they should be (I think they're both meant to archive, too!). | 12:37 |
| * SotK wonders what the problematic difference is (other than the naming)? | 12:39 | |
| Zara | hmm... they handle redirects differently, but the code doesn't suggest the behaviour should be different, since 'redirect' is set to 'true' in worklistdetailcontroller | 12:40 |
| Zara | so now I'm confused | 12:40 |
| Zara | but yeah, wondering why one just goes to the dashboard while the other checks if it should redirect or not first | 12:41 |
| SotK | ah, that's because WorklistDeleteController is also used when checking if you want to archive a board's lane | 12:41 |
| Zara | aha | 12:41 |
| SotK | and in that situation you don't want to redirect to the dashboard | 12:41 |
| Zara | yeah | 12:41 |
| SotK | but boards don't have that limitation, and should always redirect | 12:41 |
| Zara | okay, yeah, that makes sense. still confused about why it's not redirecting when it should be, then! | 12:42 |
| SotK | oh hm, it doesn't redirect? :/ | 12:43 |
| Zara | yeah, it didn't for me just then (boards do, though) | 12:43 |
| Zara | gonna try again | 12:44 |
| SotK | hm, apparently it doesn't | 12:44 |
| Zara | yeah :/ | 12:44 |
| Zara | am I right in thinking that the controller files are named a little differently in worklists (from boards) because they are also lanes? | 12:46 |
| Zara | eg: 'add_board_controller.js' vs 'add_controller.js' | 12:46 |
| SotK | nope, its because I'm apparently terrible at naming things consistently :) | 12:48 |
| Zara | hahaha | 12:48 |
| Zara | yeah, we should fix that xD | 12:48 |
| Zara | I only just noticed it so... | 12:48 |
| SotK | yeah, I'll send a patch to tidy things up once I've finished this speedups stuff | 12:49 |
| SotK | I realised why it doesn't redirect... the stuff in the resolve: section when creating a modal has to be functions which return the value you want, not just the value | 12:50 |
| Zara | sounds familiar. I think I had that sort of problem a lot with the subscriptions stuff | 12:50 |
| Zara | (hah, I was gonna offer to mess with the controller titles, but I've still got review to do and you'll have a better idea of what'll break when names change. still, can look if it's useful.) | 12:51 |
| openstackgerrit | Adam Coldrick proposed openstack-infra/storyboard-webclient: Fix redirection when deleting worklists https://review.openstack.org/272080 | 12:54 |
| Zara | bwahahaha yes that was much faster than I'd've been. | 12:54 |
| * SotK notices he's put "deleting" instead of "archiving" again... | 12:58 | |
| openstackgerrit | Adam Coldrick proposed openstack-infra/storyboard-webclient: Fix redirection when archiving worklists https://review.openstack.org/272080 | 12:58 |
| Zara | :) I think there are a few things in the code round those parts that refer to deleting. | 13:01 |
| Zara | eg: 'app/worklists/template/delete.html' | 13:02 |
| Zara | (I'm testing the server-side resolving patch atm, seems fine so far with my webclient) | 13:03 |
| Zara | hm, when I move lanes around... | 13:06 |
| Zara | 500: PUT /api/v1/boards/22: 'Board' object has no attribute 'permissions' | 13:06 |
| SotK | \o/ | 13:07 |
| Zara | =D you're welcome! | 13:07 |
| Zara | yup, just checked it's fine on master, so looks like that patch is responsible. | 13:07 |
| SotK | hm, it seems to be working here | 13:09 |
| Zara | the lanes still move for me | 13:10 |
| SotK | can you paste the traceback from the API by any chance? | 13:10 |
| Zara | I just get a 500 | 13:10 |
| Zara | 2016-01-25 13:06:20.487 22911 ERROR wsme.api [-] Server-side error: "'Board' object has no attribute 'permissions'". Detail: | 13:10 |
| Zara | Traceback (most recent call last): | 13:10 |
| Zara | File "/home/ubuntu/storyboard/.tox/venv/local/lib/python2.7/site-packages/wsmeext/pecan.py", line 84, in callfunction | 13:10 |
| Zara | result = f(self, *args, **kwargs) | 13:10 |
| Zara | File "/home/ubuntu/storyboard/storyboard/api/v1/boards.py", line 246, in put | 13:10 |
| Zara | if visible(board, user_id): | 13:10 |
| Zara | File "/home/ubuntu/storyboard/storyboard/api/v1/boards.py", line 41, in visible | 13:10 |
| Zara | permissions = boards_api.get_permissions(board, user) | 13:10 |
| Zara | File "/home/ubuntu/storyboard/storyboard/db/api/boards.py", line 117, in get_permissions | 13:10 |
| Zara | return [permission.codename for permission in board.permissions | 13:10 |
| Zara | AttributeError: 'Board' object has no attribute 'permissions' | 13:10 |
| Zara | should've done that on paste.openstack.org but it wasn't that long... | 13:10 |
| SotK | o.O | 13:11 |
| Zara | well that's a good sign | 13:11 |
| SotK | oh heh, I'm an idiot | 13:12 |
| Zara | if you're an idiot there's no hope for any of us. | 13:13 |
| Zara | but I assume that means you've worked out what's up! | 13:13 |
| SotK | yeah, I was passing the WSME board object rather than the database model of the board | 13:14 |
| SotK | didn't used to be a problem since visible() used to do boards_api.get(board.id), but I got rid of that as it was pointless most of the time | 13:15 |
| Zara | ah, I see it's changed in various places from `board.id` or `board_id` to just `board` | 13:25 |
| Zara | aaand `board = boards_api.get(board_id)` comes after visible, editable and update_lanes | 13:27 |
| *** coolsvap is now known as coolsvap|away | 13:51 | |
| Zara | https://review.openstack.org/#/c/270406/ needs a workflow +1, not sure if we should do the +2 and +1 to merge with these sorts of things, or if one +2 is sufficient | 15:49 |
| Zara | \o/ | 15:50 |
| openstackgerrit | Merged openstack-infra/storyboard: Remove argparse from requirements https://review.openstack.org/270406 | 15:56 |
| Zara | gah, so my 'show most recently created first' patch worked for stories in the stories list, but not stories in a project. | 16:34 |
| Zara | have fixed it now | 16:35 |
| Zara | wonder if I've missed any other places... | 16:36 |
| Zara | hm, projects in project groups | 16:38 |
| openstackgerrit | Zara proposed openstack-infra/storyboard-webclient: Put most recently created things at top of lists https://review.openstack.org/272176 | 16:43 |
| *** mrmartin has joined #storyboard | 17:02 | |
| openstackgerrit | Zara proposed openstack-infra/storyboard-webclient: Rename board and worklist controllers https://review.openstack.org/272211 | 18:04 |
| Zara | night-night, storyboard! | 18:09 |
| *** openstackgerrit has quit IRC | 19:02 | |
| *** openstackgerrit has joined #storyboard | 19:03 | |
| *** mrmartin has quit IRC | 19:16 | |
| *** mrmartin has joined #storyboard | 20:17 | |
| *** mrmartin has quit IRC | 20:18 | |
| *** davidlenwell has quit IRC | 21:16 | |
| *** davidlenwell has joined #storyboard | 21:18 | |
| *** davidlenwell has quit IRC | 21:55 | |
| *** davidlenwell has joined #storyboard | 21:56 | |
| *** davidlenwell has quit IRC | 22:34 | |
| *** davidlenwell has joined #storyboard | 22:36 | |
| *** jtomasek has quit IRC | 23:32 | |
| *** jtomasek has joined #storyboard | 23:44 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!