| *** coolsvap|away is now known as coolsvap | 04:49 | |
| *** jtomasek has joined #storyboard | 07:55 | |
| *** openstackgerrit has quit IRC | 10:02 | |
| *** openstackgerrit has joined #storyboard | 10:02 | |
| Zara | huh, jenkins didn't like that... wonder what's up? | 10:15 |
|---|---|---|
| Zara | (removing argparse) | 10:15 |
| pedroalvarez | I think it just failed in jenkins, but it should work. Although there is a bit of debate because this will drop support for python 2.6, and removing it is not really fixingh anything | 10:22 |
| pedroalvarez | (from other changes with the same topic https://review.openstack.org/#/q/topic:rm-argparse) | 10:22 |
| Zara | gah, what's going on with this redirect patch | 11:37 |
| Zara | it's reported as a problem in the style check, but it needs to be that way to work... so I'm guessing I need to do it differently, and it's some angular quirk that I don't know or have forgotten | 11:38 |
| Zara | https://review.openstack.org/#/c/270337/ | 11:39 |
| Zara | (if it's just function () then it doesn't redirect properly, whereas function (Story) works ) | 11:39 |
| Zara | but that's declaring the variable twice since it's already in the upper scope | 11:40 |
| pedroalvarez | does it still work if you rename "Story" ? | 11:42 |
| * pedroalvarez <- no idea about js and Angular | 11:42 | |
| Zara | (but if I *don't* declare it there, then it doesn't seem to get the value of the variable from the upper scope, so... wha? ) | 11:42 |
| Zara | if I rename it, I get '*placeholder* is declared but never used' | 11:42 |
| Zara | though I should check if everything still works | 11:43 |
| pedroalvarez | I mean something like this: http://paste.openstack.org/show/484546/ | 11:44 |
| pedroalvarez | it will be used.. no reason to say 'is declared but never used' | 11:44 |
| Zara | hah I forgot to change it inside the function to match up, that might be it... xD | 11:45 |
| pedroalvarez | if that works, then I would call it "NewStory" :) | 11:46 |
| Zara | yup, that worked | 11:46 |
| Zara | thanks | 11:46 |
| pedroalvarez | nice :) | 11:46 |
| pedroalvarez | np | 11:46 |
| Zara | heh, I was actually using that as my test variable, but not in camelCase. though the function is called newStory, so that might get confusing. | 11:47 |
| pedroalvarez | fair | 11:51 |
| Zara | I'm going with createdStory for now, because I couldn't think of something better and all the good names were taken (newStory and story) ;_; | 11:51 |
| openstackgerrit | Zara proposed openstack-infra/storyboard-webclient: Always go to Story Detail Page after adding Story https://review.openstack.org/270337 | 11:53 |
| pedroalvarez | makes sense :) | 11:54 |
| Zara | I should turn off emails in my test instance... my inbox is full of 'story fdkslfjdksfjdsl was created' | 11:56 |
| pedroalvarez | add a filter for them :) | 11:57 |
| Zara | that would also work | 11:58 |
| *** coolsvap is now known as coolsvap|away | 12:07 | |
| SotK | does calling the variable `story` not work? | 12:18 |
| Zara | no, it said it had been used | 12:18 |
| Zara | It wouldn't let me have 'story' and 'Story', hehe | 12:19 |
| Zara | (though it's possible I'd done something else strange so I'll check jic) | 12:20 |
| Zara | I tried it at the last minute last night; may have been tired and got errors for unrelated reasons! | 12:21 |
| SotK | `story` doesn't look to be defined in the parent scope, so I don't see why it would give an error about that | 12:22 |
| Zara | yeah, it seems fine. I'm guessing it was a different error and I didn't change it in the body of the function to match. | 12:23 |
| Zara | then thought it was the declaring variables twice error | 12:24 |
| Zara | this is why I should just go home when I'm tired... eh, I'll post the 'story' version now, anyway :P | 12:25 |
| openstackgerrit | Zara proposed openstack-infra/storyboard-webclient: Always go to Story Detail Page after adding Story https://review.openstack.org/270337 | 12:26 |
| openstackgerrit | Zara proposed openstack-infra/storyboard-webclient: Change Hover Cursor for Interactable Titles https://review.openstack.org/270776 | 12:47 |
| Zara | (I'm very sleepy today so going through old bugs and fixing the little ones) | 12:50 |
| Zara | in case anyone is wondering why the heck hover cursors are a priority for me :P | 12:50 |
| pedroalvarez | haha | 12:51 |
| pedroalvarez | just tested, looks good to me :) | 12:52 |
| Zara | \o/ | 12:53 |
| *** jtomasek has quit IRC | 13:09 | |
| openstackgerrit | Adam Coldrick proposed openstack-infra/storyboard-webclient: Fix some minor project group issues https://review.openstack.org/269627 | 14:00 |
| *** jtomasek has joined #storyboard | 14:31 | |
| pedroalvarez | thanks for fixing that one :0 | 14:52 |
| pedroalvarez | :) | 14:52 |
| openstackgerrit | Merged openstack-infra/storyboard-webclient: Fix some minor project group issues https://review.openstack.org/269627 | 15:07 |
| Zara | \o/ | 15:07 |
| Zara | gardening tasks etc-- so, for emails, we're just waiting on jeblair's patches? afaik there isn't anything else we can do on that side. | 15:47 |
| SotK | that is my understanding, yes | 15:47 |
| Zara | cool.. guess it depends how they go, but hopefully it's just a few syntax tweaks and then infra will get their emails! :) | 15:48 |
| Zara | I should say 'our' emails but I'm used to using recentEvents by now. | 15:48 |
| openstackgerrit | Michael Krotscheck proposed openstack-infra/storyboard-webclient: Logging in no longer causes page refresh. https://review.openstack.org/270882 | 16:06 |
| krotscheck | Zara: ^^ | 16:06 |
| Zara | krotscheck: Thank you! I'm so excited! =D | 16:06 |
| krotscheck | Now to see if I can reproduce this refresh token nonsense | 16:07 |
| pedroalvarez | topic => king_of_the_north | 16:07 |
| pedroalvarez | :) | 16:07 |
| krotscheck | Urm, actually | 16:08 |
| Zara | I hope to send news of the coronation to successbot soon | 16:08 |
| Zara | uh oh | 16:08 |
| krotscheck | Don't merge that | 16:08 |
| krotscheck | I've got an infinite token refresh loop. | 16:08 |
| krotscheck | :D | 16:08 |
| * krotscheck goes and figures that out | 16:08 | |
| Zara | we're still waaaay closer than before. :) | 16:09 |
| krotscheck | Zara, pedroalvarez: Ok, nevermind, it's fine to merge. My loop was caused by a misconfig - THe server expired tokens after 5 seconds, but my internal refresh time would check for "expire_time" minus "600 seconds", which resulted in a negative timeout value. | 16:16 |
| krotscheck | Also, I'm no longer seeing the 401 | 16:16 |
| SotK | \o/ | 16:17 |
| SotK | thanks krotscheck! | 16:17 |
| krotscheck | Though there are some edge cases about an expired token that y'all might want to look at. | 16:17 |
| krotscheck | i.e. "If the refresh timer doesn't fire/work what happens" | 16:17 |
| krotscheck | To test manually, you'll have to set your local storyboard-api token expiry to "small", and then manually adjust your webclient's pre_expire_delta.js to something "less than small". | 16:18 |
| paulsherwood | heard elsewhere... 'email notifications *for comments* etc too please' | 16:19 |
| Zara | hm, there should already be notifications for comments. | 16:20 |
| pedroalvarez | yup, there are | 16:20 |
| Zara | krotscheck: cool, will test now! :) | 16:20 |
| pedroalvarez | krotscheck: nice, will test | 16:20 |
| krotscheck | I've added more detailed instructions to the review. | 16:22 |
| Zara | thank you | 16:25 |
| krotscheck | Hrm, tests fail, just a sec | 16:29 |
| krotscheck | Ahhh, phantomJS doesn't support the URL class. | 16:30 |
| krotscheck | Hrm | 16:30 |
| Zara | I'm following the steps and still being logged out and getting 401s; wondering if I've definitely configured the right things | 16:48 |
| Zara | # Time in seconds before an access_token expires | 16:48 |
| Zara | access_token_ttl = 5 | 16:48 |
| Zara | # Time in seconds before an refresh_token expires | 16:48 |
| Zara | refresh_token_ttl = 5 | 16:48 |
| Zara | wondering if it should just be the refresh token... | 16:49 |
| Zara | oh, nvm, logging in itself is fine | 16:50 |
| Zara | I think everything is behaving as expected, since the bit I mentioned there is the 2nd part of the fix... | 16:51 |
| Zara | yep, that seems fine. | 16:56 |
| *** davidlenwell has quit IRC | 16:58 | |
| *** davidlenwell has joined #storyboard | 16:59 | |
| openstackgerrit | Michael Krotscheck proposed openstack-infra/storyboard-webclient: Logging in no longer causes page refresh. https://review.openstack.org/270882 | 17:00 |
| Zara | \o/ | 17:02 |
| krotscheck | Yeah, I figured: our users don't use phantom, let's not test on phantom, let's test on chrome instead. | 17:06 |
| krotscheck | Though i can split that into a separate patch. | 17:06 |
| krotscheck | ....wait a sec. Wasn't the king of the north beheaded? | 17:07 |
| *** coolsvap|away has quit IRC | 17:07 | |
| Zara | hm, good point, we could do with a luckier title | 17:07 |
| Zara | I used it because we're based in the North of England, but it doesn't work well as a metaphor | 17:08 |
| Zara | very-successful-king-in-the-north-unlike-that-other-guy? | 17:08 |
| paulsherwood | Zara, pedroalvarez - ok thanks | 17:08 |
| Zara | I'm heading off in a minute-- does anyone need anything before I vanish for the night? | 17:22 |
| pedroalvarez | nope from me :) | 17:26 |
| * pedroalvarez goes to test the patch with the right settings | 17:26 | |
| Zara | okay, night! :) | 17:29 |
| *** davidlenwell has quit IRC | 17:50 | |
| *** davidlenwell has joined #storyboard | 17:55 | |
| *** mrmartin has joined #storyboard | 18:52 | |
| *** mrmartin has quit IRC | 19:45 | |
| krotscheck | Derp still broken, | 19:50 |
| krotscheck | Ok, I'm shifting to daycare mode, will be available when naps happen, but I'm focused on getting an NPM mirror into infra over in #openstack-infra, so I won't be able to update things until tomorow. | 19:51 |
| krotscheck | Feel free to take on that patch and fix the silly browser things. | 19:51 |
| *** yarkot has joined #storyboard | 20:45 | |
| *** yarkot has quit IRC | 21:18 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!