| *** coolsvap|away is now known as coolsvap | 04:21 | |
| *** mrmartin has joined #storyboard | 04:24 | |
| *** mrmartin has quit IRC | 05:12 | |
| *** coolsvap is now known as coolsvap|away | 06:56 | |
| *** coolsvap|away is now known as coolsvap | 07:41 | |
| *** mrmartin has joined #storyboard | 07:50 | |
| *** jtomasek has joined #storyboard | 07:53 | |
| *** jtomasek has quit IRC | 08:29 | |
| *** jtomasek has joined #storyboard | 08:30 | |
| *** mrmartin has quit IRC | 09:22 | |
| Zara | morning, storyboard! | 09:50 |
|---|---|---|
| pedroalvarez | o/ ! | 09:52 |
| Zara | :) | 09:52 |
| Zara | thogh :( because apparently SotK is ill today as well | 09:52 |
| Zara | looking at tags templates again now | 10:44 |
| Zara | know what the files need to be and where to put them... not sure how to get the tag title yet! hah, I'll work it out. | 10:44 |
| Zara | (hm, trying to put the same tag on a story twice causes an odd-looking error on the server side. I think we'll want to tidy that.) | 10:49 |
| *** coolsvap is now known as coolsvap|away | 11:11 | |
| Zara | so confused... sub resources are set to 'None' but tags seem to behave like a sub resource | 11:40 |
| Zara | btw, unlimited paging is finally unblocked and has been waiting around since forever | 12:24 |
| Zara | https://review.openstack.org/#/c/235993/ <- if anyone has a moment to review | 12:25 |
| *** mrmartin has joined #storyboard | 12:25 | |
| pedroalvarez | Zara: hey, I can't see that patch working :( | 12:45 |
| pedroalvarez | the sha1 in the about page helped me find out I wasn't testing the right version :) | 12:47 |
| Zara | heh | 12:51 |
| Zara | phew | 12:51 |
| Zara | and also, cool, it's nice when stuff we've just merged makes things easier! :) | 12:51 |
| pedroalvarez | I think there is one little thing missing | 12:53 |
| pedroalvarez | I can't see the option in /#!/profile/preferences | 12:54 |
| Zara | ooh, good catch | 12:55 |
| Zara | I totally missed that | 12:55 |
| pedroalvarez | noted in the patch | 12:56 |
| Zara | adam will cry; that patch has been waiting since october. | 12:56 |
| Zara | I think it's cursed. | 12:56 |
| pedroalvarez | The fix should be easy | 12:57 |
| Zara | yeah, he'll just cry on principle :P | 12:59 |
| pedroalvarez | heh, I was suggesting that you could fix it :) | 13:00 |
| Zara | ah, right I thought it'd be weird to do it as a separate patch but can do (hopefully!) :P | 13:01 |
| openstackgerrit | Zara proposed openstack-infra/storyboard-webclient: Add unlimited pagination option for preferences https://review.openstack.org/264770 | 13:22 |
| Zara | took longer than necessary messing with git; ended up giving up trying to get a pretty 'depends on' in gerrit and ended up just doing it the manual way. | 13:25 |
| Zara | have already just noticed that that preference seems to only work one way (ie: it changes the display on the other pages, but selecting the 'unlimted' option on another page doesn't change the preference on the profile | 13:25 |
| Zara | not sure exactly what's causing that, would guess I've maybe got an 'unlimited' where I need a -1 somewhere | 13:26 |
| Zara | I can smell chicken | 13:29 |
| Zara | hm, wrong channel | 13:29 |
| Zara | still true, though. | 13:29 |
| Zara | looking at tag templates again. the PUT for tags returns a story, the tag names are not part of this story, and I don't know how to get data that isn't part of the story. probably general fuzziness about getting stuff from place A to place B showing. | 13:40 |
| Zara | on one of my schema diagrams, tags are floating off in their own little disconnected bubble, haha | 13:41 |
| Zara | my storyboard instance freaked out when I checked out a different branch because I still had pagination set to 'unlimited' and there was no longer an option for it. so for anyone testing, make sure you change it back before you switch branches back, or strange errors await! | 13:57 |
| pedroalvarez | :/ I didn't mean to send a separate patch, sorry if I wasn't clear | 14:04 |
| Zara | hah, I didn't want to hijack his patch series, not had to do this before so don't really know the etiquette | 14:05 |
| pedroalvarez | I don't know how rude people think is fixing other's patch.. | 14:05 |
| pedroalvarez | I've done that in the past, so that I don't have to wait for the author to fix it | 14:05 |
| pedroalvarez | not in opsntack, though | 14:05 |
| Zara | okay, if it's okay for me to just add a commit on the end of it then I can do that, I don't think sotk would care much but there might be a general 'don't do this in openstack' rule that I don't know about | 14:06 |
| Zara | yeah | 14:06 |
| Zara | I'll have a look around | 14:06 |
| pedroalvarez | I'll test the patch in the mean time | 14:07 |
| pedroalvarez | what I wouldn't want is to merge the first patch and not merge the second one | 14:07 |
| pedroalvarez | Zara: it doesn't work btw :( | 14:08 |
| Zara | hm, it definitely won't work without the first one but worked for me in testing | 14:09 |
| Zara | what's up with it? | 14:09 |
| pedroalvarez | when I check the new option in the preferences page nothing happens | 14:09 |
| pedroalvarez | so lists keep showing 50 (for example) | 14:10 |
| * pedroalvarez is bad at wording | 14:10 | |
| pedroalvarez | so, if I go to stories (for example) and set the limit to 10, then the preferences page will have 10 selected | 14:11 |
| pedroalvarez | If I do the same for unlimited, it doesn't show unlimited checked | 14:11 |
| Zara | ah, right, I mentioned that before; it seems to work one way round but not the other? | 14:12 |
| pedroalvarez | also, if check Unlimited in the preferences page, and reload the page, the radiobutton is still unchecked | 14:12 |
| Zara | gah | 14:12 |
| Zara | I've probably got an 'unlimited' where I need a -1 somewhere | 14:12 |
| Zara | will look closer at it | 14:12 |
| pedroalvarez | hang on! | 14:13 |
| pedroalvarez | ignore "also, if check Unlimited in the preferences page, and reload the page, the radiobutton is still unchecked" | 14:13 |
| pedroalvarez | you have to press "Save", oh yes, you have to... | 14:13 |
| Zara | haha | 14:13 |
| Zara | phew | 14:13 |
| pedroalvarez | found a typo | 14:15 |
| pedroalvarez | see patch in gerrit | 14:16 |
| Zara | lol | 14:17 |
| Zara | should've noticed the colour change in my editor... | 14:17 |
| pedroalvarez | :) I was wondering why "Unlimited" wasn't in bold | 14:18 |
| Zara | okay, found the issue | 14:20 |
| Zara | needed a -1 for value | 14:20 |
| Zara | might as well upload this change to sotk's patch series, since I can't find anything in openstack docs advising against that | 14:20 |
| Zara | I guess in the worst case, gerrit won't let me do it | 14:21 |
| pedroalvarez | good :) | 14:23 |
| pedroalvarez | could you point me where to put that -1? to test it :) | 14:24 |
| pedroalvarez | Ah, found it I think | 14:24 |
| Zara | heh | 14:25 |
| Zara | gerrit didn't like me trying to add this patch to sotk's, so I'll just update mine for now, I guess, and it'll be slightly easier for him to copy-paste | 14:26 |
| Zara | well that was exciting. | 14:26 |
| pedroalvarez | heh | 14:27 |
| pedroalvarez | ok, "-1" fixed that issue :) | 14:27 |
| openstackgerrit | Zara proposed openstack-infra/storyboard-webclient: Add unlimited pagination option for preferences https://review.openstack.org/264770 | 14:31 |
| Zara | :) | 14:33 |
| Zara | I was typing when you posted your reply, hehe | 14:34 |
| Zara | think we agree on it, anyway | 14:34 |
| pedroalvarez | I don't mind. I'm not a maintainer here :P | 14:34 |
| Zara | yeah, but you have experience of these things, so if you dislike an approach, I think it's worth listening to you! | 14:35 |
| Zara | anyway, I think this wins for the most convoluted path to applying a 5 line html patch ever | 14:38 |
| Zara | GET WELL SOON SOTK. | 14:38 |
| Zara | it's quicker if we merge the patches as they are, downside is if mine needs a rebase anyway there could be a gap between them. currently thinking it's better to just wait a day for sotk to get back. if he's ill tomorrow as well then I'll merge them as they are. | 14:42 |
| pedroalvarez | I still think gerrit should let you fix up the patch | 14:43 |
| pedroalvarez | well, it might be configured to not let you do that, but looks weird to me | 14:43 |
| Zara | tbf, it might not be gerrit; I got a lot of error messages to do with git rebase and then my changes all disappeared until I aborted the rebase. I just thought the patch was too small to be worth untangling the mysteries of git this time | 14:45 |
| persia | I have seen cases where a patch is updated by someone not the owner elsewhere in review.o.o | 14:51 |
| persia | Generally it involves collapsing the update and the original change into a single change, and then using git-review with the same change-id | 14:52 |
| Zara | probably-definitely me, then, since I left my commit as a separate one so it was easy to distinguish them. | 15:01 |
| *** mrmartin has quit IRC | 15:07 | |
| *** jtomasek has quit IRC | 15:20 | |
| *** jtomasek has joined #storyboard | 15:25 | |
| *** mrmartin has joined #storyboard | 17:13 | |
| *** mrmartin has quit IRC | 17:23 | |
| *** mrmartin has joined #storyboard | 17:33 | |
| *** yarkot has joined #storyboard | 17:53 | |
| pedroalvarez | do we have merge powers for https://review.openstack.org/#/c/263304/ ? | 17:54 |
| Zara | infra root do, I think. storyboard cores don't. | 18:04 |
| *** mrmartin has quit IRC | 18:04 | |
| pedroalvarez | I see, then we will have to poke someone else :) | 18:06 |
| pedroalvarez | Which I think it's fair | 18:06 |
| Zara | yeah, I should have poked over the last couple of days; have refrained because it's not my patch and I didn't want the awkward situation where someone asked about the patch and I couldn't answer the question | 18:07 |
| *** mrmartin has joined #storyboard | 18:28 | |
| *** mrmartin has quit IRC | 18:37 | |
| *** mrmartin has joined #storyboard | 19:15 | |
| *** mrmartin has quit IRC | 19:22 | |
| *** yarkot has quit IRC | 19:31 | |
| *** yarkot has joined #storyboard | 19:31 | |
| *** jjardon_ has joined #storyboard | 19:38 | |
| *** jjardon has quit IRC | 19:38 | |
| *** jjardon_ is now known as jjardon | 19:44 | |
| *** openstackgerrit has quit IRC | 20:23 | |
| *** openstackgerrit has joined #storyboard | 20:25 | |
| *** mrmartin has joined #storyboard | 21:34 | |
| *** mrmartin has quit IRC | 21:39 | |
| *** jtomasek has quit IRC | 22:45 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!