| *** mrmartin has joined #storyboard | 05:58 | |
| *** mrmartin has quit IRC | 06:09 | |
| *** mrmartin has joined #storyboard | 07:49 | |
| Zara | morning, storyboard! | 10:11 |
|---|---|---|
| * pedroalvarez waves | 10:12 | |
| Zara | yeah, I was using <pre> because I didn't know markdown well enough to get roughly the same layout without <pre> | 10:12 |
| pedroalvarez | I think that wiki is not in markdown, though | 10:12 |
| Zara | ah, well that makes it even better! \o/ | 10:13 |
| pedroalvarez | Looks like mediawiki format | 10:13 |
| Zara | I'll try to learn more html-for-formatting-purposes, then. | 10:14 |
| pedroalvarez | If the goal is to write markdonw so that it can go to a story later, I guess is ok | 10:15 |
| Zara | in general it seems like people put roadmaps on wiki pages, so I've been going by that so far; we could link to a story from the wiki instead, though we'll need to merge the preview button for descriptions patch first | 10:20 |
| SotK | good morning! | 10:39 |
| * SotK decides how to smoothly transition from object to array | 10:46 | |
| Zara | turn it into a string and then hackily change all the relevant punctuation with a regexp? =P | 10:48 |
| SotK | try to get it with isArray: true, but then fallback onto the old method if that fails | 10:50 |
| SotK | hopefully that works neatly and I don't have to manually detect failure | 10:50 |
| SotK | of course that didn't work, hooray | 10:56 |
| Zara | \o/ | 10:58 |
| Zara | I'm a bit confused about what you want as the array; the whole object or just the keys or the values? | 10:59 |
| SotK | at the moment the API just sends an object like `{ edit_board: true, move_cards: true }`, but the permissions patch changes it so that it sends an array containing all of the permissions set for the user on the relevant board, so something like `["edit_board", "move_cards"]` | 11:11 |
| SotK | and $resource needs to know whether the result of GETs will be an object or an array for some reason, and errors if it gets an unexpected result | 11:12 |
| Zara | oh, so you'd want to put the object key in an array, but only if the key had the value 'true' in the object? | 11:15 |
| SotK | pretty much, the object was a bit hacky anyway since it just got those two keys set to true if the current user was the creator of the board/worklist | 11:16 |
| Zara | eg: `{edit_board: true, move_cards: true, take_over_the_world: false}` would be `['edit_board', 'move_cards']` | 11:17 |
| SotK | argh, shoving it in a try ... catch block didn't work either | 11:31 |
| Zara | would anyone be able to see if my reverse default order patch works for recentevents on the dash? | 11:38 |
| * SotK makes the fallback work | 11:45 | |
| SotK | I'll send patches once I've eaten | 11:45 |
| SotK | and then test the reverse default order patch :) | 11:45 |
| Zara | :D | 11:46 |
| Zara | just looked at resource wrappers update, seems to break with old db (which makes sense) but the dependency wasn't explicit so workflow -1 for now | 11:47 |
| SotK | yeah, the patch I've half-made should make it work with both | 11:47 |
| Zara | :) | 11:47 |
| Zara | oh, turns out I was also using the wrong db version, gah | 12:01 |
| Zara | (50. which is awkward because downgrading to 49 doesn't work.) | 12:04 |
| SotK | the downgrade works in the new version of that patch :) | 12:32 |
| *** openstackgerrit has quit IRC | 12:32 | |
| Zara | ahahaha | 12:32 |
| Zara | maybe I still have the old version checked out then, gahhhh | 12:33 |
| *** openstackgerrit has joined #storyboard | 12:33 | |
| Zara | aaand I do | 12:34 |
| Zara | still getting errors | 12:35 |
| Zara | I wonder if it's like last time | 12:35 |
| Zara | and it's becuase I did stuff in the UI before upgrading/downgrading appropriately | 12:35 |
| SotK | have you already tried running it and had a failure? | 12:35 |
| Zara | the downgrade? yeah | 12:35 |
| Zara | sqlalchemy.exc.InternalError: (InternalError) (1060, u"Duplicate column name 'permission_id'") 'ALTER TABLE worklists ADD COLUMN permission_id INTEGER(11)' () | 12:35 |
| Zara | ERROR: InvocationError: '/home/ubuntu/storyboard/.tox/venv/bin/storyboard-db-manage --config-file ./etc/storyboard.conf downgrade 049' | 12:35 |
| Zara | ______________________________________________________________________ summary _______________________________________________________________________ | 12:35 |
| Zara | ERROR: venv: commands failed | 12:35 |
| SotK | yeah, you'll need to clean up manually I'm afraid | 12:36 |
| Zara | \o/ | 12:36 |
| SotK | `delete from user_permissions;`, `drop table board_permissions;`, `drop table worklist_permissions;`, `delete from permissions`, `update alembic_version set version_num="049";` should do the trick I think | 12:39 |
| Zara | hah, I just finished scrolling up to yesterday's notes, but thanks! | 12:40 |
| SotK | heh | 12:40 |
| Zara | yay, worked | 12:41 |
| SotK | oh dear. I've just noticed that worklists don't use their permissions API yet, so you can attempt to drag other people's worklist contents... | 13:17 |
| *** openstackgerrit has quit IRC | 13:17 | |
| SotK | the result will be a screen full of errors, but it's a bit annoying | 13:17 |
| SotK | it does however mean there is no code to fix for them to switch to using an array | 13:17 |
| *** openstackgerrit has joined #storyboard | 13:18 | |
| openstackgerrit | Adam Coldrick proposed openstack-infra/storyboard-webclient: Update $resource wrappers to use new permissions API https://review.openstack.org/235475 | 13:24 |
| *** jjardon has quit IRC | 14:07 | |
| *** jjardon has joined #storyboard | 14:08 | |
| openstackgerrit | Adam Coldrick proposed openstack-infra/storyboard-webclient: Update $resource wrappers to use new permissions API https://review.openstack.org/235475 | 14:14 |
| openstackgerrit | Adam Coldrick proposed openstack-infra/storyboard-webclient: Add UI for complex permissions on boards and worklists https://review.openstack.org/235476 | 14:14 |
| * SotK points out we also need to merge https://review.openstack.org/#/c/251970/ in order to have working preferences again :) | 14:22 | |
| Zara | ah, nice spot, sorry missed it | 14:22 |
| Zara | I can't easily test if it works; are there other patches it'd be better for me to look at at this point (ie: is the permissions stuff still wip or ready for me to peer at?) | 14:23 |
| Zara | I've left it alone so far this afternoon | 14:24 |
| SotK | you can look at it now :) | 14:24 |
| Zara | \o/ | 14:24 |
| SotK | but it would be good if you could review https://review.openstack.org/#/c/251970/ first I think | 14:24 |
| SotK | (I appreciate it is tough to test if you can't reproduce the duplicate thing, but you can just check it doesn't ruin your preferences table or something) | 14:26 |
| Zara | yeah, that's the thing, I can test it doesn't break things but I wouldn't merge it until someone had tested it against the issue. Happy to take a look, though. | 14:27 |
| * SotK hopes pedro can test it sometime soon | 14:27 | |
| SotK | I've tested it on storyboard.sotk.co.uk against the real db and it seemed to work fine | 14:27 |
| SotK | the permissions patches need to be merged in order btw: https://review.openstack.org/#/c/235475/ first, then https://review.openstack.org/#/c/235472/, then https://review.openstack.org/#/c/235476/4 | 14:28 |
| Zara | That should probably be mentioned in the patches themselves, then | 14:29 |
| Zara | (sorry if it is, didn't see it but could've just missed it) | 14:29 |
| * SotK leaves a -1 workflow on the second one as well as just the last one | 14:33 | |
| Zara | hehe | 14:35 |
| openstackgerrit | Merged openstack-infra/storyboard-webclient: Don't save default preference values https://review.openstack.org/252350 | 14:35 |
| Zara | -1 all the things \o/ | 14:36 |
| Zara | my tables seem normal | 14:45 |
| Zara | not totally sure what I'd be looking for, but I don't spot anything amiss | 14:46 |
| Zara | I do note it mentions 'tags added' and 'tags deleted' but there's no checkbox; might've mentioned that yesterday | 14:46 |
| SotK | yeah, I think pedroalvarez was going to add checkboxes for them | 14:46 |
| Zara | rings a bell | 14:46 |
| SotK | mostly you should just check that the preferences got set how you wanted them to be | 14:47 |
| SotK | and not "ALL FALSE" or something | 14:47 |
| Zara | seems fine | 14:49 |
| SotK | Zara: your reverse order patch does not affect Recent Events | 14:52 |
| Zara | bah, annoying, I was hoping | 14:52 |
| SotK | however, it is amazing for the lists | 14:52 |
| Zara | would've been too convenient. xD | 14:53 |
| Zara | I wish it worked for updated at before created_at, but I think it's because it's tied to IDs | 14:53 |
| Zara | which happen to overlap with created_at, but not updated_at | 14:53 |
| Zara | so yeah, I'd like sb to go 'most recently updated', then 'most recently created' for items that haven't been updated (and actually track when things are updated in a sensible way) | 14:54 |
| Zara | but oh well | 14:54 |
| SotK | hmm, you could change $scope.sortField to 'updated_at' instead of 'id' I'd imagine | 14:54 |
| SotK | but most things have updated_at == Null, so it wouldn't be particularly sorted | 14:55 |
| * SotK reads what Zara just wrote | 14:55 | |
| pedroalvarez | yes, I plan to add checkboxes for the tags events, I'm okay if the default is set to false in the meantime | 14:55 |
| pedroalvarez | (blank events appear otherwise) | 14:56 |
| Zara | SotK: heheh | 14:56 |
| Zara | yeah, once updates work sensbily it'd make sense to try to do it that way, I think | 14:56 |
| *** mrmartin has quit IRC | 15:16 | |
| Zara | *sensibly | 15:25 |
| Zara | spelling correction, half an hour later | 15:25 |
| * SotK gets to the bottom of the trouble with https://review.openstack.org/#/c/235993/ | 16:12 | |
| * SotK tidies up the project groups module.js to fix it :) | 16:12 | |
| Zara | heh, please! I thought it was probably my code, given the project groups have caused a few weird things :/ | 16:13 |
| openstackgerrit | Pedro Alvarez Piedehierro proposed openstack-infra/storyboard: RFC: Add story_title to tag events. https://review.openstack.org/251566 | 16:17 |
| SotK | how attached are we to the edit and delete buttons on the project group list items? | 16:22 |
| Zara | I think they need to be somewhere, but they look awful | 16:24 |
| SotK | is it enough for them to be on the project group detail pages? | 16:25 |
| Zara | It would be more consistent. personally I dislike having to click two different things to get onto a detail page to delete any resource (and one at a time!) but it would look nicer | 16:26 |
| * SotK will make them go away from the list page for now then :) | 16:28 | |
| Zara | I'm not sure there is a 'delete' button on the detail page for them | 16:28 |
| Zara | but I don't think deleting works anyway for project groups | 16:28 |
| Zara | really, I'd like little buttons like those on all the list pages, but that looked good, somehow. I can't visualise how to do that, and that's why I'm not a UX person at heart. | 16:29 |
| Zara | in general I want the convenience of being able to edit a bunch of resources at once from the webclient, seems to be a theme with me | 16:29 |
| * SotK finds the current edit button for project groups anything but convenient :) | 16:30 | |
| SotK | I'd like to be able to edit things in place like tasks in stories | 16:30 |
| SotK | but that is a job for a different day! | 16:30 |
| openstackgerrit | Adam Coldrick proposed openstack-infra/storyboard-webclient: Tidy up project groups states https://review.openstack.org/253049 | 16:31 |
| Zara | :) | 16:31 |
| SotK | gah, I have to resubmit that if I want to submit something that depends on it, whaaat | 16:32 |
| openstackgerrit | Adam Coldrick proposed openstack-infra/storyboard-webclient: Add an "Unlimited" option to the paging controls https://review.openstack.org/235993 | 16:32 |
| Zara | yeah, it's in a stupid place because it's between (and too close to) 'delete' and 'subscribe', but I like the idea of having it in the list view at some point. | 16:33 |
| SotK | ah good, it didn't actually resubmit the other change | 16:33 |
| SotK | it just said it would | 16:33 |
| Zara | haha | 16:33 |
| * SotK claps gerrit | 16:33 | |
| SotK | maybe s/gerrit/git review/ | 16:33 |
| Zara | first permissions patch seems fine btw, though I noticed there's no way to make worklists private from the edit button on the worklist detail page | 16:33 |
| Zara | that I could find, anyway | 16:34 |
| SotK | Zara: indeed, thankfully the delete button asks for confirmation and probably doesn't work | 16:34 |
| SotK | ah hm, I hope I add that in the last patch | 16:34 |
| Zara | for project groups? it doesn't work | 16:35 |
| Zara | because you can only delete an empty group | 16:35 |
| Zara | and you can't make a group empty | 16:35 |
| Zara | because you can't have a group with no projects | 16:35 |
| SotK | \o/ | 16:35 |
| Zara | there's a story for that one, somewhere | 16:35 |
| Zara | yeah, 'private' comes up in the new worklist modal, but not for the edit worklist page | 16:36 |
| Zara | it's there for boards, though | 16:36 |
| SotK | its because of the terrible UI I created for editing worklists :) | 16:36 |
| Zara | hehehe | 16:36 |
| Zara | oh yeah, the archive button still doesn't give the user an indication the worklist has been archived | 16:37 |
| Zara | mentioned it before but it might've been forgotten :P | 16:37 |
| SotK | oops | 16:38 |
| * SotK makes the UI less terrible in https://review.openstack.org/#/c/235476/4 but still doesn't add a checkbox, I'll update :) | 16:38 | |
| SotK | what kind of indication would be good? | 16:38 |
| Zara | probably going back to the worklist/boards list page | 16:39 |
| Zara | so user can see it's not listed | 16:39 |
| SotK | sounds good | 16:39 |
| Zara | also needs to be some way to retrieve things from an archive, I think, not sure where that'd go. | 16:39 |
| SotK | I should probably make a way to unarchive them | 16:39 |
| Zara | snap | 16:39 |
| Zara | xD | 16:39 |
| Zara | I need to fix my db at some point so that fulltext works for users | 16:49 |
| Zara | I think I went home before I did that and then forgot about it | 16:49 |
| pedroalvarez | ALTER TABLE users ADD FULLTEXT INDEX users_fti (full_name, email); ? | 16:53 |
| SotK | sounds about right | 16:53 |
| pedroalvarez | (I have that noted as a migration step for whenever I move my database to somewhere that supports fulltext :) | 16:53 |
| Zara | yeah, I think I did it for the other tables and forgot users for some reason xD | 16:54 |
| SotK | pedroalvarez: oh, I was thinking about that... | 16:54 |
| *** betherly has quit IRC | 16:55 | |
| *** betherly has joined #storyboard | 16:56 | |
| SotK | can you take a dump of your mariadb database, restore it into a mysql database, run the migrations against that, then take a dump of that and overwrite the original db with the new dump? | 16:56 |
| SotK | although that assumes that the only difference between mariadb and mysql is the version reporting | 16:56 |
| pedroalvarez | well, I gave up trying to get a mariadb instance that supports fulltext.. | 16:57 |
| Zara | oh, there's a reason we're not using that template for project groups as-is | 16:58 |
| Zara | it's because it doesn't list the projects in the groups | 16:58 |
| SotK | pedroalvarez: ah, that plan won't help then :/ | 16:59 |
| Zara | and given the project groups exist *solely* to group projects together, it's kind of useless not to have that info there. | 16:59 |
| pedroalvarez | SotK: but yeah, what you said would work. although the migration scripts needed to add the fulltext indexes won't run | 16:59 |
| Zara | I think we need a button to hide/collapse projects in a group, but I want that information to stay visible on the list page | 16:59 |
| pedroalvarez | but don't worry about that :) | 16:59 |
| SotK | Zara: I'll add it back then :) | 17:00 |
| SotK | along with a button to show/hide them | 17:00 |
| * SotK thinks https://storyboard.openstack.org/#!/project_group/list is crazy at the moment | 17:00 | |
| Zara | yeah, I think it's actually more *useful* than it was, but it looks bad | 17:01 |
| Zara | I was expecting fewer projects per group, and more groups... | 17:01 |
| Zara | cool :) but yeah, with projects, they have loads of stories, so it's not practical to show them on the list page-- and stories have descriptions, anyway. | 17:01 |
| Zara | and people use projects as a quick way to filter stories that they're interested in. but imo people don't use groups as a filter in the same way; they use them more to see what's grouped where. | 17:03 |
| Zara | so that was the reasoning, anyway. | 17:03 |
| * SotK uses the storyboard project group as a filter | 17:04 | |
| Zara | hah, maybe the issue is with how things are currently grouped rather than groups themselves | 17:05 |
| Zara | I can't see how anyone can usefully use openstack-ci as a filter right now, for example. | 17:05 |
| SotK | I agree with that :) | 17:07 |
| SotK | oh dear, archiving worklists is very broken | 17:10 |
| Zara | ~o~ | 17:12 |
| * SotK was very silly when he wrote that code | 17:12 | |
| SotK | might only be broken with the permissions patch I think | 17:15 |
| Zara | hah | 17:16 |
| SotK | yep, just broken with the permissions patch, I'll send a new version | 17:22 |
| openstackgerrit | Pedro Alvarez Piedehierro proposed openstack-infra/storyboard: RFC: Add story_title to tag events. https://review.openstack.org/251566 | 17:25 |
| *** cody-somerville has quit IRC | 17:29 | |
| openstackgerrit | Adam Coldrick proposed openstack-infra/storyboard-webclient: Add UI for complex permissions on boards and worklists https://review.openstack.org/235476 | 17:29 |
| openstackgerrit | Adam Coldrick proposed openstack-infra/storyboard: Implement complex permissions for worklists and boards https://review.openstack.org/235472 | 17:38 |
| SotK | fixed! | 17:38 |
| SotK | also fixed the redirect to dashboard and added a way to make worklists private on the edit screen in https://review.openstack.org/235476 | 17:39 |
| *** mrmartin has joined #storyboard | 17:42 | |
| openstackgerrit | Pedro Alvarez Piedehierro proposed openstack-infra/storyboard: RFC: Add story_title to tag events. https://review.openstack.org/251566 | 17:55 |
| pedroalvarez | I hoped the 79 chars limit wasn't in use here :) | 17:56 |
| SotK | afraid so :) | 17:56 |
| openstackgerrit | Pedro Alvarez Piedehierro proposed openstack-infra/storyboard: RFC: Add story_title to tag events. https://review.openstack.org/251566 | 17:56 |
| pedroalvarez | so much noise, sorry | 17:56 |
| pedroalvarez | I should learn how to run the tests locally | 17:57 |
| SotK | the pep8 tests are easy to run | 17:57 |
| SotK | `tox -e pep8` | 17:57 |
| SotK | the other ones "should" be easy too, but I haven't successfully run them except in the vm that results from doing `vagrant up` | 17:58 |
| SotK | (with `tox -e py27` and `tox -e py34` | 17:58 |
| SotK | ) | 17:58 |
| pedroalvarez | pep8: commands succeeded | 17:59 |
| pedroalvarez | congratulations :) | 17:59 |
| * SotK will resend the project_groups thing in the morning :) | 18:11 | |
| SotK | night o/ | 18:11 |
| Zara | cool, s'fine :) | 18:12 |
| Zara | night! | 18:12 |
| Zara | I'm off, too, night-night, storyborad | 18:24 |
| Zara | erm, storyboard | 18:25 |
| Zara | I can spell your name, little storyboard, honest. | 18:25 |
| *** cody-somerville has joined #storyboard | 19:05 | |
| *** cody-somerville has quit IRC | 19:05 | |
| *** cody-somerville has joined #storyboard | 19:05 | |
| *** mrmartin has quit IRC | 19:48 | |
| *** openstackgerrit has quit IRC | 20:47 | |
| *** openstackgerrit has joined #storyboard | 20:48 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!