| *** openstackstatus has quit IRC | 00:24 | |
| *** openstackstatus has joined #storyboard | 00:26 | |
| *** ChanServ sets mode: +v openstackstatus | 00:26 | |
| openstackgerrit | Pedro Alvarez Piedehierro proposed openstack-infra/storyboard-webclient: RFC: Add tag/untag story to dashboard events. https://review.openstack.org/251605 | 01:16 |
|---|---|---|
| *** openstackgerrit has quit IRC | 01:22 | |
| *** openstackgerrit has joined #storyboard | 01:22 | |
| *** mrmartin has joined #storyboard | 06:04 | |
| *** mrmartin has quit IRC | 06:43 | |
| *** coolsvap has quit IRC | 08:09 | |
| *** mrmartin has joined #storyboard | 08:37 | |
| *** coolsvap has joined #storyboard | 09:04 | |
| *** wuhg has joined #storyboard | 10:09 | |
| *** wuhg has left #storyboard | 10:11 | |
| pedroalvarez | I looked yesterday at the forth task listed here (https://storyboard.openstack.org/#!/story/2000435) and given that it works on my really old instane of storyboard (Baserock one) I guess there was a regression at some point | 12:11 |
| pedroalvarez | I'll try to find out this evening :) | 12:14 |
| Zara | hahaha, just saw the comments there :P (and thanks!) | 12:16 |
| Zara | I wanted to go further without checking with others. | 12:16 |
| Zara | ^ good plan, +12 :P | 12:16 |
| SotK | pedroalvarez: the patches seem sensible to me, and work fine | 12:22 |
| pedroalvarez | note that I was talking about '"task_assignee_changed" event is not being used when changing assignee' | 12:30 |
| pedroalvarez | for the patches sent, I mostly think they are not ready because for old subscription_events we won't have story_title | 12:30 |
| pedroalvarez | Zara: hehe yeah, that was me doing English a bit late | 12:38 |
| Zara | :) I think it improved it. :P | 12:40 |
| Zara | wow, two emoticons in one sentence; somebody stop me. | 12:40 |
| Zara | I can't be trusted with punctuation marks. | 12:41 |
| SotK | pedroalvarez: it should be fairly easy to write a migration to fix that if you feel like it | 13:05 |
| pedroalvarez | it should! I'll try | 13:07 |
| SotK | in other news, preferences don't appear to be broken on my test instance | 13:08 |
| *** mase_x200 has joined #storyboard | 13:08 | |
| Zara | \o/ | 13:09 |
| SotK | this is going to be tough to debug without access to the box I suspect, I'll ask in -infra | 13:10 |
| SotK | hmm, I can reproduce it for a single preference locally | 13:16 |
| * SotK thinks that the boolean preferences patch is probably to blame | 13:17 | |
| Zara | :S | 13:17 |
| *** persia has joined #storyboard | 13:18 | |
| SotK | I suggest we revert that patch | 13:19 |
| SotK | (sorry for the messy history it will cause) | 13:19 |
| Zara | I'm looking at it now; the logic seemed fine to me so is there something else misbehaving with it that's causing the issue? | 13:20 |
| Zara | or have we missed something obvious in that patch :/ | 13:21 |
| Zara | I guess there's nothing for if not pref and value is none | 13:21 |
| SotK | I'm not entirely sure, but I don't think anything else has touched preferences since they were last working | 13:22 |
| Zara | (whereas previously that would've been covered by the second bit edited.) | 13:22 |
| SotK | `if not pref and value is None` should do nothing (doesn't exist, and nothing to create) | 13:22 |
| Zara | right, whereas I'm guessing that before it would have been doing the code under 'if not pref and value' (otherwise why is the 'is not None' needed there at all?) | 13:23 |
| SotK | nope, because in conditions `None` evaluates to `False` | 13:24 |
| SotK | the `is not None` was added because if the `value == False` then there is a preference that should be added (whatever preference it is, set to False) | 13:25 |
| SotK | so `value is not None` is True for all cases except a deliberately unset preference | 13:26 |
| SotK | the preference that is broken on my test instance has somehow ended up with its value set to `True`, and is now refusing to update | 13:27 |
| Zara | I'm trying to work out how that patch would result in that, seems really weird. | 13:33 |
| SotK | its very weird | 13:34 |
| SotK | I think the issue in storyboard.o.o is different though, since the values all still appear to be text | 13:35 |
| Zara | (the pref.cast_value updates to match the value as long as there is a preference and the value is not none. if the value is none, the preference is deleted.) that seems fine for a case where something has its value set to true, which is the area where things are going weird on your instance. gah. | 13:36 |
| Zara | so either there's something going wrong with the preference being deleted, or for some reason it's not being picked up as 'none' when it should be | 13:38 |
| Zara | the text thing would suggest the latter at a guess | 13:38 |
| *** mrmartin has quit IRC | 13:39 | |
| Zara | (but that's just a guess. I'm wary of reverting unless we're sure it's that patch, since we might end up having to revert and then replace a few if it's not.) | 13:39 |
| * SotK isn't sure what other patch it could possibly be :/ | 13:40 | |
| SotK | I'll investigate some more | 13:40 |
| Zara | okay. I did have issues setting preferences with a different patch that you submitted, so that might hold a clue. | 13:41 |
| Zara | well, unsetting preferences. | 13:41 |
| Zara | (it was the plugin email one: https://review.openstack.org/#/c/241665/) | 13:42 |
| SotK | are the rest of the preferences working on your test instance? | 13:45 |
| Zara | as far as I could tell, I should check more thoroughly now | 13:45 |
| Zara | ooh, but that might have been before pulling latest from master | 13:47 |
| Zara | so if it's broken now, that'll be some corroboration | 13:47 |
| pedroalvarez | git bisect! \o/ | 13:48 |
| Zara | they still seem fine for me. just to check, are these user preferences in profile? | 13:48 |
| SotK | yeah | 13:48 |
| Zara | they work fine for me, both storyboard and storyboard-webclient pulled from master | 13:48 |
| pedroalvarez | They don't work for me | 13:49 |
| Zara | ooh, hang on | 13:49 |
| Zara | just rebased, now they're broken | 13:49 |
| Zara | \o/ | 13:49 |
| SotK | gah, why are they working for me?! | 13:49 |
| Zara | and now they're not | 13:50 |
| Zara | wat | 13:50 |
| Zara | I think I refreshed the page too fast before | 13:50 |
| Zara | they seem fine again. | 13:50 |
| Zara | are we just checking that the boxes display accurately, or are you using some other method to see if they work? | 13:51 |
| SotK | I was looking at the response to the POST request using Chrome's debugging tools | 13:52 |
| SotK | and checking it matches the data sent in the request | 13:52 |
| SotK | also by refreshing the page and checking the boxes were how I left them | 13:52 |
| Zara | okay, mine might still be buggy with a UX that's working as expected, I'll have a look. | 13:52 |
| Zara | ... my request looks fine, as far as I can tell | 13:55 |
| Zara | weirdly it mentions tags added as being set to 'true', but there's no box for that (maybe it comes under 'story details changed'? | 13:58 |
| * pedroalvarez needs to implement that box too | 13:59 | |
| Zara | hm, and the page size for projects and stories for project groups are set to '10', but there's no way to change it yet. | 13:59 |
| SotK | you can change that on the relevant pages | 14:00 |
| SotK | I don't know how to represent that nicely in the preferences UIO | 14:00 |
| SotK | -O | 14:00 |
| Zara | yeah, I don't think it changes it permanently, iirc? | 14:00 |
| SotK | it should do | 14:00 |
| Zara | hm, I thought i made a story; seems to work in my instance so maybe it was another thing that was strange on storyboard.openstack.org... or I'm imagining things | 14:01 |
| Zara | ah, yeah, I added tasks for it in API paging | 14:02 |
| SotK | probably didn't work on storyboard.o.o because of the preferences being broken on there :P | 14:02 |
| Zara | yup, that's what I was thinking. it seems fine on my test instance. | 14:03 |
| Zara | whyyyyy are they different | 14:03 |
| SotK | does anyone care about the data on storyboard.sotk.co.uk? | 14:10 |
| paulsherwood | not me | 14:12 |
| Zara | nope | 14:12 |
| * SotK backs it up prior to potential obliteration to be on the safe side | 14:13 | |
| Zara | I just lose some strangely named demo worklists and boards | 14:13 |
| Zara | in general I like the strange little test stories that have popped up on there, but there's nothing essential. | 14:13 |
| SotK | database appears to have survived upgrading mysql, s'all good :) | 14:14 |
| Zara | \o/ | 14:17 |
| *** mase_x200 has quit IRC | 14:36 | |
| SotK | hooray, preferences are broken on storyboard.sotk.co.uk (which is now using a dump of the production db) | 14:53 |
| * SotK has a place to debug! | 14:53 | |
| Zara | yay! | 14:53 |
| SotK | oh dear, it looks like the db is full of duplicate preference records | 15:04 |
| SotK | this makes no sense | 15:09 |
| SotK | eg: my preferences http://paste.baserock.org/uponigexif | 15:10 |
| *** mrmartin has joined #storyboard | 15:11 | |
| pedroalvarez | wow | 15:12 |
| SotK | that explains why it's broken at least, but I don't know how best to fix it | 15:14 |
| * SotK tries blowing away his preferences so they get recreated | 15:14 | |
| Zara | oh wait those were your latest preferences?! I thought just some strange things had happened on the 25th of june. well, I guess those aren't mutually exclusive | 15:16 |
| SotK | the recreated ones are sensible | 15:16 |
| SotK | indeed, that was every preference stored in the db related to my user id | 15:17 |
| SotK | so they weren't working properly because there were multiple of the same record, so there was no guarantee you'd change the right one | 15:18 |
| pedroalvarez | My db has the same issues as far I can tell: http://paste.baserock.org/lawilubena | 15:21 |
| SotK | ouch, looks like it | 15:22 |
| SotK | even the newest users in the prod db have the same issue | 15:22 |
| SotK | so I don't think it's fixed | 15:23 |
| *** mrmartin has quit IRC | 15:24 | |
| pedroalvarez | make the key (id , user_id, key) ? | 15:25 |
| pedroalvarez | I'm not sure about what I just said, but who knows | 15:25 |
| * SotK is very confused as to why it happens in the production db but not his test db | 15:26 | |
| * SotK wonders if it is happening in Zara's db or not | 15:31 | |
| Zara | I should check... | 15:33 |
| *** mrmartin has joined #storyboard | 15:33 | |
| Zara | (sorry, got distracted by an email about a flat; bit all over the place today.) | 15:34 |
| SotK | no problem :) | 15:35 |
| Zara | http://paste.baserock.org/obivucayot | 15:36 |
| SotK | whaaaat | 15:37 |
| Zara | mine's tiny! | 15:37 |
| SotK | still has some duplicates though :/ | 15:38 |
| * pedroalvarez sees 2 different user_ids | 15:38 | |
| SotK | oh yeah, ignore me :) | 15:39 |
| Zara | yeah | 15:39 |
| Zara | ahahahaha | 15:39 |
| Zara | I get weird 500 errors when I search for things, that mention users and fulltext, so I don't think I updated that bit right. that's one difference between my db and master. | 15:40 |
| * SotK wonders how the machine that pedroalvarez's paste is from was set up | 15:40 | |
| pedroalvarez | using my ansible role :) | 15:40 |
| SotK | pedroalvarez: any chance you could paste the log of a user accessing the preferences page for the first time? | 15:42 |
| pedroalvarez | tell me how to generate that log | 15:43 |
| pedroalvarez | hang on.. my database is not fresh, it has all the data in this old instance we have in Baserock | 15:44 |
| pedroalvarez | sorry | 15:46 |
| pedroalvarez | so it probably works, but the database in production for any storyboard instance is wrong | 15:47 |
| Zara | why is mine the only one that mentions plugin_email_enable? | 15:50 |
| SotK | because we didn't merge the UI for setting that in production yet :) | 15:51 |
| *** mrmartin has quit IRC | 15:52 | |
| SotK | pedroalvarez: add some more detail like http://paste.baserock.org/lasomireza and then either create a new user and go to the preferences page as that user, or delete the preferences db records for an existing one and go to the preferences page with that user | 15:52 |
| * SotK is worried, because http://paste.baserock.org/qiyofoxiji suggests to him that it is still broken | 15:53 | |
| * pedroalvarez will provide logs | 16:04 | |
| SotK | thank you pedroalvarez :) | 16:04 |
| pedroalvarez | no problem! I'll help whenever possible | 16:06 |
| pedroalvarez | I wonder if you want that log with a clean database or with the dumped (and "corrupted") one | 16:07 |
| SotK | the dumped one is probably best | 16:08 |
| Zara | okay, I'm off to see a guy about a flat. should be around later tonight. | 16:11 |
| Zara | night-for-now | 16:11 |
| SotK | night | 16:11 |
| openstackgerrit | Adam Coldrick proposed openstack-infra/storyboard-webclient: Add a dashboard page for boards and worklists https://review.openstack.org/231973 | 16:41 |
| openstackgerrit | Adam Coldrick proposed openstack-infra/storyboard-webclient: Update $resource wrappers to use new permissions API https://review.openstack.org/235475 | 16:41 |
| openstackgerrit | Adam Coldrick proposed openstack-infra/storyboard-webclient: Add UI for complex permissions on boards and worklists https://review.openstack.org/235476 | 16:41 |
| pedroalvarez | I ended up being a bit busy today sorry | 16:42 |
| openstackgerrit | Merged openstack-infra/storyboard-webclient: Align story subscription stars on right https://review.openstack.org/250417 | 16:42 |
| SotK | no problem :) | 16:43 |
| * SotK writes a thing to work around the problem until we can figure out how best to fix it | 16:46 | |
| openstackgerrit | Adam Coldrick proposed openstack-infra/storyboard: Work around "duplicate preferences" issue https://review.openstack.org/251970 | 17:00 |
| SotK | that should "fix" the preferences on storyboard.o.o | 17:01 |
| SotK | (by updating all of the duplicated preferences rather than just one of them) | 17:02 |
| *** mrmartin has joined #storyboard | 17:07 | |
| pedroalvarez | haha | 17:14 |
| *** mrmartin has quit IRC | 17:21 | |
| *** mrmartin has joined #storyboard | 17:22 | |
| openstackgerrit | Adam Coldrick proposed openstack-infra/storyboard-webclient: Add plugin_email_enabled preference by default https://review.openstack.org/241665 | 17:51 |
| openstackgerrit | Adam Coldrick proposed openstack-infra/storyboard-webclient: Fix checkboxes on preferences page https://review.openstack.org/252002 | 17:58 |
| Zara | I return! | 18:43 |
| SotK | hi Zara | 18:43 |
| Zara | hi there | 18:43 |
| openstackgerrit | Adam Coldrick proposed openstack-infra/storyboard-webclient: Add a preview button for story descriptions https://review.openstack.org/252055 | 20:39 |
| SotK | should probably add one on everything else that can be markdown too, but I don't have time right now :) | 20:39 |
| *** mrmartin has quit IRC | 21:50 | |
| *** mase_x200 has joined #storyboard | 21:54 | |
| *** mase_x200 has quit IRC | 22:41 | |
| *** mase_x200 has joined #storyboard | 23:24 | |
| *** mase_x200 has quit IRC | 23:29 | |
| *** mase_x200 has joined #storyboard | 23:34 | |
| *** mase_x200 has quit IRC | 23:40 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!