| *** mrmartin has joined #storyboard | 04:33 | |
| *** mrmartin has quit IRC | 07:46 | |
| *** openstackgerrit has quit IRC | 07:46 | |
| *** openstackgerrit has joined #storyboard | 07:47 | |
| *** mrmartin has joined #storyboard | 08:02 | |
| *** mrmartin has quit IRC | 08:08 | |
| *** pedroalvarez has quit IRC | 08:21 | |
| *** pedroalvarez has joined #storyboard | 08:22 | |
| *** mrmartin has joined #storyboard | 08:23 | |
| *** openstack has joined #storyboard | 09:21 | |
| *** cody-somerville has joined #storyboard | 09:21 | |
| *** openstackstatus has joined #storyboard | 09:23 | |
| *** ChanServ sets mode: +v openstackstatus | 09:23 | |
| *** jtomasek has quit IRC | 09:46 | |
| *** jtomasek has joined #storyboard | 09:48 | |
| Zara | morning, storyboard! | 10:58 |
|---|---|---|
| Zara | I've just asked in infra about the summit. | 11:08 |
| * SotK updates http://185.98.149.23/#!/ to reflect the current state of his worklists/boards patches | 11:39 | |
| Zara | \o/ | 11:43 |
| Zara | I'm wary of looking at it in case I break it | 11:43 |
| * SotK tries out the subscriptions patch and watches the world explode :) | 11:43 | |
| Zara | mwahahaha | 11:43 |
| SotK | it appears to make that 401 bug catastrophic rather than annoying :( | 11:44 |
| Zara | ack :( might be to do with the removal of the if/else for users being logged in? | 11:44 |
| Zara | ah yes, it wasn't doing that before but it is now | 11:45 |
| Zara | gah. | 11:45 |
| SotK | I wonder why it repeats the request.. | 11:46 |
| Zara | yeah | 11:47 |
| Zara | strange, it seems a bit different from what it was doing before | 11:47 |
| Zara | so the service looks for subscriptions that match the currentuser | 11:48 |
| Zara | so either something's going wrong at that step when there isn't one | 11:48 |
| Zara | or something's going wrong after it with whatever it's returning (i'd've thought that would be 'null' or an empty list, so my guess is it's the earlier step where things are going weird) | 11:49 |
| SotK | oh, actually, I wonder if its because StoryBoard redirects to the dashboard when the API returns an error | 11:51 |
| SotK | but when you aren't logged in the dashboard redirects to the project list | 11:51 |
| SotK | which errors, and redirects to the dashboard | 11:52 |
| SotK | ... | 11:52 |
| Zara | aha | 11:52 |
| Zara | ahahaha | 11:52 |
| Zara | thanks for catching it, that sounds plausible | 11:52 |
| SotK | looks like you do need that if statement after all, since apparently you need to be logged in to call the subscriptions api | 11:53 |
| * SotK apologises | 11:53 | |
| Zara | heh, I checked and it seemed like it wasn't necessary so that's my fault too | 11:55 |
| Zara | I'm wondering why it didn't always go weird when I was logged out. | 11:55 |
| Zara | must have been something that changed. :/ | 11:55 |
| Zara | hopefully a straightforward fix in the service, anyway :) | 11:56 |
| Zara | thanks for diagnosing that; would have taken me forever. | 11:56 |
| SotK | no problem :) | 11:57 |
| SotK | hmm, the dashboard looks weird to me too | 11:58 |
| SotK | the rows are extremely wide | 11:58 |
| SotK | ah, I think that is unrelated | 11:58 |
| SotK | indeed it is | 11:59 |
| * SotK files a bug | 11:59 | |
| SotK | hm, actually its probably not worthwhile making a story for | 12:00 |
| Zara | there is a bug re: placement of stars in some of the lists | 12:01 |
| Zara | (I think stories in projects might be an example, will look | 12:01 |
| Zara | they're not pulled right | 12:01 |
| Zara | it seemed to be the case on master so I didn't want to include a fix in this patch | 12:01 |
| Zara | okay, seem to have fixed the apocalypse thing | 12:01 |
| Zara | I do get an error in the web console so there's probably a better way of doing it | 12:02 |
| Zara | I just don't know it :( | 12:02 |
| SotK | all the stars look fine to me | 12:02 |
| Zara | oh, that was it, they're on the left, it's not quite a bug, just a bit inconsistent | 12:04 |
| Zara | just for stories listed within a project, I think | 12:04 |
| Zara | also projects and project group details pages don't have a subscribe button at the top | 12:05 |
| Zara | again, not the end of the world, just inconsistent because stories do | 12:05 |
| Zara | (I'm wary of tweaking this forever when there are more important things.) | 12:05 |
| SotK | yeah, we can fix those some other time I think :) | 12:06 |
| persia | subscription (and unsubscription) to stories is the important part. | 12:06 |
| persia | Subscription to projects and project groups requires UI for negative subscription to stories, which adds complication | 12:07 |
| persia | (I want everything in this project *except* these stories) + (I want everything in this group *except* this project) | 12:07 |
| persia | Absence of negative subscription causes subscriber rage (I've seen this: people actually red and screaming at developers) | 12:07 |
| Zara | I'm actually not sure whether this currently works or not. I was just looking at speeding up the way pages were displayed, and in the process found that the problem lay in the way subscriptions were displayed. | 12:08 |
| openstackgerrit | Zara proposed openstack-infra/storyboard-webclient: Subscriptions https://review.openstack.org/223562 | 12:12 |
| Zara | hopefully the apocalypse is no more. | 12:13 |
| SotK | \o/ | 12:28 |
| Zara | I make no promises | 12:28 |
| SotK | seems fixed! | 12:45 |
| Zara | :0 | 12:50 |
| * SotK suspects that the limit: 100 parameter in the subscriptions browse may cause problems down the line | 12:51 | |
| Zara | I really hope it speeds things up. the openstack storyboard instance is on a much bigger scale than any other instances to hand. | 12:51 |
| Zara | yeah, that's true | 12:51 |
| SotK | specifically if the user is subscribed to more than 100 stories | 12:51 |
| Zara | once people have more than 100 | 12:51 |
| Zara | snap | 12:51 |
| Zara | I think I left that because it was elsewhere, and I thought it might be in there for a reason | 12:52 |
| Zara | but come to think, it might have been because of the paging | 12:52 |
| Zara | or lack thereof, and it's not relevant here. | 12:52 |
| Zara | I'll remove it | 12:52 |
| * SotK is very happy that the stories page now only causes him to do 5 GETs instead of 38! | 12:54 | |
| Zara | yeah, I'm a little concerned that my code in the directive is clumsy and it will take a long time with long lists | 12:54 |
| Zara | albeit less time than a GET for each item | 12:55 |
| SotK | I also don't think you need the `$scope.subscriptions = [];` line in the controllers anymore | 12:55 |
| Zara | ah, I was wondering about that | 12:56 |
| Zara | should have tested before submitting really. | 12:56 |
| * SotK looks at the directive code | 12:59 | |
| Zara | (okay, all seems fine without limit) | 12:59 |
| SotK | Zara: looks OK, but I think `for (foo in bar)` is bad if `bar` is an array in JavaScript | 13:11 |
| * SotK recommends doing something like: http://pastebin.com/nR4MdtbK | 13:11 | |
| * SotK finishes nitpicking :) | 13:12 | |
| openstackgerrit | Zara proposed openstack-infra/storyboard-webclient: Subscriptions https://review.openstack.org/223562 | 13:13 |
| Zara | okay, haven't got round to that yet but current patchset removes the pointless things :) | 13:14 |
| Zara | will take a look at the directive now. | 13:14 |
| SotK | also can you make the commit message title more descriptive than "Subscriptions" by any chance? :) | 13:15 |
| Zara | haha, yes | 13:15 |
| Zara | sorry, that was originally 'subscriptions wip' then I knocked off the 'wip' but forgot to flesh it out | 13:15 |
| Zara | yay, seems to work fine with the directive change you suggested | 13:39 |
| SotK | \o/ | 13:39 |
| * SotK wants to merge the markdown patch but isn't sure whether we can assume that Sam's +1 from the earlier patch still stands | 13:40 | |
| Zara | yeah, I was wondering about that. :( (ooi, why is foreach preferable?) | 13:40 |
| SotK | I think `for (foo in bar)` can do weird things with arrays, instead of just iterating over the contents | 13:41 |
| * SotK looks for an example | 13:41 | |
| SotK | http://stackoverflow.com/a/500531 | 13:42 |
| SotK | And I prefer the angular.forEach(array, callback) syntax nicer than `for (var i; i < array.length; i++) { var thing = array[i]; //do stuff }` syntax | 13:44 |
| Zara | hah, wow, that example is illuminating | 13:44 |
| Zara | bet it's led to many a terrifying bug | 13:44 |
| Zara | ah, I think I still think in C when it comes to control flow, heheh. | 13:45 |
| Zara | but this is an angularjs project and I'd much rather follow the angularjs conventions! | 13:45 |
| Zara | changing commit message title now, 'Subscriptions-- one GET per list' acceptable? | 13:47 |
| Zara | I might as well check in here than submit yet another patch. | 13:47 |
| * SotK would prefer something like "Speed up resolution of subscriptions by doing one GET per list" I think | 13:48 | |
| openstackgerrit | Zara proposed openstack-infra/storyboard-webclient: Resolve subscriptions faster- do one GET per list https://review.openstack.org/223562 | 13:51 |
| SotK | thanks :) | 13:51 |
| Zara | hopefully that's okay; I was wary of it being too long. | 13:51 |
| Zara | argh, tried to fix user-isolation stuff | 14:31 |
| Zara | turned out CurrentUser.id was undefined. still not working. | 14:31 |
| Zara | okay, made a fix, it involves a lot of files and I'm falling asleep so it may wait over the weekend. | 15:27 |
| openstackgerrit | Zara proposed openstack-infra/storyboard-webclient: Resolve subscriptions faster- do one GET per list https://review.openstack.org/223562 | 15:41 |
| Zara | hopefully that worked. | 15:41 |
| Zara | I'm pretty tired, might be forgotten things or even typos; tested it on my instance in my browser but not as thoroughly as I normally would | 15:41 |
| * SotK crosses fingers | 15:41 | |
| *** ChanServ has quit IRC | 17:37 | |
| *** ChanServ has joined #storyboard | 17:40 | |
| *** cameron.freenode.net sets mode: +o ChanServ | 17:40 | |
| *** mrmartin has quit IRC | 21:05 | |
| *** jasondotstar is now known as jasondotstar|afk | 22:48 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!