| *** lifeless has quit IRC | 08:49 | |
| *** lifeless has joined #storyboard | 09:03 | |
| *** jtomasek has quit IRC | 11:46 | |
| *** jtomasek has joined #storyboard | 11:47 | |
| SotK | I'm looking at solving the "lanes bigger than the window" issue at the moment, and was wondering what people would prefer lanes to do. | 13:26 |
|---|---|---|
| SotK | Do you like your lanes to start small and grow to some set size (relative to window size) and then scroll when overflowing, or start at some set size (relative to window size) and fill up, then scroll when overflowing? | 13:27 |
| Zara | I like ones that start small, but it's such a small preference that I'd say go for whatever's easier to implement. | 13:29 |
| SotK | Both are equally easy, that's why I decided to search for opinions :D | 13:31 |
| Zara | hahaha | 13:31 |
| Zara | I think ones that start small might give an instant visual hint of where a project is at, but tbh I'd expect there to soon be so many items in each that they'd all be the same length anyway | 13:32 |
| Zara | which is fewer lines of code/less time to process? | 13:33 |
| persia | Some folk manage to keep lanes small, but it seems to me that lots of folk end up just stuffing lots of things into lists. | 13:34 |
| Zara | hmm, looks like subscribing to projects from their project detail pages was never a thing | 14:08 |
| Zara | or project groups, come to that | 14:08 |
| Zara | got a bit tangled up in services and things; for now have added the code to the bottom of the story_detail_controller and the project_story_list controller | 14:11 |
| Zara | noticed in the process that the story detail controller was already enormous and could probably do with a tidy at some point | 14:11 |
| Zara | aaaand there seems to be a controller for projects in project groups... | 14:12 |
| * Zara goes on a hunt | 14:12 | |
| Zara | gah, it displays both projects and stories from the same controller. | 14:15 |
| Zara | so you can't just pass on a 'subscriptions' object on to the view like you normally would; you'd need a separate one for projects and stories | 14:16 |
| Zara | leading to more code in the directive | 14:16 |
| Zara | urgh. | 14:20 |
| Zara | (hm, though because it seemed to work before, so presumably it passed different resourceIds and so on. time to look at template...) | 14:23 |
| Zara | ahh, okay, it's not as bad as I thought | 14:33 |
| Zara | It just means I can't pass 'subscriptions="subscriptions"' to the template | 14:33 |
| Zara | it has to be 'subscriptions="storysubscriptions" or subscriptions="projectsubscriptions"' | 14:33 |
| Zara | (I tried a quick test with 'stbscriptions' and 'prbscriptions' and it made my eyes bleed but it worked) | 14:35 |
| SotK | ah, yeah, I ended up doing a similar thing for paging those lists | 14:35 |
| Zara | I want to go back at some point and see if I can tidy the controller. | 14:37 |
| Zara | but for now, I want everything working by the end of the week. | 14:37 |
| *** mrmartin has joined #storyboard | 14:47 | |
| openstackgerrit | Zara proposed openstack-infra/storyboard-webclient: Subscriptions WIP https://review.openstack.org/223562 | 15:37 |
| Zara | subscriptions on story detail page should work | 15:38 |
| SotK | \o/ | 15:39 |
| Zara | along with subscriptions for projects and stories listed on project group page | 15:39 |
| Zara | and other places, since there's both story/project *list* and story/project *search* | 15:39 |
| Zara | there's currently a lot of duplicated (or near-duplicated) code | 15:39 |
| Zara | I looked into abstracting with a service, got confused, decided to do it this way first and learned that the added projectgroups complexity would have probably foiled my attempt at that point. | 15:40 |
| Zara | anyway, please take a look in case there are bugs on the user side. at this point I'm tempted to remove the WIP label and go for a 'try to merge first so users get the speed asap, tackle tidying the controllers as a separate patch', but that might set a bad precedent. | 15:48 |
| SotK | I will have a look soon | 15:49 |
| SotK | I don't mind merging it sooner and tidying later if it works | 15:50 |
| SotK | (as long as tidying actually gets done) | 15:50 |
| Zara | :) yeah, I worry that it'll be delayed for a long time given that I got perplexed trying to make it work from a service today; I think I'd need a better grasp of angular. otoh, the danger is that it gets forgotten about and the controllers bloat. | 15:52 |
| Zara | and of course there's also a chance I think it works and it turns out not to. :D | 15:53 |
| openstackgerrit | Zara proposed openstack-infra/storyboard-webclient: Move project group admin and streamline list page https://review.openstack.org/206108 | 16:42 |
| *** mrmartin has quit IRC | 18:01 | |
| *** davidlenwell has quit IRC | 23:57 | |
| *** davidlenwell has joined #storyboard | 23:58 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!