| *** mrmartin has quit IRC | 00:42 | |
| *** cody-somerville has joined #storyboard | 01:02 | |
| *** cody-somerville has quit IRC | 03:12 | |
| *** coolsvap|holiday is now known as coolsvap | 05:28 | |
| *** openstackgerrit has quit IRC | 05:31 | |
| *** openstackgerrit has joined #storyboard | 05:31 | |
| *** mrmartin has joined #storyboard | 05:32 | |
| *** mrmartin has quit IRC | 06:04 | |
| *** mrmartin has joined #storyboard | 06:05 | |
| *** mrmartin has quit IRC | 06:52 | |
| SotK | Zara: I'm reviewing you patch now btw, sorry its not yesterday :/ | 08:39 |
|---|---|---|
| Zara | no worries; I'm so behind with yours they were probably due last year. | 08:40 |
| Zara | I wish I knew enough about other projects to review other stuff; feels cut off here and it seems cheeky asking for reviews when I can't return the favour. | 08:50 |
| SotK | Zara: done! | 09:09 |
| SotK | If my explanations were confusing just ask :) | 09:09 |
| SotK | (and I'll probably give a further confusing explanation :D ) | 09:10 |
| Zara | great, will look now... | 09:11 |
| * Zara braces herself | 09:11 | |
| Zara | thanks for that, not as bad as I feared! I'm going to do some testing and work out now if the bits you pointed out are unnecessary or not (and why if not); I thought I'd checked for that earlier but I could easily be getting mixed up. | 09:43 |
| Zara | the suggestion about how to go about separating it out is also useful, thanks | 09:43 |
| Zara | I'm still a bit fuzzy about the relations between factories, controllers, directives and the scope, though it's clearer than it was. | 09:44 |
| SotK | I think factories are basically used to provide shared functionality | 09:44 |
| Zara | yeah, I think I originally got confused because they're documented as 'services' but then have factory functions | 09:52 |
| *** openstackgerrit has quit IRC | 13:46 | |
| *** openstackgerrit has joined #storyboard | 13:46 | |
| Zara | gave one of the pagination patches a +1 workflow | 14:47 |
| Zara | I'm not sure about saying yes to a bunch of things; guessing there'd be merge conflicts and would need rebasing, but then I'd think the gate would account for that? | 14:47 |
| Zara | for now I'm playing it safe jic | 14:47 |
| SotK | I think that patch is dependent on the other pagination one, so they both need workflow +1 to be merged | 14:50 |
| SotK | but yeah, any merge issues get raised whenever something is merged to master | 14:51 |
| Zara | where the other one is the result set pager one? I thought that in practice it was dependent, but it didn't depend on it in terms of 'all of storyboard will be broken without it', just that the numbers would be wrong? | 14:52 |
| Zara | I can +1 workflow it anyway. | 14:53 |
| Zara | I think I was able to merge the backend stuff a while ago. | 14:54 |
| Zara | it's been so long since I first looked at these, heh. | 14:56 |
| Zara | yeah, I'd got the one I'd left mixed up with an older one. | 14:57 |
| SotK | thanks | 15:00 |
| SotK | pagination inbound! | 15:00 |
| Zara | :D | 15:00 |
| openstackgerrit | Merged openstack-infra/storyboard-webclient: Add paging controls to the result set pager https://review.openstack.org/198768 | 15:05 |
| openstackgerrit | Merged openstack-infra/storyboard-webclient: Implement offset/limit pagination of lists https://review.openstack.org/198769 | 15:06 |
| SotK | \o/ | 15:07 |
| Zara | still paranoid that there'll be some timing weirdness and merge conflict horribleness will result, haha | 15:09 |
| SotK | Zuul should protect against that I think | 15:11 |
| openstackgerrit | Merged openstack-infra/storyboard-webclient: Change the page title when different things are being viewed https://review.openstack.org/212085 | 15:11 |
| Zara | I really hope so. :) | 15:14 |
| SotK | It did when I was trying to use it for Baserock's CI | 15:16 |
| Zara | ah, cool, I've not had much experience with zuul really. I was guessing it'd work in those situations since otherwise it'd be very very awkward to update big projects. | 15:17 |
| Zara | but didn't want to assume, haha | 15:17 |
| * SotK wonders how long storyboard.openstack.org takes to update | 15:20 | |
| Zara | yeahhh. | 15:22 |
| Zara | sometimes when testing I've had to manually restart the webclient | 15:23 |
| Zara | so it might even be that. idk, I seem to remember it taking much longer to merge changes a few weeks ago | 15:23 |
| Zara | but maybe I'm thinking of a different openstack repo. | 15:23 |
| openstackgerrit | Merged openstack-infra/storyboard-webclient: Bugfix: 'right click is interpreted as left click' https://review.openstack.org/199047 | 15:30 |
| Zara | yay | 15:54 |
| Zara | I meant to say that 20 minutes ago. | 15:54 |
| SotK | haha :) | 15:54 |
| Zara | a colleague brought me a kinder egg. | 15:55 |
| openstackgerrit | Merged openstack-infra/storyboard-webclient: Display 'about' and 'license' icons on higher zooms https://review.openstack.org/199097 | 16:02 |
| *** notnownikki has joined #storyboard | 16:04 | |
| *** MarkAtwood has joined #storyboard | 16:23 | |
| *** MarkAtwood has quit IRC | 19:09 | |
| * SotK notices that storyboard.openstack.org got updated | 19:53 | |
| * SotK updates the relevant stories | 19:55 | |
| * SotK notices that the page size isn't remembered for some stuff and wonders how on earth he didn't notice that | 20:04 | |
| *** cody-somerville has joined #storyboard | 20:05 | |
| *** notnownikki has quit IRC | 21:16 | |
| *** NewHorizons has joined #storyboard | 21:33 | |
| *** openstackgerrit has quit IRC | 22:46 | |
| *** openstackgerrit has joined #storyboard | 22:46 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!