*** cody-somerville has quit IRC | 01:06 | |
*** cody-somerville has joined #storyboard | 01:47 | |
*** jtomasek has joined #storyboard | 06:50 | |
*** jcoufal has joined #storyboard | 08:22 | |
*** CTtpollard has joined #storyboard | 09:07 | |
*** CTtpollard has quit IRC | 09:34 | |
*** CTtpollard has joined #storyboard | 09:34 | |
*** CTtpollard has quit IRC | 09:35 | |
*** CTtpollard has joined #storyboard | 09:35 | |
*** CTtpollard has quit IRC | 09:47 | |
*** CTtpollard has joined #storyboard | 09:47 | |
*** SotK_ has joined #storyboard | 10:14 | |
*** SotK has quit IRC | 10:18 | |
*** SotK_ is now known as SotK | 10:18 | |
SotK | when I run "tox -e venv "storyboard-worker-daemon --help"" I get "ImportError: No module named daemon"... | 10:19 |
---|---|---|
* SotK continues trying to figure it out | 10:19 | |
SotK | aha, there's a problem in setup.cfg | 10:21 |
openstackgerrit | Adam Coldrick proposed openstack-infra/storyboard: Fix entry point for storyboard-worker-daemon https://review.openstack.org/199042 | 10:26 |
Zara_ | tried updating angular to fix click issue, issue persisted, looked around and discovered that storyboard-webclient/dist/js/libs.js still had the old code. I'd thought that would be updated automatically to match the current version of angular (and so on) but I obviously haven't understood it properly! | 10:32 |
Zara_ | (ah, the angularjs code in bower_components is still the old version, so maybe I didn't update enough in the bower.json... (am assuming the bower_components are determined by the contents of bower.json)) | 10:41 |
Zara_ | yaaaaaay it worked. | 10:43 |
openstackgerrit | Zara proposed openstack-infra/storyboard-webclient: Bugfix: 'right click is interpreted as left click' https://review.openstack.org/199047 | 10:56 |
*** CTtpollard has quit IRC | 11:59 | |
Zara_ | atm the 'about' and 'license' buttons display oddly at different zooms (over the icons, etc). It's trivial to fix (by just putting them in the same class as the other nav pills) but separating them out this way seems to be a deliberate move. is there a reason for doing it this way that I don't know about? | 12:04 |
Zara_ | cluster of not-very-informative reviews incoming. I've tested the pagination implementation, although admittedly not *that* thoroughly. | 12:42 |
SotK | \o/ thanks! | 12:43 |
Zara_ | it seems to work for me, anyway, so to me it's much better than it was before! :) | 12:43 |
SotK | I still haven't managed to get any subscription events to appear :( | 12:44 |
SotK | I have storyboard-worker-daemon and storyboard-subscriber running, but can't seem to cause anything to be created | 12:54 |
* SotK wonders what he is missing | 12:54 | |
openstackgerrit | Zara proposed openstack-infra/storyboard-webclient: Stop 'about' and 'license' buttons overlapping others https://review.openstack.org/199095 | 13:25 |
openstackgerrit | Zara proposed openstack-infra/storyboard-webclient: Display 'about' and 'license' icons on higher zooms https://review.openstack.org/199097 | 13:30 |
Zara_ | I hope those changes display things better consistently; they improved things on chromium and iceweasel at multiple zooms on my laptop screen, but I don't have a lot of different devices to test on. | 13:35 |
Zara_ | I'm planning to leave it as two commits for now, since I'm not sure just how atomic upstream like their commits, and it's easier to squash than to separate again. | 14:11 |
SotK | that's fine by me, I only suggested it since they both touch the same code (in fact, I think that the second change actually incorporates the first one!) | 14:13 |
openstackgerrit | Zara proposed openstack-infra/storyboard-webclient: Display 'about' and 'license' icons on higher zooms https://review.openstack.org/199097 | 14:21 |
Zara_ | is it overkill if I put my new changes (that visually separate the about/license buttons from the others) in *yet another* new patch? | 15:15 |
SotK | I don't mind either way :) | 15:20 |
Zara_ | I'll probably play around a bit more before I submit anything, then :) | 15:25 |
*** davidlenwell has quit IRC | 15:38 | |
persia | If you have patches that depend upon each other, be sure to indicate that to gerrit. | 15:39 |
*** davidlenwell has joined #storyboard | 15:53 | |
openstackgerrit | Zara proposed openstack-infra/storyboard-webclient: Display 'about' and 'license' icons on higher zooms https://review.openstack.org/199097 | 15:54 |
*** davidlenwell is now known as daviddavid | 15:54 | |
*** daviddavid is now known as davidlenwell | 15:54 | |
Zara_ | in the end I updated the old patch, since I'd already incorporated centering into it. | 15:58 |
*** davidlenwell has quit IRC | 15:58 | |
*** davidlenwell has joined #storyboard | 15:58 | |
*** jtomasek has quit IRC | 16:01 | |
*** davidlenwell has quit IRC | 16:08 | |
*** davidlenwell has joined #storyboard | 16:08 | |
*** davidlenwell is now known as omnibus7 | 16:12 | |
*** omnibus7 is now known as davidlenwell | 16:12 | |
*** davidlenwell is now known as david_enwell | 16:12 | |
*** MarkAtwood has joined #storyboard | 16:17 | |
*** david_enwell is now known as davidlenwell | 16:19 | |
*** davidlenwell has quit IRC | 16:20 | |
*** davidlenwell has joined #storyboard | 16:20 | |
*** davidlenwell has quit IRC | 16:23 | |
*** davidlenwell has joined #storyboard | 16:24 | |
krotscheck | Ok, so, out of curiosity: Who are you people, where did you come from, and where were you, say, 6 months ago when everyone else on this project disappeared? | 16:26 |
*** davidlenwell has quit IRC | 16:27 | |
*** davidlenwell has joined #storyboard | 16:28 | |
*** jcoufal has quit IRC | 16:28 | |
*** pedroalvarez has joined #storyboard | 16:30 | |
*** davidlenwell has quit IRC | 16:31 | |
*** davidlenwell has joined #storyboard | 16:35 | |
*** davidlenwell is now known as davidlenwell_ | 16:36 | |
persia | krotscheck: My apologies: as I said in Vancouver, I got distracted by other things for a bit. | 16:38 |
*** davidlenwell_ is now known as davidlenwell | 16:38 | |
Zara_ | krotscheck: Me personally? Codethink developer, previously on other projects, just assigned to Storyboard. Six months ago, I think I was writing an import tool that nobody used in the end... | 16:42 |
SotK | Zara_: I used it once! | 17:12 |
Zara_ | the npm bit? | 17:12 |
SotK | krotscheck: I'm a developer from Codethink too, also recently assigned to look at Storyboard. I've been lurking in this channel for a long time, without any time spare to usefully learn about and contribute to this previously. | 17:14 |
krotscheck | Well, I'm glad to see some work being done here, but I have to admit that it's a bit late in coming ;) | 17:14 |
SotK | Zara_: I *think* I used that bit once | 17:15 |
Zara_ | :) 'night. I'm off to get food and irritate my flatmates with the guitar. | 17:17 |
*** jtomasek has joined #storyboard | 17:21 | |
*** reed_ has quit IRC | 17:59 | |
*** coolsvap|away is now known as coolsvap | 18:04 | |
*** jtomasek has quit IRC | 20:00 | |
*** jtomasek has joined #storyboard | 20:06 | |
*** jtomasek has quit IRC | 20:09 | |
persia | SotK, Zara_: Just FYI (since you are not both on -infra), I've forwarded your names/email to jeblair, who will probably take some action (the meeting ended before the precise action was determined). | 20:09 |
*** jtomasek has joined #storyboard | 20:10 | |
*** jtomasek has quit IRC | 20:19 | |
*** coolsvap is now known as coolsvap|away | 20:39 | |
*** MarkAtwood has quit IRC | 21:21 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!