| *** mrmartin has joined #storyboard | 04:37 | |
| *** jtomasek has joined #storyboard | 05:32 | |
| *** mrmartin has quit IRC | 06:12 | |
| *** jcoufal has joined #storyboard | 06:26 | |
| *** MaxV has joined #storyboard | 07:50 | |
| *** notnownikki has joined #storyboard | 08:28 | |
| *** CTtpollard has joined #storyboard | 08:56 | |
| *** alexismonville has joined #storyboard | 09:08 | |
| *** SotK_ has joined #storyboard | 09:20 | |
| *** SotK has quit IRC | 09:24 | |
| *** SotK_ is now known as SotK | 09:25 | |
| *** alexismonville has quit IRC | 09:25 | |
| *** mrmartin has joined #storyboard | 10:27 | |
| openstackgerrit | Merged openstack-infra/storyboard-webclient: Support for tags https://review.openstack.org/166847 | 10:38 |
|---|---|---|
| *** ttx has quit IRC | 11:48 | |
| *** ttx has joined #storyboard | 11:48 | |
| *** ttx has quit IRC | 11:49 | |
| *** ttx has joined #storyboard | 11:49 | |
| *** ttx has quit IRC | 12:45 | |
| *** ttx has joined #storyboard | 12:45 | |
| *** ttx has quit IRC | 12:46 | |
| *** ttx has joined #storyboard | 12:46 | |
| *** openstackgerrit has quit IRC | 13:00 | |
| *** openstackgerrit has joined #storyboard | 13:03 | |
| *** alexismonville has joined #storyboard | 13:37 | |
| *** Piet has quit IRC | 13:58 | |
| *** tpollard_ has joined #storyboard | 14:01 | |
| *** CTtpollard has quit IRC | 14:01 | |
| *** mattfarina has joined #storyboard | 14:19 | |
| *** mrmartin has quit IRC | 14:31 | |
| *** ttx has quit IRC | 15:57 | |
| *** ttx has joined #storyboard | 15:57 | |
| ttx | anyone up for a storyboard meeting? | 16:01 |
| NikitaKonovalov | o/ | 16:02 |
| krotscheck | eep | 16:03 |
| *** ttx has quit IRC | 16:05 | |
| *** ttx has joined #storyboard | 16:05 | |
| *** MaxV has quit IRC | 16:29 | |
| *** MaxV has joined #storyboard | 16:37 | |
| krotscheck | Right, so sorry about my comments on that review. | 16:46 |
| krotscheck | I'm just frustrated that an honest effort to improve the product basically stalls out because someone has a disagreement. | 16:46 |
| yolanda | so i was surprised to hear that, because you are the first person that was asking for high quality code changes, basically | 16:46 |
| krotscheck | I mean yes: In that context you're right, the code could be more reusable, and we really do need to figure out injected constants. | 16:47 |
| yolanda | i don't want to be blocking anything, i mean, it's my -1 my opinion | 16:47 |
| yolanda | but it doesn't mean any other people can have other comments and have a +2 there | 16:47 |
| yolanda | so i agree that the situation now it's quite different, we don't have time, and we should be giving priority to features | 16:48 |
| krotscheck | Well, let me ask you a question. | 16:48 |
| yolanda | tell me | 16:48 |
| krotscheck | When you look at a review, and you look through the reviewers. If you see a -1 from a core - say Jim - are you more or less likely to review that code? | 16:49 |
| krotscheck | I'll be honest: If I see a -1 from you, and I don't have a specific request to review that code, I don't bother, because I trust your opinion. | 16:49 |
| yolanda | i've set -1 on reviews with a +2 from cores really, but they are not considered normally | 16:49 |
| krotscheck | And maybe that's just me. | 16:49 |
| yolanda | but krotscheck, you have another cores, i'm not a core on infra, but on SB, and all cores on SB should have their own opinion, and look to changes | 16:50 |
| yolanda | even if there is a -1 from a peer | 16:50 |
| krotscheck | Ok, so do the math here. | 16:50 |
| yolanda | so i'm in a lower position on infra, than Jim or Clark, but ttx, Nikita, are in the same level as me on SB, so my opinion is just an opinion | 16:50 |
| krotscheck | We have, effectively, 4 cores. | 16:50 |
| krotscheck | One of them is the author. | 16:51 |
| krotscheck | One of them's a -1. | 16:51 |
| krotscheck | We need two cores to +2 | 16:51 |
| krotscheck | And none of us are very actively engaged. | 16:51 |
| yolanda | if i have another core that sets a +2, and exposes his opinion, i'm open to discussion | 16:51 |
| krotscheck | Right. | 16:51 |
| krotscheck | I get that. | 16:51 |
| krotscheck | And I believe your -1 is totally warranted. | 16:52 |
| krotscheck | However I am also frurstrated that it's this lack of resources that's basically hamstrung storyboard and brought us to the situation we're at today. | 16:52 |
| yolanda | so... talking practically, i've found that sometimes just sending a comment into the code, and not setting a +1 or -1 goes totally ignored, as gerrit doesn't flag it | 16:52 |
| yolanda | and i found that people just don't look at it | 16:52 |
| krotscheck | Point | 16:52 |
| yolanda | so i have a negative comment, i flag it with a -1, and let's start discussion | 16:53 |
| krotscheck | I for one don't look at anything with a -1 from jenkins | 16:53 |
| * krotscheck should probably just look at all the cdoe. | 16:53 | |
| yolanda | yes, i don't look at -1 from jenkins too, but i look at the ones with -1 from peers | 16:53 |
| krotscheck | Hrm. Why is your integration tools patch not landed yet? | 16:54 |
| krotscheck | Sorry. Got distracted | 16:54 |
| yolanda | so my concern was also about the standards for review, you know that in the past, this code should have a -1 and some refactor needed... if we agree that we want to focus on speed and be pragmatic, i will be ok with that | 16:54 |
| krotscheck | Well, maybe I need to change my pattern. | 16:55 |
| krotscheck | Hrm. | 16:55 |
| krotscheck | Let's put that on the agenda. | 16:55 |
| yolanda | so i don't know why my integration hasn't landed, readlly | 16:55 |
| krotscheck | It's a thing everyone needs to weigh in on . | 16:55 |
| yolanda | really | 16:55 |
| krotscheck | yolanda: I just +2/a'd it | 16:55 |
| yolanda | ah cool | 16:55 |
| yolanda | they really suck now :( | 16:55 |
| yolanda | only a basic integration test | 16:55 |
| openstackgerrit | Merged openstack-infra/storyboard: Add tools to run integration tests https://review.openstack.org/155975 | 17:00 |
| yolanda | nice | 17:00 |
| *** MaxV has quit IRC | 17:18 | |
| *** MaxV has joined #storyboard | 17:19 | |
| *** alexismonville has quit IRC | 17:23 | |
| *** MaxV has quit IRC | 17:23 | |
| *** jcoufal has quit IRC | 17:26 | |
| *** coolsvap|afk is now known as coolsvap | 18:26 | |
| *** MaxV has joined #storyboard | 18:29 | |
| *** MaxV has quit IRC | 18:33 | |
| *** coolsvap is now known as coolsvap|afk | 18:36 | |
| *** Piet has joined #storyboard | 19:13 | |
| *** coolsvap|afk is now known as coolsvap | 19:21 | |
| *** coolsvap is now known as coolsvap|afk | 19:48 | |
| *** coolsvap has joined #storyboard | 19:57 | |
| *** Piet has quit IRC | 20:13 | |
| *** Piet has joined #storyboard | 20:55 | |
| openstackgerrit | Michael Krotscheck proposed openstack-infra/storyboard: Updated oslo_db. https://review.openstack.org/173083 | 21:22 |
| openstackgerrit | Michael Krotscheck proposed openstack-infra/storyboard: Removed hack. https://review.openstack.org/173084 | 21:22 |
| *** mattfarina has quit IRC | 21:23 | |
| *** Piet has quit IRC | 21:36 | |
| openstackgerrit | Michael Krotscheck proposed openstack-infra/storyboard: Updated oslo_log https://review.openstack.org/173093 | 21:38 |
| openstackgerrit | Michael Krotscheck proposed openstack-infra/storyboard: Updated all oslo versions. https://review.openstack.org/173094 | 21:38 |
| *** cody-somerville has joined #storyboard | 21:45 | |
| *** jtomasek has quit IRC | 21:46 | |
| *** notnownikki has quit IRC | 21:53 | |
| *** MaxV has joined #storyboard | 22:23 | |
| *** alexismonville has joined #storyboard | 22:23 | |
| krotscheck | ttx, yolanda: Hey, so, https://review.openstack.org/#/c/153591/ should never have landed. For security reasons, we should _never_ have more than one refresh token per access token. | 22:31 |
| krotscheck | .... | 22:32 |
| krotscheck | I know I +2'd it | 22:32 |
| krotscheck | I'm trying to figure what the correct approach should be. | 22:32 |
| krotscheck | Technically, all refresh tokens are deleted when a single refresh token is deleted. | 22:35 |
| krotscheck | But, well... | 22:35 |
| krotscheck | _why_ | 22:35 |
| krotscheck | If we're never going to use multiple refresh tokens.... | 22:35 |
| krotscheck | ARGH | 22:38 |
| *** MaxV has quit IRC | 22:41 | |
| *** coolsvap has quit IRC | 22:51 | |
| *** cody-somerville has quit IRC | 23:09 | |
| krotscheck | Well, looks like many-to-many cascades are not allowed in SQLA, so the token cleaner plugin is basically broken. | 23:10 |
| krotscheck | Honestly I'm a bit surprised by the fact that it broke, because it's got good test coverage. | 23:10 |
| krotscheck | Oh, greghaynes' patch revert exposed it. | 23:11 |
| krotscheck | _sigh_ | 23:11 |
| *** alexismonville has quit IRC | 23:16 | |
| *** cody-somerville has joined #storyboard | 23:27 | |
| *** SergeyLukjanov has quit IRC | 23:39 | |
| *** SergeyLukjanov has joined #storyboard | 23:40 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!