| *** jcoufal has quit IRC | 00:02 | |
| *** alexismonville has quit IRC | 00:06 | |
| *** jcoufal_ has quit IRC | 00:31 | |
| openstackgerrit | greghaynes proposed openstack-infra/storyboard: Use python3 compatible urllib https://review.openstack.org/155150 | 00:43 |
|---|---|---|
| *** Piet has joined #storyboard | 01:38 | |
| *** gulic has quit IRC | 01:42 | |
| *** gulic has joined #storyboard | 02:00 | |
| *** gulic has quit IRC | 02:07 | |
| openstackgerrit | greghaynes proposed openstack-infra/storyboard: Use Python 3 compatible configparser https://review.openstack.org/155922 | 02:07 |
| openstackgerrit | greghaynes proposed openstack-infra/storyboard: Use TempDir fixture for working dir https://review.openstack.org/155956 | 02:20 |
| openstackgerrit | greghaynes proposed openstack-infra/storyboard: Use TempDir fixture for working dir https://review.openstack.org/155956 | 02:35 |
| *** reed has quit IRC | 03:56 | |
| openstackgerrit | greghaynes proposed openstack-infra/storyboard: Fix bytes vs string python 3 issues https://review.openstack.org/155969 | 04:22 |
| *** coolsvap_ is now known as coolsvap | 04:31 | |
| openstackgerrit | greghaynes proposed openstack-infra/storyboard: Fix bytes vs string python 3 issues https://review.openstack.org/155969 | 04:36 |
| greghaynes | ok, fairly confident ^ should *actually* do it | 04:36 |
| *** coolsvap is now known as coolsvap_ | 05:02 | |
| *** coolsvap_ is now known as coolsvap | 05:09 | |
| *** coolsvap is now known as coolsvap_ | 05:53 | |
| *** coolsvap_ is now known as coolsvap | 06:00 | |
| *** jcoufal has joined #storyboard | 06:05 | |
| *** alexismonville has joined #storyboard | 07:14 | |
| *** alexismonville has quit IRC | 07:17 | |
| *** alexismonville has joined #storyboard | 07:28 | |
| *** mrmartin has joined #storyboard | 07:45 | |
| *** mrmartin has quit IRC | 07:49 | |
| *** mrmartin has joined #storyboard | 07:50 | |
| *** jtomasek has joined #storyboard | 08:14 | |
| *** cody-somerville has quit IRC | 08:19 | |
| *** alexismonville has quit IRC | 08:23 | |
| *** alexismonville has joined #storyboard | 08:29 | |
| *** MaxV has joined #storyboard | 08:43 | |
| *** cody-somerville has joined #storyboard | 08:56 | |
| *** jedimike has joined #storyboard | 09:05 | |
| openstackgerrit | Merged openstack-infra/storyboard-webclient: Fix error notifications https://review.openstack.org/155242 | 09:41 |
| *** gulic has joined #storyboard | 10:08 | |
| yolanda | hi ttx, can you ping me when you are available? i wanted to present you to Jovanka so we can talk about file attachments project | 10:32 |
| *** ilyashakhat_ has quit IRC | 10:32 | |
| *** ilyashakhat has joined #storyboard | 10:32 | |
| openstackgerrit | yolanda.robla proposed openstack-infra/storyboard: Add an index on accesstokens table tor access_token column https://review.openstack.org/156543 | 10:58 |
| *** jcoufal_ has joined #storyboard | 11:00 | |
| *** jcoufal has quit IRC | 11:03 | |
| openstackgerrit | Aleksey Ripinen proposed openstack-infra/storyboard: Split auth in api and change user_tokens https://review.openstack.org/153591 | 11:34 |
| *** mrmartin has quit IRC | 11:49 | |
| *** mrmartin has joined #storyboard | 11:56 | |
| *** yolanda has quit IRC | 12:06 | |
| *** yolanda has joined #storyboard | 12:07 | |
| openstackgerrit | Aleksey Ripinen proposed openstack-infra/storyboard: Datetime instances from SQLAlchemy now all contain timezone. https://review.openstack.org/155083 | 12:32 |
| openstackgerrit | Aleksey Ripinen proposed openstack-infra/storyboard: Authorization codes validate on TTL. https://review.openstack.org/155084 | 12:37 |
| *** mrmartin has quit IRC | 12:49 | |
| openstackgerrit | Aleksey Ripinen proposed openstack-infra/storyboard: Split auth in api and change user_tokens https://review.openstack.org/153591 | 13:06 |
| *** jtomasek has quit IRC | 13:29 | |
| openstackgerrit | Aleksey Ripinen proposed openstack-infra/storyboard: Added branches to storyboard https://review.openstack.org/150447 | 13:42 |
| *** jtomasek has joined #storyboard | 13:48 | |
| *** mrmartin has joined #storyboard | 13:52 | |
| openstackgerrit | Aleksey Ripinen proposed openstack-infra/storyboard: Added milestones https://review.openstack.org/152500 | 13:57 |
| *** Piet has quit IRC | 14:28 | |
| *** jtomasek has quit IRC | 15:51 | |
| *** jtomasek has joined #storyboard | 15:55 | |
| *** jtomasek has quit IRC | 16:02 | |
| *** reed has joined #storyboard | 16:11 | |
| *** jtomasek has joined #storyboard | 16:16 | |
| *** Piet has joined #storyboard | 16:18 | |
| *** gulic has quit IRC | 16:20 | |
| *** jtomasek has quit IRC | 16:26 | |
| *** jtomasek has joined #storyboard | 16:28 | |
| *** coolsvap is now known as coolsvap_ | 16:51 | |
| *** jcoufal_ has quit IRC | 17:06 | |
| *** Piet has quit IRC | 17:07 | |
| *** miqui has quit IRC | 17:37 | |
| *** MaxV has quit IRC | 17:50 | |
| *** gulic has joined #storyboard | 17:58 | |
| yolanda | krotscheck, around? i'm interested in your feedback for SB integration tests, the ones in the storyboard-webclient side | 18:50 |
| krotscheck | Nope | 18:51 |
| krotscheck | Not around. | 18:51 |
| krotscheck | I am a turing machine. | 18:51 |
| yolanda | as spec got +2, and i will have the jobs ready tomorrow | 18:51 |
| yolanda | krotscheck, i need one of these machines too | 18:51 |
| yolanda | they seem so effective | 18:51 |
| krotscheck | Initial feedback: Your test config is likely conflict with greghaynes’s pymysql work, I would like to see them chained in some way. | 18:53 |
| krotscheck | Probably his work on top of yours, because I think his will require some fiddling with our puppet config as well. | 18:53 |
| krotscheck | SB is down | 18:55 |
| krotscheck | n/m | 18:56 |
| yolanda | mm, no, i don't mean that | 18:57 |
| yolanda | that's for the setup of the backend | 18:57 |
| krotscheck | The other one’s still WIP? | 18:57 |
| yolanda | this one | 18:57 |
| yolanda | https://review.openstack.org/156217 | 18:57 |
| yolanda | yes, but i need your ideas | 18:57 |
| krotscheck | Oh, that doesn’t show up on my list :) | 18:57 |
| yolanda | as there are few options on how to build them | 18:58 |
| yolanda | i did an approach with protractor and requests, but you have been working with karma on it, so i wanted to have your comments | 18:58 |
| yolanda | sb down? | 18:59 |
| krotscheck | Error on first load issue. | 18:59 |
| yolanda | ah, that happens still quite often, yes... | 18:59 |
| *** rcarrillocruz has quit IRC | 18:59 | |
| krotscheck | That root state patch of mine MIGHT fix it. | 19:00 |
| krotscheck | No problem switching to protractor. | 19:00 |
| yolanda | so i considered 2 options there. Checking actions by clicking buttons, checking ui to see results, etc... | 19:01 |
| yolanda | or directly testing urls and spying the json returned | 19:01 |
| yolanda | what do you think? | 19:01 |
| krotscheck | So, that’s two kinds of tests, no? Clicking buttons is functional testing, testing API layer against the URL’s is integration. | 19:01 |
| yolanda | well. yes... but functional can be done with mocking, or directly attacking the api | 19:02 |
| yolanda | i went by testing the api layer, but i was wondering if that would cover everything | 19:02 |
| yolanda | if i do it complete enough it shold | 19:03 |
| yolanda | should | 19:03 |
| krotscheck | Technically, yes, however bugs like the no-load-on-link issue wouldn’t come through on a mock. Functional tests lets us test UI with real latency. | 19:03 |
| *** rcarrillocruz has joined #storyboard | 19:03 | |
| yolanda | so i'd go with an initial set of tests that just test against the api, then we could add more integration tests if we need | 19:05 |
| krotscheck | Coolio | 19:06 |
| yolanda | we have a plan :) | 19:07 |
| yolanda | so i finally know how zuul-cloner works, clarkb and jeblair helped me | 19:07 |
| yolanda | i need to refactor the jobs a bit and it should do the work | 19:07 |
| krotscheck | Comments left. Mostly curious about the reports. | 19:11 |
| yolanda | about chrome, we switched to it with the firefox issue | 19:12 |
| krotscheck | Oh that’s right | 19:12 |
| krotscheck | I wonder if firefox has updated since. | 19:12 |
| yolanda | i can test it | 19:13 |
| yolanda | so if you agree with the approach i'll go with some initial tests, not as dummy as this one :) | 19:13 |
| krotscheck | No problems :) | 19:14 |
| krotscheck | Go for it | 19:14 |
| yolanda | i need to figure out how to force login, it's needed for some tests, i guess that doing the login on the beforeeach will be enough | 19:15 |
| krotscheck | Preloading the database with a known state would probably be best there. | 19:16 |
| krotscheck | There should bea way to preload the mock data. | 19:16 |
| yolanda | mm, but should be done from the webclient, right? | 19:16 |
| yolanda | or do you meann doing that on the tools for installing the backend? | 19:16 |
| krotscheck | yeaaahahhhhhrmmmm.... | 19:17 |
| krotscheck | There’s got to be a way to do test hooks. | 19:17 |
| yolanda | yeah for the first option or the second? | 19:17 |
| krotscheck | Neither. | 19:18 |
| krotscheck | I kindof want to be able to invoke storyboard-db-manage with every call. | 19:18 |
| krotscheck | Sorry -every test. | 19:18 |
| krotscheck | I know that’ll add test overhead, but it’ll be way better to start with a clean database every time. | 19:18 |
| krotscheck | Looks like protractor has some hooks for that… https://github.com/angular/protractor/issues/997 | 19:19 |
| *** openstackgerrit has quit IRC | 19:20 | |
| *** openstackgerrit has joined #storyboard | 19:20 | |
| yolanda | so you'd go in the same way that storyboard backend tests do, that create a db on each run? | 19:20 |
| krotscheck | I’m torn. | 19:24 |
| krotscheck | Setting up the DB every single time is crazy overhead, especially if we have to do it via the API | 19:24 |
| yolanda | yes | 19:24 |
| krotscheck | A pity we don’t have batch request middleware :) | 19:24 |
| yolanda | what i wanted to do is fill database with data, using the api directly | 19:25 |
| yolanda | so you test the create, create some entries, then test the get, etc... | 19:25 |
| yolanda | not sure if that will work | 19:25 |
| krotscheck | It should, as long as each test makes sure to return the database to its previous state. | 19:26 |
| yolanda | and tests are done in the right order | 19:26 |
| krotscheck | Yep | 19:26 |
| yolanda | doesn't look perfect to me but it can wor | 19:27 |
| yolanda | work | 19:27 |
| * krotscheck wants a batch api. | 19:29 | |
| * krotscheck really wants a batch api | 19:29 | |
| yolanda | well, shoudln't be so hard, have some inserts or deletes in bulk | 19:31 |
| krotscheck | greghaynes: Question on https://review.openstack.org/#/c/155969/ | 19:38 |
| krotscheck | Although I LOVE the fact that the Py3 jobs pass in that one :) | 19:39 |
| greghaynes | ohai | 19:39 |
| krotscheck | you can haz +2? | 19:39 |
| greghaynes | heh | 19:39 |
| *** Piet has joined #storyboard | 19:39 | |
| greghaynes | question is the str thing? | 19:40 |
| krotscheck | greghaynes: On that one, yes. | 19:40 |
| krotscheck | greghaynes: I also have a question on the first patch in the tree. | 19:40 |
| greghaynes | uh oh | 19:41 |
| krotscheck | greghaynes: RElated to not accidentally taking down storyboard.o.o | 19:41 |
| greghaynes | so the str thing doesnt matter really, if the traceback included non-ascii chars, and we cared about the output encoding it would matter | 19:41 |
| greghaynes | but really, the traceback shouldnt include non-ascii | 19:41 |
| greghaynes | and even so, it actually doesnt fix that - wed have to do six.text_type(e).encode('utf-8') or somesuch | 19:42 |
| krotscheck | And we can’t just hand ve.message to the db value error...? | 19:44 |
| greghaynes | Nope, because its bytes | 19:45 |
| krotscheck | Right | 19:45 |
| krotscheck | blargh | 19:45 |
| krotscheck | What about the config | 19:45 |
| * greghaynes tries to find that | 19:45 | |
| krotscheck | Basically: The storyboard.conf file on storyboard.o.o does not include the +pymysql thing. | 19:46 |
| greghaynes | ah, yes | 19:46 |
| greghaynes | so it still works with the old driver | 19:46 |
| greghaynes | so, in theory, it should be fine | 19:46 |
| greghaynes | we should probably test that theory | 19:46 |
| krotscheck | Sec, I still have an old config file, I can just pull it down and see what happens. | 19:47 |
| *** gulic has quit IRC | 19:47 | |
| greghaynes | We should also probably switch the config to use the pymysql driver but I dont think we need to be careful about when | 19:47 |
| krotscheck | _seems_ to work. | 19:54 |
| krotscheck | I lied | 19:55 |
| krotscheck | ImportError: No module named MySQLdb | 19:55 |
| krotscheck | Although I did scrub my tox venv | 19:55 |
| greghaynes | ooo | 19:57 |
| krotscheck | Also, it appears that the pyMysql dependency is only in the test-requirements file, not the requirements file. | 19:57 |
| krotscheck | Our current documentation says you have to install that manually, but with this change I don’t think that’s necessary anymore, no? | 19:57 |
| krotscheck | Ok- so if I include both drivers in the tox requirements it works. | 19:58 |
| greghaynes | well, you had to install them manually unless you ran tests (since they are only in the test-req's file) | 19:59 |
| greghaynes | I guess the advantage to that is the user can decide whether or not to use pymysql | 19:59 |
| greghaynes | so, depending on how storyboard.o.o is deployed, it might not be an issue | 19:59 |
| greghaynes | but thats something worth checking - does it manually install python-mysql | 20:00 |
| krotscheck | It does not. | 20:00 |
| greghaynes | huh, so how does it get there? | 20:00 |
| greghaynes | does it install test-requirements? | 20:00 |
| krotscheck | greghaynes: “ include mysql::python” | 20:01 |
| krotscheck | Who knows what that is. | 20:01 |
| greghaynes | oh wow | 20:01 |
| greghaynes | so maybe it does install it manually | 20:02 |
| greghaynes | which is actually the right way | 20:02 |
| * greghaynes knows basically 0 puppet | 20:02 | |
| greghaynes | totally separate from this, putting pymysql in the requirements isnt a bad thing IMO | 20:03 |
| krotscheck | It looks like it installs the python-mysqldb package from whatever the provider is. | 20:03 |
| greghaynes | ok, so yea, it should *just work* then | 20:03 |
| krotscheck | Probably pip | 20:03 |
| krotscheck | Huhn. | 20:03 |
| krotscheck | Is that some kind of a virtual package that install sboth? | 20:04 |
| * greghaynes is boarding train, back in a few | 20:04 | |
| greghaynes | we should ask someone who knows puppet though | 20:05 |
| krotscheck | I know a reasonable amount of puppet. | 20:05 |
| krotscheck | I’m tracing it. | 20:05 |
| greghaynes | ah, well then | 20:05 |
| greghaynes | wow, I got shafted | 20:09 |
| greghaynes | they are using a bus today | 20:09 |
| krotscheck | The apt package does not include pymysql. Looks lik eon trusty it’s mysql-python 1.2.3 | 20:12 |
| krotscheck | So, it’s there. | 20:12 |
| krotscheck | But we’ll need to add pymysql to the requirements so that it’s installed. | 20:12 |
| greghaynes | oh, so its using a system packaged mysql-python? | 20:13 |
| greghaynes | thats...wierd | 20:13 |
| krotscheck | greghaynes: Ehn, I was in a hurry. | 20:15 |
| greghaynes | heh | 20:15 |
| greghaynes | krotscheck: so the venv storyboard is installed in must use --system-site-packages? | 20:15 |
| krotscheck | greghaynes: it’s not installed in a venv. | 20:16 |
| greghaynes | orly | 20:16 |
| greghaynes | well that would explain that | 20:16 |
| krotscheck | Nobody seemed to care at the time. | 20:16 |
| greghaynes | yea, its not a big deal, just suddenly making sense what is going on here ;) | 20:17 |
| krotscheck | Would you mind updating your patch so that the +pymysql is also in the storyboard.conf.sample file>? | 20:18 |
| greghaynes | yerp | 20:19 |
| krotscheck | Thanks | 20:19 |
| krotscheck | greghaynes: Oh, and the docs. | 20:19 |
| greghaynes | I will do that while I try and contain my anger at being stuck on a bus | 20:19 |
| krotscheck | Ragecode. It’s what I’d do in your place. | 20:20 |
| greghaynes | Youre still in downtown SEA office right? | 20:21 |
| krotscheck | Yep | 20:21 |
| *** mrmartin has quit IRC | 20:21 | |
| greghaynes | Ill be there tomorrow-fri | 20:21 |
| krotscheck | Yeah, TripleO things, right? | 20:21 |
| krotscheck | New PTL elections? :) | 20:21 |
| greghaynes | The event formerly known as tripleo mid cycle | 20:21 |
| gothicmindfood | greghaynes: you are making my decision to fly because train would've taken too long seem like the right one. | 20:28 |
| greghaynes | Yeaaa, I failed hard at this one | 20:29 |
| greghaynes | ive done this train tens of times and this is the first time its happened | 20:29 |
| greghaynes | gothicmindfood: when are you heading up? | 20:33 |
| ttx | yolanda: better wait that I'm back from travel. Like Thursday morning | 20:37 |
| yolanda | ttx, ok | 20:37 |
| yolanda | no problem | 20:37 |
| gothicmindfood | greghaynes: tomorrow morning :) | 20:40 |
| openstackgerrit | greghaynes proposed openstack-infra/storyboard: Add PyMySQL to requirements https://review.openstack.org/156764 | 20:48 |
| greghaynes | krotscheck: Ill just merge ^ into the first patch, then | 20:51 |
| krotscheck | kk | 20:51 |
| *** Piet has quit IRC | 20:54 | |
| *** jtomasek has quit IRC | 21:00 | |
| *** MaxV has joined #storyboard | 21:32 | |
| openstackgerrit | Merged openstack-infra/storyboard: Fix comments put method https://review.openstack.org/155790 | 21:58 |
| krotscheck | rainya: Hey, is your session being voted on right now? | 22:01 |
| krotscheck | NikitaKonovalov: I’m going to hold off commenting on aripinen’s branch and mileston patches until we can figure out whether we need DB foreign keys back. | 22:02 |
| openstackgerrit | greghaynes proposed openstack-infra/storyboard: Switch from mysql-python to PyMySQL https://review.openstack.org/152339 | 22:08 |
| openstackgerrit | greghaynes proposed openstack-infra/storyboard: Reorder py27 test to happen after py3 tests https://review.openstack.org/155161 | 22:09 |
| openstackgerrit | greghaynes proposed openstack-infra/storyboard: Use python3 compatible httpclient https://review.openstack.org/155139 | 22:09 |
| openstackgerrit | greghaynes proposed openstack-infra/storyboard: Use python3 compatible unicode types https://review.openstack.org/155140 | 22:09 |
| openstackgerrit | greghaynes proposed openstack-infra/storyboard: Use python3 compatible urllib https://review.openstack.org/155150 | 22:10 |
| openstackgerrit | greghaynes proposed openstack-infra/storyboard: Use Python 3 compatible configparser https://review.openstack.org/155922 | 22:10 |
| openstackgerrit | greghaynes proposed openstack-infra/storyboard: Use TempDir fixture for working dir https://review.openstack.org/155956 | 22:10 |
| openstackgerrit | greghaynes proposed openstack-infra/storyboard: Fix bytes vs string python 3 issues https://review.openstack.org/155969 | 22:10 |
| *** jedimike has quit IRC | 22:16 | |
| *** MaxV has quit IRC | 22:31 | |
| *** alexismonville has quit IRC | 23:02 | |
| *** Piet has joined #storyboard | 23:10 | |
| openstackgerrit | Michael Krotscheck proposed openstack-infra/storyboard: Removed rfc3987 library https://review.openstack.org/156833 | 23:16 |
| krotscheck | greghaynes: I based ^^ off of your urllib patch, because I didn’t want to have to make you redo all the things. | 23:17 |
| greghaynes | ty | 23:17 |
| *** MaxV has joined #storyboard | 23:41 | |
| *** MaxV has quit IRC | 23:46 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!