| *** wuhg has joined #storyboard | 01:49 | |
| *** miqui has quit IRC | 03:41 | |
| *** coolsvap_ is now known as coolsvap | 04:02 | |
| *** coolsvap is now known as coolsvap_ | 04:55 | |
| *** coolsvap_ is now known as coolsvap | 04:56 | |
| *** alexismonville has joined #storyboard | 06:37 | |
| *** alexismonville has quit IRC | 07:03 | |
| *** alexismonville has joined #storyboard | 07:19 | |
| *** jcoufal has joined #storyboard | 08:40 | |
| openstackgerrit | Aleksey Ripinen proposed openstack-infra/storyboard: Added new paginate query https://review.openstack.org/153231 | 08:41 |
|---|---|---|
| *** mrmartin has joined #storyboard | 08:44 | |
| openstackgerrit | Aleksey Ripinen proposed openstack-infra/storyboard: Added controller for refresh tokens https://review.openstack.org/153591 | 08:56 |
| *** MaxV has joined #storyboard | 09:16 | |
| *** jedimike has joined #storyboard | 09:42 | |
| *** CTtpollard has joined #storyboard | 09:49 | |
| openstackgerrit | Nikita Konovalov proposed openstack-infra/storyboard: Fix exception in stories db api https://review.openstack.org/153968 | 09:57 |
| openstackgerrit | Nikita Konovalov proposed openstack-infra/storyboard: Fix exception in stories db api https://review.openstack.org/153968 | 10:06 |
| *** ssam2 has joined #storyboard | 10:08 | |
| openstackgerrit | Nikita Konovalov proposed openstack-infra/storyboard: Added controller for refresh tokens https://review.openstack.org/153591 | 10:17 |
| *** alexismonville has quit IRC | 10:21 | |
| *** alexismonville has joined #storyboard | 10:21 | |
| openstackgerrit | Nikita Konovalov proposed openstack-infra/storyboard: Revert "Adding pretty-tox" https://review.openstack.org/153971 | 10:21 |
| openstackgerrit | Nikita Konovalov proposed openstack-infra/storyboard: Revert "Adding pretty-tox" https://review.openstack.org/153971 | 10:23 |
| openstackgerrit | Nikita Konovalov proposed openstack-infra/storyboard: Added controller for refresh tokens https://review.openstack.org/153591 | 10:24 |
| openstackgerrit | Merged openstack-infra/storyboard: Added new way to filter stories by tags https://review.openstack.org/152951 | 10:28 |
| rcarrillocruz | NikitaKonovalov , yolanda: are you cool approving https://review.openstack.org/#/c/151645/ ? | 10:32 |
| rcarrillocruz | i need that change to continue doing streaming stuff... | 10:32 |
| yolanda | ok, taking a look | 10:32 |
| NikitaKonovalov | rcarrillocruz: done | 10:33 |
| yolanda | oh, faster than me :) | 10:34 |
| rcarrillocruz | excellent, thx folks :-) | 10:38 |
| openstackgerrit | Nikita Konovalov proposed openstack-infra/storyboard: Added controller for refresh tokens https://review.openstack.org/153591 | 10:45 |
| ttx | yolanda: I +2ed the chain starting at https://review.openstack.org/#/c/153409/2 -- if you can rereview it that would be great, to clear some of the long patch series | 10:51 |
| yolanda | sure | 10:51 |
| ttx | You could even bypass my -1 from https://review.openstack.org/#/c/152253/ and we can fix that typo later | 10:52 |
| *** ssam2 has quit IRC | 10:52 | |
| yolanda | i can amend this one, ttx | 10:53 |
| yolanda | and we have Nikita around as well so we could push it fast | 10:53 |
| ttx | yolanda: ok, hopefully that won't lose votes on the rest of the chain | 10:54 |
| ttx | yolanda: let me know when/where to reapply +2 if necessary | 10:55 |
| yolanda | ok, will ping you | 10:55 |
| openstackgerrit | Merged openstack-infra/storyboard: OAuth checks for remote data access permissions. https://review.openstack.org/153409 | 10:56 |
| openstackgerrit | yolanda.robla proposed openstack-infra/storyboard: Explicit Hook Priorities https://review.openstack.org/152253 | 10:57 |
| yolanda | here it goes, let's wait for tests to pass | 10:58 |
| ttx | ok, so that debased https://review.openstack.org/#/c/151645/ and the rest of the patch chain | 10:59 |
| ttx | it will need to be rebased | 11:00 |
| ttx | yolanda: you can still review/approve https://review.openstack.org/#/c/153674/ & https://review.openstack.org/#/c/153675/ & https://review.openstack.org/#/c/153710/ & https://review.openstack.org/#/c/153715/ | 11:01 |
| ttx | that would be the patch chain before 152253 | 11:02 |
| yolanda | Michael is a test machine :) | 11:03 |
| openstackgerrit | Merged openstack-infra/storyboard: OAuth Validate Token Grant Types https://review.openstack.org/153674 | 11:06 |
| openstackgerrit | Merged openstack-infra/storyboard: OAuth tests for invalid authorization codes. https://review.openstack.org/153675 | 11:07 |
| yolanda | ttx, tons of changes being merged, can you take a look after that, to check if everything works fine? | 11:11 |
| yolanda | on-call this week, so no much free time | 11:11 |
| yolanda | really no free time | 11:11 |
| ttx | yolanda: sure! I think the rest of the patch chain will need a rebase, I'll see with michael | 11:12 |
| yolanda | my change failed nearly inmediately, looked as a false positive, i rechecked | 11:12 |
| openstackgerrit | Merged openstack-infra/storyboard: OAuth delete refresh tokens when access tokens deleted. https://review.openstack.org/153710 | 11:12 |
| ttx | looks like a pretty-tox fail | 11:13 |
| openstackgerrit | Merged openstack-infra/storyboard: OAuth now validates client ID against a configured list. https://review.openstack.org/153715 | 11:14 |
| yolanda | mm, i remember some comment from jeblair asking to remove pretty-tox? | 11:20 |
| rcarrillocruz | uh oh | 11:22 |
| rcarrillocruz | i think https://review.openstack.org/#/c/151645/ is not merging because it depends on a change that was set outdated | 11:22 |
| rcarrillocruz | ah nm | 11:23 |
| rcarrillocruz | it's one of the changes from the patch chain you were talking about | 11:23 |
| rcarrillocruz | i'll await | 11:24 |
| ttx | yolanda: might be some stuck node, because we managed to merge stuff | 11:24 |
| ttx | yolanda: your rename was incomplete, just commented | 11:26 |
| yolanda | ok, looking | 11:26 |
| ttx | taht might be what makes tests fail, but then the message is pretty misleading | 11:26 |
| * ttx lunches | 11:27 | |
| *** ssam2 has joined #storyboard | 11:28 | |
| yolanda | ttx, you are totally right, correcting it | 11:28 |
| openstackgerrit | yolanda.robla proposed openstack-infra/storyboard: Explicit Hook Priorities https://review.openstack.org/152253 | 11:30 |
| openstackgerrit | Aleksey Ripinen proposed openstack-infra/storyboard: Fix method is_valid in access_token api https://review.openstack.org/153997 | 11:44 |
| yolanda | ttx, change passed now, can you +2 it? | 12:05 |
| *** alexismonville has quit IRC | 12:26 | |
| openstackgerrit | Merged openstack-infra/storyboard: Explicit Hook Priorities https://review.openstack.org/152253 | 12:30 |
| *** alexismonville has joined #storyboard | 12:32 | |
| rcarrillocruz | nice | 12:32 |
| rcarrillocruz | so after the explicit hooks merged | 12:32 |
| rcarrillocruz | now https://review.openstack.org/#/c/151645/ is unmergeable :S | 12:32 |
| rcarrillocruz | i'll fetch the change and figure out the rebase | 12:36 |
| openstackgerrit | Aleksey Ripinen proposed openstack-infra/storyboard: Fix method checks.superuser https://review.openstack.org/154013 | 12:41 |
| *** alexismonville has quit IRC | 12:48 | |
| *** alexismonville has joined #storyboard | 12:51 | |
| openstackgerrit | Aleksey Ripinen proposed openstack-infra/storyboard: Added controller for refresh tokens https://review.openstack.org/153591 | 12:56 |
| ttx | rcarrillocruz: you actually need to rebase the whole patchseries. Otherwise you're just propagating the conflict one step higher in the chain | 12:56 |
| * ttx has a try | 12:58 | |
| openstackgerrit | Thierry Carrez proposed openstack-infra/storyboard: Email Templating Engine https://review.openstack.org/147734 | 13:02 |
| openstackgerrit | Thierry Carrez proposed openstack-infra/storyboard: API events now include resource before/after state. https://review.openstack.org/152318 | 13:02 |
| openstackgerrit | Thierry Carrez proposed openstack-infra/storyboard: Email configuration. https://review.openstack.org/151946 | 13:02 |
| openstackgerrit | Thierry Carrez proposed openstack-infra/storyboard: Pass the old entity values in the NotificationHook https://review.openstack.org/151645 | 13:02 |
| rcarrillocruz | ttx saw your new patchset, thx | 13:07 |
| ttx | I rebased up to the first patch without approvals | 13:08 |
| openstackgerrit | Merged openstack-infra/storyboard: Pass the old entity values in the NotificationHook https://review.openstack.org/151645 | 13:25 |
| openstackgerrit | Merged openstack-infra/storyboard: API events now include resource before/after state. https://review.openstack.org/152318 | 13:25 |
| openstackgerrit | Merged openstack-infra/storyboard: Email Templating Engine https://review.openstack.org/147734 | 13:26 |
| openstackgerrit | Merged openstack-infra/storyboard: Email configuration. https://review.openstack.org/151946 | 13:29 |
| mrmartin | hi | 13:46 |
| mrmartin | is it possible, that I can't create a new story? | 13:46 |
| mrmartin | I get back a HTTP 500 code. | 13:47 |
| mrmartin | yolanda are you here? | 13:52 |
| *** alexismonville has quit IRC | 13:52 | |
| yolanda | mm, crashes? | 13:52 |
| yolanda | that was my fear | 13:52 |
| yolanda | taking a look | 13:52 |
| mrmartin | yeap, I cannot even login in a different browser window | 13:52 |
| yolanda | there have been some merges today, let me take a look | 13:53 |
| yolanda | do you see this one? https://review.hpcloud.net/#/c/51853/ | 13:53 |
| yolanda | oops | 13:53 |
| yolanda | 500: POST /api/v1/openid/token?grant_type=refresh_token&refresh_token=MjpK1jKglvFNVFXrJcDv3P07ruDcZI: No error details available. | 13:53 |
| mrmartin | similar | 13:54 |
| yolanda | ok, going to debug locally | 13:54 |
| mrmartin | but I get back 500 too when I tried to post a story with a logged-in user. | 13:54 |
| yolanda | there have been some merges related with oauth, must be one of them | 13:56 |
| *** alexismonville has joined #storyboard | 13:56 | |
| rcarrillocruz | yah, i'm getting a 500 as well from refresh_token | 13:58 |
| yolanda | ahh, i want time for the integration tests. | 13:58 |
| yolanda | i wish days were longer | 13:58 |
| mrmartin | we all wish the same :) | 13:59 |
| rcarrillocruz | uh | 14:00 |
| rcarrillocruz | i can't even login | 14:00 |
| rcarrillocruz | let me check on my dev SB instance | 14:00 |
| *** jcoufal has quit IRC | 14:02 | |
| *** jcoufal has joined #storyboard | 14:02 | |
| yolanda | mm, something like invalid_grant | 14:03 |
| rcarrillocruz | yolanda, are you core on the SB instance? | 14:09 |
| rcarrillocruz | i can login on my SB instance, maybe a commit that breaks it that I don't have it locally | 14:09 |
| yolanda | rcarrillocruz, i'm not root on that instance, no | 14:09 |
| yolanda | but if you sync latest changes it fails | 14:10 |
| yolanda | locally | 14:10 |
| yolanda | it's something related to the oauth_validator changes | 14:14 |
| yolanda | ok, got it | 14:15 |
| yolanda | expiration date issues | 14:15 |
| yolanda | going to revert that change | 14:16 |
| rcarrillocruz | different problem on my side | 14:19 |
| rcarrillocruz | i get unauthorized_client, which seems to be happening due to "OAuth now validates client ID against a configured list." | 14:20 |
| yolanda | mm, worked for me when i commented that one | 14:20 |
| yolanda | have you upgraded schema as well? | 14:20 |
| openstackgerrit | yolanda.robla proposed openstack-infra/storyboard: Revert "OAuth tests for invalid authorization codes." https://review.openstack.org/154056 | 14:21 |
| yolanda | ok, i'm reverting this one | 14:23 |
| yolanda | failing for me, maybe because of timezones | 14:23 |
| *** wuhg has quit IRC | 14:29 | |
| openstackgerrit | yolanda.robla proposed openstack-infra/storyboard: Revert "OAuth tests for invalid authorization codes." https://review.openstack.org/154056 | 14:32 |
| yolanda | here, let's wait for it to pass and then we need an urgent approval | 14:32 |
| *** jcoufal has quit IRC | 14:34 | |
| *** jcoufal has joined #storyboard | 14:34 | |
| *** reed has joined #storyboard | 14:42 | |
| openstackgerrit | Nikita Konovalov proposed openstack-infra/storyboard: Fix exception in stories db api https://review.openstack.org/153968 | 14:46 |
| yolanda | mm, this patch doesn't apply cleanly | 14:50 |
| yolanda | i'll create a new one | 14:50 |
| openstackgerrit | yolanda.robla proposed openstack-infra/storyboard: Temporarily bypass expiration date check https://review.openstack.org/154069 | 15:09 |
| rcarrillocruz | yolanda: i find the problem for the 500 | 15:20 |
| rcarrillocruz | the map_resource function in NotificationHook was renamed | 15:21 |
| yolanda | mm, so that's another issue... | 15:21 |
| rcarrillocruz | to get_original_resource | 15:21 |
| rcarrillocruz | but in the same class we still call it to old name map_resource | 15:21 |
| rcarrillocruz | i'll push a change | 15:21 |
| yolanda | k, thx | 15:22 |
| openstackgerrit | Ricardo Carrillo Cruz proposed openstack-infra/storyboard: Rename map_resource call to get_original_resource https://review.openstack.org/154077 | 15:24 |
| openstackgerrit | yolanda.robla proposed openstack-infra/storyboard: Temporarily bypass expiration date check https://review.openstack.org/154069 | 15:26 |
| *** jcoufal_ has joined #storyboard | 15:26 | |
| krotscheck | You’d figure that adding all those tests would result in, you know, things NOT breaking with auth. | 15:26 |
| * krotscheck peers at those dates. | 15:28 | |
| rcarrillocruz | doh | 15:29 |
| *** jcoufal has quit IRC | 15:29 | |
| rcarrillocruz | the map_resource is still referenced in tests | 15:29 |
| rcarrillocruz | i'm prepping another patchset | 15:29 |
| krotscheck | Wait a sec. The tests let it _pass_? | 15:30 |
| krotscheck | That doesn’t sound like a very useful test. | 15:30 |
| rcarrillocruz | minor things , krotschec, there are mentions to map_resource in the tests, but just in docstrings | 15:32 |
| rcarrillocruz | krotscheck: ^ | 15:32 |
| krotscheck | rcarrillocruz: Oh, gotcha. | 15:32 |
| krotscheck | Clearly, we need more test. | 15:33 |
| krotscheck | It’s someone else’s job to write tests this week, I’m all tested out. | 15:33 |
| krotscheck | :D | 15:34 |
| yolanda | hi krotscheck | 15:34 |
| yolanda | busy monday as always | 15:35 |
| krotscheck | hi hi | 15:35 |
| krotscheck | Indeed | 15:35 |
| yolanda | so the expiration date check fails, i imagine that due to timezones | 15:35 |
| yolanda | i'm trying to bypass that check | 15:35 |
| yolanda | till we can look at it properly | 15:35 |
| krotscheck | Probably. Timezones are a rather large PITA. | 15:35 |
| krotscheck | Especially since mysql may not store in UTC. | 15:36 |
| yolanda | this is what i'm trying to push https://review.openstack.org/#/c/154069/ | 15:36 |
| krotscheck | Yeah, still waiting on jenkins | 15:36 |
| yolanda | so i tested locally ... expiration date of my token was few hours ago than my local time | 15:36 |
| krotscheck | You’re UTC -1, right? | 15:37 |
| rcarrillocruz | in other news | 15:38 |
| rcarrillocruz | i get alembic errors when running tox | 15:38 |
| rcarrillocruz | krotscheck: i'm NOT oncall this week, so let me know where you left off in terms of tests or what's needed to get done, i can tackle for real | 15:38 |
| krotscheck | rcarrillocruz: When I’ve gotten alembic errors, it usually means that the migration pyc files in storyboard/db/migration/migrations/somethingsomething no longer match what’s in the actual code. | 15:39 |
| krotscheck | rcarrillocruz: Notifications need tests. | 15:40 |
| rcarrillocruz | k | 15:40 |
| krotscheck | rcarrillocruz: In fact | 15:40 |
| krotscheck | rcarrillocruz: Here are 800 lines of subscription tests I wrote :) | 15:40 |
| krotscheck | https://review.openstack.org/#/c/143744/5/storyboard/tests/worker/task/test_subscription.py | 15:40 |
| krotscheck | The event constants are NOT the same. | 15:40 |
| krotscheck | And this particular event handling doesn’t use timeline_events anymore, it now uses the actual CRUD events from the resources. | 15:41 |
| krotscheck | So it might need to be adapted a bit. | 15:41 |
| krotscheck | But if you want to write some tests around the hooks- those are more critical because if they break the API goes down. | 15:41 |
| *** jcoufal_ has quit IRC | 15:43 | |
| *** jcoufal has joined #storyboard | 15:44 | |
| rcarrillocruz | hmm | 15:46 |
| rcarrillocruz | you getting this failure on tests? | 15:46 |
| rcarrillocruz | CommandError: Multiple head revisions are present for given argument 'head' | 15:46 |
| yolanda | mm, not here | 15:46 |
| rcarrillocruz | that by running 'python -m unittest2 storyboard/tests/notifications/test_notification_hook.py | 15:46 |
| krotscheck | Not here either. | 15:47 |
| krotscheck | Try rm -rf storyboard/db/migration/alembic_migrations/versions/*.pyc | 15:47 |
| rcarrillocruz | k, something hosed on my env | 15:48 |
| rcarrillocruz | let's merge https://review.openstack.org/#/c/154077/ | 15:48 |
| rcarrillocruz | got +1 | 15:48 |
| rcarrillocruz | we can push later to fix the docstrings, right now that causes a nice 500 | 15:48 |
| rcarrillocruz | i had some migration cruft indeed: | 15:50 |
| rcarrillocruz | ubuntu@storyboard:~/storyboard/storyboard/db/migration/alembic_migrations/versions$ rm 585eb4ff8bca_.py | 15:50 |
| rcarrillocruz | ubuntu@storyboard:~/storyboard/storyboard/db/migration/alembic_migrations/versions$ rm 585eb4ff8bca_.pyc | 15:50 |
| rcarrillocruz | that fixed it | 15:50 |
| rcarrillocruz | now running tests with tox | 15:50 |
| yolanda | krotscheck, change passed | 15:51 |
| yolanda | we shal approve it to have storyboard working | 15:51 |
| krotscheck | yolanda: aight | 15:53 |
| krotscheck | Any last minute items for the agenda? | 15:57 |
| yolanda | SB is broken? | 15:57 |
| yolanda | looks as the monday topic :) | 15:57 |
| krotscheck | :D | 15:58 |
| krotscheck | Yeah, well, at least we’re slowly learning. | 15:58 |
| krotscheck | Storyboard meeting in #openstack-meeting-3 | 16:00 |
| openstackgerrit | Merged openstack-infra/storyboard: Rename map_resource call to get_original_resource https://review.openstack.org/154077 | 16:08 |
| openstackgerrit | Merged openstack-infra/storyboard: Temporarily bypass expiration date check https://review.openstack.org/154069 | 16:13 |
| *** coolsvap is now known as coolsvap_ | 16:15 | |
| mrmartin | sb works for me now, thanks | 16:19 |
| yolanda | monday hotfix! | 16:22 |
| rcarrillocruz | heh, yeah, i'm seeing some other stuff breaking with notificationhook code :-), i'll dive into that shortly... | 16:25 |
| rcarrillocruz | getting this whne updating a task status on SB: | 16:29 |
| rcarrillocruz | http://paste.openstack.org/show/170041/ | 16:29 |
| rcarrillocruz | i'll look when meeting ends | 16:30 |
| openstackgerrit | Merged openstack-infra/storyboard: Prevent duplicate register_options call https://review.openstack.org/151630 | 16:33 |
| ttx | krotscheck: also there have been discussions about dropping pre-milestone targeting in OpenStack release processes, which would match nicely with our usage of milestone (i.e. we track the milestone fixes landed, rather than the promise that it will land in a given milestone) | 17:01 |
| * ttx likes being on both ends of the spectrum | 17:01 | |
| krotscheck | Oh, nice. | 17:01 |
| krotscheck | That’ll simplify things for us too :) | 17:01 |
| ttx | People are actually very bad at predicting when a change will land. | 17:02 |
| ttx | so that could all be replaced with the task list concept | 17:02 |
| *** coolsvap_ is now known as coolsvap | 17:02 | |
| ttx | if there are a list of tasks you want to track completion off for a given deadline, you can just create another task list | 17:02 |
| ttx | and promote it publicly | 17:03 |
| *** MaxV has quit IRC | 17:03 | |
| ttx | I uncovered the tension with LP using milestones both for pre-milestone promises and post-milestones completed-work in https://wiki.openstack.org/wiki/StoryBoard/Vision already | 17:04 |
| yolanda | they had a good tool, used upstream, with launchpad | 17:06 |
| yolanda | it had problems but with proper work and enabling needed functionality, they had it done | 17:06 |
| * krotscheck wanders off to commute to the office. | 17:08 | |
| krotscheck | bbiab | 17:08 |
| openstackgerrit | Ricardo Carrillo Cruz proposed openstack-infra/storyboard: Jsonify the result from get_original_resource https://review.openstack.org/154134 | 17:24 |
| *** jcoufal has quit IRC | 17:57 | |
| *** cawil has joined #storyboard | 18:07 | |
| openstackgerrit | Michael Krotscheck proposed openstack-infra/storyboard: Email base plugin. https://review.openstack.org/151948 | 18:15 |
| openstackgerrit | Michael Krotscheck proposed openstack-infra/storyboard: Email SMTP Sender https://review.openstack.org/149792 | 18:15 |
| openstackgerrit | Michael Krotscheck proposed openstack-infra/storyboard: [WIP] Email Send Cron Worker https://review.openstack.org/151416 | 18:15 |
| openstackgerrit | Michael Krotscheck proposed openstack-infra/storyboard: Email Working Directory Utility Method https://review.openstack.org/151947 | 18:15 |
| openstackgerrit | Michael Krotscheck proposed openstack-infra/storyboard: Email Outbox https://review.openstack.org/151413 | 18:15 |
| *** coolsvap is now known as coolsvap_ | 18:45 | |
| openstackgerrit | Michael Krotscheck proposed openstack-infra/storyboard: Jsonify the result from get_original_resource https://review.openstack.org/154134 | 18:45 |
| *** coolsvap_ is now known as coolsvap | 18:46 | |
| *** coolsvap is now known as coolsvap_ | 18:47 | |
| openstackgerrit | Merged openstack-infra/storyboard: Fix method checks.superuser https://review.openstack.org/154013 | 18:51 |
| openstackgerrit | Merged openstack-infra/storyboard: Fix method is_valid in access_token api https://review.openstack.org/153997 | 18:52 |
| *** ssam2 has quit IRC | 19:09 | |
| *** openstackgerrit has quit IRC | 19:41 | |
| *** openstackgerrit has joined #storyboard | 19:41 | |
| *** mrmartin has quit IRC | 20:00 | |
| *** alexismonville has quit IRC | 20:28 | |
| rcarrillocruz | wootz | 20:30 |
| rcarrillocruz | thx krotscheck, i throwed that jsonify change before leaving and saw you pushed a patchset to fix it :-) | 20:31 |
| krotscheck | rcarrillocruz: No worries :) | 20:31 |
| *** jedimike has quit IRC | 20:39 | |
| *** reed has quit IRC | 23:00 | |
| *** MarkAtwood has joined #storyboard | 23:41 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!