| *** openstackgerrit has quit IRC | 00:21 | |
| *** openstackgerrit has joined #storyboard | 00:21 | |
| nibalizer | -/win 37 | 00:22 |
|---|---|---|
| nibalizer | er | 00:22 |
| *** jedimike has joined #storyboard | 00:44 | |
| *** openstackgerrit has quit IRC | 01:05 | |
| *** openstackgerrit has joined #storyboard | 01:05 | |
| openstackgerrit | Michael Krotscheck proposed openstack-infra/storyboard: Email Templating Engine https://review.openstack.org/147734 | 01:10 |
| openstackgerrit | Michael Krotscheck proposed openstack-infra/storyboard: Added email sender and configuration. https://review.openstack.org/149792 | 01:10 |
| *** mase_x200 has joined #storyboard | 01:23 | |
| *** mase_x200 has quit IRC | 01:25 | |
| openstackgerrit | Michael Krotscheck proposed openstack-infra/storyboard: Recast exceptions in get_plugin_directory() https://review.openstack.org/151068 | 01:42 |
| openstackgerrit | Michael Krotscheck proposed openstack-infra/storyboard: subscription_helper now supports timeline_events https://review.openstack.org/150170 | 01:51 |
| openstackgerrit | Michael Krotscheck proposed openstack-infra/storyboard: Singularized resource names. https://review.openstack.org/150169 | 01:51 |
| *** jedimike has quit IRC | 02:13 | |
| *** openstackgerrit has quit IRC | 02:20 | |
| *** openstackgerrit has joined #storyboard | 02:21 | |
| *** mrmartin has joined #storyboard | 02:51 | |
| *** openstackgerrit has quit IRC | 03:20 | |
| *** openstackgerrit has joined #storyboard | 03:20 | |
| openstackgerrit | Michael Krotscheck proposed openstack-infra/storyboard: Email Templating Engine https://review.openstack.org/147734 | 03:35 |
| openstackgerrit | Michael Krotscheck proposed openstack-infra/storyboard: Added email sender and configuration. https://review.openstack.org/149792 | 03:35 |
| openstackgerrit | Michael Krotscheck proposed openstack-infra/storyboard: Created test class for temporary working directories https://review.openstack.org/151086 | 03:35 |
| openstackgerrit | Michael Krotscheck proposed openstack-infra/storyboard: Email Utility Methods https://review.openstack.org/151087 | 03:35 |
| *** mrmartin has quit IRC | 03:39 | |
| *** reed has quit IRC | 06:26 | |
| *** coolsvap|afk is now known as coolsvap | 07:10 | |
| *** mrmartin has joined #storyboard | 07:28 | |
| *** alexismonville has joined #storyboard | 07:46 | |
| *** jcoufal has joined #storyboard | 07:51 | |
| *** MaxV has joined #storyboard | 08:35 | |
| *** jtomasek has joined #storyboard | 08:38 | |
| yolanda | hi NikitaKonovalov, can you take a look at https://review.openstack.org/150027 ? | 09:01 |
| yolanda | project groups is broken | 09:01 |
| NikitaKonovalov | yolanda: sure. looking now | 09:01 |
| yolanda | ah, sorry | 09:01 |
| openstackgerrit | Merged openstack-infra/storyboard-webclient: Fix project groups controller https://review.openstack.org/150027 | 09:10 |
| yolanda | thx Nikita | 09:13 |
| * CTtpollard hopes this snow leaves england before his flight to FOSDEM tomorrow morning | 09:26 | |
| *** ssam2 has joined #storyboard | 09:27 | |
| yolanda | oh, i wanted to see snow here this year,but seems it won't happen | 11:31 |
| yolanda | over 13 degrees now, so no chances | 11:31 |
| rcarrillocruz | hmm | 11:33 |
| rcarrillocruz | ok | 11:33 |
| rcarrillocruz | i think i have how to sort out the notifications showing what has changed | 11:34 |
| rcarrillocruz | i put a before method in the notification hook that pulls the object from the DB that is about to be modified by the request | 11:35 |
| rcarrillocruz | jsonify it | 11:35 |
| rcarrillocruz | then in the after method i diff that json representation to what is returned in the response | 11:35 |
| rcarrillocruz | and flag what fields changed, then dump that to rabbitmq | 11:35 |
| *** yolanda has quit IRC | 11:46 | |
| *** yolanda has joined #storyboard | 11:47 | |
| *** yolanda has quit IRC | 11:47 | |
| *** yolanda has joined #storyboard | 11:49 | |
| *** yolanda has quit IRC | 11:51 | |
| *** yolanda has joined #storyboard | 11:52 | |
| *** yolanda has quit IRC | 11:52 | |
| *** yolanda has joined #storyboard | 11:53 | |
| *** jtomasek has quit IRC | 12:09 | |
| *** alexismonville has quit IRC | 12:23 | |
| openstackgerrit | Nikita Konovalov proposed openstack-infra/python-storyboardclient: Stories and Tasks support https://review.openstack.org/150067 | 12:38 |
| openstackgerrit | Nikita Konovalov proposed openstack-infra/storyboard: Refactor Tasks to work as a Subcontroller https://review.openstack.org/150052 | 12:45 |
| *** yolanda has quit IRC | 12:53 | |
| *** yolanda has joined #storyboard | 12:54 | |
| *** alexismonville has joined #storyboard | 12:57 | |
| *** jcoufal_ has joined #storyboard | 13:06 | |
| *** jtomasek has joined #storyboard | 13:09 | |
| *** jcoufal has quit IRC | 13:09 | |
| openstackgerrit | Merged openstack-infra/storyboard: Corrected usage of subscription helper. https://review.openstack.org/150150 | 13:14 |
| *** alexismonville has quit IRC | 13:15 | |
| openstackgerrit | Merged openstack-infra/storyboard: Singularized resource names. https://review.openstack.org/150169 | 13:15 |
| openstackgerrit | Merged openstack-infra/storyboard: subscription_helper now supports timeline_events https://review.openstack.org/150170 | 13:17 |
| openstackgerrit | Merged openstack-infra/storyboard: Recast exceptions in get_plugin_directory() https://review.openstack.org/151068 | 13:17 |
| openstackgerrit | Merged openstack-infra/storyboard: Created test class for temporary working directories https://review.openstack.org/151086 | 13:17 |
| openstackgerrit | Merged openstack-infra/python-storyboardclient: Adding pretty-tox https://review.openstack.org/150417 | 13:19 |
| *** alexismonville has joined #storyboard | 13:27 | |
| yolanda | woot, tons of merges | 13:43 |
| openstackgerrit | Nikita Konovalov proposed openstack-infra/storyboard: Fix status code for delete endpoint. https://review.openstack.org/151254 | 14:13 |
| *** CTtpollard has quit IRC | 14:32 | |
| *** mattfarina has joined #storyboard | 14:33 | |
| *** CTtpollard has joined #storyboard | 14:40 | |
| *** Piet has joined #storyboard | 15:09 | |
| openstackgerrit | Michael Krotscheck proposed openstack-infra/storyboard: Email Templating Engine https://review.openstack.org/147734 | 15:24 |
| openstackgerrit | Michael Krotscheck proposed openstack-infra/storyboard: Added email sender and configuration. https://review.openstack.org/149792 | 15:24 |
| openstackgerrit | Michael Krotscheck proposed openstack-infra/storyboard: Email Utility Methods https://review.openstack.org/151087 | 15:24 |
| *** mattfarina has quit IRC | 15:25 | |
| * krotscheck is on the rebase train! | 15:27 | |
| yolanda | can there be a more annoying thing than rebasing? | 15:27 |
| yolanda | i was reading an article about a comand for git called git rere or somewhat like that, that was remembering your preferences when rebasing | 15:27 |
| krotscheck | You know, it is a bit annoying, but I’ve come to this fun zen place where I just go git rebase -i master, then switch all the pick’s to edit’s, and slowly reconstruct my code :) | 15:28 |
| yolanda | the worse end for it is that when you are rebasing and you discover that the change you've worked so hard makes no sense now | 15:30 |
| krotscheck | Oh yea. | 15:31 |
| krotscheck | Does anyone remember why we do not permit underscores in project names | 15:32 |
| krotscheck | ? | 15:32 |
| krotscheck | We’ve got a few infra projects that contain them. | 15:32 |
| yolanda | we should permit... | 15:32 |
| yolanda | krotscheck, can you take a look at the integration tests spec when you have time between rebases? :) | 15:35 |
| yolanda | https://review.openstack.org/150743 | 15:35 |
| * yolanda is totally losing a battle with VMWare today | 15:35 | |
| rcarrillocruz | and when that rebase is because your code has moved away to other repo due to a split is EVEN more annoying | 15:35 |
| *** mattfarina has joined #storyboard | 15:37 | |
| openstackgerrit | Michael Krotscheck proposed openstack-infra/storyboard: Added underscores as permitted in a nametype. https://review.openstack.org/151280 | 15:37 |
| krotscheck | yolanda: I’ll trade ya : https://review.openstack.org/#/c/151280/ | 15:40 |
| yolanda | heh | 15:40 |
| yolanda | krotscheck, are there tests for validating the project name? | 15:41 |
| krotscheck | yolanda: I don’t know? We’ll know as soon as zuul comes along. | 15:42 |
| yolanda | if there are they may be using nametype as well so we'll be fine | 15:43 |
| *** jtomasek has quit IRC | 15:44 | |
| rcarrillocruz | krotscheck: do you know if there's an available method to jsonify an entity? | 15:44 |
| rcarrillocruz | e.g. taking a Task to json format | 15:45 |
| rcarrillocruz | i've been using pecan.jsonify, but i was wondering if oslo.db.sqlalchemy has some method for that | 15:45 |
| krotscheck | rcarrillocruz: There’s no wrapper to jsonify that I know of. I do believe that using it is the right thing to do here, since it means we’re only using one json encoder across the whole system. | 15:48 |
| NikitaKonovalov | krotscheck: re underscore, there was an idea to allow access to project by name in the url, and underscore should be escaped then | 16:03 |
| NikitaKonovalov | I guess people just didnt want to have %5F in project name | 16:04 |
| krotscheck | NikitaKonovalov: Well, they want it now, so meh. | 16:05 |
| * krotscheck actually wonders if it’s ok to have an underscore in the url fragment... | 16:05 | |
| krotscheck | NikitaKonovalov: Turns out underscores are safe -> https://tools.ietf.org/html/rfc3986#section-2.3 | 16:06 |
| NikitaKonovalov | I'm ok with having underscores if browsers are | 16:08 |
| openstackgerrit | George Peristerakis proposed openstack-infra/storyboard: Whitelisted bash in the tox configuration https://review.openstack.org/151293 | 16:08 |
| *** mattfarina has quit IRC | 16:14 | |
| openstackgerrit | Michael Krotscheck proposed openstack-infra/storyboard: Email Templating Engine https://review.openstack.org/147734 | 16:16 |
| openstackgerrit | Michael Krotscheck proposed openstack-infra/storyboard: Added email sender and configuration. https://review.openstack.org/149792 | 16:16 |
| openstackgerrit | Michael Krotscheck proposed openstack-infra/storyboard: Email Utility Methods https://review.openstack.org/151087 | 16:16 |
| krotscheck | I didn’t realize that ordered dicts are a thing. | 16:16 |
| openstackgerrit | Aleksey Ripinen proposed openstack-infra/storyboard: Added branches to storyboard https://review.openstack.org/150447 | 16:20 |
| yolanda | krotscheck, what do you think about the spec apart than my horrible typo? | 16:23 |
| *** mrmartin has quit IRC | 16:28 | |
| *** mrmartin has joined #storyboard | 16:28 | |
| openstackgerrit | Merged openstack-infra/storyboard: Added underscores as permitted in a nametype. https://review.openstack.org/151280 | 16:30 |
| *** mrmartin has quit IRC | 16:32 | |
| *** mattfarina has joined #storyboard | 16:43 | |
| openstackgerrit | Aleksey Ripinen proposed openstack-infra/storyboard: Added branches to storyboard https://review.openstack.org/150447 | 16:55 |
| *** peristeri has joined #storyboard | 16:56 | |
| *** coolsvap is now known as coolsvap|afk | 17:10 | |
| *** CTtpollard has quit IRC | 17:26 | |
| *** ssam2 has quit IRC | 17:32 | |
| *** MaxV has quit IRC | 17:32 | |
| *** MaxV has joined #storyboard | 17:33 | |
| *** jcoufal_ has quit IRC | 17:35 | |
| *** MaxV has quit IRC | 17:38 | |
| *** reed has joined #storyboard | 18:00 | |
| *** coolsvap|afk is now known as coolsvap | 18:22 | |
| *** alexismonville has quit IRC | 18:30 | |
| *** MaxV has joined #storyboard | 18:43 | |
| *** MaxV has quit IRC | 18:47 | |
| *** openstackgerrit has quit IRC | 18:50 | |
| *** openstackgerrit has joined #storyboard | 18:51 | |
| *** yolanda has quit IRC | 18:56 | |
| *** coolsvap is now known as coolsvap|afk | 18:56 | |
| openstackgerrit | Michael Krotscheck proposed openstack-infra/storyboard: Email Templating Engine https://review.openstack.org/147734 | 19:26 |
| openstackgerrit | Michael Krotscheck proposed openstack-infra/storyboard: Added email sender and configuration. https://review.openstack.org/149792 | 19:26 |
| openstackgerrit | Michael Krotscheck proposed openstack-infra/storyboard: Email Utility Methods https://review.openstack.org/151087 | 19:26 |
| *** reed has quit IRC | 19:27 | |
| rcarrillocruz | krotscheck: ping | 19:42 |
| rcarrillocruz | are you around? | 19:42 |
| krotscheck | rcarrillocruz: Yep, what’s up | 19:43 |
| rcarrillocruz | i've done progress in the notifications, i figured how to dump into the rabbitmq exchange what has changed in a resource on PUT operations | 19:43 |
| krotscheck | NICE | 19:44 |
| rcarrillocruz | what i do is add a 'before' method in the NotificationHook, and get the resource and resource_id | 19:44 |
| krotscheck | Right | 19:44 |
| krotscheck | And then store it on request.context? | 19:44 |
| rcarrillocruz | then I pull the whole entity and pass it on to the state object, that is shared and thread-safe in the hook | 19:44 |
| krotscheck | Or that :) | 19:44 |
| rcarrillocruz | and then I compare it to the response given on the 'after' | 19:44 |
| rcarrillocruz | is it ok ? | 19:44 |
| krotscheck | That seems like a good solution, do you have a review? | 19:45 |
| rcarrillocruz | it's an additional sql query, but i guess is better than pulling the notifications out of pecan hooks... | 19:45 |
| rcarrillocruz | i'll do shortly, prolly tomorrow | 19:45 |
| rcarrillocruz | i have it a POC, but wanted to check first if you were ok with the approach | 19:45 |
| krotscheck | rcarrillocruz: For the sake of simplicity though, don’t worry about comparing the diff in the after hook. Let’s just send the entire before/after entity and let the subscriber decide what they want to do about it. | 19:45 |
| rcarrillocruz | oh | 19:45 |
| rcarrillocruz | nice | 19:45 |
| rcarrillocruz | you simplified my life | 19:45 |
| rcarrillocruz | lol | 19:45 |
| rcarrillocruz | :D | 19:45 |
| rcarrillocruz | thx, i'll do that then | 19:46 |
| krotscheck | rcarrillocruz: Sec, lemme show you the API I had in mind.... | 19:46 |
| krotscheck | rcarrillocruz: https://review.openstack.org/#/c/143744/5/storyboard/notifications/publisher.py | 19:46 |
| krotscheck | (incidentally, that patchset is missing exactly the modification that you’re working on before I can land it.) | 19:47 |
| krotscheck | :D | 19:47 |
| krotscheck | Although I should probably split the event names out into a different patch | 19:48 |
| rcarrillocruz | i see | 19:49 |
| rcarrillocruz | ok, let's sync up | 19:49 |
| krotscheck | Really, I just have 800 lines of tests in there for the subscription handler that I really want to land :/ | 19:49 |
| rcarrillocruz | i'll let you know when i have the change ready | 19:49 |
| krotscheck | rcarrillocruz: Awesome, thanks :) | 19:49 |
| *** petefoth1ringham has joined #storyboard | 19:51 | |
| *** tteggel_ has joined #storyboard | 19:52 | |
| *** perister1 has joined #storyboard | 19:54 | |
| *** petefotheringham has quit IRC | 19:56 | |
| *** tteggel has quit IRC | 19:56 | |
| *** peristeri has quit IRC | 19:56 | |
| *** openstackgerrit has quit IRC | 20:04 | |
| *** alexismonville has joined #storyboard | 20:04 | |
| *** openstackgerrit has joined #storyboard | 20:05 | |
| *** alexismonville has quit IRC | 20:16 | |
| *** alexismonville has joined #storyboard | 20:33 | |
| *** alexismonville has quit IRC | 20:33 | |
| *** petefoth1ringham has left #storyboard | 20:44 | |
| *** mrmartin has joined #storyboard | 21:01 | |
| *** MaxV has joined #storyboard | 21:41 | |
| *** mrmartin has quit IRC | 21:51 | |
| *** Piet has quit IRC | 21:59 | |
| *** MaxV has quit IRC | 22:00 | |
| *** Piet has joined #storyboard | 22:14 | |
| *** mattfarina has quit IRC | 22:32 | |
| *** perister1 has quit IRC | 22:34 | |
| openstackgerrit | Michael Krotscheck proposed openstack-infra/storyboard: Email Templating Engine https://review.openstack.org/147734 | 22:42 |
| openstackgerrit | Michael Krotscheck proposed openstack-infra/storyboard: Added email sender and configuration. https://review.openstack.org/149792 | 22:42 |
| openstackgerrit | Michael Krotscheck proposed openstack-infra/storyboard: Email Utility Methods https://review.openstack.org/151087 | 22:42 |
| openstackgerrit | Michael Krotscheck proposed openstack-infra/storyboard: Email Outbox https://review.openstack.org/151413 | 22:42 |
| *** openstackgerrit has quit IRC | 22:51 | |
| *** openstackgerrit has joined #storyboard | 22:52 | |
| openstackgerrit | Michael Krotscheck proposed openstack-infra/storyboard: [WIP] Send Email Worker https://review.openstack.org/151416 | 22:54 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!