| *** MaxV has joined #storyboard | 01:13 | |
| *** MaxV has quit IRC | 01:18 | |
| *** MaxV has joined #storyboard | 03:02 | |
| *** MaxV has quit IRC | 03:07 | |
| *** MaxV has joined #storyboard | 03:25 | |
| *** MaxV has quit IRC | 03:30 | |
| *** jcoufal has joined #storyboard | 06:19 | |
| *** alexismonville has joined #storyboard | 07:13 | |
| *** mrmartin has joined #storyboard | 07:20 | |
| *** jtomasek has joined #storyboard | 07:27 | |
| *** MaxV has joined #storyboard | 07:53 | |
| *** MaxV has quit IRC | 08:07 | |
| *** MaxV has joined #storyboard | 08:08 | |
| *** MaxV has quit IRC | 08:14 | |
| *** MaxV has joined #storyboard | 08:49 | |
| *** rcarrillocruz has joined #storyboard | 08:49 | |
| *** CTtpollard has joined #storyboard | 09:00 | |
| *** ilyashakhat has joined #storyboard | 09:02 | |
| *** tteggel_ is now known as tteggel | 09:26 | |
| *** tteggel has quit IRC | 09:26 | |
| *** tteggel has joined #storyboard | 09:26 | |
| *** ssam2 has joined #storyboard | 10:00 | |
| *** yolanda has joined #storyboard | 10:18 | |
| openstackgerrit | Merged openstack-infra/storyboard: Task status endpoint now matches api https://review.openstack.org/147335 | 10:43 |
|---|---|---|
| openstackgerrit | Merged openstack-infra/python-storyboardclient: Project Groups and Projects support https://review.openstack.org/147104 | 11:04 |
| rcarrillocruz | krotscheck: have day-job meetings, won't be able to attend today's meeting. I will update this week my progress on the channel | 11:05 |
| openstackgerrit | Merged openstack-infra/storyboard-webclient: Gruntfile Connect Hostname commandline option https://review.openstack.org/138053 | 11:06 |
| rcarrillocruz | yolanda: ^ | 11:07 |
| rcarrillocruz | oh | 11:07 |
| rcarrillocruz | i like that gruntfile connect change | 11:07 |
| rcarrillocruz | no more modifications to gruntfile needed | 11:08 |
| yolanda | yes, useful change | 11:08 |
| CTtpollard | awesome :) | 11:49 |
| CTtpollard | glad my original patch was able to be modified for it | 11:49 |
| CTtpollard | 'Documentation will be updated in a separate commit on | 11:50 |
| CTtpollard | openstack-infra/storyboard' I could look to do this if I get pointed to the right place | 11:50 |
| yolanda | CTtpollard, there is a doc/source/ in storyboard project | 11:51 |
| CTtpollard | What are we looking to be added, anything beyond --hostname VALUE letting you bind to different address for vm port forwarding ? | 11:52 |
| yolanda | yes, something in that way, explaining the flag | 11:58 |
| CTtpollard | I'll get onto it when I'm away from work to FOSDEM on friday if it's not done before then | 12:00 |
| rcarrillocruz | fosdem, nice! | 12:02 |
| rcarrillocruz | where are you based CTtpollard? | 12:02 |
| CTtpollard | Manchester, England rcarrillocruz :) | 12:02 |
| rcarrillocruz | fosdem is Belgium , right? | 12:05 |
| CTtpollard | yeh Brussels :) | 12:07 |
| rcarrillocruz | i think nibalizer and pleia2 are going, they are colleagues from our team, make sure you meet them :-) | 12:12 |
| ttx | I'll be introducing StoryBoard as part of my FOSDEM presentation, for those interested | 12:25 |
| rcarrillocruz | that's shame we can't attend | 12:25 |
| rcarrillocruz | ttx: are FOSDEM presentations recorded? do you know? | 12:25 |
| ttx | In theory yes | 12:26 |
| ttx | last year was a bit of a disaster though, but they are supposed to have changed everything | 12:26 |
| yolanda | ttx , please share it | 12:26 |
| yolanda | i 'd like to have attended as well | 12:26 |
| rcarrillocruz | nice | 12:27 |
| rcarrillocruz | in other news, seems like I cannot create stories in SB... | 12:27 |
| rcarrillocruz | tried with Linux Chromium and Chrome in windows | 12:27 |
| rcarrillocruz | i get 400 | 12:27 |
| rcarrillocruz | https://storyboard.openstack.org/api/v1/stories Failed to load resource: the server responded with a status of 400 (Bad Request) | 12:27 |
| rcarrillocruz | libs.js:3 POST https://storyboard.openstack.org/api/v1/stories 400 (Bad Request) | 12:27 |
| rcarrillocruz | from chrome inspector | 12:28 |
| CTtpollard | ttx: do you have a url to your talk please so I can add it to my calendar? | 12:28 |
| ttx | CTtpollard: https://fosdem.org/2015/schedule/event/openstack_infra_tools_to_borrow/ | 12:28 |
| CTtpollard | cheers | 12:29 |
| rcarrillocruz | yolanda: should we send a mail to the ML then, since we can't open a bug about SB not being able to open bugs | 12:29 |
| yolanda | here, so looks as latest changes raised a bug on creating stories | 12:29 |
| yolanda | {"field":"","message":"Additional properties are not allowed (u'project_id' was unexpected)"} | 12:29 |
| yolanda | that's shown on response when creating a new story | 12:29 |
| rcarrillocruz | yay | 12:29 |
| yolanda | going to send an email and debug it | 12:30 |
| *** alexismonville has quit IRC | 12:30 | |
| *** alexismonville has joined #storyboard | 12:47 | |
| *** NikitaKonovalov has quit IRC | 12:51 | |
| *** SergeyLukjanov has quit IRC | 12:51 | |
| *** SergeyLukjanov has joined #storyboard | 12:52 | |
| *** NikitaKonovalov has joined #storyboard | 12:53 | |
| openstackgerrit | yolanda.robla proposed openstack-infra/storyboard-webclient: Remove project_id from story https://review.openstack.org/150026 | 13:17 |
| yolanda | ttx, NikitaKonovalov, urgent bugfix | 13:18 |
| *** mase_x200 has joined #storyboard | 13:19 | |
| ttx | yolanda: ok, waiting for tests to pass | 13:22 |
| yolanda | i'm debugging all webclient because i think new validations are causing more problems as well | 13:23 |
| yolanda | but i prefer one change for each bug | 13:23 |
| openstackgerrit | Nikita Konovalov proposed openstack-infra/storyboard: Added tags controllers https://review.openstack.org/114217 | 13:24 |
| openstackgerrit | yolanda.robla proposed openstack-infra/storyboard-webclient: Fix project groups controller https://review.openstack.org/150027 | 13:48 |
| yolanda | more fixes... | 13:48 |
| yolanda | ttx, change passed, we should +2 +1 as soon as possible as it's a critical bug, no stories can be created now | 13:50 |
| ttx | +2ed | 13:51 |
| yolanda | shall we +1 only with your vote as it's critical thing? | 13:52 |
| ttx | yolanda: let's get another +1 on it and I'll Workflow+1 it | 13:53 |
| yolanda | ok, ricardocarrillocruz looking,as he noticed the bug | 13:54 |
| ttx | we can also ask regular infra-core people | 13:55 |
| yolanda | yes, problem is the time, maybe SergeyLukjanov? | 13:55 |
| * SergeyLukjanov here now | 13:56 | |
| ttx | yolanda: fungi should be online really soon | 13:56 |
| SergeyLukjanov | yolanda, ttx, are you talking about 150027? | 13:56 |
| yolanda | SergeyLukjanov https://review.openstack.org/150026 | 13:56 |
| yolanda | that's more critical | 13:56 |
| ttx | SergeyLukjanov: great, have a look at urgent fix @ https://review.openstack.org/150026 | 13:56 |
| * SergeyLukjanov looking | 13:57 | |
| yolanda | i'm just reviewing all frontend as i detected more issues, but the urgent one is that we cannot create stories | 13:57 |
| ttx | yolanda: why was project_id passed in the first place ? | 13:57 |
| yolanda | i think it's a legacy thing | 13:57 |
| yolanda | as it's passed as null | 13:57 |
| ttx | patch looks good, just trying to understand it | 13:57 |
| yolanda | and project_id don't belong to the story model, only tasks have it | 13:58 |
| ttx | ack | 13:58 |
| yolanda | we have this extra validation now in the backend | 13:58 |
| yolanda | that rejects fields that don't belong to the model when they are sent by post | 13:58 |
| yolanda | and this is causing trouble | 13:58 |
| SergeyLukjanov | ttx, yolanda, approved | 13:58 |
| yolanda | k, thx | 13:58 |
| ttx | thx | 13:58 |
| yolanda | there are more issues related to that, but validation is good, is frontend that needs to be fixed, from my point of view | 13:59 |
| openstackgerrit | yolanda.robla proposed openstack-infra/storyboard-webclient: Fix project groups controller https://review.openstack.org/150027 | 14:05 |
| openstackgerrit | Merged openstack-infra/storyboard-webclient: Remove project_id from story https://review.openstack.org/150026 | 14:06 |
| yolanda | mm, ttx, the new validation method is crashing on every update | 14:18 |
| yolanda | we cannot update tasks, stories... due to that | 14:19 |
| ttx | hah! | 14:19 |
| yolanda | do you think we could just revert that change and properly fix it? | 14:19 |
| yolanda | that's a fragment of the story i wanted to create: | 14:19 |
| yolanda | Storyboard is sending following fields by default: | 14:19 |
| yolanda | - created_at | 14:19 |
| yolanda | - updated_at | 14:19 |
| yolanda | - creator_id | 14:19 |
| yolanda | As these fields are not part of the original models, but from base, the new validation controls added on storyboard backend are preventing nearly ANY update to work. Sample of updating a task: | 14:19 |
| yolanda | {"field":"","message":"Additional properties are not allowed (u'creator_id', u'created_at', u'updated_at', u'id' were unexpected)"} | 14:19 |
| yolanda | Either this type of validation needs to be removed or improved to allow these fields as an exception | 14:19 |
| ttx | yolanda: maybe prepare a revert, and we'll discuss it first thing at the meeting ? | 14:20 |
| yolanda | ok, quite a blocker now for storyboard | 14:21 |
| yolanda | i was trying to do fixes for it but i found it's a problem from the backend at the end | 14:21 |
| openstackgerrit | yolanda.robla proposed openstack-infra/storyboard: Revert "Controlling fields in requests with jsonschema" https://review.openstack.org/150035 | 14:23 |
| *** yolanda changes topic to "StoryBoard - Found bugs updating entities, fix on progress - A task tracker for OpenStack development needs :: http://storyboard.openstack.org/ :: https://wiki.openstack.org/wiki/StoryBoard" | 14:24 | |
| yolanda | ttx, ok , that was the revert, and i updated the topic in the meantime | 14:25 |
| *** jedimike has joined #storyboard | 14:30 | |
| *** mattfarina has joined #storyboard | 14:36 | |
| *** mase_x200 has quit IRC | 14:37 | |
| openstackgerrit | Nikita Konovalov proposed openstack-infra/storyboard: Refactor Tasks to work as a Subcontroller https://review.openstack.org/150052 | 15:09 |
| rcarrillocruz | have a couple bugs to open when SB recovers... | 15:11 |
| rcarrillocruz | PUT on tasks return 400, even though they change in UI | 15:11 |
| rcarrillocruz | should be 200/201 | 15:11 |
| rcarrillocruz | and storyboard_worker_daemon stacktraces on me, something about not being able to register CLI options | 15:11 |
| openstackgerrit | Ricardo Carrillo Cruz proposed openstack-infra/storyboard: Add UTC datetime on event hook https://review.openstack.org/150061 | 15:38 |
| openstackgerrit | Nikita Konovalov proposed openstack-infra/python-storyboardclient: Stories and Tasks support https://review.openstack.org/150067 | 15:41 |
| krotscheck | Hrm | 15:58 |
| yolanda | krotscheck, today is not a good day | 15:59 |
| yolanda | we have troubles with schema validation | 16:00 |
| krotscheck | I can see that. | 16:00 |
| krotscheck | StoryBoard Meeting in #openstack-meeting-3 | 16:00 |
| openstackgerrit | Merged openstack-infra/storyboard: Revert "Controlling fields in requests with jsonschema" https://review.openstack.org/150035 | 16:08 |
| yolanda | so.. what do we do with that revert? we need to rewrite it? maybe accept additional fields , not controlling that? or make sure that we are covering all cases and validate it properly? | 17:02 |
| openstackgerrit | yolanda.robla proposed openstack-infra/storyboard-webclient: Add missing subscription button to story detail https://review.openstack.org/149595 | 17:04 |
| krotscheck | If the validation framework allows us to set up some fields to ignore, that might make the most sense. Either way, we should test the crap out of it. | 17:06 |
| yolanda | i see something like: "additionalProperties": False | 17:08 |
| yolanda | maybe we could update it to "additionalProperties" :[created_at, updated_at, ...] | 17:08 |
| jedimike | krotscheck, i hate reporting statuses like that :( hopefully things will quieten down after this week and i'll be able to get back on here more | 17:09 |
| pleia2 | CTtpollard: hope to meet you at fosdem :) nibalizer and I are both speaking on the config mgmt track: https://fosdem.org/2015/schedule/track/configuration_management/ | 17:28 |
| pleia2 | we've both signed up for shifts at the openstack booth too | 17:28 |
| nibalizer | CTtpollard: pleia2 lets do it! | 17:29 |
| CTtpollard | :) | 17:29 |
| CTtpollard | I'll add to my calendar tomorrow, I'm about to shoot off for the evening | 17:30 |
| pleia2 | have a good evening | 17:30 |
| mrmartin | pleia2: you'll be there with me on saturday from 14.00 | 17:38 |
| *** MaxV has quit IRC | 17:39 | |
| pleia2 | mrmartin: so I am, should be fun :) | 17:39 |
| mrmartin | pleia2: will you travel from the States? | 17:40 |
| pleia2 | mrmartin: yes, coming in from California | 17:40 |
| mrmartin | I just heard that a lot a flight canceld due to heavy storms, I hope it won't affect your flights. | 17:42 |
| *** ssam2 has quit IRC | 17:43 | |
| pleia2 | mrmartin: thanks, fortunately I'm not flying out until Thursday, the storm should be cleared up by then | 18:00 |
| *** jeblair has joined #storyboard | 18:08 | |
| *** jcoufal has quit IRC | 18:37 | |
| *** reed has joined #storyboard | 19:04 | |
| yolanda | here, is Recent events working for you? | 19:07 |
| yolanda | not seeing any event although i'm subscribed to some stories with activity | 19:07 |
| krotscheck | sec | 19:08 |
| krotscheck | yolanda: Also noticing that. | 19:20 |
| krotscheck | It’s on my list of things to work on. | 19:21 |
| yolanda | never ending list... | 19:21 |
| openstackgerrit | Merged openstack-infra/storyboard: Working Directory fails consistenly. https://review.openstack.org/149454 | 19:23 |
| krotscheck | yep | 19:23 |
| krotscheck | I’ll look at it right after I handle the various gerrit comments. | 19:23 |
| krotscheck | My taks for today is “Get it all working well" | 19:23 |
| openstackgerrit | Michael Krotscheck proposed openstack-infra/storyboard: Added an API test for malicious user updates. https://review.openstack.org/149372 | 19:30 |
| openstackgerrit | Michael Krotscheck proposed openstack-infra/storyboard-webclient: An experimental improvement on the dashboard event list. https://review.openstack.org/149127 | 19:33 |
| openstackgerrit | Michael Krotscheck proposed openstack-infra/storyboard-webclient: Parse event_info into JSON. https://review.openstack.org/149126 | 19:33 |
| rcarrillocruz | folks, the 'events' table, what's the purpose of 'modified_at'? On my SB instance, all rows have it NULL, and that makes sense to me. An event is something that happens and gets recorded, but not something you modify in the future | 19:47 |
| rcarrillocruz | thoughts? | 19:47 |
| rcarrillocruz | unless there'a reason for having it , i would make a change to remove it... | 19:48 |
| krotscheck | rcarrillocruz: it’s a column that is inherited for all entities. In this case it doesn’t do much. | 19:48 |
| rcarrillocruz | ah | 19:48 |
| rcarrillocruz | so it's due to inheritance. | 19:48 |
| krotscheck | rcarrillocruz: Yep. | 19:48 |
| rcarrillocruz | a SQLAlchemy thing? | 19:48 |
| rcarrillocruz | i'm not aware of inheritance in SQL tables | 19:48 |
| krotscheck | rcarrillocruz: It’s an oslo_db inheritance thing that comes from TimestampMixin | 19:49 |
| * rcarrillocruz goes to look | 19:49 | |
| rcarrillocruz | k thx | 19:49 |
| krotscheck | jedimike: No worries :) | 19:50 |
| rcarrillocruz | krotscheck: i see a bit of drift in terms of fields comparing 'events' table and the events being notified to RabbitMQ | 19:50 |
| krotscheck | drift? | 19:51 |
| rcarrillocruz | reason i checked is because i think it's better to handle the 'reconnect to on-demand queue if websocket comes back in a short time' with queues and handle 'replay me this events since date X' with SQL queries against 'events' table, rather than doing both with rabbitmq | 19:52 |
| rcarrillocruz | i was expecting the same kind of info in 'events' table on the 'events' notification in RabbitMQ | 19:52 |
| rcarrillocruz | for example, no datetime on when the event was published | 19:53 |
| rcarrillocruz | old value vs new value in PUT operations | 19:53 |
| rcarrillocruz | and a few more | 19:53 |
| rcarrillocruz | i'll wrap up an email and send to the ML to show all differences I can see | 19:54 |
| krotscheck | rcarrillocruz: Works for me. That, plus data diff, are things I was starting to work on in that enormous WIP patch of mine. | 19:55 |
| rcarrillocruz | i'd love to have the same info doing on a websocket 'replay me tasks since date X' as when you are regularly listening to events from Rabbitmq with 'subscribe tasks' | 19:55 |
| rcarrillocruz | k | 19:55 |
| rcarrillocruz | let me -1 my change on the event datetime then, i'll widen the scope | 19:55 |
| krotscheck | I got hung up on email though. The tricky bit was that it’s not easy to capture the entity before it was changed. | 19:56 |
| rcarrillocruz | yeah, i guess it's due to the nature of doing the notification with a pecan hook, i saw your approach of guessing what was done by reading the request | 19:56 |
| rcarrillocruz | i'll see what i can do | 19:56 |
| krotscheck | rcarrillocruz: I was starting to play around with decorators, but didnt’ get very far. Also, i ran into the fact that our DB session is destroyed after every query, so even if we load the entity at every request to capture it, it would just get reloaded as soon as the actual method logic started to execute. | 19:58 |
| openstackgerrit | Michael Krotscheck proposed openstack-infra/storyboard: Revert "Working Directory fails consistenly." https://review.openstack.org/150129 | 20:02 |
| krotscheck | ARGH | 20:03 |
| openstackgerrit | Michael Krotscheck proposed openstack-infra/storyboard: Fixed working directory log message. https://review.openstack.org/150133 | 20:13 |
| openstackgerrit | Merged openstack-infra/storyboard: Fixed working directory log message. https://review.openstack.org/150133 | 20:22 |
| *** alexismonville has quit IRC | 20:33 | |
| openstackgerrit | Merged openstack-infra/storyboard: Added tags controllers https://review.openstack.org/114217 | 20:35 |
| openstackgerrit | Michael Krotscheck proposed openstack-infra/storyboard-webclient: An experimental improvement on the dashboard event list. https://review.openstack.org/149127 | 20:38 |
| openstackgerrit | Merged openstack-infra/storyboard: Added an API test for malicious user updates. https://review.openstack.org/149372 | 20:40 |
| openstackgerrit | Merged openstack-infra/storyboard-webclient: Add extra confirmation when removing the last task of a story https://review.openstack.org/149588 | 20:44 |
| *** alexismonville has joined #storyboard | 21:00 | |
| *** jedimike has quit IRC | 21:10 | |
| openstackgerrit | Michael Krotscheck proposed openstack-infra/storyboard: Corrected usage of subscription helper. https://review.openstack.org/150150 | 21:17 |
| *** jtomasek has quit IRC | 21:22 | |
| *** alexismonville has quit IRC | 21:30 | |
| *** mrmartin has quit IRC | 22:00 | |
| openstackgerrit | Michael Krotscheck proposed openstack-infra/storyboard: Singularized resource names. https://review.openstack.org/150169 | 22:33 |
| openstackgerrit | Michael Krotscheck proposed openstack-infra/storyboard: subscription_helper now supports timeline_events https://review.openstack.org/150170 | 22:33 |
| *** mattfarina has quit IRC | 22:39 | |
| openstackgerrit | Michael Krotscheck proposed openstack-infra/storyboard: subscription_helper now supports timeline_events https://review.openstack.org/150170 | 22:43 |
| openstackgerrit | Michael Krotscheck proposed openstack-infra/storyboard: Singularized resource names. https://review.openstack.org/150169 | 22:43 |
| openstackgerrit | Michael Krotscheck proposed openstack-infra/storyboard: [WIP] Normalized event data https://review.openstack.org/143744 | 22:48 |
| krotscheck | NikitaKonovalov: I wasn’t able to look into working on the validation revert today. If you or aleksey have a chance, feel free. | 23:00 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!