*** nibalizer has joined #storyboard | 00:34 | |
*** wuhg has joined #storyboard | 05:50 | |
*** coolsvap|afk is now known as coolsvap | 05:57 | |
*** MaxV has joined #storyboard | 06:08 | |
*** mrmartin has joined #storyboard | 06:14 | |
*** alexismonville has joined #storyboard | 06:25 | |
*** coolsvap is now known as coolsvap|afk | 06:31 | |
*** coolsvap|afk is now known as coolsvap | 06:43 | |
*** alexismonville has quit IRC | 06:43 | |
*** alexismonville has joined #storyboard | 07:05 | |
*** MaxV has quit IRC | 07:38 | |
*** coolsvap is now known as coolsvap|afk | 07:39 | |
*** coolsvap|afk is now known as coolsvap | 07:46 | |
*** miqui_ has quit IRC | 07:54 | |
*** MaxV has joined #storyboard | 08:13 | |
*** wdutch has joined #storyboard | 08:13 | |
*** jtomasek has joined #storyboard | 08:17 | |
*** tteggel_ is now known as tteggel | 08:40 | |
*** tteggel has quit IRC | 08:40 | |
*** tteggel has joined #storyboard | 08:40 | |
*** jcoufal has joined #storyboard | 08:43 | |
openstackgerrit | Aleksey proposed openstack-infra/storyboard: Modified method user_create https://review.openstack.org/148247 | 09:01 |
---|---|---|
*** yolanda_ has joined #storyboard | 09:03 | |
*** coolsvap is now known as coolsvap|afk | 09:10 | |
*** coolsvap|afk is now known as coolsvap | 09:10 | |
*** alexismonville has quit IRC | 09:11 | |
*** jedimike has joined #storyboard | 09:16 | |
*** alexismonville has joined #storyboard | 09:16 | |
NikitaKonovalov | rcarrillocruz, krotscheck: I found the reason why a token is validated in a strange way | 09:33 |
NikitaKonovalov | it was introduces along with modifying entity_get_all, where strings are compares with a LIKE statement | 09:33 |
NikitaKonovalov | I'll fix that | 09:34 |
*** ssam2 has joined #storyboard | 09:35 | |
*** yolanda_ has quit IRC | 09:44 | |
openstackgerrit | Aleksey proposed openstack-infra/storyboard: Added oslo.context to requirements https://review.openstack.org/148476 | 09:46 |
openstackgerrit | Nikita Konovalov proposed openstack-infra/storyboard: Fix access_token validation https://review.openstack.org/148477 | 09:48 |
NikitaKonovalov | everyone please review ^^ | 09:49 |
yolanda | hi NikitaKonovalov, i'll take a look this morning | 10:00 |
*** mase_x200 has joined #storyboard | 10:45 | |
rcarrillocruz | i'll have a look shortly, NikitaKonovalov | 10:58 |
openstackgerrit | Aleksey proposed openstack-infra/storyboard: Added oslotest to requirements https://review.openstack.org/148497 | 11:05 |
openstackgerrit | Aleksey proposed openstack-infra/storyboard: New versions of SQLAlchemy in requirements https://review.openstack.org/148504 | 11:38 |
*** alexismonville has quit IRC | 11:53 | |
openstackgerrit | Aleksey proposed openstack-infra/storyboard: Added oslo.log to requirements https://review.openstack.org/148518 | 12:17 |
openstackgerrit | Nikita Konovalov proposed openstack-infra/python-storyboardclient: Teams endpoint https://review.openstack.org/146451 | 12:28 |
rcarrillocruz | NikitaKonovalov: haven't read your comments in the channel before, that explains why removing chars at the end of the token string worked for me :S | 12:39 |
rcarrillocruz | good find! | 12:39 |
openstackgerrit | Aleksey proposed openstack-infra/storyboard: Added oslo.log to requirements https://review.openstack.org/148532 | 12:47 |
openstackgerrit | Aleksey proposed openstack-infra/storyboard: Added oslo.utils to requirements https://review.openstack.org/148532 | 12:47 |
*** alexismonville has joined #storyboard | 12:54 | |
*** wdutch has left #storyboard | 14:19 | |
*** mattfarina has joined #storyboard | 14:28 | |
mrmartin | Hi, I get an 500 Internal Server error when I try to login to storyboard: https://storyboard.openstack.org/api/v1/openid/authorize?response_type=code&client_id=storyboard.openstack.org&redirect_uri=https%3A%2F%2Fstoryboard.openstack.org%2F%23!%2Fauth%2Ftoken&scope=user&state=n00MkMZXZIdcbFQXmmcB | 14:30 |
*** Piet has quit IRC | 14:34 | |
*** alexismonville has quit IRC | 14:39 | |
*** alexismonville has joined #storyboard | 14:48 | |
yolanda | mrmartin, thx for reporting | 14:57 |
mrmartin | yolanda, the infra guys checking that | 14:57 |
mrmartin | http://paste.openstack.org/show/159200/ | 14:58 |
mrmartin | https://github.com/openstack-infra/storyboard/blob/master/storyboard/common/working_dir.py#L57 | 14:58 |
mrmartin | yolanda, what is the release policy for storyboard? every approved patch goes directly to storyboard.openstack.org ? | 14:58 |
yolanda | yes, at the moment is like that | 14:59 |
mrmartin | yolanda: do you know what storyboard does in this working directory? | 15:04 |
yolanda | checking now | 15:05 |
yolanda | going to take a look at the latest patches merged | 15:06 |
mrmartin | seems to be the latest storyboard patch was merged 5 days ago | 15:08 |
yolanda | yes, and i was logged these days | 15:10 |
yolanda | also that patch is not related | 15:10 |
yolanda | maybe something got merged for the puppet manifest that changed things? | 15:11 |
mrmartin | the cron part | 15:14 |
*** coolsvap is now known as coolsvap|afk | 15:16 | |
yolanda | this removed some directory or updated some path? | 15:16 |
mrmartin | I guess it is a simple permission issue | 15:17 |
mrmartin | the cron and mod_wsgi using a different user, but need to check | 15:18 |
yolanda | it shoudn't be failing that badly anyway | 15:19 |
*** mase_x200 has quit IRC | 15:19 | |
*** alexismonville has quit IRC | 15:40 | |
*** yolanda_ has joined #storyboard | 15:45 | |
*** yolanda_ has quit IRC | 15:45 | |
*** wuhg has quit IRC | 16:04 | |
*** jcoufal has quit IRC | 16:17 | |
krotscheck | mrmartin: Thanks for debugging that. | 16:48 |
mrmartin | krotscheck: let's see the results :) | 16:48 |
mrmartin | I just wanted to talk with you yesterday, about the notification. but if you on holiday, we can discuss this later, it is not so urgent. | 16:49 |
krotscheck | Holiday was yesterday, I’m back today. | 16:49 |
mrmartin | ok. | 16:50 |
krotscheck | I’ve got a doctor’s appointment in an hour though, which I’ll have to leave for soon. My connection will be intermittent. | 16:50 |
krotscheck | (Of all the days for things to blow up) | 16:50 |
mrmartin | ok, let's talk tomorrow then | 16:50 |
krotscheck | Thanks | 16:50 |
mrmartin | I've checked the webclient, this AngularJS awesome | 16:50 |
krotscheck | mrmartin: It really is, isn’t it. | 16:54 |
krotscheck | No more django :) | 16:54 |
*** CTtpollard has quit IRC | 16:56 | |
mrmartin | I guess the directory is there, do we need to an apache restart to pickup storyboard.conf settings? | 16:56 |
mrmartin | to / to do | 16:56 |
krotscheck | Probably | 16:56 |
yolanda | krotschek, so could we drop that sys.exits from storyboard? it could just have continue working without that dir existing¿ | 16:57 |
yolanda | ? | 16:57 |
krotscheck | yolanda: Yes. Did I put a sys exit in there? | 16:58 |
* krotscheck didn’t read all the scrollback. | 16:58 | |
krotscheck | It might be a cron worker thing, which doesn’t run in the wsgi thread. | 16:58 |
yolanda | https://github.com/openstack-infra/storyboard/blob/master/storyboard/common/working_dir.py#L57 | 16:58 |
mrmartin | yolanda: but the working_directory must be in the storyboard.conf | 16:59 |
mrmartin | and this directory is created by puppet | 16:59 |
yolanda | i mean, if given the case we could leave without that, logging error but not aborting work | 17:00 |
*** MaxV has quit IRC | 17:07 | |
krotscheck | Honestly, I think exit() is the right approach here. | 17:14 |
krotscheck | Reason is that the application is clearly misconfigured, and is unable to work properly. | 17:15 |
krotscheck | A similar situation might be “hey you didn’t configure an OAuth provider, but we’re going to keep working anyway" | 17:15 |
mrmartin | krotscheck: it is a good question, why not picked up the working_directory parameter we specified in the .conf file. | 17:18 |
krotscheck | Yeah, that file needs more tests. | 17:19 |
yolanda | so there was a conf change on puppet,and storyboard didn't pick it? | 17:31 |
mrmartin | yeap, I've added the working_directory option | 17:33 |
mrmartin | https://github.com/openstack-infra/puppet-storyboard/commit/7fe4951d7d6d9a9ecd415f9de9fe1a12fb782ce9 | 17:33 |
yolanda | maybe it needs a reboot of storyboard on config changes? | 17:33 |
mrmartin | is it running as a standalone process? | 17:34 |
mrmartin | seems to be a mod_wsgi, and we restarted apache | 17:35 |
yolanda | yes, using wsgiref | 17:37 |
rcarrillocruz | krotscheck: what's up with storyboard-dev? is it already in place? | 17:47 |
rcarrillocruz | i think i checked last week and didn't see it on system-config | 17:47 |
rcarrillocruz | i've been pushed changes for websockets for etherpad serevr, i may do the same thing for storyboard-dev | 17:48 |
*** coolsvap|afk has quit IRC | 18:00 | |
krotscheck | rcarrillocruz: It’s not, we need to make the puppet module support HTTP, right now it forces HTTPS | 18:03 |
*** ssam2 has quit IRC | 18:13 | |
rcarrillocruz | k | 18:15 |
rcarrillocruz | s/pushed/pushing | 18:18 |
*** alexismonville has joined #storyboard | 18:30 | |
*** alexismonville has quit IRC | 18:46 | |
*** jtomasek has quit IRC | 19:09 | |
krotscheck | yolanda: When you get a chance, can you upgrade your +1 on https://review.openstack.org/#/c/145918/ ? :) | 19:14 |
yolanda | ok | 19:14 |
yolanda | done | 19:16 |
*** alexismonville has joined #storyboard | 19:27 | |
*** Piet has joined #storyboard | 19:27 | |
openstackgerrit | Merged openstack-infra/storyboard: Modified method user_create https://review.openstack.org/148247 | 19:31 |
*** jedimike has quit IRC | 19:40 | |
*** openstackstatus has joined #storyboard | 19:46 | |
*** ChanServ sets mode: +v openstackstatus | 19:46 | |
-openstackstatus- NOTICE: Gerrit restarted to address likely memory leak leading to server slowness. Sorry if you were caught in the restart | 19:54 | |
openstackgerrit | Michael Krotscheck proposed openstack-infra/storyboard-webclient: Gruntfile Connect Hostname commandline option https://review.openstack.org/138053 | 20:10 |
krotscheck | tpollard ^^ | 20:12 |
openstackgerrit | Michael Krotscheck proposed openstack-infra/storyboard: Grunt invocation now allows passing of --hostname https://review.openstack.org/148708 | 20:18 |
openstackgerrit | Michael Krotscheck proposed openstack-infra/storyboard: Grunt invocation now allows passing of --hostname https://review.openstack.org/148708 | 20:19 |
openstackgerrit | Michael Krotscheck proposed openstack-infra/storyboard-webclient: Gruntfile Connect Hostname commandline option https://review.openstack.org/138053 | 20:20 |
*** alexismonville has quit IRC | 20:21 | |
*** mrmartin has quit IRC | 20:42 | |
*** alexismonville has joined #storyboard | 20:59 | |
*** alexismonville has quit IRC | 21:00 | |
openstackgerrit | Michael Krotscheck proposed openstack-infra/storyboard: Added python storyboard client to docs. https://review.openstack.org/148722 | 21:14 |
openstackgerrit | Michael Krotscheck proposed openstack-infra/storyboard: Added python storyboard client to docs. https://review.openstack.org/148722 | 21:16 |
openstackgerrit | Michael Krotscheck proposed openstack-infra/storyboard: Created Subscriber Utility https://review.openstack.org/146956 | 21:28 |
openstackgerrit | Michael Krotscheck proposed openstack-infra/storyboard: Explicit Event API https://review.openstack.org/145874 | 21:31 |
openstackgerrit | Michael Krotscheck proposed openstack-infra/storyboard: Email Templating Engine https://review.openstack.org/147734 | 21:32 |
openstackgerrit | Michael Krotscheck proposed openstack-infra/storyboard: Task status endpoint now matches api https://review.openstack.org/147335 | 21:39 |
openstackgerrit | Michael Krotscheck proposed openstack-infra/storyboard: Task status endpoint now matches api https://review.openstack.org/147335 | 21:51 |
*** jeblair has quit IRC | 21:51 | |
*** alexismonville has joined #storyboard | 21:53 | |
*** alexismonville has quit IRC | 22:10 | |
*** mattfarina has quit IRC | 22:27 | |
*** Piet has quit IRC | 22:54 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!