Friday, 2015-01-16

*** Piet has joined #storyboard00:10
*** reed_ has quit IRC00:10
*** miqui_ has joined #storyboard00:12
*** alexismonville has quit IRC00:16
*** omnibus7 is now known as davidlenwell00:49
*** davidlenwell is now known as davidlenwell__00:50
*** davidlenwell__ is now known as davidlenwell00:50
*** openstack has joined #storyboard01:36
openstackgerritMichael Krotscheck proposed openstack-infra/storyboard: Created Subscriber Utility  https://review.openstack.org/14695603:09
openstackgerritMichael Krotscheck proposed openstack-infra/storyboard: Email Templating Engine  https://review.openstack.org/14773403:09
*** wuhg has quit IRC04:04
*** mrmartin has joined #storyboard05:39
*** alexismonville has joined #storyboard06:10
*** alexismonville has quit IRC06:31
*** alexismonville has joined #storyboard06:39
*** wuhg has joined #storyboard07:00
*** petefoth has joined #storyboard07:27
*** jtomasek_ has joined #storyboard07:41
*** mrmartin has quit IRC07:49
*** jtomasek_ has quit IRC08:31
*** jtomasek has joined #storyboard08:35
*** jtomasek has quit IRC08:50
*** wdutch has joined #storyboard09:02
*** coolsvap|afk is now known as coolsvap09:03
openstackgerrityolanda.robla proposed openstack-infra/storyboard-webclient: Add button to remove all recent events in dashboard  https://review.openstack.org/14710509:13
*** jtomasek has joined #storyboard09:15
*** MaxV has joined #storyboard09:24
*** MaxV has quit IRC09:34
*** MaxV has joined #storyboard09:35
*** MaxV has quit IRC09:37
*** MaxV has joined #storyboard09:37
*** jcoufal has joined #storyboard09:38
*** ilyashakhat has joined #storyboard09:39
*** MaxV has quit IRC09:40
*** MaxV_ has joined #storyboard09:40
*** MaxV_ has quit IRC09:41
*** wuhg has quit IRC09:54
*** jedimike has joined #storyboard09:55
*** MaxV has joined #storyboard09:59
ttxyolanda: around?10:39
yolandattx yes10:40
ttxyolanda: About the may_mutate_to list -- how would you implement it ? With a specific table ?10:40
yolandaspecific table looks correct to me10:41
yolandaalternative option should be a text storing a set of separated values or a json10:41
ttxok10:41
* ttx adds it to story types spec10:41
yolandagreat10:41
ttxdone @ https://review.openstack.org/#/c/129267/10:55
ttxyolanda: ^10:55
yolandathx ttx, taking a look10:55
*** petefoth has left #storyboard10:56
yolandattx, i miss the description of UI or administration of that10:57
yolandawe need to be able to define the story type, with settings, status they can mutate?10:57
yolandado you think it's worth adding that as well?10:57
ttxyolanda: I would rather leave that part to whoever would implement it10:57
yolandaok10:57
yolandai think that specs gives us freedom for all types of workflows now10:58
ttxyolanda: I don't expect the types to change that much once they are defined10:58
ttxso a UI could be overkill10:58
ttxor at least, could be low priority10:59
yolandajust feeding data in the databse initially?10:59
ttxor use the APi to do it10:59
ttxwe'll need at least one type in there10:59
ttxor you won't be able to do much11:00
yolandayes, initial data is needed11:00
ttxbut it's an implementation detail imho11:00
yolanda+1 on it11:01
ttxI'm fine with the implementer refining the spec's implementation section11:01
yolandattx, talking about specs, i created the one for duplicates https://review.openstack.org/14725311:01
ttxsince I'll likely not do the work, I'd rather not be too prescriptive there :)11:01
ttxyeah, I'm about to review it11:01
yolandalow priority but i think it's useful11:02
* yolanda whishes to have more time to actually work on the project11:03
yolandattx, saw your comments. The latest one is just caused by spec being copy/pasted from another11:22
yolanda:)11:22
yolandai will review that with care11:22
yolandai filed the spec with a bugfix, but i'm on you on the story relationships11:43
*** mase_x200 has joined #storyboard12:42
*** alexismonville has joined #storyboard13:04
*** mattfarina has joined #storyboard14:18
*** coolsvap is now known as coolsvap|afk14:55
*** mase_x200 has quit IRC15:04
*** CTtpollard has quit IRC15:26
*** jcoufal_ has joined #storyboard15:30
*** jcoufal has quit IRC15:33
*** jcoufal_ has quit IRC15:40
*** CTtpollard has joined #storyboard15:41
*** jcoufal has joined #storyboard15:45
*** jtomasek has quit IRC16:19
yolandahi Krotscheck16:37
krotscheckHey!16:37
yolandai would just raise an exception if templates don't exist16:37
krotscheckyolanda: Gotcha. That’s what it does already.16:37
krotscheckyolanda: But I can add a few tests to assert that.16:38
yolandaso the get_template raises an exception?16:38
yolandai may be missing something, i was looking at the env.get_template method16:39
openstackgerrityolanda.robla proposed openstack-infra/storyboard: Send a 400 error code when duplicate user is created  https://review.openstack.org/14791516:43
krotscheckyolanda: Yep, i don’t recall where the exception is thrown though, it’s a few layers down.16:47
krotscheckyolanda: I’ll add some tests to assert that, it’ll make it clearer.16:47
yolandaah ok, i was just looking for sanity checks as the others, but it's ok for me if that is thrown later16:47
yolandai wanted to avoid empty emails being sent16:48
*** mrmartin has joined #storyboard16:49
*** mrmartin has quit IRC16:54
yolandakrotscheck, i was looking at the "story with no task is not being shown"16:56
yolandaactually it shows but with invalid status16:56
yolandais that what we are expecting?16:56
krotscheckyolanda: I think I may have fixed that when I dropped that big search patch a while ago.16:57
krotscheckyolanda: Wait, no. There was another one where I changed the key that we were grouping on.16:57
krotscheckyolanda: And yeah, now that I think about it, it’s totally accurate.16:58
krotscheckyolanda: What do yo uthink?16:58
yolandait was confusing by me until i reached the code16:58
yolandabecause initially we are filtering by "active" status16:58
yolandawhat i would do is raise an alert if someone tries to remove the unique task of a story16:59
yolandabecause well, initially all stories have one task, right?16:59
krotscheckyolanda: That makes sense.17:00
* krotscheck needs to wear a suit to work more often.17:01
yolandai will allow to remove the task but i will popup a modal alerting of the thing and telling that the story is going to be considered invalid, something like that...17:01
krotscheckperfect17:02
yolandakrotscheck, what are you doing with suit?!17:02
*** CTtpollard has quit IRC17:02
krotscheckyolanda: Oh, I just feel way more awesome and productive right now.17:02
yolanda:)17:03
yolandai don't feel any productive on a friday afternoon...17:07
*** mrmartin has joined #storyboard17:13
*** MaxV has quit IRC17:17
*** yolanda has quit IRC17:30
*** yolanda has joined #storyboard17:30
*** wdutch has quit IRC17:53
openstackgerritMichael Krotscheck proposed openstack-infra/storyboard: Email Templating Engine  https://review.openstack.org/14773418:04
*** alexismonville has quit IRC18:20
*** jcoufal has quit IRC18:41
*** jcoufal has joined #storyboard18:54
*** jcoufal has quit IRC18:55
*** mrmartin has quit IRC20:11
*** wendar_ is now known as wendar20:38
*** mattfarina has quit IRC22:11
*** openstackgerrit has quit IRC23:19
*** openstackgerrit has joined #storyboard23:19
openstackgerritMichael Krotscheck proposed openstack-infra/storyboard: Created Subscriber Utility  https://review.openstack.org/14695623:31
openstackgerritMichael Krotscheck proposed openstack-infra/storyboard: Explicit Event API  https://review.openstack.org/14587423:31
*** jedimike has quit IRC23:42
openstackgerritMerged openstack-infra/python-storyboardclient: Setting up base classes  https://review.openstack.org/13809223:44
openstackgerritMerged openstack-infra/python-storyboardclient: Update method improved  https://review.openstack.org/14684023:44
krotscheckTo what extend to we want ot force class documentation on methods in python-storyboardclient? I feel that as a developer, I often read the code of my clients directly, and thus the method documentation is my primary source of figuring out what something does and/or how it does it.23:53

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!