| *** openstack has joined #storyboard | 16:02 | |
| *** openstackstatus has joined #storyboard | 16:17 | |
| *** ChanServ sets mode: +v openstackstatus | 16:17 | |
| *** wuhg has quit IRC | 16:44 | |
| krotscheck | NikitaKonovalov: What is aleksey’s IRC handle? | 17:32 |
|---|---|---|
| krotscheck | NikitaKonovalov: I want to make sure we file a webclient story for https://review.openstack.org/#/c/143984/ | 17:33 |
| openstackgerrit | Merged openstack-infra/storyboard: Fix i18n in exception module. https://review.openstack.org/143992 | 17:34 |
| openstackgerrit | Merged openstack-infra/storyboard: Extended titles https://review.openstack.org/143984 | 17:35 |
| openstackgerrit | Merged openstack-infra/storyboard: All aborts now have message https://review.openstack.org/143465 | 17:36 |
| *** yolanda has quit IRC | 18:27 | |
| *** yolanda has joined #storyboard | 18:29 | |
| *** NikitaKonovalov has quit IRC | 18:29 | |
| *** NikitaKonovalov has joined #storyboard | 18:31 | |
| openstackgerrit | Michael Krotscheck proposed openstack-infra/storyboard: Corrected type casting in OAuth Response https://review.openstack.org/144341 | 18:51 |
| openstackgerrit | Michael Krotscheck proposed openstack-infra/storyboard: Corrected type casting in OAuth Response https://review.openstack.org/144341 | 18:59 |
| openstackgerrit | Merged openstack-infra/storyboard: Corrected type casting in OAuth Response https://review.openstack.org/144341 | 19:07 |
| yolanda | krotscheck, i was thinking about the failure caused by six. Would it be possible to have same test we have with the frontend, where we can test in a draft frontend, and be sure that everything works, but on the backend? have same test, but use master frontend, and the backend of the change | 19:14 |
| krotscheck | yolanda: I think that’s called functional tests :) | 19:26 |
| yolanda | but we are replacing that functional tests at the moment in the frontend by human tests :) | 19:26 |
| krotscheck | And our human tests are actual users :) | 19:27 |
| krotscheck | I think we both agree that bugs like that one should not crop up. | 19:27 |
| krotscheck | I feel that the amount of effort to build coverage for that component in our functional tests is probably equivalent to building a test in the frontend and gating on that. | 19:28 |
| yolanda | so adding more tests in the backend, ensuring that basic operations, is needed | 19:29 |
| yolanda | we all gave positive feedback on that change, it was quite simple, but even simple things can cause trouble | 19:29 |
| krotscheck | Yep | 19:30 |
| krotscheck | But we caught it quick. | 19:30 |
| krotscheck | So that’s good | 19:30 |
| yolanda | you were fast :) | 19:31 |
| yolanda | agh, i'm going to throw Furby through the window :) | 19:33 |
| *** reed has joined #storyboard | 19:36 | |
| krotscheck | Did you get it for them? | 19:46 |
| yolanda | yes :( | 19:48 |
| yolanda | it has been singing, farting and laughing all day :( | 19:49 |
| openstackgerrit | yolanda.robla proposed openstack-infra/storyboard-webclient: Add timeout to the blur event for story inline edition https://review.openstack.org/144354 | 19:57 |
| yolanda | krotscheck, eternal diff in that review about newline. Shall we leave it like that, until i create the lintian warn for it and we force newlines? | 19:58 |
| yolanda | it seems to happen only in js files, created by other people, as my editors are always adding a trailing newline | 19:59 |
| krotscheck | You have created your own hell :) | 19:59 |
| yolanda | so, my changes are adding the right newline there :) | 19:59 |
| openstackgerrit | Michael Krotscheck proposed openstack-infra/storyboard: Added cron plugin to clean old access tokens. https://review.openstack.org/140536 | 20:01 |
| openstackgerrit | Michael Krotscheck proposed openstack-infra/storyboard: Consolidated OAuth Configuration, added enable flag to oauth cleaner. https://review.openstack.org/144355 | 20:01 |
| *** Piet has joined #storyboard | 21:00 | |
| *** mase_x200 has joined #storyboard | 21:22 | |
| *** mase_x200 has quit IRC | 21:31 | |
| *** Piet has quit IRC | 22:18 | |
| openstackgerrit | Khai Do proposed openstack-infra/storyboard: Allow overriding test database from an environment variable https://review.openstack.org/144375 | 23:04 |
| openstackgerrit | Khai Do proposed openstack-infra/storyboard: Allow overriding test database from an environment variable https://review.openstack.org/144375 | 23:24 |
| openstackgerrit | Khai Do proposed openstack-infra/storyboard: Allow overriding test database from an environment variable https://review.openstack.org/144375 | 23:30 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!